lib/dp-packet.c:60
#3 in dp_packet_init lib/dp-packet.c:126
#4 in dp_packet_new lib/dp-packet.c:150
[...]
Signed-off-by: Mike Pattrick
---
lib/dp-packet.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/dp-packet.c b/lib/dp-packet.c
index 61e405460..ae8ab5800 100644
lib/netdev-dummy.c:208
#2 dummy_packet_conn_set_config lib/netdev-dummy.c:436
[...]
Signed-off-by: Mike Pattrick
---
lib/netdev-dummy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
index 72cb95471..0b1eb7108 100644
--- a/lib
On Wed, Jan 11, 2023 at 6:24 AM Ilya Maximets wrote:
>
> On 1/11/23 06:33, Mike Pattrick wrote:
> > UB Sanitizer report:
> >
> > lib/hash.h:219:17: runtime error: load of misaligned address
> > 0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byt
On Fri, Dec 2, 2022 at 10:20 AM Maxime Coquelin
wrote:
>
>
>
> On 12/2/22 15:59, Mike Pattrick wrote:
> > On Fri, Dec 2, 2022 at 5:37 AM Maxime Coquelin
> > wrote:
> >>
> >>
> >>
> >> On 12/2/22 11:09, David Marchand wrote
On Fri, Dec 2, 2022 at 1:40 PM Ilya Maximets wrote:
>
> On 12/2/22 18:59, Mike Pattrick wrote:
> > On Fri, Dec 2, 2022 at 11:59 AM Ilya Maximets wrote:
> >>
> >> On 12/2/22 11:36, Maxime Coquelin wrote:
> >>>
> >>>
> >>> On 12/2/2
On Fri, Dec 2, 2022 at 11:59 AM Ilya Maximets wrote:
>
> On 12/2/22 11:36, Maxime Coquelin wrote:
> >
> >
> > On 12/2/22 11:09, David Marchand wrote:
> >> On Wed, Nov 30, 2022 at 9:30 PM Ilya Maximets wrote:
> >>> Shouldn't this be 0x7f instead?
> >>> 0x3f doesn't enable bit #6, which is
by over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function to reduce stack usage.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif-xlate.c | 168
gt;
> Only writers with exclusive access to the rculist should access .prev
> via some of the provided *_protected() accessors.
>
> Use rculist_back_protected() in REVERSE_PROTECTED iterators to avoid
> clang's compilation warning.
>
> Signed-off-by: Adrian Moreno
This fixes the
ntended.
Acked-by: Mike Pattrick
> ---
> tests/automake.mk| 1 +
> tests/library.at | 5 ++
> tests/test-rculist.c | 205 +++
> 3 files changed, 211 insertions(+)
> create mode 100644 tests/test-rculist.c
>
> diff --git
Add new option --dump-hugepages option in ovs-ctl to enable the addition
of hugepages in the core dump filter.
Signed-off-by: Mike Pattrick
---
V2:
- Rebased NEWS
- Included shared huge pages in dump
Signed-off-by: Mike Pattrick
---
NEWS | 4
utilities/ovs-ctl.in | 15
f-by: Mike Pattrick
---
Since v1:
- Retain support for pre-TCA_STATS_PKT64 kernels
Since v2:
- Added compat header
Since v3:
- Rebased on to current master
Signed-off-by: Mike Pattrick
---
lib/tc.c | 105 ++-
1 file changed, 66 insertions(+), 39
if the 32bit one has rolled over. Because
the TCA_STATS_PKT64 attribute may appear multiple times in a netlink
message, the method of parsing attributes was changed.
Fixes: f98e418fbdb6 ("tc: Add tc flower functions")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1776816
Signed-of
On Fri, Dec 2, 2022 at 5:37 AM Maxime Coquelin
wrote:
>
>
>
> On 12/2/22 11:09, David Marchand wrote:
> > On Wed, Nov 30, 2022 at 9:30 PM Ilya Maximets wrote:
> >> Shouldn't this be 0x7f instead?
> >> 0x3f doesn't enable bit #6, which is responsible for dumping
> >> shared huge
On Wed, Nov 23, 2022 at 5:03 AM Adrian Moreno wrote:
>
I believe the commit message was cut out.
> Signed-off-by: Adrian Moreno
> ---
> python/ovs/flow/kv.py| 17 ++---
> python/ovs/flow/ofp.py | 7 ---
> python/ovs/tests/test_ofp.py | 15 +++
> 3
aliases
> so it's easy to map OXM/NXM names to their fields and decoding
> information.
>
> Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
> ---
> build-aux/gen_ofp_field_decoders | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/bu
offload, so this
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/conntrack.c | 15
offload alone, so the
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
lib/conntrack.c | 17 +++---
lib/dp-packet.c | 15 ++
lib/dp-packet.h | 60
This is a subset of the larger TSO patchset with various checksum
improvements. This set includes additional documentation, new appctl
command "dpif-netdev/offload-show" to display interface offload
support, and improvements to tracking when an updated checksum is
required.
In a simple iperf test
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Reviewed-by: David Marchand
Signed-off-by: Mike Pattrick
---
Documentation/automake.mk| 1 +
Documentation
From: Flavio Leitner
This patch introduces a command to display the current checksum offload
status by port, allowing the user to gain insight into where checksum
offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
Reviewed-by: David
ink this is a reasonable change, 100MB has mostly been relegated
to embedded devices for a long time.
Acked-by: Mike Pattrick
Slightly related, I noticed that we're missing support for 20 and
56Gbps, we should probably add those as well.
-M
> ---
> NEWS | 4
&
On Wed, Nov 30, 2022 at 7:27 AM Ilya Maximets wrote:
>
> On 11/25/22 18:19, Adrian Moreno wrote:
> > Hi Mike,
> >
> > Sorry it took that long to review this patch.
> >
> > On 3/25/22 23:17, Mike Pattrick wrote:
> >> Add new option --dump-hugep
On Mon, Jan 16, 2023 at 10:17 AM Adrián Moreno wrote:
>
> From: Adrian Moreno
>
> IPFIX templates have to be sent for each Observation Domain ID.
> Currently, a timer is kept at each dpif_ipfix_exporter to send them.
> This works fine for per-bridge sampling where there is only one
> Observation
On Tue, Jan 24, 2023 at 2:21 PM Adrián Moreno wrote:
>
> From: Adrian Moreno
>
> IPFIX templates have to be sent for each Observation Domain ID.
> Currently, a timer is kept at each dpif_ipfix_exporter to send them.
> This works fine for per-bridge sampling where there is only one
> Observation
lib/netdev-dummy.c:208
#2 dummy_packet_conn_set_config lib/netdev-dummy.c:436
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
---
lib/netdev-dummy.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/netdev
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
---
v2:
- Fixed
lib/dp-packet.c:60
#3 in dp_packet_init lib/dp-packet.c:126
#4 in dp_packet_new lib/dp-packet.c:150
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
---
lib/dp-packet.c | 4
lib/dp-packet.h | 4
2 files changed, 8 insertions
On Mon, Jan 30, 2023 at 2:03 PM Ilya Maximets wrote:
>
> On 1/30/23 17:03, Mike Pattrick wrote:
> > UB Sanitizer report:
> >
> > lib/netdev-dummy.c:197:15: runtime error: member access within
> > misaligned address 0x0217a7f0 for type 'struct
> > dummy_pa
lib/netdev-dummy.c:208
#2 dummy_packet_conn_set_config lib/netdev-dummy.c:436
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
---
lib/netdev-dummy.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/netdev
lib/dp-packet.c:60
#3 in dp_packet_init lib/dp-packet.c:126
#4 in dp_packet_new lib/dp-packet.c:150
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
---
lib/dp-packet.c | 4
lib/dp-packet.h | 4
2 files changed, 8 insertions
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
---
v2:
- Fixed
lib/netdev-dummy.c:208
#2 dummy_packet_conn_set_config lib/netdev-dummy.c:436
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
v4:
- fixed incorrectly spelled function name
---
lib/netdev-dummy.c | 10 +-
1 file changed, 5 insertions
lib/dp-packet.c:60
#3 in dp_packet_init lib/dp-packet.c:126
#4 in dp_packet_new lib/dp-packet.c:150
[...]
Signed-off-by: Mike Pattrick
---
v3:
- used proper free method for non-posix platforms
---
lib/dp-packet.c | 4
lib/dp-packet.h | 4
2 files changed, 8 insertions(+)
diff
UB Sanitizer report:
lib/hash.h:219:17: runtime error: load of misaligned address
0x7ffc164a88b4 for type 'const uint64_t', which requires 8 byte
alignment
#0 in hash_words_inline lib/hash.h:219
#1 in hash_words lib/hash.h:297
[...]
Signed-off-by: Mike Pattrick
---
v2:
- Fixed
0.0 % of total cycles)
> - idle iterations: 0 ( 0.0 % of used cycles)
> - busy iterations: 0 ( 0.0 % of used cycles)
>
> Signed-off-by: Kevin Traynor
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
0
>1025 0
>1469 0
>
> ---
>cycles/it
>0
>
> Signed-off-by: Kevin Traynor
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
if the 32bit one has rolled over. Because
the TCA_STATS_PKT64 attribute may appear multiple times in a netlink
message, the method of parsing attributes was changed.
Fixes: f98e418fbdb6 ("tc: Add tc flower functions")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1776816
Signed-of
On Fri, Nov 4, 2022 at 11:45 AM Adrian Moreno wrote:
>
> Currently, things like the number of handler and revalidator threads are
> calculated based on the number of available CPUs. However, this number
> is considered static and only calculated once, hence ignoring events
> such as cpus being
On Fri, Nov 4, 2022 at 2:46 AM Peng He wrote:
>
> The tail of the struct dp_netdev_flow contains a whole netdev_flow_key
> struct.
>
> We need to first minus the size of netdev_flow_key then add back
> the real size of this netdev_flow_key.
>
> Signed-off-by: Peng He
> ---
> lib/dpif-netdev.c |
On Mon, Oct 17, 2022 at 9:19 AM Adrian Moreno wrote:
>
> Create a small helper script and check that flows tested in odp.at are
> parseable.
>
> Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvs
should be done by the caller anyway.
>
> Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
that already takes that into account from ofp_act.py to
> kv.py and use it for datapath action "clone".
>
> Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ed. Also, if a KVDecoder does
> need this default behavior, it can be explicitly configured specifying
> it's default decoder.
>
> Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Mon, Oct 17, 2022 at 9:19 AM Adrian Moreno wrote:
>
> Create a small helper script and check that flows used in ofp-actions.at
> are parseable.
>
> Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
___
dev mailing list
d...@
e_output,
> "drop": decode_flag,
> "controller": decode_controller,
> +"CONTROLLER": decode_controller,
This is beyond the scope of this patch, but I was surprised to see
that format_CONTROLLER in ofp-actions.c
On Mon, Oct 17, 2022 at 9:18 AM Adrian Moreno wrote:
>
> Fix the following erros in odp decoding:
> - Missing push_mpls action
> - Typos in collector_set_id, tp_src/tp_dst and csum
> - Missing two fields in vxlan match
>
> Signed-off-by: Adrian Moreno
Ac
ec.
>
> Fixes: be15ec48d766 ("lib: Use a more accurate value for CPU count
> (sched_getaffinity).")
> Cc: david.march...@redhat.com
> Signed-off-by: Adrian Moreno
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Nov 9, 2022 at 3:32 PM David Marchand wrote:
>
> The count of received multicast packets has been computed internally,
> but not exposed to ovsdb. Fix this.
>
> Signed-off-by: David Marchand
Acked-by: Mike Pattrick
> ---
> Strictly speaking, nothing was broken s
On Tue, Jan 31, 2023 at 10:45 AM Phelan, Michael
wrote:
>
> > -Original Message-
> > From: Ilya Maximets
> > Sent: Tuesday 31 January 2023 12:23
> > To: Phelan, Michael ; Mike Pattrick
> > ; Adrián Moreno
> > Cc: i.maxim...@ovn.org; d...@openvswitc
attribute
'CryptographyDeprecationWarning'
This import was only added to __init__ to deprecate python3.6. Importing
the exception from cryptography.utils is the compatible option.
Signed-off-by: Mike Pattrick
---
tests/mfex_fuzzy.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --g
offload, so this
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
- Extended
From: Flavio Leitner
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
offload alone, so the
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c
- Left rx_csum_offload field as it is not duplicative
- Moved system-userspace
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
- Renamed documentation to reflect the userspace checksum nature of
this feature
On Tue, Feb 21, 2023 at 5:35 AM Simon Horman wrote:
>
> On Thu, Feb 16, 2023 at 03:05:08PM -0500, Mike Pattrick wrote:
> > Currently OVS keeps track of which mirrors that each packet has been
> > sent to for the purpose of deduplication. However, this doesn't consider
> >
There was a minor typo in the ovs-actions man page.
Signed-off-by: Mike Pattrick
---
Documentation/ref/ovs-actions.7.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/ref/ovs-actions.7.rst
b/Documentation/ref/ovs-actions.7.rst
index b59b7634f..d13895655
On Fri, Mar 3, 2023 at 12:31 PM Adrian Moreno wrote:
>
> Hi Mike,
>
> I've gone though this patch and have some minor style comments and nits. I've
> also played a bit with it and run it through valgrind and looks solid.
>
> On 12/8/22 17:22, Mike Pattrick wrote:
> >
an echo reply even though
one has been sent.
This patch resets the mirrors every time a packet is modified, so
mirrors will recieve every copy of a packet that is sent for output.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif
On Tue, Mar 22, 2022 at 10:09 AM Emeel Hakim via dev
wrote:
>
> patch ovs-monitor-ipsec: Migration from ipsec.conf to swanctl.conf
> introduces strongswan-swanctl as an openvswitch-ipsec dependency,
> this patch adds it to the openvswitch-ipsec dependencies.
>
> Signed-off-by: Emeel Hakim
> ---
On Tue, Mar 22, 2022 at 10:09 AM Emeel Hakim via dev
wrote:
>
> As strongswan moved to the modern vici-based interface,this patch
> modifies ovs-monitor-ipsec to use strongswan's vici-based
> configuration instead of the legacy stroke-based configuration.
>
> Reviewed-by: Raed Salem
>
On Fri, Apr 28, 2023 at 6:46 PM Ilya Maximets wrote:
>
> On 3/27/23 12:50, Mike Pattrick wrote:
> > From: Flavio Leitner
> >
> > This patch modifies netdev_get_status to include information about
> > checksum offload status by port, allowing the user to gain i
On Tue, Mar 28, 2023 at 6:02 AM Ilya Maximets wrote:
>
> On 3/27/23 22:32, Mike Pattrick wrote:
> > UB Sanitizer report:
> >
> > lib/netdev-offload-tc.c:1276:19: runtime error: load of misaligned
> > address 0x7f74e801976c for type 'union ovs_u128', which
On Mon, Mar 27, 2023 at 7:25 AM Eelco Chaudron wrote:
>
> Make the read of the current seq->value atomic, i.e., not needing to
> acquire the global mutex when reading it. On 64-bit systems, this
> incurs no overhead, and it will avoid the mutex and potentially
> a system call.
>
> For
#2 in dpif_netlink_flow_dump_next lib/dpif-netlink.c:1921
[...]
Signed-off-by: Mike Pattrick
---
Since v1:
- Changed memcpy to get_32aligned_u128
- Checked full size of cookie length
---
lib/netdev-offload-tc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib
offload, so this
patch enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
- Extended
offload alone, so the
support is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
--
Since v9:
- Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c
- Left rx_csum_offload field as it is not duplicative
- Moved system-userspace
From: Flavio Leitner
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
Since v9:
- Renamed documentation to reflect the userspace checksum nature of
this feature
This patch set is a stripped down subset of the initial 17 patchset introduced
by Flavio Leitner in 2021.
The initial omnibus patchset was very complex and included a refactor, which
stymied review and would have made backporting more complex. It also didn't
resolve an ongoing issue with the DPDK
From: Flavio Leitner
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
solation.")
> Cc: msant...@redhat.com
>
> Suggested-by: Aaron Conole
> Signed-off-by: Adrian Moreno
I didn't test this, but it seems reasonable to me that we prevent the
creation of zero threads.
Acked-by: Mike Pattrick
___
dev
it's unclear
whether that's better, or just different. I only mention it because
count_cpu_cores__() can return 0.
Acked-by: Mike Pattrick
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Fri, Mar 31, 2023 at 10:45 AM Eelco Chaudron wrote:
>
>
>
> On 30 Mar 2023, at 17:57, Jon Kohler wrote:
>
> >> On Mar 28, 2023, at 1:32 PM, Mike Pattrick wrote:
> >>
> >> On Mon, Mar 27, 2023 at 7:25 AM Eelco Chaudron wrote:
> >>>
>
#2 in dpif_netlink_flow_dump_next lib/dpif-netlink.c:1921
[...]
Signed-off-by: Mike Pattrick
---
lib/netdev-offload-tc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-offload-tc.c b/lib/netdev-offload-tc.c
index 4fb9d9f21..506b74ce7 100644
--- a/lib/netdev
by over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function to reduce stack usage.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Signed-off-by: Mike Pattrick
Reviewed-by: Simon Horman
---
Since v1
S/RHEL spec file in order to have
> the version be aligned with the downstream one.
>
> Signed-off-by: Timothy Redaelli
This seems reasonable to me, and it looks like you've incorporated the
requests from v1 and v2.
Acked-by: Mike Pattrick
> ---
> Makefile.am
g-Properties#max_line_length
> Signed-off-by: Robin Jarry
> ---
Great idea, editorconfig is super convenient to have.
Acked-by: Mike Pattrick
>
> Notes:
> v2: add .editorconfig to EXTRA_DIST
>
> .editorconfig | 14 ++
> Makefile.am | 1 +
>
enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Extended miniflow_extract changes
is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c
- Left rx_csum_offload field as it is not duplicative
- Moved system-userspace-offload.at tests
ES once
- Respect FLOW_TNL_F_CSUM flag
Mike Pattrick (4):
Documentation: Document netdev offload.
dpif-netdev: Show netdev offloading flags.
userspace: Enable IP checksum offloading by default.
userspace: Enable L4 checksum offloading by default.
Documentation/automake.mk
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed
Document the implementation of netdev hardware offloading
in userspace datapath.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Renamed documentation to reflect the userspace checksum nature of
this feature
- Edited
by over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Signed-off-by: Mike Pattrick
Reviewed-by: Simon Horman
Acked-by: Eelco Chaudron
---
Since v1
is sent in order to the netdev.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
v4:
- Various formatting changes
- Fixed memory leak in soft-gso code if packet is flagged
for GSO but incorrectly lacks segment size.
---
lib/automake.mk | 2
packets are dropped.
Signed-off-by: Flavio Leitner
Co-authored-by: Mike Pattrick
Signed-off-by: Mike Pattrick
---
v3: Corrected sparse error
---
lib/dp-packet.c| 3 ++
lib/dp-packet.h| 26
lib/netdev-dpdk.c | 12 +++-
lib/netdev-linux.c | 76
On Tue, Jul 4, 2023 at 9:00 PM Ilya Maximets wrote:
>
> On 6/21/23 22:36, Mike Pattrick wrote:
> > From: Flavio Leitner
> >
> > This provides a software implementation in the case
> > the egress netdev doesn't support segmentation in hardware.
> >
> >
an echo reply even though
one has been sent.
This patch resets the mirrors every time a packet is modified, so
mirrors will recieve every copy of a packet that is sent for output.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif
On Wed, Mar 1, 2023 at 10:14 AM David Marchand
wrote:
>
> Hi Mike,
>
> This patch will need some rebasing.
>
>
> On Tue, Nov 1, 2022 at 5:27 PM Mike Pattrick wrote:
> >
> > Currently a bridge mirror will collect all packets and tools like
> > ovs-tcp
n setup. And this patch fixed those
issues.
Acked-by: Mike Pattrick
> ---
> utilities/ovs-tcpdump.in | 4
> 1 file changed, 4 insertions(+)
> diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in
> index 420c11eb8..4cbd9a5d3 100755
> --- a/utilities/ovs-tcpdump.
%|2%|
netdev | 7.39 Gbps | 4.95 Gbps | 6.24 Gbps |33%| 15%|
The ratios above are the percent reduction in total throughput when
mirroring is used either with or without a filter.
Signed-off-by: Mike Pattrick
---
Documentation/ref/ovs-tcpdump.8.rst | 4 ++
NEWS
On Fri, Jul 14, 2023 at 7:31 AM Ilya Maximets wrote:
>
> On 7/11/23 14:46, Eelco Chaudron wrote:
> >
> >
> > On 10 Jul 2023, at 17:34, Mike Pattrick wrote:
> >
> >> Currently OVS keeps track of which mirrors that each packet has been
> >> s
an echo reply even though
one has been sent.
This patch resets the mirrors every time a packet is modified, so
mirrors will receive every copy of a packet that is sent for output.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
Signed-off-by: Mike Pattrick
---
v2: Refactored all
. If it is
removed and the caller is xlate_push_stats_entry, then a new rule will
not be replaced.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2213892
Signed-off-by: Mike Pattrick
---
ofproto/ofproto-dpif-xlate-cache.c | 2 +-
ofproto/ofproto-dpif-xlate.c | 2 +-
ofproto/ofproto-dpif.c
by over 3kb from several translation actions.
This patch also moves some trace function from do_xlate_actions into its
own function.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2104779
Signed-off-by: Mike Pattrick
Reviewed-by: Simon Horman
---
Since v1:
- Refactored code
an echo reply even though
one has been sent.
This patch resets the mirrors every time a packet is modified, so
mirrors will recieve every copy of a packet that is sent for output.
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2155579
Signed-off-by: Mike Pattrick
---
v2: Refactored all
On Wed, May 24, 2023 at 8:56 AM Ilya Maximets wrote:
>
> On 5/17/23 05:11, Mike Pattrick wrote:
> > From: Flavio Leitner
> >
> > The netdev receiving packets is supposed to provide the flags
> > indicating if the L4 checksum was verified and it is OK or BAD,
>
port.
>
> Fixes: faf71e492263 ("netdev-dpdk: Print port name in offload API messages.")
> Signed-off-by: David Marchand
LGTM.
Acked-by: Mike Pattrick
> ---
> lib/netdev-offload-dpdk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/
is not enabled.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed duplicative field tx_ip_csum_offload from netdev-dpdk.c
- Left rx_csum_offload field as it is not duplicative
- Moved system-userspace-offload.at tests
enables the feature. However, Linux socket interface
remains disabled because the API doesn't allow enabling
those two features without enabling TSO too.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Extended miniflow_extract changes
section of the documentation
- Removed exclusion of the combination of rte_flow offload, userspace tso, and
RAW_ENCAP
- Added a TUNGETFEATURES check in netdev-linux.c for better support of early
2.6 era kernels
Mike Pattrick (4):
Documentation: Document netdev offload.
dpif-netdev: Show
This patch modifies netdev_get_status to include information about
checksum offload status by port, allowing the user to gain insight into
where checksum offloading is active.
Signed-off-by: Flavio Leitner
Co-authored-by: Flavio Leitner
Signed-off-by: Mike Pattrick
---
Since v9:
- Removed
301 - 400 of 724 matches
Mail list logo
