Re: [ovs-dev] [PATCH ovn] lflow.c: Reapply the dbg log fix for handling a lflow for a non-local DP.

2022-02-23 Thread Numan Siddique
ted is_switch instead of querying > external IDs.") > Signed-off-by: Han Zhou Acked-by: Numan Siddique Numan > --- > controller/lflow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/controller/lflow.c b/controller/lflow.c > index

Re: [ovs-dev] [PATCH ovn v2] controller: Use precomputed is_switch instead of querying external IDs.

2022-02-23 Thread Numan Siddique
On Wed, Feb 23, 2022 at 8:22 PM Han Zhou wrote: > > On Wed, Feb 23, 2022 at 3:24 PM Numan Siddique wrote: > > > > On Tue, Feb 8, 2022 at 5:28 AM Dumitru Ceara wrote: > > > > > > We already store whether a datapath is a switch or not. No need to do > >

Re: [ovs-dev] [PATCH ovn v2 00/11] ovn-controller: Fine-grained address set incremental processing.

2022-02-23 Thread Numan Siddique
On Wed, Feb 23, 2022 at 7:57 PM Han Zhou wrote: > > On Wed, Feb 23, 2022 at 2:51 PM Numan Siddique wrote: > > > > On Tue, Feb 22, 2022 at 10:18 AM Numan Siddique wrote: > > > > > > On Thu, Feb 17, 2022 at 5:54 PM Han Zhou wrote: > > > > > &

Re: [ovs-dev] [PATCH ovn] northd: introduce nat-only-router for nat-addresses option

2022-02-24 Thread Numan Siddique
On Thu, Feb 17, 2022 at 12:34 PM Lorenzo Bianconi wrote: > > Introduce nat-only-router flag for nat-addresses option in order to > advertise in GARPs packets all SNAT/DNAT configured in the connected > logical router but skip all configured load_balancers. > > Reported-at: https://bugzilla.redhat.

Re: [ovs-dev] [PATCH ovn v3] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 11:17 AM Mark Michelson wrote: > > On 2/23/22 19:39, Numan Siddique wrote: > > On Wed, Feb 23, 2022 at 7:22 AM Frode Nordahl > > wrote: > >> > >> Hello Mark, > >> > >> This overall looks great, it also looks like

Re: [ovs-dev] [PATCH ovn v4] northd: Add feature to log reply and related ACL traffic.

2022-02-24 Thread Numan Siddique
llowing for the behavior > > to be similar for both ACL types. Since logging reply traffic requires > > adding more flows, it is not enabled by default. In order to have reply > > traffic logged, the ACL must have logging enabled, be stateful, have a > > label, and have the

Re: [ovs-dev] [PATCH ovn 0/2] ci: ovn-kubernetes: Make tests run again.

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 11:06 AM Dumitru Ceara wrote: > > This series addresses two independent issues: > - ovn-kubernetes needs to be built against the NB/SB schema defined in > the OVN tree we're running the test for. > - ovn-kubernetes bumped go and k8s versions and we should do the same >

Re: [ovs-dev] [PATCH v2 ovn] northd: introduce nat-only-router for nat-addresses option

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 5:23 PM Lorenzo Bianconi wrote: > > The CMS can configure the same lbs on multiple gw routers so the > same IPs/mac bindings will be adverised by multiple routers > through GARPs. > In order to fix the issue, introduce nat-only-router flag for > nat-addresses option in orde

Re: [ovs-dev] [PATCH ovn 1/2] Prepare for 22.03.0

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 5:01 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 4 ++-- > configure.ac | 2 +- > debian/changelog | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > &g

Re: [ovs-dev] [PATCH ovn 2/2] Prepare for post-22.03.0

2022-02-24 Thread Numan Siddique
On Thu, Feb 24, 2022 at 5:00 PM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-) > &g

Re: [ovs-dev] [PATCH ovn] ovs: Bump submodule to stable branch-2.17.

2022-02-25 Thread Numan Siddique
On Fri, Feb 25, 2022 at 2:00 AM Han Zhou wrote: > > On Thu, Feb 24, 2022 at 3:07 PM wrote: > > > > From: Numan Siddique > > > > The following commits are required for OVN: > > > > 498cedc48 reconnect: Fix broken inactivity probe if there is no other

Re: [ovs-dev] [PATCH v3 ovn] northd: introduce exclude-lb-vips-from-garp option for lsp

2022-02-25 Thread Numan Siddique
On Fri, Feb 25, 2022 at 9:25 AM Lorenzo Bianconi wrote: > > The CMS can configure the same lbs on multiple gw routers so the > same VIPs will be adverised by multiple routers through GARPs. > In order to fix the issue, introduce exclude-lb-vips-from-garp > option in the logical_switch_port table i

Re: [ovs-dev] [PATCH ovn] ovs: Bump submodule to stable branch-2.17.

2022-02-25 Thread Numan Siddique
On Fri, Feb 25, 2022 at 1:20 PM Mark Michelson wrote: > > On 2/25/22 10:26, Ilya Maximets wrote: > > On 2/25/22 16:19, Numan Siddique wrote: > >> On Fri, Feb 25, 2022 at 2:00 AM Han Zhou wrote: > >>> > >>> On Thu, Feb 24, 2022 at 3:07

Re: [ovs-dev] [PATCH ovn] pinctrl: give a 'no such name' response when no DNS record is available

2022-02-25 Thread Numan Siddique
Hi, Can you please fix the below compilation issue and submit another version ? Thanks Numan On Tue, Feb 22, 2022 at 7:39 AM 0-day Robot wrote: > > Bleep bloop. Greetings 294754599--- via dev, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered s

Re: [ovs-dev] [PATCH ovn v2] ovn.at: Fix flaky tests "VLAN transparency, passthru=true, multiple hosts"

2022-02-25 Thread Numan Siddique
On Fri, Feb 4, 2022 at 11:03 AM Xavier Simonart wrote: > > Tests were waiting for ports to be reported up before sending packets. > However, waiting for both ports to be up is not enough to guarantee > that all flows are installed for both ports. > We now wait for flows outputting to patch port to

Re: [ovs-dev] [PATCH ovn v3 01/16] tests: log more info on OVN_CHECK_PACKETS* failure

2022-02-25 Thread Numan Siddique
On Thu, Feb 17, 2022 at 10:17 AM Ihar Hrachyshka wrote: > > Right now it logs diff between expected and observed only when enough > packets arrived. If less than expected packets arrived, only the > number of packets observed was logged, but not the packets themselves. > This patch makes the funct

Re: [ovs-dev] [PATCH ovn v3 02/16] tests: don't bail from OVN_CHECK_PACKETS_CONTAIN prematurily

2022-02-25 Thread Numan Siddique
On Thu, Feb 17, 2022 at 10:18 AM Ihar Hrachyshka wrote: > > When the expected number of packets arrive, OVN_CHECK_PACKETS_CONTAIN > bails out. But it should bail out from waiting only when the expected > packets were observed or when timeout reached, because the whole point > of the function is to

Re: [ovs-dev] [PATCH ovn v2] ovn-ic: Support IGMP/MLD in multi-AZ deployments.

2022-03-07 Thread Numan Siddique
On Thu, Mar 3, 2022 at 5:08 AM Dumitru Ceara wrote: > > Commit 974618c61de8 ("ovn-ic: physical: Support multicast_group flooding > on IC transit switches.") added support for statically forwarding IP > multicast traffic between AZs. While this works, it's a waste of > resources to flood all IP mu

Re: [ovs-dev] [PATCH ovn] test: fix race in ARP replies for SNAT external ips

2022-03-07 Thread Numan Siddique
On Fri, Mar 4, 2022 at 8:10 AM Lorenzo Bianconi wrote: > > There is a small race where gw-router-port can be running on both > hvs and both of them can reply to the arp request ending up with > two arp replies in the pcap file. This is transitory not significant > in a real deployment that can tri

Re: [ovs-dev] [PATCH ovn] northd: Support the option to apply from-lport ACLs after load balancer.

2022-03-08 Thread Numan Siddique
On Tue, Mar 8, 2022 at 9:51 AM Dumitru Ceara wrote: > > On 3/7/22 18:46, num...@ovn.org wrote: > > From: Numan Siddique > > > > Presently for ACLs and LBs we do the following in the logical switch > > ingress pipeline > > > >1. Send the packet to co

Re: [ovs-dev] [PATCH ovn] northd: Support the option to apply from-lport ACLs after load balancer.

2022-03-09 Thread Numan Siddique
On Wed, Mar 9, 2022, 5:53 PM Han Zhou wrote: > On Tue, Mar 8, 2022 at 8:02 AM Numan Siddique wrote: > > > > On Tue, Mar 8, 2022 at 9:51 AM Dumitru Ceara wrote: > > > > > > On 3/7/22 18:46, num...@ovn.org wrote: > > > > From: Numan Siddique > &g

Re: [ovs-dev] [PATCH ovn] ovn-northd: Skip conntrack related stages for router ports in switch pipeline.

2022-03-10 Thread Numan Siddique
On Thu, Mar 10, 2022 at 4:22 AM Dumitru Ceara wrote: > > On 3/10/22 04:04, num...@ovn.org wrote: > > From: Numan Siddique > > > > Hi Numan, > > > Presently, if the inport or outport is a peer port (of router port), > > then we skip sending the packet to

Re: [ovs-dev] [OVN question consultation] About logical router policies configured on the logical router

2022-03-17 Thread Numan Siddique
On Thu, Mar 17, 2022 at 6:39 AM 黄海伦 wrote: > > Hi, > > > In OVN logical flows table, the table number of Router policies table > (lr_in_policy) in ovn logical router is 13, and IP Routing > table(lr_in_ip_routing) is 11. > The priority of router policy route is higher than that of static route i

Re: [ovs-dev] [PATCH ovn] NEWS: Mention new IGMP/MLD snooping support for OVN-IC.

2022-03-17 Thread Numan Siddique
On Tue, Mar 8, 2022 at 3:27 AM Dumitru Ceara wrote: > > Signed-off-by: Dumitru Ceara Thanks. Applied to the main branch. Numan > --- > NEWS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/NEWS b/NEWS > index 9648f6cb21..5ba9c3cf4c 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,5 +1,7 @@

Re: [ovs-dev] [PATCH ovn] northd: Properly warn for NAT on LR with multiple gw ports.

2022-03-17 Thread Numan Siddique
On Wed, Mar 9, 2022 at 4:39 AM Dumitru Ceara wrote: > > This is not supported and ovn-northd was not logging it properly. > The previous attempt tried to log in init_nat_entries() but there > the logical router port configuration has not yet been parsed. > > Move the check and log instead to where

Re: [ovs-dev] [PATCH ovn] northd: Fix typo in cleanup_stale_fdp_entries().

2022-03-17 Thread Numan Siddique
On Wed, Mar 9, 2022 at 4:40 AM Dumitru Ceara wrote: > > Signed-off-by: Dumitru Ceara Thanks. Applied to the main branch. Numan > --- > northd/northd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/northd/northd.c b/northd/northd.c > index 7f309098e1..4ad0ec5821

Re: [ovs-dev] [PATCH ovn] northd: Properly warn for NAT on LR with multiple gw ports.

2022-03-17 Thread Numan Siddique
On Thu, Mar 17, 2022 at 11:46 AM Numan Siddique wrote: > > On Wed, Mar 9, 2022 at 4:39 AM Dumitru Ceara wrote: > > > > This is not supported and ovn-northd was not logging it properly. > > The previous attempt tried to log in init_nat_entries() but there > > the log

Re: [ovs-dev] [PATCH v2 ovn] northd: allow explicit nat-addresses for distributed gw ports

2022-03-17 Thread Numan Siddique
On Tue, Mar 15, 2022 at 2:28 PM Lorenzo Bianconi wrote: > > Allow the CMS to explicitly configure nat addresses to use in > GARP advertising even if the logical switch port is connected > to a distributed gateway router port. > > Signed-off-by: Lorenzo Bianconi Thanks. Applied to the main branc

Re: [ovs-dev] [PATCH ovn] northd: Consolidate load balancer processing functions.

2022-03-17 Thread Numan Siddique
On Wed, Mar 16, 2022 at 12:11 PM Dumitru Ceara wrote: > > This commit doesn't change any functionality, it just performs the > following refactor work: > > a. consolidates the old build_ovn_lbs(), build_lrouter_lbs() and >build_ovn_lr_lbs() functions into a single function, build_lbs(), >t

Re: [ovs-dev] [PATCH ovn] northd: Use separate SNAT for already-DNATted traffic.

2022-03-18 Thread Numan Siddique
On Wed, Mar 9, 2022 at 2:38 PM Mark Michelson wrote: > > Commit 4deac4509abbedd6ffaecf27eed01ddefccea40a introduced functionality > in ovn-northd to use a single zone for SNAT and DNAT when possible. It > accounts for certain situations, such as hairpinned traffic, where we > still need a separate

Re: [ovs-dev] [PATCH ovn 1/5] ovn-sb.xml: Fix ct_lb documentation.

2022-03-21 Thread Numan Siddique
Thanks for fixing this. Acked-by: Numan Siddique Numan > --- > ovn-sb.xml | 29 ++--- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/ovn-sb.xml b/ovn-sb.xml > index f7c41ccdc..3afea4ed4 100644 > ---

Re: [ovs-dev] [PATCH ovn v2 1/5] ovn-sb.xml: Fix ct_lb documentation.

2022-03-21 Thread Numan Siddique
Thanks for fixing this. Acked-by: Numan Siddique Numan > --- > ovn-sb.xml | 29 ++--- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/ovn-sb.xml b/ovn-sb.xml > index f7c41ccdc..3afea4ed4 100644 > ---

Re: [ovs-dev] [PATCH ovn v2 2/5] actions: Add action ct_lb_mark.

2022-03-21 Thread Numan Siddique
abel to ct_mark while keeping the backward compatibility. > > Signed-off-by: Han Zhou Acked-by: Numan Siddique Numan > --- > include/ovn/actions.h | 3 ++- > lib/actions.c | 55 --- > ovn-sb.xml| 10 +

Re: [ovs-dev] [PATCH ovn v2 2/5] actions: Add action ct_lb_mark.

2022-03-21 Thread Numan Siddique
On Mon, Mar 21, 2022 at 12:21 PM Numan Siddique wrote: > > On Sun, Mar 13, 2022 at 8:01 PM Han Zhou wrote: > > > > Add a new action ct_lb_mark, which is the same as ct_lb except that it > > internally uses ct_mark to store the NAT flag, while ct_lb uses ct_label > &

Re: [ovs-dev] [PATCH ovn v2 2/5] actions: Add action ct_lb_mark.

2022-03-21 Thread Numan Siddique
On Mon, Mar 21, 2022 at 12:26 PM Numan Siddique wrote: > > On Mon, Mar 21, 2022 at 12:21 PM Numan Siddique wrote: > > > > On Sun, Mar 13, 2022 at 8:01 PM Han Zhou wrote: > > > > > > Add a new action ct_lb_mark, which is the same as ct_lb except that it > &

Re: [ovs-dev] [PATCH ovn] controller/pinctrl: avoid accessing invalid memory

2022-03-21 Thread Numan Siddique
On Mon, Mar 14, 2022 at 7:10 AM Mohammad Heib wrote: > > currently pinctrl main thread uses some shash lists > that were supplied by ovn-controller main thread to prepare > and send IPv6 RAs, those lists are not updated properly when > LRP is deleted and can cause some invalid memory access > in t

Re: [ovs-dev] [PATCH ovn] Added test cases with ovn-northd parallelization enabled

2022-03-22 Thread Numan Siddique
as > some tests are not run through OVN_FOR_EACH_NORTHD. Instead use for instance > make check TESTSUITEFLAGS="-k parallelization=yes" and > make check TESTSUITEFLAGS="-k \!parallelization=yes" to run all tests > > If less than four physical cores are avail

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Don't commit to conntrack if the conntrack was skipped.

2022-03-22 Thread Numan Siddique
On Thu, Mar 10, 2022 at 2:42 PM wrote: > From: Numan Siddique > > Presently, if the inport or outport is a peer port (of router port), > then we skip sending the packet to conntrack by not setting the > reg0[0]/reg0[1] bits. But the packet still goes through the > stage

Re: [ovs-dev] [PATCH ovn v3 5/5] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-23 Thread Numan Siddique
On Wed, Mar 23, 2022 at 2:13 PM Han Zhou wrote: > > On Wed, Mar 23, 2022 at 9:42 AM Numan Siddique wrote: > > > > On Tue, Mar 22, 2022 at 2:54 PM Han Zhou wrote: > > > > > > Some NICs support HW offloading for datapath flows, but masked access to > >

Re: [ovs-dev] [PATCH ovn v3 5/5] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-23 Thread Numan Siddique
On Wed, Mar 23, 2022 at 2:39 PM Han Zhou wrote: > > On Wed, Mar 23, 2022 at 11:26 AM Numan Siddique wrote: > > > > On Wed, Mar 23, 2022 at 2:13 PM Han Zhou wrote: > > > > > > On Wed, Mar 23, 2022 at 9:42 AM Numan Siddique wrote: > > > > > &g

Re: [ovs-dev] Possible backport candidate

2022-03-24 Thread Numan Siddique
On Tue, Mar 22, 2022 at 12:31 PM Mark Michelson wrote: > > Hi everyone, > > Last month, commit d7514abe1 (acl-log: Log the direction (logical > pipeline) of the matching ACL.) was added to the main branch of OVN. > This commit was made because of the issue report at > https://bugzilla.redhat.com/s

Re: [ovs-dev] [PATCH ovn] rhel: fix logrotate user config option

2022-03-24 Thread Numan Siddique
On Tue, Mar 22, 2022 at 2:33 PM Mark Michelson wrote: > > Acked-by: Mark Michelson > Thanks. I applied this patch to the main branch and backported upto branch-21.03. Numan > On 3/22/22 13:37, Vladislav Odintsov wrote: > > If rpm is built with libcapng (default), /etc/logrotate.d/ovn > > confi

Re: [ovs-dev] [PATCH ovn] northd: Use separate SNAT for already-DNATted traffic.

2022-03-24 Thread Numan Siddique
On Thu, Mar 24, 2022 at 4:47 PM Mark Michelson wrote: > > Hi Numan, > > This message got buried in my inbox, so sorry about only replying now. I > have some replies in-line below > > On 3/18/22 16:34, Numan Siddique wrote: > > On Wed, Mar 9, 2022 at 2:38 PM Mark Michels

Re: [ovs-dev] [PATCH ovn] tests: Make "check CoPP config" more reliable.

2022-03-29 Thread Numan Siddique
0220329201800.462820-1-mmich...@redhat.com/ I manually deleted the above few lines and then I was able to apply the patch locally. Please fix this issue before applying. Acked-by: Numan Siddique Numan > The data is correct, but the test is being too strict about the expected > ordering o

Re: [ovs-dev] [PATCH ovn v4 5/6] ovn-controller: Handle SB_Global:options:northd_internal_version in I-P engine.

2022-03-29 Thread Numan Siddique
On Mon, Mar 28, 2022 at 1:48 AM Han Zhou wrote: > > Add an engine node en_northd_internal_version as an input to > en_lflow_output. When this node is updated, it triggers a recompute for > en_lflow_output. This node adds SB_Global as its only input, and it is > updated only when SB_Global's option

Re: [ovs-dev] [PATCH ovn v4 0/6] Use ct_mark for masked access to make flows HW-offloading friendly.

2022-03-29 Thread Numan Siddique
; traffic breaking during upgrading. It relies on the > northd-internal-version to internally determine if it is currently > upgrading from a version that requires the ct_label flows being > kept, and automatically removes the flows when northd-internal-version > is up-to-date. > &g

Re: [ovs-dev] [PATCH ovn v4 5/6] ovn-controller: Handle SB_Global:options:northd_internal_version in I-P engine.

2022-03-29 Thread Numan Siddique
On Tue, Mar 29, 2022 at 5:43 PM Han Zhou wrote: > > On Tue, Mar 29, 2022 at 2:19 PM Numan Siddique wrote: > > > > On Mon, Mar 28, 2022 at 1:48 AM Han Zhou wrote: > > > > > > Add an engine node en_northd_internal_version as an input to > > > e

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2022-03-30 Thread Numan Siddique
ing hardware offload all the way off appears to resolve the issue, > so this might as well be driver/firmware related. May I ask what > card/driver/firmware you've been using this with? > Hi Frode, This patch attempted to resolve this BZ - https://bugzilla.redhat.com/show_

Re: [ovs-dev] [PATCH ovn v4] northd: Add support for NAT with multiple DGP

2022-03-30 Thread Numan Siddique
" On Thu, Mar 24, 2022 at 12:14 PM Abhiram Sangana wrote: > > Currently, if multiple distributed gateway ports (DGP) are configured > on a logical router, NAT is disabled as part of commit 15348b7 > (northd: Multiple distributed gateway port support.) > > This patch adds a new column called "gate

Re: [ovs-dev] [PATCH ovn v4] northd: Add support for NAT with multiple DGP

2022-03-30 Thread Numan Siddique
On Wed, Mar 30, 2022 at 1:41 PM Abhiram Sangana wrote: > > Hi Numan, > > Thanks for reviewing the patch > > On 30 Mar 2022, at 16:55, Numan Siddique > mailto:num...@ovn.org>> wrote: > > I think the "gateway_port" column can be a weak reference to >

Re: [ovs-dev] [PATCH ovn v4] northd: Add support for NAT with multiple DGP

2022-03-31 Thread Numan Siddique
if gateway_port is not set, then ignore that NAT entry in ovn-northd And in the subsequent patch determine the gateway port if not specified. @Mark Michelson do you have any comments on this? Thanks Numan > Thanks, > Abhiram Sangana > > > On 30 Mar 2022, at 19:32, Numan S

Re: [ovs-dev] [PATCH ovn v5] northd: Add support for NAT with multiple DGP

2022-04-06 Thread Numan Siddique
On Wed, Apr 6, 2022 at 8:08 AM Abhiram Sangana wrote: > > Thanks for reviewing, Mark. Can we merge the patch if it looks good? Thanks. I applied this patch to the main branch, Numan > > Thanks, > Abhiram Sangana > > > On 4 Apr 2022, at 21:05, Mark Michelson wrote: > > > > Hi Abhriam, > > > >

Re: [ovs-dev] [PATCH ovn] tests: Enable 'ACLs after lb' for all test configs.

2022-04-06 Thread Numan Siddique
On Wed, Apr 6, 2022 at 9:16 AM Dumitru Ceara wrote: > > This was skipped by accident when the test was added. > > Fixes: 74d82e296f80 ("northd: Support the option to apply from-lport ACLs > after load balancer.") > Signed-off-by: Dumitru Ceara Thanks for fixing this. I applied this patch to th

Re: [ovs-dev] [PATCH ovn] Fixed multiple other flaky tests

2022-04-06 Thread Numan Siddique
On Tue, Apr 5, 2022 at 3:56 PM Mark Michelson wrote: > > Thanks a bunch Xavier! > > Acked-by: Mark Michelson Thanks for fixing this. I applied this patch to the main branch. Numan > > On 3/30/22 07:26, Xavier Simonart wrote: > > - options:requested-chassis for logical port > > - NAT and Load

Re: [ovs-dev] [PATCH ovn] Fixed multiple flaky tests

2022-04-06 Thread Numan Siddique
On Tue, Apr 5, 2022 at 12:07 PM Dumitru Ceara wrote: > > On 4/5/22 17:22, Mark Michelson wrote: > > On 3/30/22 06:40, Xavier Simonart wrote: > >> Hi Dumitru > >> > >> On Mon, Mar 21, 2022 at 12:02 PM Dumitru Ceara wrote: > >> > >>> On 3/21/22 10:56, Xavier Simonart wrote: > - send gratuitous

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2022-04-06 Thread Numan Siddique
On Wed, Apr 6, 2022 at 4:58 AM Frode Nordahl wrote: > > On Wed, Mar 30, 2022 at 4:54 PM Numan Siddique wrote: > > > > On Wed, Mar 30, 2022 at 6:21 AM Frode Nordahl > > wrote: > > > > > > On Wed, Mar 30, 2022 at 11:45 AM Frode Nordahl

Re: [ovs-dev] [PATCH ovn] controller: properly remove qos policy meters

2022-04-06 Thread Numan Siddique
On Tue, Apr 5, 2022 at 11:34 AM Mark Michelson wrote: > > Thanks Lorenzo, > > Acked-by: Mark Michelson Thanks. I applied this patch to the main branch and backported to branch-22.03 and branch-21.12. Numan > > On 4/1/22 17:11, Lorenzo Bianconi wrote: > > Remove meters created through set_mete

Re: [ovs-dev] [PATCH ovn 1/2] vtep: correctly bring vtep lport up in SBDB

2022-04-06 Thread Numan Siddique
On Wed, Apr 6, 2022 at 9:56 AM Mark Michelson wrote: > > You don't need to resend the patch. Whoever merges this can fix the > problem when they merge it. > > On 4/6/22 02:26, Vladislav Odintsov wrote: > > Regarding the code style, should I resend patch or this can be fixed when > > the patch get

Re: [ovs-dev] [PATCH ovn v2] northd: avoid snat on reply packets

2022-04-07 Thread Numan Siddique
On Tue, Apr 5, 2022 at 2:18 PM Mark Michelson wrote: > > Thanks Xavier. It's amazing this issue has been around so long. > The main reason this issue has not been an actual issue is because generally a gateway router is connected to a join switch and E-W traffic doesn't reach the gateway router

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2022-04-07 Thread Numan Siddique
On Wed, Apr 6, 2022 at 12:11 PM Numan Siddique wrote: > > On Wed, Apr 6, 2022 at 4:58 AM Frode Nordahl > wrote: > > > > On Wed, Mar 30, 2022 at 4:54 PM Numan Siddique wrote: > > > > > > On Wed, Mar 30, 2022 at 6:21 AM Frode Nordahl > > > wrote:

Re: [ovs-dev] [PATCH ovn] northd: Fix check for NAT on LR with multiple gw ports.

2022-04-07 Thread Numan Siddique
On Wed, Mar 23, 2022 at 11:35 AM Dumitru Ceara wrote: > > Add check to see if the LR actually has NAT entries configured. > Otherwise we spam the log unnecessarily. > > Fixes: b8194738c99e ("northd: Properly warn for NAT on LR with multiple gw > ports.") > Signed-off-by: Dumitru Ceara Hi Dumitr

Re: [ovs-dev] [PATCH ovn v2] controller/pinctrl: avoid accessing invalid memory

2022-04-07 Thread Numan Siddique
On Tue, Apr 5, 2022 at 10:21 AM Mark Michelson wrote: > > Thanks for the update Mohammad. I like this version much better. > > Acked-by: Mark Michelson Thanks for the fix. I applied this patch to the main and backported upto branch-21.09 with the below changes as it would reduce the code.

Re: [ovs-dev] [PATCH ovn v2] northd: Use separate SNAT for already-DNATted traffic.

2022-04-07 Thread Numan Siddique
On Fri, Apr 1, 2022 at 1:55 PM Mark Michelson wrote: > > Commit 4deac4509abbedd6ffaecf27eed01ddefccea40a introduced functionality > in ovn-northd to use a single zone for SNAT and DNAT when possible. It > accounts for certain situations, such as hairpinned traffic, where we > still need a separate

Re: [ovs-dev] [PATCH ovn v7] Add a northbound interface to program MAC_Binding table

2022-04-08 Thread Numan Siddique
On Fri, Apr 8, 2022 at 2:27 PM wrote: > > From: Karthik Chandrashekar > > Add a new NB and SB table for managing Static MAC_Binding entries. > This table is currently supported for logical routers. OVN northd > is responsible for propagating the values from NB to SB. OVN controller > is responsib

Re: [ovs-dev] [PATCH ovn] northd: avoid writing to IDL in parallel when using northd parallelization

2022-04-11 Thread Numan Siddique
On Fri, Apr 8, 2022 at 10:25 AM Dumitru Ceara wrote: > > On 4/1/22 22:10, Xavier Simonart wrote: > > The issue might have caused potential memory leaks or crashes in northd > > > > Signed-off-by: Xavier Simonart > > --- > > Looks good to me, thanks! > > Acked-by: Dumitru Ceara Thanks. I applie

Re: [ovs-dev] [PATCH ovn] ovn-controller: Avoid reprocessing same lflows in the same I-P run.

2022-04-11 Thread Numan Siddique
On Sat, Feb 5, 2022 at 12:12 AM Han Zhou wrote: > > On Fri, Feb 4, 2022 at 7:58 AM Mark Michelson wrote: > > > > As far as I can tell, this looks correct. > > > > Acked-by: Mark Michelson > > Thanks Mark. I applied it to the main branch. Hi Han, We have an issue in OVN 21.12 (and OVN 21.09) w

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2022-04-12 Thread Numan Siddique
On Mon, Apr 11, 2022 at 12:37 PM Frode Nordahl wrote: > > tor. 7. apr. 2022, 19:40 skrev Frode Nordahl : > > > On Thu, Apr 7, 2022 at 6:51 PM Numan Siddique wrote: > > > > > > On Wed, Apr 6, 2022 at 12:11 PM Numan Siddique wrote: > > > > > &g

Re: [ovs-dev] [PATCH ovn] system-ovn: fix CoPP test failures

2022-04-12 Thread Numan Siddique
On Tue, Apr 12, 2022 at 6:08 AM Dumitru Ceara wrote: > > On 4/12/22 10:02, Lorenzo Bianconi wrote: > > Meter bucket configuration has been fixed in ovs commit > > 7d742b509dd7 ("openvswitch: meter: remove rate from the > > bucket size calculation"). Fix CoPP system test failures due to new ovs > >

Re: [ovs-dev] [PATCH ovn v4 14/15] Allow to disable tunneling enforcement for multi-chassis port

2022-04-13 Thread Numan Siddique
On Tue, Apr 12, 2022 at 8:06 PM Ihar Hrachyshka wrote: > > There's a discussion to have on the intended behavior of a port with 2+ > chassis when the switch is attached to localnet. > > In general, the patch series makes all chassis switch to tunneling when > multiple chassis are set. (See patch 1

Re: [ovs-dev] [PATCH ovn] ofctrl.c: Check installed flow when merging tracked flow changes.

2022-04-13 Thread Numan Siddique
y adding the check for installed flows > before making the decision to merge the "delete and add/update" entries. > We will not merge if the installed flow doesn't match the desired flow > finally added/update. > > Reported-by: François Rigault > Reported-at: ht

Re: [ovs-dev] [PATCH ovn] ovn-controller: Avoid reprocessing same lflows in the same I-P run.

2022-04-13 Thread Numan Siddique
On Wed, Apr 13, 2022 at 2:36 AM Han Zhou wrote: > > On Mon, Apr 11, 2022 at 2:05 PM Numan Siddique wrote: > > > > On Sat, Feb 5, 2022 at 12:12 AM Han Zhou wrote: > > > > > > On Fri, Feb 4, 2022 at 7:58 AM Mark Michelson > wrote: > > > &g

Re: [ovs-dev] [PATCH] ovsdb-idl: Support change tracking of write-only columns.

2022-04-14 Thread Numan Siddique
On Fri, Apr 1, 2022 at 7:23 AM Dumitru Ceara wrote: > > At a first glance, change tracking should never be allowed for > write-only columns. However, some clients (e.g., ovn-northd) that are > mostly exclusive writers of a database, use change tracking to avoid > duplicating the IDL row records i

Re: [ovs-dev] [PATCH ovn v4 07/15] Use get_port_binding_tun instead of chassis_tunnel_find

2022-04-17 Thread Numan Siddique
On Tue, Mar 29, 2022 at 8:48 PM Ihar Hrachyshka wrote: > > Right now consider_port_binding first extracts *a* tunnel for a > chassis, then later in put_remote_port_redirect_overlay it fetches > *the* proper tunnel before configuring encapsulation. > > Instead of doing it in two steps, just extract

Re: [ovs-dev] [PATCH ovn v4 00/15] Support multiple requested-chassis

2022-04-19 Thread Numan Siddique
On Tue, Mar 29, 2022 at 8:47 PM Ihar Hrachyshka wrote: > > This version of the series switched to supporting multiple chassis set in > requested-chassis option. This allows for more than two chassis > specified for the same port. > > Also, this series includes a patch that allows to disable tunnel

Re: [ovs-dev] [PATCH ovn v4 14/15] Allow to disable tunneling enforcement for multi-chassis port

2022-04-20 Thread Numan Siddique
On Thu, Apr 14, 2022 at 4:54 PM Ihar Hrachyshka wrote: > > On 4/13/22 11:36 AM, Numan Siddique wrote: > > On Tue, Apr 12, 2022 at 8:06 PM Ihar Hrachyshka wrote: > >> There's a discussion to have on the intended behavior of a port with 2+ > >> chassis when

Re: [ovs-dev] [PATCH ovn v4 00/15] Support multiple requested-chassis

2022-04-20 Thread Numan Siddique
On Wed, Apr 20, 2022 at 1:15 PM Ihar Hrachyshka wrote: > > Thanks for your review. See below. > > On Tue, Apr 19, 2022 at 11:43 AM Numan Siddique wrote: > > > > On Tue, Mar 29, 2022 at 8:47 PM Ihar Hrachyshka wrote: > > > > > > This version of the seri

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2022-04-20 Thread Numan Siddique
On Tue, Apr 12, 2022 at 11:01 AM Numan Siddique wrote: > > On Mon, Apr 11, 2022 at 12:37 PM Frode Nordahl > wrote: > > > > tor. 7. apr. 2022, 19:40 skrev Frode Nordahl : > > > > > On Thu, Apr 7, 2022 at 6:51 PM Numan Siddique wrote: > > > > > &

Re: [ovs-dev] [PATCH ovn v3 2/2] northd: Use ct_(snat/dnat)_in_czone action for distributed routers.

2022-04-21 Thread Numan Siddique
On Thu, Apr 21, 2022 at 5:02 AM Frode Nordahl wrote: > > On Wed, Apr 20, 2022 at 10:10 PM Numan Siddique wrote: > > > > On Tue, Apr 12, 2022 at 11:01 AM Numan Siddique wrote: > > > > > > On Mon, Apr 11, 2022 at 12:37 PM Frode Nordahl > > > wrote: &

Re: [ovs-dev] [PATCH ovn] ovn-northd: Add flow to use eth.src if nd.tll is 0 in put_nd() action.

2022-04-25 Thread Numan Siddique
On Mon, Apr 25, 2022, 8:59 AM Dumitru Ceara wrote: > On 4/23/22 20:14, num...@ovn.org wrote: > > From: Numan Siddique > > > > Presently OVN assumes that an IPv6 Neigh Adv packet will have the > > target link layer option preset. But that's not the case all the

Re: [ovs-dev] [PATCH ovn] ovn-northd: Add flow to use eth.src if nd.tll is 0 in put_nd() action.

2022-04-25 Thread Numan Siddique
On Mon, Apr 25, 2022 at 10:20 AM Dumitru Ceara wrote: > > On 4/25/22 16:06, Numan Siddique wrote: > > On Mon, Apr 25, 2022, 8:59 AM Dumitru Ceara wrote: > > > >> On 4/23/22 20:14, num...@ovn.org wrote: > >>> From: Numan Siddique > >>> > &

Re: [ovs-dev] [PATCH] ovsdb idl: Add the support to specify the uuid for row insert.

2022-05-04 Thread Numan Siddique
; supported in the create command. I think we can support something like - ovs-vsctl --id= create ... What do you think ? I've incorporated it in v2. Please check it out. > > On 3/8/22 01:56, num...@ovn.org wrote: > > From: Numan Siddique > > > > ovsdb-server a

Re: [ovs-dev] [PATCH ovn] northd: Mark most of the SB columns as write-changed-only.

2022-05-04 Thread Numan Siddique
On Tue, May 3, 2022 at 7:32 PM Han Zhou wrote: > > On Thu, Apr 28, 2022 at 9:36 AM Dumitru Ceara wrote: > > > > This uses the newly added ovsdb_idl_set_write_changed_only_all() to > > explicitly disable atomicity checks for read/write columns and to enable > > optimizing the process of building t

Re: [ovs-dev] [PATCH ovn] northd: fix lflow grouping in build_lb_rules

2022-05-16 Thread Numan Siddique
On Mon, May 16, 2022 at 4:51 AM Dumitru Ceara wrote: > > On 5/16/22 10:29, Lorenzo Bianconi wrote: > >> On 5/3/22 21:09, Lorenzo Bianconi wrote: > >>> Do not group lflows if the corresponding datapath does not run > >>> copp meters and the previous one has an associated copp entry. > >>> In order

Re: [ovs-dev] [PATCH ovn 0/3] Adding generic port security flows.

2022-05-16 Thread Numan Siddique
ovn-controller does not see any noticeable > performance decrease. > > If we can get confirmation, then I'll ack the series. > Thanks Mark for the reviews. Sure. I'll do some tests and share the results. Numan > > On 5/12/22 20:42, num...@ovn.org wrote: > >

Re: [ovs-dev] [PATCH ovn] controller, northd, vtep: support routed networks with HW VTEP

2022-05-16 Thread Numan Siddique
On Wed, May 4, 2022 at 5:35 AM Vladislav Odintsov wrote: > Hi, > > this is a quick reminder. > Thanks. > > Regards, > Vladislav Odintsov > > > On 15 Apr 2022, at 11:46, Vladislav Odintsov wrote: > > > > Hi Numan, Ihar, Han, Mark, > > > > would somebody find some time to take a look on this pleas

Re: [ovs-dev] [PATCH ovn v3] northd: handle container lport type update

2022-05-16 Thread Numan Siddique
On Tue, May 10, 2022 at 10:55 AM Mark Michelson wrote: > Thanks Mohammad, > > Acked-by: Mark Michelson > Thanks. I applied this patch to the main branch and backported to branch-22.03 and branch-21.12. Numan > > On 4/26/22 05:49, Mohammad Heib wrote: > > currently, when a lport with a nonemp

Re: [ovs-dev] [PATCH ovn v4 1/3] actions: add sample action

2022-11-01 Thread Numan Siddique
On Mon, Oct 17, 2022 at 9:14 AM Adrian Moreno wrote: > > sample ovn action encodes into the OFPACT_SAMPLE ovs action. > > OVN action allows the following parameters: > > - obs_domain_id: 8-bit integer that identifies the sampling application. > This value will be combined with the datapath's tun

Re: [ovs-dev] [PATCH ovn v4 2/3] northd: make default drops explicit

2022-11-01 Thread Numan Siddique
On Mon, Oct 17, 2022 at 9:15 AM Adrian Moreno wrote: > > By default, traffic that doesn't match any configured flow will be dropped. > But having that behavior implicit makes those drops more difficult to > visualize. > > Make default drops explicit both as default logical flows and as default > o

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

2022-11-01 Thread Numan Siddique
On Fri, Oct 28, 2022 at 11:36 AM Dumitru Ceara wrote: > > Hi Xavier, > > On 10/24/22 17:21, Xavier Simonart wrote: > > In the following scenario: > > - interface "old" is created and external_ids:iface-id is set (to lp) > > - interface "new" is created and external_ids:iface-id is set (to same lp)

Re: [ovs-dev] [PATCH ovn 1/4] logical-fields: add rarp fields

2022-11-01 Thread Numan Siddique
On Mon, Oct 24, 2022 at 6:47 AM Felix Hüttner via dev wrote: > > We need to be able to handle rarp fields in order to ensure we can > handle rarp messages we send ourselves. > This will be used by the next patch in the series. > > Signed-off-by: Felix Huettner Acked-by: Numa

Re: [ovs-dev] [PATCH ovn 2/4] northd: handle own rarps like garps

2022-11-01 Thread Numan Siddique
hanges done, you can add my Acked-by tag in the next version Acked-by: Numan Siddique Numan > --- > northd/northd.c | 9 + > northd/ovn_northd.dl | 2 +- > tests/ovn-northd.at | 18 +- > tests/ovn.at | 8 +++- > 4 files changed, 22

Re: [ovs-dev] [PATCH ovn 3/4] ovn-macros: support ipv6 in ovn_attach

2022-11-01 Thread Numan Siddique
On Mon, Oct 24, 2022 at 6:48 AM Felix Hüttner via dev wrote: > > in order to easily add future ipv6 test cases the common `ovn_attach` > function should also support ipv6 addresses. > > Signed-off-by: Felix Huettner Acked-by: Numan Siddique Numan > --- > tes

Re: [ovs-dev] [PATCH ovn 4/4] pinctrl: Send RARPs for external ipv6 interfaces

2022-11-01 Thread Numan Siddique
t; > This change has been tested in an environment with 600 logical routers > on a single ipv6 external network. > > Signed-off-by: Felix Huettner Acked-by: Numan Siddique Numan > --- > controller/pinctrl.c | 23 + > tests/ovn.at | 80 +

Re: [ovs-dev] [PATCH ovn 0/4] Send Rarps for ipv6 router lsp

2022-11-01 Thread Numan Siddique
On Mon, Oct 24, 2022 at 6:47 AM Felix Hüttner via dev wrote: > > previously garps/rarps where only sent for "external" lsp's if these > had an ipv4 address attached. For lsp's on gateway routers that do > not have an ipv4 address assigned (e.g. if they are ipv6 only) no > rarps were send out. > >

Re: [ovs-dev] [PATCH ovn v3] ovn-controller: Fix some issues with CT zone assignment.

2022-11-01 Thread Numan Siddique
get_zone_num "$ct_zones" ls0-hv1) > +port2_zone=$(get_zone_num "$ct_zones" ls0-hv2) > +snat_zone=$(get_zone_num "$ct_zones" ${lr_uuid}_snat) > + > +check test "$snat_zone" -eq "$snat_req_zone" > +check test "$port1_zone" -ne

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

2022-11-02 Thread Numan Siddique
On Wed, Nov 2, 2022 at 7:39 AM Xavier Simonart wrote: > > Hi Numan, Dumitru > > Thanks for looking at this patch and for your feedback. > > > On Tue, Nov 1, 2022 at 10:41 PM Numan Siddique wrote: > > > On Fri, Oct 28, 2022 at 11:36 AM Dumitru Ceara wrote: > &g

Re: [ovs-dev] [PATCH ovn v4] ovn-controller: Fixed missing flows after interface deletion

2022-11-03 Thread Numan Siddique
On Thu, Nov 3, 2022 at 7:10 AM Xavier Simonart wrote: > > On Wed, Nov 2, 2022 at 3:31 PM Dumitru Ceara wrote: > > > On 11/2/22 15:21, Numan Siddique wrote: > > > On Wed, Nov 2, 2022 at 7:39 AM Xavier Simonart > > wrote: > > >> > > >> Hi N

Re: [ovs-dev] [PATCH ovn v3 0/4] Send Rarps for ipv6 router lsp

2022-11-08 Thread Numan Siddique
On Fri, Nov 4, 2022 at 5:00 AM Felix Hüttner via dev wrote: > > previously garps/rarps where only sent for "external" lsp's if these > had an ipv4 address attached. For lsp's on gateway routers that do > not have an ipv4 address assigned (e.g. if they are ipv6 only) no > rarps were send out. > > T

Re: [ovs-dev] [PATCH ovn] northd: bypass connection tracking for stateless flows when there are LB flows present

2022-11-09 Thread Numan Siddique
On Wed, Nov 9, 2022 at 4:11 PM Han Zhou wrote: > > On Tue, Nov 8, 2022 at 7:51 AM venu.iyer wrote: > > > > Currently, even stateless flows are subject to connection tracking when > there are > > LB rules (for DNAT). However, if a flow needs to be subjected to LB, then > it shouldn't > > be config

Re: [ovs-dev] [PATCH ovn] northd: bypass connection tracking for stateless flows when there are LB flows present

2022-11-14 Thread Numan Siddique
On Wed, Nov 9, 2022 at 4:15 PM Numan Siddique wrote: > > On Wed, Nov 9, 2022 at 4:11 PM Han Zhou wrote: > > > > On Tue, Nov 8, 2022 at 7:51 AM venu.iyer wrote: > > > > > > Currently, even stateless flows are subject to connection tracking when > > th

<    1   2   3   4   5   6   7   8   9   10   >