Re: [ovs-dev] [PATCH ovn 0/2] Add IPv6 Prefix delegation (RFC3633)

2019-11-20 Thread Numan Siddique
On Thu, Nov 7, 2019 at 2:18 PM Lorenzo Bianconi wrote: > > Introduce IPv6 Prefix delegation state machine according to RFC 3633 > https://tools.ietf.org/html/rfc3633. > Add dhcp6_server_pkt controller action to parse advertise/reply from > IPv6 delegation server. > Introduce logical flows in ovn

Re: [ovs-dev] [PATCH v4 0/3] Associate identifier with OVN ACL connection tracking entry

2019-11-21 Thread Numan Siddique
On Sat, Nov 9, 2019 at 8:20 AM Ankur Sharma wrote: > > I submitted this patch long time back and somehow lost track it. > Resubmitting the series, calling it as V4, as it addresses the > review comments given till v3. > https://mail.openvswitch.org/pipermail/ovs-dev/2019-April/358280.html > >

Re: [ovs-dev] [PATCH ovn v2 2/2] northd: Improve handling of pause and resume

2019-11-22 Thread Numan Siddique
On Fri, Nov 22, 2019 at 8:22 PM Frode Nordahl wrote: > > Move paused state to ``struct northd_context`` and pass the > context to paused and status command handlers. > > On pause release the OVSDB lock on SB DB. > > Re-instante the lock on resume. > > Status command will now provide accurate

Re: [ovs-dev] [PATCH ovn] testsuite.at: Add ovn-performance.at back to testsuite.

2019-12-02 Thread Numan Siddique
On Tue, Dec 3, 2019 at 4:50 AM Han Zhou wrote: > > It seems the ovn-performance.at was missing when spliting from OVS. > This patch just add it back. > > Signed-off-by: Han Zhou Acked-by: Numan Siddique > --- > tests/testsuite.at | 1 + > 1 file changed, 1 ins

Re: [ovs-dev] [PATCH ovn] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

2019-12-03 Thread Numan Siddique
On Tue, Dec 3, 2019 at 5:38 AM Han Zhou wrote: > > On Mon, Dec 2, 2019 at 12:41 AM Numan Siddique wrote: > > > > On Mon, Dec 2, 2019 at 1:53 PM Han Zhou wrote: > > > > > > On Sun, Dec 1, 2019 at 11:59 PM Numan Siddique wrote: > > > > > &g

Re: [ovs-dev] [PATCH ovn v1] northd: Load config before processing nbdb contents

2019-12-09 Thread Numan Siddique
e MAC address. > > With ovn-kubernetes, whatever first set of addresses were assigned is > what ends up cached on the Node object and used by the Pod. This bug > can cause all of this to get out of sync, breaking network > connectivity for Pods on an OVN virtual network. >

Re: [ovs-dev] [PATCH ovn v1 2/2] northd: Log all dynamic address assignments

2019-12-09 Thread Numan Siddique
; > > We could ... it'd be a little bit extra tracking that would hopefully never > be needed. It'd be a bug if the same message was emitted more than once at > all. > Since this code would not hit all the time when ovn_db_run is called, I think VLOG_INFO should not cause any log fl

Re: [ovs-dev] [PATCH] ovsdb replication: Provider option to configure probe interval.

2019-12-13 Thread Numan Siddique
13/19 9:37 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > When ovsdb-server is in backup mode and connects to the active > > ovsdb-server for replication, and if takes more than 5 seconds to > > get the dump of the whole database, it will drop the connection &

Re: [ovs-dev] [PATCH v2] ovsdb replication: Provide option to configure probe interval.

2019-12-13 Thread Numan Siddique
On Fri, Dec 13, 2019 at 2:23 PM Dumitru Ceara wrote: > > On Fri, Dec 13, 2019 at 11:37 AM wrote: > > > > From: Numan Siddique > > > > When ovsdb-server is in backup mode and connects to the active > > ovsdb-server for replication, and if takes mor

Re: [ovs-dev] [PATCH v3 ovn 2/2] northd: add logical flows for dhcpv6 pfd parsing

2019-12-16 Thread Numan Siddique
On Thu, Dec 5, 2019 at 5:51 AM Lorenzo Bianconi wrote: > > Introduce logical flows in ovn router pipeline in order to parse dhcpv6 > advertise/reply from IPv6 prefix delegation router. > Do not overwrite ipv6_ra_pd_list info in options column of SB port_binding > table written by ovn-controller >

Re: [ovs-dev] [PATCH ovn] system-ovn.at: check HAVE_TCPDUMP in "2 LSs IGMP" test

2019-12-06 Thread Numan Siddique
On Thu, Dec 5, 2019 at 8:10 PM Dumitru Ceara wrote: > > On Thu, Dec 5, 2019 at 11:42 AM Lorenzo Bianconi > wrote: > > > > Do not run "2 LSs IGMP" unitest if tcpdump is not currently installed on > > the machine > > > > Signed-off-by: Lorenzo Bianconi > > Thanks Lorenzo for the patch. It looks

Re: [ovs-dev] [PATCH ovn] system-ovn.at: Fix failing system tests.

2019-12-16 Thread Numan Siddique
the IGMP-related error message. > > > > Signed-off-by: William Tu > > Signed-off-by: Yi-Hung Wei > > Co-authored-by: Yi-Hung Wei > > Signed-off-by: Ben Pfaff > > > > This OVS change was performed in the OVS repo after the OVS-OVN sp

Re: [ovs-dev] [PATCH ovn] controller: Downgrade a warning log message

2019-10-25 Thread Numan Siddique
be to create the chassis record. > > This was found by trying to run the system-ovn.at tests, and they > failed because of these unexpected warning log messages. > > Signed-off-by: Russell Bryant > Acked-by: Numan Siddique Thanks Numan --- > controller/chassis.c | 5 +++-- >

Re: [ovs-dev] [PATCH v2 ovn 1/2] Add RDNSS support to OVN

2019-10-25 Thread Numan Siddique
On Fri, Oct 25, 2019 at 4:18 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > On Wed, Oct 23, 2019 at 8:49 PM Lorenzo Bianconi < > > lorenzo.bianc...@redhat.com> wrote: > > > > > Introduce the possibility to specify a RDNSS option to Router > > > Advertisement packets. DNS IPv6

Re: [ovs-dev] [PATCH v2 1/2 ovn] OVN: ADD nbctl cli to mark a dnat_and_snat rule as stateless

2019-10-28 Thread Numan Siddique
On Thu, Oct 17, 2019 at 10:50 PM Ankur Sharma wrote: > Hi, > > Gentle reminder for reviewing this series. > > Regards, > Ankur > > From: Ankur Sharma > Sent: Friday, October 4, 2019 1:13 PM > To: ovs-dev@openvswitch.org > Cc: Ankur Sharma > Subject: [PATCH v2

Re: [ovs-dev] [PATCH v2 2/2 ovn] OVN: Use ipv4.src and ipv4.dst actions for NAT rules

2019-10-28 Thread Numan Siddique
On Sat, Oct 5, 2019 at 1:45 AM Ankur Sharma wrote: > > For dnat_and_snat rules which are meant to be stateless > instead of using ct_snat/dnat OVN actions, we will use > ipv4.src/ipv4.dst. > > This actions will do 1:1 mapping to inner ip to external ip, > while recalculating the checksums. > >

Re: [ovs-dev] [PATCH ovn 00/19] OVN Interconnection

2019-10-28 Thread Numan Siddique
> For the first 5 patches in the series - Acked-by: Numan Siddique I think these 5 patches can be merged so that the v2 of this series will have lesser patches. Regarding the patch 6, which updates the NEWS, does it makes sense to delete the contents of this file and start fresh capturing only OV

Re: [ovs-dev] [PATCH 2/3] Combine conjunctions with identical matches into one flow.

2019-10-28 Thread Numan Siddique
On Sat, Oct 26, 2019 at 2:37 AM Mark Michelson wrote: > > As stated in previous commits, conjunctive matches have an issue where > it is possible to install multiple flows that have identical matches. > This results in ambiguity, and can lead to features (such as ACLs) not > functioning properly.

Re: [ovs-dev] [PATCH 2/3] Combine conjunctions with identical matches into one flow.

2019-10-28 Thread Numan Siddique
On Mon, Oct 28, 2019, 9:29 PM Mark Michelson wrote: > On 10/28/19 11:33 AM, Numan Siddique wrote: > > On Sat, Oct 26, 2019 at 2:37 AM Mark Michelson > wrote: > >> > >> As stated in previous commits, conjunctive matches have an issue where > >> it is possi

Re: [ovs-dev] [PATCH 1/3] Revert conjunctive match removal patches.

2019-10-28 Thread Numan Siddique
ve match misbehavior described in commit > 298701dbc99645700be41680a43d049cb061847a is restored. However, this will > be fixed in an upcoming commit in this series. > > Signed-off-by: Mark Michelson > Acked-by: Numan Siddique --- > TODO.rst

Re: [ovs-dev] [PATCH 2/3] Combine conjunctions with identical matches into one flow.

2019-10-28 Thread Numan Siddique
On Mon, Oct 28, 2019, 9:54 PM Numan Siddique wrote: > > > On Mon, Oct 28, 2019, 9:29 PM Mark Michelson wrote: > >> On 10/28/19 11:33 AM, Numan Siddique wrote: >> > On Sat, Oct 26, 2019 at 2:37 AM Mark Michelson >> wrote: >> >> >> >>

Re: [ovs-dev] [PATCH v3] OVN: Send RARP for vif ports for which OVN does not know the IP.

2019-10-16 Thread Numan Siddique
On Sat, Oct 12, 2019 at 4:53 AM Ankur Sharma wrote: > ISSUE: > For a VIF port (on a bridged logical switch), OVN sends out > GARPs, advertising port's mac and IP. > > However, if a VIF port (on a bridged logical switch) has not > been assigned an IP, then OVN does not advertise anything. > As a

Re: [ovs-dev] [PATCH] ovsdb-server: Allow replication from older schema version servers.

2019-10-16 Thread Numan Siddique
On Wed, Oct 16, 2019 at 3:21 AM Ben Pfaff wrote: > On Wed, Oct 16, 2019 at 12:20:48AM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Presently, replication is not allowed if there is a schema version > mismatch between > > the schema retur

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Fix IP multicast flooding to mrouter.

2019-10-16 Thread Numan Siddique
On Wed, Oct 16, 2019 at 6:36 PM Dumitru Ceara wrote: > OVN logical flow "drop" actions can't be combined with other actions. > Commit 79308138891a created such a scenario if a logical switch has > mcast_snoop=true, mcast_flood_unregistered=false and is connected to a > logical router with

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix IP multicast flooding to mrouter.

2019-10-16 Thread Numan Siddique
On Wed, Oct 16, 2019 at 4:11 PM Dumitru Ceara wrote: > OVN logical flow "drop" actions can't be combined with other actions. > Commit 79308138891a created such a scenario if a logical switch has > mcast_snoop=true, mcast_flood_unregistered=false and is connected to a > logical router with

Re: [ovs-dev] [PATCH ovn] ovn-controller.c: Fix memory leak of local_datapath->ports.

2019-10-22 Thread Numan Siddique
On Tue, Oct 22, 2019 at 5:19 AM Han Zhou wrote: > Fixes: 89f5048f960c ("ovn-controller: Minimize SB DB port_binding > lookups.") > Signed-off-by: Han Zhou > Acked-by: Numan Siddique Numan > --- > controller/ovn-controller.c | 2 ++ > 1 file changed,

Re: [ovs-dev] [PATCH ovn v2] tests: Fix check-valgrind and check-lcov.

2019-10-22 Thread Numan Siddique
once for all. > > Signed-off-by: Han Zhou > Acked-by: Numan Siddique Numan > --- > tests/automake.mk | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/automake.mk b/tests/automake.mk > index 013e592..47e6a5d 100644 > --- a/tests/automa

Re: [ovs-dev] [PATCH] rhel: Remove the cond 'build_python3'

2019-10-22 Thread Numan Siddique
On Mon, Oct 21, 2019 at 10:51 PM Ben Pfaff wrote: > On Mon, Oct 21, 2019 at 03:12:42PM +0530, num...@ovn.org wrote: > > From: Numan Siddique > > > > A previous patch removed python2 support from ovs. So we can remove > > this condition and make python3 ma

Re: [ovs-dev] [PATCH ovn] lflow.c: Fix memory leak of lflow_ref_list_node->ref_name.

2019-10-22 Thread Numan Siddique
lete it from lflow_ref_list_node, together with the > "type" field. > > Fixes: d2aa2c7cafead ("ovn-controller: Maintain resource references for > logical flows.") > Signed-off-by: Han Zhou > Acked-by: Numan Siddique > --- > controller/lflow.c | 2 -- >

Re: [ovs-dev] [PATCH ovn] tests/system-ovn: Ignore some ovn-controller warnings

2019-10-24 Thread Numan Siddique
On Fri, Oct 25, 2019, 7:59 AM Numan Siddique wrote: > > > On Fri, Oct 25, 2019, 6:56 AM Russell Bryant wrote: > >> This log message was introduced in commit 5344f24ecb. It may be more >> appropriate as a deubg message, but as a warning, it breaks this test >&

Re: [ovs-dev] [PATCH ovn] tests/system-ovn: Ignore some ovn-controller warnings

2019-10-24 Thread Numan Siddique
On Fri, Oct 25, 2019, 6:56 AM Russell Bryant wrote: > This log message was introduced in commit 5344f24ecb. It may be more > appropriate as a deubg message, but as a warning, it breaks this test > suite. > Filtering it out of the logs gets these tests passing for me. > > A sample of the

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: Limit ARP/ND broadcast domain whenever possible.

2019-10-24 Thread Numan Siddique
On Wed, Oct 23, 2019 at 12:41 PM Dumitru Ceara wrote: > ARP request and ND NS packets for router owned IPs were being > flooded in the complete L2 domain (using the MC_FLOOD multicast group). > However this creates a scaling issue in scenarios where aggregation > logical switches are connected

Re: [ovs-dev] [PATCH v2 ovn 1/2] Add RDNSS support to OVN

2019-10-24 Thread Numan Siddique
On Wed, Oct 23, 2019 at 8:49 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Introduce the possibility to specify a RDNSS option to Router > Advertisement packets. DNS IPv6 address can be specified using > 'rdnss' tag in the ipv6_ra_configs column of logical router > port table > >

Re: [ovs-dev] [PATCH v4 ovn 1/2] Add RDNSS support to OVN

2019-10-29 Thread Numan Siddique
On Mon, Oct 28, 2019 at 8:09 PM Lorenzo Bianconi wrote: > > Introduce the possibility to specify a RDNSS option to Router > Advertisement packets. DNS IPv6 address can be specified using > 'rdnss' tag in the ipv6_ra_configs column of logical router > port table > > Acked-by: Mark Michelson >

Re: [ovs-dev] [PATCH ovn] ovndb-servers.ocf: Change from 'openvswitch' to 'ovn' in default vars.

2019-10-29 Thread Numan Siddique
On Mon, Oct 28, 2019 at 10:57 PM Ben Pfaff wrote: > > On Mon, Oct 28, 2019 at 10:25:34AM -0700, Ben Pfaff wrote: > > On Mon, Oct 28, 2019 at 08:04:15PM +0530, num...@ovn.org wrote: > > > From: Numan Siddique > > > > > > CC: Aliasgar Ginwala > > >

Re: [ovs-dev] [PATCH v4 ovn 2/2] Add DNSSL support to OVN

2019-10-29 Thread Numan Siddique
On Mon, Oct 28, 2019 at 8:10 PM Lorenzo Bianconi wrote: > > Introduce the possibility to specify a DNSSL option to Router > Advertisement packets. DNS Search list can be specified using > 'dnssl' tag in the ipv6_ra_configs column of logical router > port table > > Signed-off-by: Lorenzo Bianconi

Re: [ovs-dev] [PATCH ovn] ovndb-servers.ocf: Change from 'openvswitch' to 'ovn' in default vars.

2019-10-29 Thread Numan Siddique
On Tue, Oct 29, 2019 at 1:31 PM Numan Siddique wrote: > > On Mon, Oct 28, 2019 at 10:57 PM Ben Pfaff wrote: > > > > On Mon, Oct 28, 2019 at 10:25:34AM -0700, Ben Pfaff wrote: > > > On Mon, Oct 28, 2019 at 08:04:15PM +0530, num...@ovn.org wrote: > > > > F

Re: [ovs-dev] [PATCH v5 ovn] Add DNSSL support to OVN

2019-10-29 Thread Numan Siddique
On Tue, Oct 29, 2019 at 3:29 PM Lorenzo Bianconi wrote: > > Introduce the possibility to specify a DNSSL option to Router > Advertisement packets. DNS Search list can be specified using > 'dnssl' tag in the ipv6_ra_configs column of logical router > port table > > Signed-off-by: Lorenzo Bianconi

Re: [ovs-dev] [PATCH v6 ovn] Add DNSSL support to OVN

2019-10-29 Thread Numan Siddique
On Tue, Oct 29, 2019 at 5:49 PM Lorenzo Bianconi wrote: > > Introduce the possibility to specify a DNSSL option to Router > Advertisement packets. DNS Search list can be specified using > 'dnssl' tag in the ipv6_ra_configs column of logical router > port table > > Signed-off-by: Lorenzo Bianconi

Re: [ovs-dev] [PATCH v5 ovn] Add DNSSL support to OVN

2019-10-29 Thread Numan Siddique
On Tue, Oct 29, 2019 at 4:39 PM Lorenzo Bianconi wrote: > > > On Tue, Oct 29, 2019 at 3:29 PM Lorenzo Bianconi > > wrote: > > > > > > Introduce the possibility to specify a DNSSL option to Router > > > Advertisement packets. DNS Search list can be specified using > > > 'dnssl' tag in the

Re: [ovs-dev] [PATCH ovn] Fix system-ovn test failures

2019-10-29 Thread Numan Siddique
; > Acked-by: hz...@ovn.org > > > > On Tue, Oct 29, 2019 at 5:26 AM wrote: > > > > > From: Numan Siddique > > > > > > The commit b740928656a1("testsuite: Use ovn-macros instead of > > > ofproto-macros.") > > > missed updating t

Re: [ovs-dev] [PATCH ovn] ovn.at: Fix vtep autotest.

2019-10-18 Thread Numan Siddique
; > however hidden by the "|| return 1" when failing to create the vtep DB. > > > > Fix the path to the vtep schema and make potential failures visible. > > > > CC: Numan Siddique > > Fixes: 84bf7d8435b8 ("Remove ovs subtree") > > Signed-off-by: D

Re: [ovs-dev] [PATCH ovn] Fix virtual port binding when the parents are scheduled in the same chassis

2019-10-17 Thread Numan Siddique
On Thu, Oct 17, 2019 at 3:09 PM Dumitru Ceara wrote: > On Wed, Oct 16, 2019 at 7:01 PM wrote: > > > > From: Numan Siddique > > > > If a virtual port has 2 parents and if both of them are scheduled > > on the same chassis, then virtual port binding doesn't work.

Re: [ovs-dev] [PATCH v3 ovn 1/2] Add RDNSS support to OVN

2019-10-25 Thread Numan Siddique
On Fri, Oct 25, 2019 at 11:15 PM Ben Pfaff wrote: > On Fri, Oct 25, 2019 at 03:45:49PM +0200, Lorenzo Bianconi wrote: > > +/* RDNSS option RFC 6106 */ > > +#define ND_RDNSS_OPT_LEN8 > > +#define ND_OPT_RDNSS25 > > +struct nd_rdnss_opt { > > +uint8_t type; /* ND_OPT_RDNSS.

Re: [ovs-dev] [PATCH ovn] Add RDNSS support to OVN

2019-10-23 Thread Numan Siddique
On Sat, Oct 19, 2019 at 12:08 AM Mark Michelson wrote: > Acked-by: Mark Michelson > > On 10/18/19 7:09 AM, Lorenzo Bianconi wrote: > > Introduce the possibility to specify a RDNSS option to Router > > Advertisement packets. DNS IPv6 address can be specified using > > 'rdnss' tag in the

Re: [ovs-dev] [PATCH ovn] Add DNSSL support to OVN

2019-10-23 Thread Numan Siddique
On Mon, Oct 21, 2019 at 10:49 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > Introduce the possibility to specify a DNSSL option to Router > Advertisement packets. DNS Search list can be specified using > 'dnssl' tag in the ipv6_ra_configs column of logical router > port table > >

Re: [ovs-dev] [PATCH ovn v3] northd: Add `status` management command

2019-11-20 Thread Numan Siddique
On Wed, Nov 20, 2019 at 3:10 PM Frode Nordahl wrote: > > Hello Numan, > > Have you had a chance to take a look at my updated proposal? > > Based on your feedback of `is-active` could be confusing since we have > `is-paused` which is used for something else, the best option I could > think of was

Re: [ovs-dev] [PATCH ovn] northd: Match IPv4 or IPv6 for MAC resolution

2019-11-19 Thread Numan Siddique
ether you'd hit the IPv4 (ARP) or IPv6 (NS) version. > > This change adds an ip4 or ip6 match to each flow as appropriate. > > Signed-off-by: Russell Bryant Acked-by: Numan Siddique > --- > northd/ovn-northd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) &

Re: [ovs-dev] [PATCH ovn v2 00/13] OVN Interconnection

2019-11-26 Thread Numan Siddique
On Wed, Nov 27, 2019, 7:25 AM Han Zhou wrote: > On Sun, Nov 17, 2019 at 10:55 PM Numan Siddique wrote: > > > > On Mon, Nov 18, 2019 at 8:22 AM Han Zhou wrote: > > > > > > On Sat, Nov 16, 2019 at 4:03 AM Numan Siddique wrote: > > > > > > >

Re: [ovs-dev] [PATCH ovn v3 0/2] northd: Improve pause, resume and status

2019-11-26 Thread Numan Siddique
On Sat, Nov 23, 2019 at 3:20 PM Frode Nordahl wrote: > > At present when the ``pause`` command is issued any lock the > ``ovn-northd`` process holds on the SB DB will be kept. > > To be able to change this behaviour the tests surrounding pause and > resume must be changed, thus I provide the

Re: [ovs-dev] [PATCH ovn] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

2019-12-02 Thread Numan Siddique
On Mon, Dec 2, 2019 at 12:44 PM Han Zhou wrote: > > On Fri, Nov 29, 2019 at 1:08 AM wrote: > > > > From: Numan Siddique > > > > If ofctrl_check_and_add_flow(F') is called where flow F' has > match-actions (M, A2) > > and if there already ex

Re: [ovs-dev] [PATCH ovn] ofctrl_check_and_add_flow: Replace the actions of an existing flow if actions have changed.

2019-12-02 Thread Numan Siddique
On Mon, Dec 2, 2019 at 1:53 PM Han Zhou wrote: > > On Sun, Dec 1, 2019 at 11:59 PM Numan Siddique wrote: > > > > On Mon, Dec 2, 2019 at 12:44 PM Han Zhou wrote: > > > > > > On Fri, Nov 29, 2019 at 1:08 AM wrote: > > > > > > > > From:

Re: [ovs-dev] [PATCH ovn v1] northd: Remove misleading warning log message

2019-12-02 Thread Numan Siddique
rrectly avoided assigning a duplicate MAC address. This patch > turns off the warning for that case. > > Signed-off-by: Russell Bryant Acked-by: Numan Siddique Numan > --- > northd/ovn-northd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [ovs-dev] [PATCH ovn v3] Require Python 3 and remove support for Python 2.

2019-11-25 Thread Numan Siddique
On Sat, Nov 23, 2019 at 12:47 AM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks for the review. I applied this patch to master. Numan > > On 11/22/19 12:21 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > OVS removed the support

Re: [ovs-dev] [PATCH] Documentation: Convert multiple manpages to ReST.

2019-11-27 Thread Numan Siddique
On Thu, Nov 28, 2019 at 12:49 PM Numan Siddique wrote: > > On Wed, Nov 27, 2019 at 4:10 AM Ben Pfaff wrote: > > > > On Thu, Oct 10, 2019 at 02:29:42PM -0700, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > > > Still needs review. > > Hi Ben, >

Re: [ovs-dev] [PATCH] Documentation: Convert multiple manpages to ReST.

2019-11-27 Thread Numan Siddique
On Wed, Nov 27, 2019 at 4:10 AM Ben Pfaff wrote: > > On Thu, Oct 10, 2019 at 02:29:42PM -0700, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > Still needs review. Hi Ben, Can you please rebase this patch. It doesn't apply. Thanks Numan > ___ >

Re: [ovs-dev] [PATCH ovn] ovn-controller: Consider non-virtual ports first when updating bindings.

2019-11-28 Thread Numan Siddique
> gets the SB update notification before the "transaction successful" > > notification. In such cases the incremental engine doesn't run > > (ovnsb_idl_txn == NULL) and a full recompute is scheduled for the next > > run. By batching the two SB updates in a single transact

Re: [ovs-dev] [PATCH v2 ovn 1/2] controller: add ipv6 prefix delegation state machine

2019-11-28 Thread Numan Siddique
On Thu, Nov 28, 2019 at 3:53 PM Numan Siddique wrote: > > On Tue, Nov 26, 2019 at 5:21 PM Lorenzo Bianconi > wrote: > > > > Introduce IPv6 Prefix delegation state machine according to RFC 3633 > > https://tools.ietf.org/html/rfc3633. > > Add handle_dhcpv6

Re: [ovs-dev] [PATCH ovn 2/2] Add support for Route Info Option in RA - RFC 4191

2019-11-28 Thread Numan Siddique
On Thu, Nov 14, 2019 at 5:10 PM Lorenzo Bianconi wrote: > > Introduce support for Route Info Option sent in Router > Advertisement according to RFC 4191. Route Info Option are > configured providing route_info in ipv6_ra_configs column of > Logical_Router_Port table. route_info is a comma

Re: [ovs-dev] [PATCH v2 ovn 1/2] controller: add ipv6 prefix delegation state machine

2019-11-28 Thread Numan Siddique
On Tue, Nov 26, 2019 at 5:21 PM Lorenzo Bianconi wrote: > > Introduce IPv6 Prefix delegation state machine according to RFC 3633 > https://tools.ietf.org/html/rfc3633. > Add handle_dhcpv6_reply controller action to parse advertise/reply from > IPv6 delegation server. Advertise/reply are parsed

Re: [ovs-dev] [PATCH ovn 1/2] Add support to Default Router Preference (PRF) - RFC 4191

2019-11-28 Thread Numan Siddique
On Thu, Nov 14, 2019 at 5:10 PM Lorenzo Bianconi wrote: > > Introduce support for Default Router Preference (PRF) in IPv6 Router > Advertisement according to RFC 4191 > > Signed-off-by: Lorenzo Bianconi Thanks Lorenzo for the patches. The patch LGTM. Just one comment 1. Can you please

Re: [ovs-dev] [PATCH] ofproto: fix stack-buffer-overflow

2019-11-29 Thread Numan Siddique
Stack right redzone: f3 > Stack after return: f5 > Stack use after scope: f8 > Global redzone: f9 > Global init order: f6 > Poisoned by user:f7 > Container overflow: fc > Array cookie:ac > Intra object redzone:

Re: [ovs-dev] [PATCH v4 0/2] ALLOW Stateless NAT operations

2019-11-01 Thread Numan Siddique
On Fri, Nov 1, 2019, 2:57 PM Numan Siddique wrote: > On Fri, Nov 1, 2019 at 6:58 AM Ankur Sharma > wrote: > > > > NAT implementation in OVN uses connection tracker to replace > > source and dest ips. This implementation works fine and > > is the right approac

Re: [ovs-dev] [PATCH ovn] Improve debuggability of OVN to OpenFlow translations.

2019-11-04 Thread Numan Siddique
Thanks for the patch. It would be really helpful in debugging. I applied this to master. Thanks Numan On Sat, Nov 2, 2019 at 2:39 AM Mark Michelson wrote: > > Great addition, Dumitru! > > Acked-by: Mark Michelson > > On 11/1/19 8:05 AM, Dumitru Ceara wrote: > > Until now, when translating SB

Re: [ovs-dev] [PATCH ovn] Skip IPv6 NS packets in router egress SNAT pipeline

2019-11-19 Thread Numan Siddique
On Tue, Nov 19, 2019 at 11:41 PM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks. I applied this to master. Numan > > On 11/19/19 7:22 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > When ovn-controller injects IPv6 NS packet to lea

Re: [ovs-dev] [PATCH ovn] ovn-northd: Avoid empty address list when limiting ARP/ND broadcast.

2019-11-14 Thread Numan Siddique
On Thu, Nov 14, 2019 at 6:14 PM Dumitru Ceara wrote: > > Reported-by: Numan Siddique > Fixes: 32f5ebb06226 ("ovn-northd: Limit ARP/ND broadcast domain whenever > possible.") > Signed-off-by: Dumitru Ceara Thanks Dumitru for the fix. I applied this to master. Thanks N

Re: [ovs-dev] [PATCH v2 ovn 0/2] Add support for PRF and Route Info Option in RA (RFC 4191)

2019-11-28 Thread Numan Siddique
On Thu, Nov 28, 2019 at 6:19 PM Lorenzo Bianconi wrote: > > Changes since v1: > - rename prf in router_preference in OVN NB DB > - allocate space for ovs_nd_route_info in ovs packet after data validation > > Lorenzo Bianconi (2): > Add support to Default Router Preference (PRF) - RFC 4191 >

Re: [ovs-dev] [PATCH ovn v2] Learn the mac binding only if required

2019-09-24 Thread Numan Siddique
Thanks Han for the reviews. Please see below for some comments. Thanks Numan On Wed, Sep 18, 2019 at 4:56 AM Han Zhou wrote: > > On Mon, Sep 16, 2019 at 10:17 AM wrote: > > > > From: Numan Siddique > > > > OVN has the actions - put_arp and put_nd

Re: [ovs-dev] Time to remove the OVS subtree from OVN repo

2019-09-25 Thread Numan Siddique
On Tue, Sep 24, 2019 at 2:25 AM Ben Pfaff wrote: > On Tue, Sep 24, 2019 at 01:27:57AM +0530, Numan Siddique wrote: > > Hi, > > > > Now that OVN is compiled with OVS sources from external sources, I think > we > > can go ahead and delete the ovs subtree [1], > &

Re: [ovs-dev] [PATCH ovn 0/1] Remove ovs subtree

2019-09-25 Thread Numan Siddique
On Wed, Sep 25, 2019 at 9:51 PM Ben Pfaff wrote: > On Wed, Sep 25, 2019 at 02:53:53PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > We can delete the ovs subtree as OVN doesn't depend on this folder any > more > > for compilation. > > &

Re: [ovs-dev] [PATCH v3] Require Python 3 and remove support for Python 2.

2019-09-25 Thread Numan Siddique
On Thu, Sep 26, 2019, 12:12 AM Ben Pfaff wrote: > Numan, please (re-)review this when you have time. > Sure. I will do it tomorrow Thanks Numan > On Fri, Sep 20, 2019 at 08:44:48AM -0700, Ben Pfaff wrote: > > Python 2 reaches end-of-life on January 1, 2020, which is only > > a few months

Re: [ovs-dev] [PATCH ovn] Partially revert "Exclude inport and outport symbol tables from conjunction."

2019-10-07 Thread Numan Siddique
On Wed, Oct 2, 2019 at 2:54 AM Han Zhou wrote: > > > On Mon, Sep 30, 2019 at 6:51 AM wrote: > > > > From: Numan Siddique > > > > This partially revers the commit - > 298701dbc99645700be41680a43d049cb061847a > > as the commit [1] disables the conj

Re: [ovs-dev] [PATCH ovn v4] Document process for compatibility between OVS and OVN.

2019-10-09 Thread Numan Siddique
> > It also creates a document to detail compatibility of specific OVN > versions. > > Signed-off-by: Mark Michelson > Acked-by: Han Zhou > Acked-by: Numan Siddique > --- > v3 -> v4: > * Addressed grammatical fixes > --- > v2 -> v3: > * Rem

Re: [ovs-dev] [PATCH ovn] ovn-ctl: Create etcdir when starting ovsdb servers

2019-10-13 Thread Numan Siddique
On Sun, Oct 13, 2019 at 4:31 AM aginwala wrote: > Acked-by: Aliasgar Ginwala > > Thanks for the review. I applied this to master. Numan > > On Sat, Oct 12, 2019 at 1:16 PM wrote: > >> From: Numan Siddique >> >> 'ovn-ctl promote_ovnnb/promote_ovnsb'

Re: [ovs-dev] [PATCH] ovsdb-server: Don't drop all connections on read/write status change.

2019-10-14 Thread Numan Siddique
On Mon, Oct 14, 2019 at 2:23 PM Dumitru Ceara wrote: > On Mon, Oct 14, 2019 at 8:21 AM wrote: > > > > From: Numan Siddique > > > > The commit [1] force drops all connections when the db read/write status > changes. > > Prior to the commit [1], whe

Re: [ovs-dev] [PATCH v3] ovsdb-server: Don't drop all connections on read/write status change.

2019-10-14 Thread Numan Siddique
On Mon, Oct 14, 2019 at 11:45 PM Numan Siddique wrote: > > > On Mon, Oct 14, 2019 at 11:37 PM Ben Pfaff wrote: > >> On Mon, Oct 14, 2019 at 08:50:02PM +0530, nusid...@redhat.com wrote: >> > From: Numan Siddique >> > >> > The commit [1] force

Re: [ovs-dev] [PATCH v3] ovsdb-server: Don't drop all connections on read/write status change.

2019-10-14 Thread Numan Siddique
On Mon, Oct 14, 2019 at 11:37 PM Ben Pfaff wrote: > On Mon, Oct 14, 2019 at 08:50:02PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > The commit [1] force drops all connections when the db read/write status > changes. > > Prior to the commit

Re: [ovs-dev] [PATCH v3] ovsdb-server: Don't drop all connections on read/write status change.

2019-10-14 Thread Numan Siddique
On Mon, Oct 14, 2019, 11:42 PM Han Zhou wrote: > > > On Mon, Oct 14, 2019 at 8:20 AM wrote: > >> From: Numan Siddique >> >> The commit [1] force drops all connections when the db read/write status >> changes. >> Prior to the commit [1], when there was

Re: [ovs-dev] [PATCH ovn v3] ovn-northd: ls_*_acl behavior not consistent for untracked flows

2019-12-20 Thread Numan Siddique
On Fri, Dec 20, 2019 at 12:15 AM wrote: > > From: venu iyer > > If one creates a port group and a MAC address set, and an > ACL that prevents packets being output to a port in that Port Group from > any MAC address in that address set, the outcome is not consistent. > > The outcome depends on

Re: [ovs-dev] [PATCH v3] ovsdb replication: Provide option to configure probe interval.

2019-12-20 Thread Numan Siddique
On Fri, Dec 20, 2019 at 12:28 AM Ben Pfaff wrote: > > On Fri, Dec 13, 2019 at 03:15:36PM -0500, num...@ovn.org wrote: > > From: Numan Siddique > > > > When ovsdb-server is in backup mode and connects to the active > > ovsdb-server for replication, and if takes

Re: [ovs-dev] [ovs-dev, ovn, 1/2] ovn-nbctl.c: Add "name" column of QoS table.

2019-12-20 Thread Numan Siddique
On Fri, Dec 20, 2019 at 1:39 PM taoyunxi...@cmss.chinamobile.com wrote: > > Hi, Could you review this patch。It is an important QoS feature for plugin of > OVN. Hi Taoyunxiang, I am sorry for the delay. Looks like I missed these patches. The patch doesn't apply to the present master. Can you

Re: [ovs-dev] [PATCH ovn v2] ovn-northd: ls_*_acl behavior notconsistent for untracked flows

2019-12-19 Thread Numan Siddique
On Tue, Dec 17, 2019 at 11:11 PM venugopal iyer via dev wrote: > > Would appreciate any thoughts on this. > thanks, > -venu Hi Venu, The patch doesn't apply cleanly. Can you please rebase and submit v3. Thanks Numan > > On Tuesday, November 19, 2019, 12:40:47 PM PST, > wrote: > >

Re: [ovs-dev] [PATCH ovn] Fix tcp_reset action handling

2020-02-10 Thread Numan Siddique
On Mon, Feb 10, 2020 at 6:52 PM Lorenzo Bianconi wrote: > > > > > From: Numan Siddique > > > > The current handling of tcp_reset, has few issues. > > > > 1. The IP and TCP checksum of the packet injected by ovn-controller is > > wro

Re: [ovs-dev] [PATCH ovn] ovn-controller: Fix memory issues due to lflow expr caching.

2020-02-12 Thread Numan Siddique
On Wed, Feb 12, 2020 at 5:44 PM Dumitru Ceara wrote: > > On 2/12/20 12:11 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > The patch [1], which added caching of lflow expr introduced a memory > > leak. The patch [1] also didn't take care of deletin

Re: [ovs-dev] [PATCH ovn] pinctrl: fix IP buffering with connection-tracking

2020-02-13 Thread Numan Siddique
ion tracking to properly SNAT/DNAT the packet. > > Do not overwrite the MFF_IN_PORT in consider_port_binding routine > > > > Signed-off-by: Numan Siddique > > Signed-off-by: Lorenzo Bianconi > > The sign-offs are a bit odd here. Should one be an Acked-by? Hi Ben, I

Re: [ovs-dev] [PATCH ovn] build: ensure python3 is used for all python scripts

2020-02-13 Thread Numan Siddique
On Fri, Feb 14, 2020 at 1:14 AM wrote: > > From: James Page > > As OVN is Python 3 only ensure that the build process only > uses PYTHON3 and not PYTHON. > > Signed-off-by: James Page This patch was submitted as PR here - https://github.com/ovn-org/ovn/pull/34 I applied this to master.

Re: [ovs-dev] [PATCH ovn] ovn-northd: Fix IP local multicast flooding.

2020-02-26 Thread Numan Siddique
On Thu, Feb 27, 2020 at 2:24 AM Mark Michelson wrote: > > Acked-by: Mark Michelson Thanks Dumitru and Mark. I applied this patch to master and branch-20.03 Thanks Numan > > On 2/14/20 5:42 AM, Dumitru Ceara wrote: > > Skip IGMP and MLD entries learned for local multicast groups when > >

Re: [ovs-dev] [PATCH branch-20.03 1/2] Set release date for 20.03.0

2020-03-01 Thread Numan Siddique
On Sat, Feb 29, 2020 at 2:44 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Since this patch didn't get merged on 28th Feb, Do you need to set the release date to the date on which this patch is merged ? Thanks Numan > --- > NEWS

Re: [ovs-dev] [PATCH branch-20.03 2/2] Prepare for 20.03.1

2020-03-01 Thread Numan Siddique
On Sat, Feb 29, 2020 at 2:44 AM Mark Michelson wrote: > > Signed-off-by: Mark Michelson Acked-by: Numan Siddique Thanks Numan > --- > NEWS | 3 +++ > configure.ac | 2 +- > debian/changelog | 6 ++ > 3 files changed, 10 insertions(+), 1 deletion(-)

Re: [ovs-dev] [PATCH v2 ovn] manage ARP process locally in a DVR scenario

2020-03-01 Thread Numan Siddique
On Thu, Feb 27, 2020 at 11:21 PM Lorenzo Bianconi wrote: > > OVN currently performs L2 address resolution and IP buffering on the > gw node. If the system relies on FIPs, OVN will re-inject the buffered > IP packets on the gw node, while following packets will go though > the localnet port on the

Re: [ovs-dev] [PATCH ovn] Broadcast DHCPREPLY when BROADCAST flag is set

2020-03-04 Thread Numan Siddique
Thanks for the patch. Please see below for few comments. Thanks Numan On Wed, Mar 4, 2020 at 8:57 PM Ilya Maximets wrote: > > On 3/4/20 3:10 PM, Ihar Hrachyshka wrote: > > As per RFC2131, section 4.1: > >A server or relay agent sending or relaying a DHCP message directly > >to a DHCP

Re: [ovs-dev] [PATCH ovn] ovn-northd: Add the option to configure probe interval

2020-03-04 Thread Numan Siddique
rote: > > External email: Use caution opening links or attachments > > > From: Numan Siddique > > This patch adds the option 'NB_Global.options:probe_interval' to > configure the probe interval for the North and South db connections > from ovn-no

Re: [ovs-dev] [PATCH ovn v3] Broadcast DHCPREPLY when BROADCAST flag is set

2020-03-04 Thread Numan Siddique
On Thu, Mar 5, 2020 at 1:45 AM Ihar Hrachyshka wrote: > > As per RFC2131, section 4.1: >A server or relay agent sending or relaying a DHCP message directly >to a DHCP client (i.e., not to a relay agent specified in the >'giaddr' field) SHOULD examine the BROADCAST bit in the 'flags' >

Re: [ovs-dev] [PATCH ovn] system tests: Fix occasional failure of the test - "Load balancer health checks".

2020-03-04 Thread Numan Siddique
On Wed, Mar 4, 2020 at 6:35 PM Dumitru Ceara wrote: > > On 2/28/20 5:39 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > Due to some timing issues, ovn-controller logs the warning message - > > "handle service check: Service monitor not found&q

Re: [ovs-dev] Creation of network using ovs in Docker

2020-03-04 Thread Numan Siddique
On Mon, Mar 2, 2020 at 2:31 PM bita wrote: > > > Hi, I have the same issue, > My ovs and ovn versions are 2.10.2 > I want to connect my two docker containers using OVS-DPDK. > Dpdk version: 17.11.9 > root@ubuntu:~# docker network create -d openvswitch --subnet=192.168.88.0/24 > ovs > Error

Re: [ovs-dev] [PATCH ovn] ovn-northd: Add the option to configure probe interval

2020-03-04 Thread Numan Siddique
On Thu, Mar 5, 2020 at 11:40 AM Girish Moodalbail wrote: > > Hello Numan, > > On 3/4/20, 9:58 PM, "Numan Siddique" wrote: > > External email: Use caution opening links or attachments > > > On Thu, Mar 5, 2020 at 10:22 AM Girish Moodalbail >

Re: [ovs-dev] [PATCH v3 ovn] manage ARP process locally in a DVR scenario

2020-03-02 Thread Numan Siddique
On Mon, Mar 2, 2020 at 3:08 PM Lorenzo Bianconi wrote: > > OVN currently performs L2 address resolution and IP buffering on the > gw node. If the system relies on FIPs, OVN will re-inject the buffered > IP packets on the gw node, while following packets will go though > the localnet port on the

Re: [ovs-dev] [PATCH ovn] ovn-controller: Revert lflow expr caching

2020-02-28 Thread Numan Siddique
On Fri, Feb 28, 2020, 3:13 AM Mark Michelson wrote: > *sigh* > > Acked-by: Mark Michelson > Thanks. I applied this patch to master and branch-20.03 Thanks Numan > :( > > On 2/25/20 10:50 AM, num...@ovn.org wrote: > > From: Numan Siddique > > > > Thi

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: No bridge for localnet port is not an error

2020-02-28 Thread Numan Siddique
On Thu, Feb 27, 2020 at 6:46 PM Frode Nordahl wrote: > > There is a pattern among CMSes to create a `localnet` port > binding without any chassis affiliation. > > It is then up to the user to configure chassis with external > connectivity by adding a mapping under the >

Re: [ovs-dev] [PATCH ovn] logical-fields: fix memory leak caused by initialize ovnfield_by_name twice

2020-02-28 Thread Numan Siddique
On Fri, Feb 28, 2020 at 4:11 PM Damijan Skvarc wrote: > > Hi Mark > > and thanks you made review of suggested patch. > > just a few words of myself... > I don't work professionally on this project, I started to look into this > code in my free hours just to satisfy my curiosity about how other

<    2   3   4   5   6   7   8   9   10   11   >