s
> Reviewed-by: Pieter Jansen van Vuuren
> Reviewed-by: Simon Horman
Thanks Louis.
Everyone else,
are there any objections to me applying this change?
> ---
> lib/meta-flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/meta-flow.c b/lib/meta
On Thu, Jun 07, 2018 at 09:36:59AM +0300, Gavi Teitz wrote:
> Previously, any rule that is offloaded via a netdev, not necessarily
> to the HW, would be reported as "offloaded". This patch fixes this
> misalignment, and introduces the 'dp' state, as follows:
>
> rule is in HW via TC offload -> of
On Wed, Jun 06, 2018 at 07:41:08AM -0700, Ben Pfaff wrote:
> On Wed, Jun 06, 2018 at 11:47:13AM +0200, Simon Horman wrote:
> > On Tue, May 29, 2018 at 08:51:15PM +0200, Louis Peens wrote:
> > > The error message states that "not_first" is a valid selection
> > &g
On Sun, Jun 10, 2018 at 03:05:39PM +, Gavi Teitz wrote:
> From: Simon Horman, Sent: Thursday, June 7, 2018 3:13 PM
> >On Thu, Jun 07, 2018 at 09:36:59AM +0300, Gavi Teitz wrote:
> >> Previously, any rule that is offloaded via a netdev, not necessarily
> >> to t
On 21 June 2018 at 18:15, Ben Pfaff wrote:
> Simon, I see that you have reviewed these patches. Are you handling
> this series?
>
Hi Ben,
yes, I reviewed these patches during internal review.
I'm happy to handle the series now its in external review.
> On Thu, Jun 21, 2018 at 02:35:55PM +010
On Thu, Jun 21, 2018 at 04:31:35PM -0700, Ben Pfaff wrote:
> On Thu, Jun 21, 2018 at 06:27:19PM +0200, Simon Horman wrote:
> > On 21 June 2018 at 18:15, Ben Pfaff wrote:
> >
> > > Simon, I see that you have reviewed these patches. Are you handling
> > > t
On Thu, Jun 28, 2018 at 05:03:01PM +0100, John Hurley wrote:
> This patchset extends OvS TC and the linux-netdev implementation to
> support the offloading of Linux Link Aggregation devices (LAG) and their
> slaves. TC blocks are used to provide this offload. Blocks, in TC, group
> together a serie
On Mon, Jul 02, 2018 at 12:07:58PM +0300, Roi Dayan wrote:
> When adding TC rules we save the prio so can reuse same prio
> for same mask since different mask will have to use different prio.
> The multi mask per prio probe broke this by using a prio but
> get_prio_for_tc_flower() didn't know about
On Sun, Jul 08, 2018 at 02:15:38PM +0300, Gavi Teitz wrote:
> Added new types to the flow dump filter, and allowed multiple filter
> types to be passed at once, as a comma separated list. The new types
> added are:
> * tc - specifies flows handled by the tc dp
> * non-offloaded - specifies flows
tree to finish before applying this series.
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Thu, Jul 12, 2018 at 09:46:40AM +0300, Roi Dayan wrote:
>
>
> On 11/07/2018 16:24, Simon Horman wrote:
> > On Sun, Jul 08, 2018 at 02:15:38PM +0300, Gavi Teitz wrote:
> >> Added new types to the flow dump filter, and allowed multiple filter
> >> types
On Tue, Jul 24, 2018 at 10:15:27AM +0200, Simon Horman wrote:
> On Tue, Jul 17, 2018 at 02:01:53AM +, Jianbo Liu wrote:
> > This patchset is to support QinQ offloading, as TC flower supports QinQ.
> >
> > v3:
> > fix checkpatch warning in patch 4.
> >
> >> number of issues with style, build breakage, and failing unit tests.
> >> The patch is being reverted so that they can addressed.
> >>
> >> This reverts commit ab15e70eb5878b46f8f84da940ffc915b6d74cad.
> >>
> >> CC: Gavi Teitz
> >> CC:
On 25 July 2018 at 23:13, Justin Pettit wrote:
>
> > On Jul 25, 2018, at 9:17 AM, Simon Horman
> wrote:
> >
> > On Thu, Jul 12, 2018 at 09:46:40AM +0300, Roi Dayan wrote:
> >>
> >> it could.
> >> currently offload unit tests in the repo fail a
Hi Or,
On Wed, Jul 25, 2018 at 09:20:06PM +0300, Or Gerlitz wrote:
> TTL can and should be used to match on IPv6's hop-limit, fix that.
>
> Fixes: ab7ecf266b0a ('netdev-tc-offloads: Add nw_ttl matching using flower')
> Fixes: 0b4b5203d12e ('tc: Add ip layer ttl matching')
> Signed-off-by: Or Gerl
Hi Or,
On Wed, Jul 25, 2018 at 09:20:07PM +0300, Or Gerlitz wrote:
> Add the missing code to match on ip tos when dealing
> with the TC data-path.
>
> Signed-off-by: Or Gerlitz
> Reviewed-by: Roi Dayan
> ---
> include/openvswitch/match.h | 1 +
> lib/match.c | 7 +++
> li
On Wed, Jul 25, 2018 at 09:20:09PM +0300, Or Gerlitz wrote:
> Support matching on tos and ttl of ip tunnels
> for the TC data-path.
>
> Signed-off-by: Or Gerlitz
> Reviewed-by: Roi Dayan
> ---
...
> diff --git a/lib/tc.c b/lib/tc.c
> index aa3147f..f5901d1 100644
> --- a/lib/tc.c
> +++ b/lib/t
On Thu, Jul 26, 2018 at 05:54:51PM +0300, Or Gerlitz wrote:
> On Thu, Jul 26, 2018 at 5:41 PM, Simon Horman
> wrote:
> > On Wed, Jul 25, 2018 at 09:20:06PM +0300, Or Gerlitz wrote:
> >> TTL can and should be used to match on IPv6's hop-limit, fix that.
>
> &g
Hi Gavi,
On 26 July 2018 at 17:36, Justin Pettit wrote:
>
> > On Jul 26, 2018, at 7:29 AM, Gavi Teitz wrote:
> >
> > From: Justin Pettit, sent: Thursday, July 26, 2018 12:02 AM:
> >> Commit ab15e70eb587 ("dpctl: Expand the flow dump type filter") had a
> number of issues with style, build break
Hi Jakub,
On Mon, Jul 30, 2018 at 04:37:49PM +0200, Jakub Sitnicki wrote:
> If a logical switch port belongs to a port group and has dynamic
> addresses assigned, propagate the addresses to the auto-generated
> address sets for the port group.
>
> Signed-off-by: Jakub Sitnicki
> Acked-by: Han Zh
Thanks Or, Thanks Ben,
On 1 August 2018 at 08:43, Or Gerlitz wrote:
> On Tue, Jul 31, 2018 at 1:40 PM, Or Gerlitz wrote:
> > This series comes to address the case to set (encap) and match (decap)
> > also the tos and ttl fields of TC based IP tunnels. This happens e.g
> > due to inherit setup o
([ovn-sbctl get Address_Set pg1_ip6 addresses],
> - [0], [[["2001:db8:11::ff:fe00:1", "2001:db8:2::ff:fe00:2"]]
> + [0], [[["2001:db8:1::ff:fe00:1", "2001:db8:2::ff:fe00:2"]]
> ])
>
> AT_CLEANUP
Reviewed-by: Simon Horman
Tested-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, Aug 01, 2018 at 11:44:58AM +0200, Jakub Sitnicki wrote:
> Hi Simon,
>
> On Wed, 1 Aug 2018 11:23:30 +0200
> Simon Horman wrote:
>
> > Hi Jakub,
> >
> > On Mon, Jul 30, 2018 at 04:37:49PM +0200, Jakub Sitnicki wrote:
> > > If a logical switch po
On 1 August 2018 at 11:31, Simon Horman wrote:
> Thanks Or, Thanks Ben,
>
> On 1 August 2018 at 08:43, Or Gerlitz wrote:
>
>> On Tue, Jul 31, 2018 at 1:40 PM, Or Gerlitz
>> wrote:
>> > This series comes to address the case to set (encap) and match (decap)
>&
Hi Or,
On 1 August 2018 at 13:21, Or Gerlitz wrote:
> On Wed, Aug 1, 2018 at 2:07 PM, Simon Horman
> wrote:
> > On 1 August 2018 at 11:31, Simon Horman
> wrote:
> >>
> >> Thanks Or, Thanks Ben,
> >>
> >> On 1 August 2018 at 08:43, Or Gerlitz
On Sun, Jul 29, 2018 at 11:46:35PM -0700, Justin Pettit wrote:
> Add support for configuring meters through the Meter and Meter_Band
> tables in the Northbound database. This commit also has ovn-northd
> sync those tables between the Northbound and Southbound databases.
>
> Add support for config
On Wed, Aug 01, 2018 at 11:56:09AM +0200, Simon Horman wrote:
> On Tue, Jul 31, 2018 at 12:45:41PM -0700, Ben Pfaff wrote:
> > These caused the test to fail.
> >
> > CC: Jakub Sitnicki
> > Fixes: 984c7d5ea8fe ("ovn-northd: Propagate dynamic addresses to port group
On Wed, Aug 01, 2018 at 04:28:03PM +0300, Or Gerlitz wrote:
> On Wed, Aug 1, 2018 at 2:29 PM, Simon Horman
> wrote:
> > Hi Or,
> >
> > On 1 August 2018 at 13:21, Or Gerlitz wrote:
> >>
> >> On Wed, Aug 1, 2018 at 2:07 PM, Simon Horman
> >> wr
On Mon, Sep 25, 2017 at 05:48:49PM +0300, Paul Blakey wrote:
>
>
> On 18/09/2017 18:05, Simon Horman wrote:
> >On Mon, Sep 18, 2017 at 07:16:04AM +0300, Roi Dayan wrote:
> >>From: Paul Blakey
> >>
> >>Implement support for offloading ovs act
On Mon, Sep 25, 2017 at 04:31:42PM +0300, Paul Blakey wrote:
>
>
> On 18/09/2017 18:01, Simon Horman wrote:
> >On Mon, Sep 18, 2017 at 07:16:03AM +0300, Roi Dayan wrote:
> >>From: Paul Blakey
> >>
> >>To be later used to implement ovs action set offlo
x uses
> the 64-bit atomic_ullong and it is in Debian, which has tons of
> architectures.
>
> CC: Simon Horman
> Signed-off-by: Ben Pfaff
Hi Ben,
I do not have any recollection of the discussion around e09d61c41b4f,
but this seems reasona
On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote:
>
>
> On 27/09/2017 12:08, Simon Horman wrote:
> > On Mon, Sep 25, 2017 at 04:31:42PM +0300, Paul Blakey wrote:
> > >
> > >
> > > On 18/09/2017 18:01, Simon Horman wrote:
> > > &g
On Tue, Oct 31, 2017 at 09:20:55AM +0200, Paul Blakey wrote:
>
>
> On 30/10/2017 15:42, Simon Horman wrote:
> > On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote:
> > >
> > >
> > > On 27/09/2017 12:08, Simon Horman wrote:
> > > >
On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote:
>
>
> On 27/09/2017 12:08, Simon Horman wrote:
> > On Mon, Sep 25, 2017 at 04:31:42PM +0300, Paul Blakey wrote:
> > >
> > >
> > > On 18/09/2017 18:01, Simon Horman wrote:
> > > &g
On Mon, Sep 18, 2017 at 07:16:00AM +0300, Roi Dayan wrote:
> Hi,
>
> This series adds support for offloading action set using
> tc interface.
>
> V1->V2:
> - Check patch whitespaces fixes
> - Changed flower_pedit_map to be non sparse.
> - Missing handling of unsupported attributes an
On Fri, Nov 17, 2017 at 04:45:05PM -0200, Flavio Leitner wrote:
> On Fri, 17 Nov 2017 14:36:22 +0100
> Paolo Abeni wrote:
> > Currently, when an offloaded DP flow is deleted, the related stats
> > are unconditionally cleared. As a result the counters for the
> > originating open flow are corrupted
On Sun, Nov 19, 2017 at 08:45:19AM +0200, Roi Dayan wrote:
>
>
> On 16/11/2017 18:29, Simon Horman wrote:
> > On Wed, Oct 25, 2017 at 02:24:15PM +0300, Roi Dayan wrote:
> > >
> > >
> > > On 27/09/2017 12:08, Simon Horman wrote:
> > > >
On Tue, Nov 21, 2017 at 07:50:24AM +0200, Roi Dayan wrote:
>
>
> On 20/11/2017 14:30, Simon Horman wrote:
> > On Sun, Nov 19, 2017 at 08:45:19AM +0200, Roi Dayan wrote:
> > >
> > >
> > > On 16/11/2017 18:29, Simon Horman wrote:
> > > > On
On Tue, Nov 21, 2017 at 02:40:35PM +0200, Roi Dayan wrote:
> Hi,
>
> The following series fixes some issues with header rewrite
> and some small refactoring.
Thanks, applied to master.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.o
On Wed, Jan 10, 2018 at 02:53:19PM +, Chandran, Sugesh wrote:
> Hi All,
>
> Based on the comments below, I wanted to call out for a meeting to decide
> what further needs to be done to handle different kinds of hardware
> acceleration in OVS-DPDK. We have some POC implementation that partial
; that further operations like offloading a rule that egresses to a geneve
> port will be rejected as the egress port cannot be found. This patch
> applies the same ifindex function to geneve as is used in vxlan.
>
> Signed-off-by: John Hurley
> Acked-by: Simon Horman
Thanks John
nnel (decap) and outputs to a new tunnel,
> the netlink conversion to TC will add the set tunnel key action before the
> unset, leading to an incorrect TC rule. This patch reorders the netlink
> generation to ensure a decap is done before an encap if both exist.
>
> Signed-off-by: Jo
e
> unset, leading to an incorrect TC rule. This patch reorders the netlink
> generation to ensure a decap is done before an encap if both exist.
>
> Signed-off-by: John Hurley
> Reviewed-by: Simon Horman
Thanks John,
I have applied to master and branch-2.9.
It looks like the fix i
e
> unset, leading to an incorrect TC rule. This patch reorders the netlink
> generation to ensure a decap is done before an encap if both exist.
>
> Patch was committed to master. Backport to branch 2.8 requested by Simon
> Horman.
>
> Signed-off-by: John Hurley
> Review
Conole, Ben LaHaise, Eran Ben Elisha, Hannes Frederic Sowa,
Jakub Kicinski, Jiri Pirko, Joe Stringer, John Fastabend, Nick Viljoen,
Rashid Khan, Rony Efraim, Simon Horman
Joe raised 2 concerns:
1) How to enable users to understand whether offload is
successful and if not, why not?
a) There
I believe that this
> seemed reasonable to the people I discussed this with.
Thanks Joe,
FWIW that sounds reasonable to me.
> On 8/04/2017 16:48, "Simon Horman" wrote:
>
> At Netdev 2.1 a meeting was held to discuss OvS offload. Minutes of the
> discussion follow. I apol
On Wed, Apr 12, 2017 at 03:01:29PM -0300, Flavio Leitner wrote:
> On Sat, Apr 08, 2017 at 04:47:57PM -0400, Simon Horman wrote:
> > At Netdev 2.1 a meeting was held to discuss OvS offload. Minutes of the
> > discussion follow. I apologise in advance for any errors or omissions;
>
On Tue, Apr 18, 2017 at 03:18:55PM +0300, Roi Dayan wrote:
>
>
> On 14/04/2017 04:11, Joe Stringer wrote:
> >On 7 April 2017 at 06:12, Roi Dayan wrote:
> >>From: Paul Blakey
> >>
> >>Signed-off-by: Paul Blakey
> >>Re
Hi Yi-Hung,
thanks for taking on this difficult piece of work and apologies for the
delay in responding.
On Mon, Apr 03, 2017 at 04:24:36PM -0700, Yi-Hung Wei wrote:
> This commit backports the following upstream commits to fix MPLS GSO in ovs
> datapath. It has been tested on kernel 4.4 and 4.9.
ac_proto field to the flow key")
> Signed-off-by: Yi-Hung Wei
> Acked-by: Jiri Benc
> Signed-off-by: David S. Miller
>
> Signed-off-by: Yi-Hung Wei
Nonetheless:
Acked-by: Simon Horman
...
___
dev mailing list
d...@
> commit 5ba0c107c51e ("datapath: Fix ovs_flow_key_update()") to behave
> correctly.
>
> Signed-off-by: Yi-Hung Wei
Very nice to see a test for this.
Acked-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, Apr 25, 2017 at 05:45:34PM -0700, Yi-Hung Wei wrote:
> Hi Simon,
>
> Thanks for your review. Please find my relies below.
> I will sent out v2 based on your review.
>
> On Tue, Apr 25, 2017 at 12:43 AM, Simon Horman
> wrote:
> > Hi Yi-Hung,
> >
> &
Hi Yi-Hung,
I'm having a little trouble following the status of this patchset.
Would it be possible to repost v3 (or post v4 if that is pending) with:
* A cover letter including:
- An overview of the patchset
- An overview of the changes between v2 and v3
(and v4 is there is one). Changes
On Mon, May 01, 2017 at 10:24:30AM -0700, Yi-Hung Wei wrote:
> This series backports the upstream mpls fixes and add a system traffic
> test for mpls actions.
Thanks Yi-Hung, this looks good to me.
Acked-by: Simon Horman
Joe, were you considering applying this?
I'm happy to do s
On Wed, May 03, 2017 at 08:20:18AM +0300, Roi Dayan wrote:
>
>
> On 24/04/2017 14:35, Simon Horman wrote:
> >On Tue, Apr 18, 2017 at 03:18:55PM +0300, Roi Dayan wrote:
> >>
> >>
> >>On 14/04/2017 04:11, Joe Stringer wrote:
> >>>On 7 April 20
On Tue, May 02, 2017 at 10:38:17AM -0700, Joe Stringer wrote:
> On 2 May 2017 at 05:03, Simon Horman wrote:
> > On Mon, May 01, 2017 at 10:24:30AM -0700, Yi-Hung Wei wrote:
> >> This series backports the upstream mpls fixes and add a system traffic
> >> test for mpls
support
./ovsdb-idl.at:1215: exit code was 1, expected 0
Fixes: d90ed7d65ba8 ("python: Add SSL support to the python ovs client library")
Cc: Numan Siddique
Signed-off-by: Simon Horman
---
tests/ovsdb-idl.at | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/ovsdb-idl.at b/t
On Wed, May 03, 2017 at 10:56:39AM -0700, Ben Pfaff wrote:
> On Wed, May 03, 2017 at 05:55:51PM +0200, Simon Horman wrote:
> > Only run python SSL test, which invokes ovsdb with a --remote=pssl,
> > if SSL support is configured.
> >
> > Without this change the following
related functions from netdev-linux.c to tc.c
>
> Co-authored-by: Shahar Klein
> Signed-off-by: Shahar Klein
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> ---
> lib/automake.mk|2 +
> lib/netdev-linux.c
On Sun, May 07, 2017 at 02:46:14PM +0300, Roi Dayan wrote:
>
>
> On 04/05/2017 19:35, Simon Horman wrote:
> >On Wed, May 03, 2017 at 06:07:52PM +0300, Roi Dayan wrote:
> >>From: Paul Blakey
> >>
> >>Add tc flower interface that will be used to
On Wed, May 03, 2017 at 06:07:53PM +0300, Roi Dayan wrote:
> From: Paul Blakey
Please add some text to the changelog.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
...
> diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads
This configuration option defaults to false - disabled.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
...
This does not appear to address Flavio Leitner's review of v7 of this patch.
___
dev mail
his option is only relevant if hw-offload is enabled.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
This does not appear to address Flavio Leitner's review of v7 of this patch.
___
dev mail
vs.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
...
> diff --git a/lib/netdev.h b/lib/netdev.h
> index 7435fdf..9aa7e5e 100644
> --- a/lib/netdev.h
> +++ b/lib/netdev.h
> @@ -181,6 +181,12 @@ int netdev_init
On Wed, May 03, 2017 at 06:07:57PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> If netdev flow offloading is enabled, flush all
> added ports using netdev flow api.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Flavio Leitne
On Wed, May 03, 2017 at 06:07:58PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
This does not appear to address Flavio Leitner's review of v7 of this patch.
___
On Wed, May 03, 2017 at 06:08:04PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Currently only tunnel offload is supported.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> ---
> lib/dpif-netlink.c | 4 +-
>
# to dump only flows that are offloaded:
> ovs-dpctl dump-flows type=offloaded
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
As per Flavio's review of v7, can this be made to return an error
if type is invalid. I may have
On Wed, May 03, 2017 at 06:08:12PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Usage:
> # to dump all datapath flows (default):
> ovs-dpctl dump-flows
>
> # to dump only flows that in kernel datapath:
> ovs-dpctl dump-flows type=ovs
>
> # to dump only flows that are offl
On Wed, May 03, 2017 at 06:08:16PM +0300, Roi Dayan wrote:
> Signed-off-by: Roi Dayan
> Reviewed-by: Paul Blakey
Reviewed-by: Simon Horman
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Wed, May 03, 2017 at 06:08:17PM +0300, Roi Dayan wrote:
Please add some changelog text here.
> Signed-off-by: Roi Dayan
> Reviewed-by: Paul Blakey
> ---
> lib/dpif-netlink.c | 55
> +-
> 1 file changed, 17 insertions(+), 38 deletions(-)
>
On Wed, May 10, 2017 at 05:19:26PM +0200, Simon Horman wrote:
> On Wed, May 03, 2017 at 06:08:16PM +0300, Roi Dayan wrote:
> > Signed-off-by: Roi Dayan
> > Reviewed-by: Paul Blakey
>
> Reviewed-by: Simon Horman
Sorry, I didn't notice before but could you add
On Tue, May 16, 2017 at 12:16:46PM +0300, Roi Dayan wrote:
>
>
> On 08/05/2017 15:49, Simon Horman wrote:
> >On Wed, May 03, 2017 at 06:07:56PM +0300, Roi Dayan wrote:
> >>From: Paul Blakey
> >>
> >>To use netdev flow offloading api, dpifs needs to i
On Sun, May 28, 2017 at 02:59:43PM +0300, Roi Dayan wrote:
> Refactor tc_make_request and tc_add_del_ingress_qdisc to accept
> ifindex instead of netdev struct.
> We later want to move those outside netdev-linux module to be
> used by other modules.
> This patch doesn't change any functionality.
>
On Sun, May 28, 2017 at 02:59:44PM +0300, Roi Dayan wrote:
> Add tc module to expose tc operations to be used by other modules.
> Move some tc related functions from netdev-linux.c to tc.c
> This patch doesn't change any functionality.
>
> Signed-off-by: Paul Blakey
> Signed-off-by: Roi Dayan
T
; In other words, the compat code is only used when compiling user-space
> code against old kernel headers.
>
> Signed-off-by: Paul Blakey
> Signed-off-by: Simon Horman
> Reviewed-by: Roi Dayan
> Acked-by: Flavio Leitner
Thanks, applied to master branch.
On Sun, May 28, 2017 at 02:59:46PM +0300, Roi Dayan wrote:
> Add tc helper functions to query and manipulate the flower classifier.
>
> Signed-off-by: Paul Blakey
> Signed-off-by: Roi Dayan
Thanks, this looks good to me and I would be happy to apply it if
someone provided a review.
Also, pleas
ete an offloaded flow
> flow_flush - flush all offloaded flows
> flow_dump_* - dump all offloaded flows
>
> In upcoming commits we will introduce an implementation of this
> API for netdev-linux.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by:
his option is only relevant if hw-offload is enabled.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Thanks, the comment below not withstanding this looks good to me
and I would be happy to apply it if someone provided a review.
> ---
> lib
This configuration option defaults to false - disabled.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
Thanks, this looks good to me.
I would be happy to apply it if someone provided a review.
___
dev mai
On Sun, May 28, 2017 at 02:59:51PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> If netdev flow offloading is enabled, flush all
> added ports using netdev flow api.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> Acked-
vs.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> Acked-by: Flavio Leitner
Thanks, this looks good to me. As it has been acked I would I would be
happy to apply it once earlier in the patches in the series ha
On Sun, May 28, 2017 at 02:59:52PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> Reviewed-by: Simon Horman
> ---
> lib/netdev-tc-offloads.c | 14 --
> 1 file changed, 12 insertions(+), 2 deletions(-)
Signed-off-by: Roi Dayan
> Reviewed-by: Paul Blakey
Thanks, this looks good to me. I would be happy to apply if someone
provided an Ack. I'd also be happy if someone else applied it with:
Acked-by: Simon Horman
> ---
> lib/dpif-netlink-rtnl.c | 2 +-
> 1 file changed, 1 inserti
On Thu, Jul 27, 2017 at 01:19:59PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Split dst/src_port and ipv4/ipv6 union so we can
> distingush them easily for later features.
The implications of this change on the size of struct tc_flower_key
seem somewhat undesirable to me. Perhaps there is a
On Thu, Jul 27, 2017 at 01:19:58PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> Refactor nl_msg_put_flower_options to be more readable.
> This commit doesn't change functionality.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
LG
On Thu, Jul 27, 2017 at 01:20:00PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> No need to parse ip related fields otherwise.
I would prefer if the changelog could be read without reference
to the subject. As you are planning to respin anyway perhaps you could
fix this up.
The code changes l
On Thu, Jul 27, 2017 at 01:20:07PM +0300, Or Gerlitz wrote:
> On 7/27/2017 1:14 PM, Roi Dayan wrote:
> >the system call is done only once.
>
> good to know, would be worth to mention that on the change-log, so it's
> clear we're good w.r.t performance.
Roi, could you respin this patch with an upd
On Tue, Aug 01, 2017 at 04:48:02PM -0700, Joe Stringer wrote:
> On 1 August 2017 at 13:57, Joe Stringer wrote:
> > On 28 July 2017 at 05:43, Simon Horman wrote:
> >> On Thu, Jul 27, 2017 at 02:40:02PM +0300, Roi Dayan wrote:
> >>> When we skip adding a port using r
by: Roi Dayan
> Reviewed-by: Paul Blakey
Acked-by: Simon Horman
> ---
> lib/netdev-tc-offloads.c |3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c
> index e51e638..2af1546 100644
>
On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote:
> Hi,
>
> This series adds support for offloading ip ttl and tcp flags
> using tc interface.
This looks nice, thanks.
Acked-by: Simon Horman
I'm also happy to apply this if someone else
On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote:
>
>
> On 07/08/2017 20:05, Ben Pfaff wrote:
> >On Mon, Aug 07, 2017 at 07:00:31AM -0700, Ben Pfaff wrote:
> >>On Mon, Aug 07, 2017 at 07:32:02AM +0300, Roi Dayan wrote:
> >>>From: Paul Blakey
> >>>
> >>>Always implement get_ifindex witho
On Tue, Aug 08, 2017 at 01:35:41PM +0300, Roi Dayan wrote:
>
>
> On 08/08/2017 11:04, Simon Horman wrote:
> >On Tue, Aug 08, 2017 at 07:36:25AM +0300, Roi Dayan wrote:
> >>
> >>
> >>On 07/08/2017 20:05, Ben Pfaff wrote:
> >>>On Mon, Aug 07, 2
On Fri, Aug 11, 2017 at 11:43:23AM -0700, Joe Stringer wrote:
> On 8 August 2017 at 01:03, Simon Horman wrote:
> > On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote:
> >> Hi,
> >>
> >> This series adds support for offloading ip ttl and tcp flags
> &g
On Tue, Aug 08, 2017 at 05:21:53PM +0300, Roi Dayan wrote:
> From: Paul Blakey
>
> To be later used to implement ovs action set offloading.
>
> Signed-off-by: Paul Blakey
> Reviewed-by: Roi Dayan
> ---
> lib/tc.c | 372
> ++-
> lib/
feature I am very pleased to see.
Acked-by: Simon Horman
>
> Thanks,
> Roi
>
>
> Paul Blakey (4):
> compat: Add act_pedit compatibility for old kernels
> odp-util: Expose ovs flow key attr len table for reuse
> tc: Add header rewrite using tc pedit action
>
ned-off-by: Pieter Jansen van Vuuren
Signed-off-by: Simon Horman
---
ofproto/bond.c | 11 ++-
ofproto/bond.h | 1 +
vswitchd/bridge.c| 3 +++
vswitchd/vswitch.xml | 8
4 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/ofproto/bond.c b/ofproto/bo
Hi Andy,
On Tue, Aug 15, 2017 at 01:31:36PM -0700, Andy Zhou wrote:
> On Tue, Aug 15, 2017 at 9:13 AM, Simon Horman
> wrote:
> > From: Pieter Jansen van Vuuren
> >
> > Adds a config parameter that determines if a bond will use recirculation
> > in the kernel datapa
On Thu, Aug 17, 2017 at 12:21:43PM +0300, Paul Blakey wrote:
>
>
> On 14/08/2017 16:00, Simon Horman wrote:
> >On Tue, Aug 08, 2017 at 05:21:53PM +0300, Roi Dayan wrote:
> >>From: Paul Blakey
> >>
> >>To be later used to implement ovs action set offlo
gt; Reviewed-by: Roi Dayan
Some minor nits below but that notwithstanding
Acked-by: Simon Horman
> ---
> lib/odp-util.c | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 4f1499e..0594840 100644
> --- a/lib/odp-ut
1 - 100 of 1623 matches
Mail list logo
