[ovs-dev] [PATCH v2 3/6] dpif-netdev: Offloading meter with DPDK

2023-03-09 Thread Simon Horman
: Jin Liu Signed-off-by: Simon Horman --- lib/dpif-netdev.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 2c08a71c8db2..e8d0ca6606de 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -7277,6 +7277,11

[ovs-dev] [PATCH v2 6/6] netdev-dpdk-offload: Add support for meter action

2023-03-09 Thread Simon Horman
From: Peng Zhang Add support of DPDK meter action logic. Signed-off-by: Peng Zhang Signed-off-by: Jin Liu Signed-off-by: Simon Horman --- lib/netdev-offload-dpdk.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib/netdev-offload-dpdk.c index

[ovs-dev] [PATCH v2 5/6] netdev-dpdk: add meter algorithms

2023-03-09 Thread Simon Horman
From: Peng Zhang Add the meter algorithms. DPDK meter support three algorithms, and OVS also can support these algorithms. Signed-off-by: Peng Zhang Signed-off-by: Jin Liu Signed-off-by: Simon Horman --- lib/netdev-dpdk.c | 58 +-- 1 file changed

[ovs-dev] [PATCH v2 4/6] netdev-offload-dpdk: Implement meter offload API for DPDK

2023-03-09 Thread Simon Horman
From: Peng Zhang For dpif-netdev, meters are mapped by DPDK meter with one-to-one relationship. Implement meter offload API to set/get/del the DPDK meter with proxy port id. Signed-off-by: Peng Zhang Signed-off-by: Jin Liu Signed-off-by: Simon Horman --- lib/netdev-dpdk.c | 202

Re: [ovs-dev] [PATCH ovn v4 1/7] ci: Add support for userspace system test

2023-03-09 Thread Simon Horman
On Wed, Mar 08, 2023 at 03:32:05PM +0100, Ales Musil wrote: > Add support for running system tests with > OvS userspace netdev. > > Signed-off-by: Ales Musil Reviewed-by: Simon Horman Reviewed-by: Simon Horman ___ dev ma

Re: [ovs-dev] [PATCH ovn v4 3/7] system-tests: Do not use verbose output for ping6

2023-03-09 Thread Simon Horman
stend as error by the > NS_CHECK_EXEC: > > ping6: sock4.fd: -1 (socktype: 0), sock6.fd: 3 (socktype: SOCK_RAW), > hints.ai_family: AF_INET6 > > There is also possibility to ignore > the stderr, but it doesn't bring any value > to the test. > &g

Re: [ovs-dev] [PATCH ovn v4 4/7] system-tests: Replace use of ADD_INT with ADD_VETH

2023-03-09 Thread Simon Horman
tead. Also remove ADD_INT as it > is not used anywhere else. > > Signed-off-by: Ales Musil Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v4 5/7] tests: Use revalidator/purge instead of dpctl/del-flows

2023-03-09 Thread Simon Horman
On Wed, Mar 08, 2023 at 03:32:09PM +0100, Ales Musil wrote: > The dpctl/del-flows shouldn't be used on running > ofproto layer, use revalidator/purge instead. > > Signed-off-by: Ales Musil Reviewed-by: Simon Horman ___ d

Re: [ovs-dev] [PATCH ovn v4 6/7] system-tests: Move the LB affinity tests into system-ovn-kmod

2023-03-09 Thread Simon Horman
On Wed, Mar 08, 2023 at 03:32:10PM +0100, Ales Musil wrote: > To be consistent moe the LB affinity tests into system-ovn-kmod > for now as they are waiting currently not working with > userspace datapath. > > Signed-off-by: Ales Musil Reviewed-by: Simon Horman Tested-b

Re: [ovs-dev] [PATCH ovn v4 7/7] ci: Replace clang jemalloc suite with system-test-userspace

2023-03-09 Thread Simon Horman
On Wed, Mar 08, 2023 at 03:32:11PM +0100, Ales Musil wrote: > The test with jemalloc and clang is redundant as > we are already testing jemalloc with gcc. Replace > it with system-test-userspace which runs system tests > over userspace OvS datapath. > > Tested-by: Simon Horma

Re: [ovs-dev] [PATCH ovn] northd: Use generic ct.est flows for LR LBs

2023-03-09 Thread Simon Horman
L4 > destination in registers. Match directly on > L3 and L4 destination for ct.new in DNAT stage. > > Populate the registers in LB affinity check stage > as they are needed for LB affinity learn. > > Reported-at: https://bugzilla.redhat.com/2172048 > Report

Re: [ovs-dev] [PATCH v3 1/2] github: Combine ASAN and UBSAN runs.

2023-03-09 Thread Simon Horman
On Wed, Mar 08, 2023 at 04:18:02PM +0100, Eelco Chaudron wrote: > Combine the ASAN and UBSAN tests into a single sanitizer run. > > Signed-off-by: Eelco Chaudron Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.

Re: [ovs-dev] [PATCH v3 2/2] ci: Run tc offload tests in GitHub Actions.

2023-03-09 Thread Simon Horman
On Wed, Mar 08, 2023 at 04:18:47PM +0100, Eelco Chaudron wrote: > Run "make check-offloads" as part of the GitHub actions tests. > > This test was run 25 times using GitHub actions, and the > failing rerun test cases where excluded. There are quite some > first-run failures, but unfortunately, the

Re: [ovs-dev] [PATCH v3 1/2] dpctl: Fix flush-conntrack with datapath as argument

2023-03-10 Thread Simon Horman
On Thu, Mar 09, 2023 at 03:00:40PM +0100, Ales Musil wrote: > Specifying datapath with "dpctl/flush-conntrack" didn't > work as expected and caused error: > ovs-dpctl: field system@ovs-system missing value (Invalid argument) > > To prevent that check if we have datapath as first argument > and use

Re: [ovs-dev] [PATCH ovn] controller: lflow: do not use tcp as default IP protocol for ct_snat_to_vip action

2023-03-10 Thread Simon Horman
> Signed-off-by: Lorenzo Bianconi Reviewed-by: Simon Horman > --- > controller/lflow.c | 19 ++-- > tests/ovn.at | 115 + > 2 files changed, 129 insertions(+), 5 deletions(-) > > diff --git a/controller/lflow.c b/controller/

Re: [ovs-dev] [PATCH v3 2/2] ci: Run tc offload tests in GitHub Actions.

2023-03-10 Thread Simon Horman
On Thu, Mar 09, 2023 at 05:22:43PM +0100, Eelco Chaudron wrote: > > > On 9 Mar 2023, at 15:42, Simon Horman wrote: > > > On Wed, Mar 08, 2023 at 04:18:47PM +0100, Eelco Chaudron wrote: > >> Run "make check-offloads" as part of the GitHub actions tests. >

Re: [ovs-dev] [PATCH v3 2/2] ci: Run tc offload tests in GitHub Actions.

2023-03-10 Thread Simon Horman
On Fri, Mar 10, 2023 at 07:12:33AM +0100, Frode Nordahl wrote: > On Thu, Mar 9, 2023 at 5:26 PM Ilya Maximets wrote: ... > > > GHA is kind of hard to debug. Cirrus has a way to give you a console > > > access to the running job, but GHA doesn't have that. > > fwiw; There are third party action

Re: [ovs-dev] [PATCH v7 1/1] userspace: Add SRv6 tunnel support.

2023-03-10 Thread Simon Horman
On Fri, Mar 10, 2023 at 02:49:06PM +0900, Nobuhiro MIKI wrote: > On 2023/01/17 18:41, Nobuhiro MIKI wrote: > > SRv6 (Segment Routing IPv6) tunnel vport is responsible > > for encapsulation and decapsulation the inner packets with > > IPv6 header and an extended header called SRH > > (Segment Routin

Re: [ovs-dev] [PATCH v2] ofproto-dpif-upcall: Remove redundant time_msec() in revalidate().

2023-03-10 Thread Simon Horman
gned-off-by: Eelco Chaudron > --- > v2: Moved time_msec() after udpif_get_n_flows(). Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v2] controller: Prevent race in packet buffering

2023-03-10 Thread Simon Horman
On Thu, Mar 09, 2023 at 07:17:15AM +0100, Ales Musil wrote: > There was a race within packet buffering that could > result in first packt being dropped. It could happen > under following conditions and topology: > S1 == R1 == public == R2 == S2 > SNAT on R1 and DGP on port connecting R1 with public

Re: [ovs-dev] [PATCH v3 1/2] dpctl: Fix flush-conntrack with datapath as argument

2023-03-10 Thread Simon Horman
On Fri, Mar 10, 2023 at 10:36:38AM +0100, Ales Musil wrote: > On Fri, Mar 10, 2023 at 9:58 AM Simon Horman > wrote: > > > On Thu, Mar 09, 2023 at 03:00:40PM +0100, Ales Musil wrote: > > > Specifying datapath with "dpctl/flush-conntrack" didn't > > &

Re: [ovs-dev] [PATCH ovn v3] northd: Make the use of common zone in NAT configurable

2023-03-10 Thread Simon Horman
On Thu, Mar 09, 2023 at 07:16:04AM +0100, Ales Musil wrote: > There are essentially three problems with the current > combination of DGP + SNAT + LB: > > 1) The first packet is being SNATed in common zone due > to a problem with pinctrl not preserving ct_mark/ct_label. > The commit would create a

Re: [ovs-dev] Reliability of system-offload test #50 [Was: Re: [PATCH v3 2/2] ci: Run tc offload tests in GitHub] Actions.

2023-03-10 Thread Simon Horman
On Fri, Mar 10, 2023 at 10:15:44AM +0100, Simon Horman wrote: > On Thu, Mar 09, 2023 at 05:22:43PM +0100, Eelco Chaudron wrote: > > > > > > On 9 Mar 2023, at 15:42, Simon Horman wrote: > > > > > On Wed, Mar 08, 2023 at 04:18:47PM +0100, Eelco Chaudron wrote:

Re: [ovs-dev] [PATCH ovn v3] northd: Make the use of common zone in NAT configurable

2023-03-13 Thread Simon Horman
On Mon, Mar 13, 2023 at 08:20:32AM +0100, Ales Musil wrote: > On Fri, Mar 10, 2023 at 2:25 PM Simon Horman > wrote: > > > On Thu, Mar 09, 2023 at 07:16:04AM +0100, Ales Musil wrote: > > > There are essentially three problems with the current > > > combination

Re: [ovs-dev] [PATCH ovn v2] controller: Prevent race in packet buffering

2023-03-13 Thread Simon Horman
On Mon, Mar 13, 2023 at 10:21:03AM +0100, Ales Musil wrote: > On Fri, Mar 10, 2023 at 11:11 AM Simon Horman > wrote: > > > On Thu, Mar 09, 2023 at 07:17:15AM +0100, Ales Musil wrote: > > > There was a race within packet buffering that could > > > result in fi

Re: [ovs-dev] [PATCH 1/1] tc: Fix cleaning chains

2023-03-13 Thread Simon Horman
On Mon, Mar 13, 2023 at 12:31:49PM +0200, Roi Dayan wrote: > > > On 13/03/2023 11:01, Eelco Chaudron wrote: > > > > > > On 13 Mar 2023, at 9:38, Roi Dayan wrote: > > > >> On 22/02/2023 12:30, Roi Dayan wrote: > >>> Sometimes there is a need to clean empty chains as done in > >>> delete_chains_

Re: [ovs-dev] [PATCH ovn v3] northd: Make the use of common zone in NAT configurable

2023-03-14 Thread Simon Horman
On Mon, Mar 13, 2023 at 03:29:19PM +0100, Ales Musil wrote: > On Mon, Mar 13, 2023 at 1:08 PM Simon Horman > wrote: > > On Mon, Mar 13, 2023 at 08:20:32AM +0100, Ales Musil wrote: > > > On Fri, Mar 10, 2023 at 2:25 PM Simon Horman > > > wrote: > > > >

Re: [ovs-dev] [PATCH 1/1] tc: Fix cleaning chains

2023-03-14 Thread Simon Horman
On Mon, Mar 13, 2023 at 07:47:14PM +0200, Roi Dayan wrote: > > > On 13/03/2023 14:16, Simon Horman wrote: > > On Mon, Mar 13, 2023 at 12:31:49PM +0200, Roi Dayan wrote: > >> > >> > >> On 13/03/2023 11:01, Eelco Chaudron wrote: > >>>

Re: [ovs-dev] [PATCH 1/1] tc: translate mirror/stolen to mirred

2023-03-14 Thread Simon Horman
On Mon, Mar 13, 2023 at 09:34:30PM +0100, Ilya Maximets wrote: > On 3/13/23 11:27, Roi Dayan wrote: > > From: Oz Shlomo > > > > Currently jumping over a output-to-port action is translated to tc > > mirror action and stolen control action. > > However, the tc control action is not propagated to t

Re: [ovs-dev] [PATCH v2] OpenFlow: Add extn to set conntrack entries limit per zone.

2023-03-14 Thread Simon Horman
On Tue, Mar 14, 2023 at 10:51:55AM +, Naveen Yerramneni wrote: > Add OpenFlow extn to set conntrack entries limit per zone. > > Signed-off-by: Naveen Yerramneni Hi Naveen, There were 4 postings of this patchset yesterday, and one so far today. Please consider allowing 24h between postings t

Re: [ovs-dev] [PATCH ovn 0/4] Add automation to automatically build containers

2023-03-14 Thread Simon Horman
On Tue, Mar 14, 2023 at 11:53:20AM +0100, Ales Musil wrote: > In order to use the containers in CI add job > that will build the containers once every week. > > The job will automatically build for arm64 > and x86_64. I am seeing a number of workflow job failures with this patchset applied: http

Re: [ovs-dev] [PATCH ovn 0/4] Add automation to automatically build containers

2023-03-14 Thread Simon Horman
On Tue, Mar 14, 2023 at 04:12:53PM +0100, Ales Musil wrote: > On Tue, Mar 14, 2023 at 3:44 PM Simon Horman > wrote: > > > On Tue, Mar 14, 2023 at 11:53:20AM +0100, Ales Musil wrote: > > > In order to use the containers in CI add job > > > that will bui

Re: [ovs-dev] [PATCH 1/1] tc: translate mirror/stolen to mirred

2023-03-15 Thread Simon Horman
On Tue, Mar 14, 2023 at 06:49:25PM +0100, Ilya Maximets wrote: > On 3/14/23 12:15, Simon Horman wrote: > > On Mon, Mar 13, 2023 at 09:34:30PM +0100, Ilya Maximets wrote: > >> On 3/13/23 11:27, Roi Dayan wrote: > >>> From: Oz Shlomo > >>> > >>

Re: [ovs-dev] [PATCH v2] OpenFlow: Add extn to set conntrack entries limit per zone.

2023-03-15 Thread Simon Horman
; > > > On 14-Mar-2023, at 6:17 PM, Simon Horman wrote: > > > > On Tue, Mar 14, 2023 at 10:51:55AM +, Naveen Yerramneni wrote: > >> Add OpenFlow extn to set conntrack entries limit per zone. > >> > >> Signed-off-by: Naveen Yerramneni > >

Re: [ovs-dev] [PATCH 1/1] tc: translate mirror/stolen to mirred

2023-03-15 Thread Simon Horman
On Mon, Mar 13, 2023 at 12:27:51PM +0200, Roi Dayan wrote: > From: Oz Shlomo > > Currently jumping over a output-to-port action is translated to tc > mirror action and stolen control action. > However, the tc control action is not propagated to the hw offload action, > thus the hardware action wi

Re: [ovs-dev] [PATCH v4 1/2] dpctl: Fix flush-conntrack with datapath as argument

2023-03-15 Thread Simon Horman
tapath as first argument > and use it accordingly. > > Also add couple of test cases to ensure that everything works as > expocted. > > Fixes: a9ae73b916ba ("ofp, dpif: Allow CT flush based on partial match.") > Signed-off-by: Ales Musil Reviewed-by: Simon Horman

Re: [ovs-dev] [PATCH v4 2/2] vswitch: Add missing documentation for "ct_flush" capability

2023-03-15 Thread Simon Horman
On Mon, Mar 13, 2023 at 08:16:35AM +0100, Ales Musil wrote: > Fixes: 08146bf7d9b4 ("openflow: Add extension to flush CT by generic match.") > Signed-off-by: Ales Musil Reviewed-by: Simon Horman ___ dev mailing list d...@openv

Re: [ovs-dev] [PATCH 1/1] tc: translate mirror/stolen to mirred

2023-03-15 Thread Simon Horman
On Wed, Mar 15, 2023 at 11:52:16AM +0200, Oz Shlomo wrote: > > On 15/03/2023 11:00, Simon Horman wrote: > > On Mon, Mar 13, 2023 at 12:27:51PM +0200, Roi Dayan wrote: > > > From: Oz Shlomo > > > > > > Currently jumping over a output-to-port action is t

Re: [ovs-dev] [PATCH 1/1] tc: Fix cleaning chains

2023-03-20 Thread Simon Horman
On Mon, Mar 20, 2023 at 09:51:48AM +0200, Roi Dayan wrote: > > > On 14/03/2023 13:04, Simon Horman wrote: > > On Mon, Mar 13, 2023 at 07:47:14PM +0200, Roi Dayan wrote: > >> > >> > >> On 13/03/2023 14:16, Simon Horman wrote: > >>> On

Re: [ovs-dev] [PATCH 1/1] tc: translate mirror/stolen to mirred

2023-03-22 Thread Simon Horman
On Tue, Mar 21, 2023 at 06:05:20PM +0100, Ilya Maximets wrote: > On 3/15/23 16:18, Marcelo Ricardo Leitner wrote: > > On Wed, Mar 15, 2023 at 09:33:09AM +0100, Simon Horman wrote: > >> On Tue, Mar 14, 2023 at 06:49:25PM +0100, Ilya Maximets wrote: > >>> On 3/1

Re: [ovs-dev] [PATCH v9 2/5] tnl-ports: Support multiple nw_protos.

2023-03-22 Thread Simon Horman
On Wed, Mar 15, 2023 at 03:07:22PM +0900, Nobuhiro MIKI wrote: > In some tunnels, inner packet needs to support both IPv4 > and IPv6. Therefore, this patch improves to allow two > protocols to be tied together in one tunneling. > > Signed-off-by: Nobuhiro MIKI Hi Miki-san, in general this looks

Re: [ovs-dev] [PATCH v9 3/5] flow: Support rt_hdr in parse_ipv6_ext_hdrs__().

2023-03-22 Thread Simon Horman
On Wed, Mar 15, 2023 at 03:07:23PM +0900, Nobuhiro MIKI wrote: > Checks whether IPPROTO_ROUTING exists in the IPv6 extension headers. > If it exists, the first address is retrieved. > > Signed-off-by: Nobuhiro MIKI Hi Miki-san, this also looks good to me. I have made a few suggestions for impro

Re: [ovs-dev] [PATCH v9 3/5] flow: Support rt_hdr in parse_ipv6_ext_hdrs__().

2023-03-24 Thread Simon Horman
On Fri, Mar 24, 2023 at 01:03:00PM +0100, Ilya Maximets wrote: > On 3/23/23 03:57, Nobuhiro MIKI wrote: > > On 2023/03/22 21:21, Simon Horman wrote: > >> On Wed, Mar 15, 2023 at 03:07:23PM +0900, Nobuhiro MIKI wrote: > >>> Checks whether IPPROTO_ROUTING exists

Re: [ovs-dev] [PATCH] flow: fix sanity check for unexpected ip header length field

2023-03-27 Thread Simon Horman
On Wed, Mar 15, 2023 at 05:11:01PM +0800, Faicker Mo wrote: > Derivation cases of CVE-2020-35498: > 1. invalid ipv4 header total-length field > 2. invalid ipv6 header payload-length field > These may cause unwanted flow to send to datapath. > > > Signed-off-by: Faicker Mo I think the immediate

Re: [ovs-dev] [PATCH v9] netdev-offload-tc: del ufid mapping if device not exist

2023-03-29 Thread Simon Horman
the rest succeeded: a success rate of 99.95% :) As it's not entirely clear how reliable such a setup is (or our expectations for it) [1], I think I am ok with this patch. Reviewed-by: Simon Horman [1] https://mail.openvswitch.org/pipermail/ovs-dev/2023-March/403164.html For the record, of

Re: [ovs-dev] [PATCH v3] OpenFlow: Add extn to set conntrack entries limit per zone.

2023-03-29 Thread Simon Horman
. The code looks good to me, thanks for addressing by review of v2. > Signed-off-by: Naveen Yerramneni > Reviewed-by: Simon Horman > --- > Notes: > v1 -> v2 > - Fix memory leak and added logs > v2 -> v3 > - Addressed nits ... _

Re: [ovs-dev] [PATCH v2] ovs-dpctl: Add new command dpctl/ct-sweep-next-run.

2023-03-29 Thread Simon Horman
reschedule time may be convenient in > some conditions, like debugging. > This patch introduces new commands allowing to get and set the sweep > next run in ms. > > Signed-off-by: Paolo Valerio Reviewed-by: Simon Horman ___ dev ma

Re: [ovs-dev] Reliability of system-offload test #50 [Was: Re: [PATCH v3 2/2] ci: Run tc offload tests in GitHub] Actions.

2023-03-29 Thread Simon Horman
On Tue, Mar 28, 2023 at 01:45:22PM +0200, Eelco Chaudron wrote: > > > On 10 Mar 2023, at 17:20, Simon Horman wrote: > > > On Fri, Mar 10, 2023 at 10:15:44AM +0100, Simon Horman wrote: > >> On Thu, Mar 09, 2023 at 05:22:43PM +0100, Eelco Chaudron wrote: > >>&

Re: [ovs-dev] [PATCH v5] utilities/ofctl: add-meters for save and restore

2023-03-29 Thread Simon Horman
On Fri, Mar 10, 2023 at 09:03:48PM +0800, Wan Junjie wrote: > put dump-meters' result in one line so add-meters can handle. > save and restore meters when restart ovs. > bundle functions are not implemented in this patch. > > Signed-off-by: Wan Junjie > > --- > v5: > merge oneline to verbosity h

Re: [ovs-dev] [PATCH v9] netdev-offload-tc: del ufid mapping if device not exist

2023-03-29 Thread Simon Horman
On Thu, Mar 30, 2023 at 11:13:32AM +0800, Faicker Mo wrote: > Thanks for your testing. > Add the ignore msg "failed to offload flow" to OVS_TRAFFIC_VSWITCHD_STOP can > pass the fail test. > I'll post an update later. Thanks. I'll look out for it. > From: Sim

Re: [ovs-dev] [PATCH v2 2/6] netdev-offload: Add DPDK meter offload API

2023-03-30 Thread Simon Horman
On Wed, Mar 22, 2023 at 09:35:29PM +0100, Ilya Maximets wrote: > On 3/9/23 14:02, Simon Horman wrote: > > From: Peng Zhang ... > > diff --git a/lib/netdev-offload-provider.h b/lib/netdev-offload-provider.h > > index 9108856d18d1..7ecbb8d026f1 100644 > > --- a/li

Re: [ovs-dev] [PATCH v5] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-03-30 Thread Simon Horman
On Fri, Mar 17, 2023 at 09:47:36PM +0100, Eelco Chaudron wrote: > > > Send from my phone > > > Op 17 mrt. 2023 om 21:11 heeft Marcelo Ricardo Leitner > > het volgende geschreven: > > > > On Thu, Mar 16, 2023 at 09:51:34AM +0100, Eelco Chaudron wrote: > >> > >> > >>> On 22 Dec 2022, at 13:3

Re: [ovs-dev] [PATCH ovn v3 1/2] CI: Add a couple of periodic jobs using ovn-fake-multinode.

2023-03-30 Thread Simon Horman
able for every push. > > [1] - > https://github.com/ovn-org/ovn-fake-multinode/blob/main/.ci/test_basic.sh > > Signed-off-by: Numan Siddique Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH ovn v3 2/2] Add fake multinode system tests.

2023-03-30 Thread Simon Horman
oy fake_multinode setup > by running 'ovn_cluster.sh start'. > > This test suite is also triggered for the newly added fake multinode CI > job. > > The fake multinode system tests suite can be enhanced further for new > features and to cover multi node scenarios. >

[ovs-dev] [PATCH dpdk-latest v3 0/6] Add support for DPDK meter HW offload

2023-03-30 Thread Simon Horman
Hi, this series adds support for DPDK meter HW offload. Changes between v2 and v3. * Use common API for DPDK and non-DPDK meter offloads * Make use of netdev_ports_traverse to offload the meter * Add dpdk-latest to subject prefix Changes between v1 and v2: * Add the prox mechanism: add the meter

[ovs-dev] [PATCH dpdk-latest v3 1/6] netdev-offload-dpdk: use flow transfer proxy

2023-03-30 Thread Simon Horman
From: Peng Zhang Manage "transfer" flows via the corresponding mechanism. Doing so requires that the traffic source be specified explicitly, via the corresponding pattern item. Signed-off-by: Peng Zhang Signed-off-by: Jin Liu Co-authored-by: Jin Liu Signed-off-by: Simon Horman

[ovs-dev] [PATCH dpdk-latest v3 5/6] netdev-dpdk: add meter algorithms

2023-03-30 Thread Simon Horman
From: Peng Zhang Add the meter algorithms. DPDK meter support three algorithms, and OVS also can support these algorithms. Signed-off-by: Peng Zhang Signed-off-by: Jin Liu Co-authored-by: Jin Liu Signed-off-by: Simon Horman --- lib/netdev-dpdk.c | 58

[ovs-dev] [PATCH dpdk-latest v3 3/6] dpif-netdev: Offloading meter with DPDK

2023-03-30 Thread Simon Horman
: Jin Liu Co-authored-by: Jin Liu Signed-off-by: Simon Horman --- lib/dpif-netdev.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 2c08a71c8db2..e8d0ca6606de 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c

[ovs-dev] [PATCH dpdk-latest v3 2/6] netdev-offload: Let meter offload API can be used with DPDK

2023-03-30 Thread Simon Horman
to HW. Signed-off-by: Peng Zhang Signed-off-by: Jin Liu Co-authored-by: Jin Liu Signed-off-by: Simon Horman --- Documentation/howto/dpdk.rst | 5 +- lib/netdev-offload-provider.h | 21 +- lib/netdev-offload-tc.c | 9 ++- lib/netdev-offload.c | 135

[ovs-dev] [PATCH dpdk-latest v3 6/6] netdev-dpdk-offload: Add support for meter action

2023-03-30 Thread Simon Horman
From: Peng Zhang Add support of DPDK meter action logic. Signed-off-by: Peng Zhang Signed-off-by: Jin Liu Co-authored-by: Jin Liu Signed-off-by: Simon Horman --- lib/netdev-offload-dpdk.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/netdev-offload-dpdk.c b/lib

[ovs-dev] [PATCH dpdk-latest v3 4/6] netdev-offload-dpdk: Implement meter offload API for DPDK

2023-03-30 Thread Simon Horman
From: Peng Zhang For dpif-netdev, meters are mapped by DPDK meter with one-to-one relationship. Implement meter offload API to set/get/del the DPDK meter with proxy port id. Signed-off-by: Peng Zhang Signed-off-by: Jin Liu Co-authored-by: Jin Liu Signed-off-by: Simon Horman --- lib/netdev

Re: [ovs-dev] [PATCH v5] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-03-31 Thread Simon Horman
On Thu, Mar 30, 2023 at 09:04:02PM +0200, Ilya Maximets wrote: > On 3/30/23 11:45, Simon Horman wrote: > > On Fri, Mar 17, 2023 at 09:47:36PM +0100, Eelco Chaudron wrote: > >> > >> > >> Send from my phone > >> > >>> Op 17 mrt. 2023 om

Re: [ovs-dev] [PATCH v10] netdev-offload-tc: del ufid mapping if device not exist.

2023-03-31 Thread Simon Horman
On Thu, Mar 30, 2023 at 05:27:23PM +0800, Faicker Mo wrote: > The device may be deleted and added with ifindex changed. > The tc rules on the device will be deleted if the device is deleted. > The func tc_del_filter will fail when flow del. The mapping of > ufid to tc will not be deleted. > The tra

Re: [ovs-dev] [PATCH v5] ofproto-dpif-upcall: Don't set statistics to 0 when they jump back

2023-03-31 Thread Simon Horman
On Fri, Mar 31, 2023 at 12:05:09PM +0200, Ilya Maximets wrote: > On 3/31/23 11:07, Simon Horman wrote: > > On Thu, Mar 30, 2023 at 09:04:02PM +0200, Ilya Maximets wrote: > >> On 3/30/23 11:45, Simon Horman wrote: > >>> On Fri, Mar 17, 2023 at 09:47:36PM +0100, Eelco

Re: [ovs-dev] [PATCH ovn 1/4] northd: Break ACLs into two stages.

2023-03-31 Thread Simon Horman
On Tue, Mar 21, 2023 at 01:59:06PM -0400, Mark Michelson wrote: > Prior to this commit, ACLs were evaluated and acted on in a single > stage. With this commit, evaluation of ACLs and acting on an ACL's > decision are separated into two stages. > > The acl_eval stage checks the ACL match and will s

Re: [ovs-dev] [PATCH v11 1/4] Documentation: Document netdev offload.

2023-03-31 Thread Simon Horman
On Mon, Mar 27, 2023 at 06:50:10AM -0400, Mike Pattrick wrote: > From: Flavio Leitner > > Document the implementation of netdev hardware offloading > in userspace datapath. > > Signed-off-by: Flavio Leitner > Co-authored-by: Mike Pattrick > Signed-off-by: Mike Pattr

Re: [ovs-dev] [PATCH v11 2/4] dpif-netdev: Show netdev offloading flags.

2023-03-31 Thread Simon Horman
Signed-off-by: Flavio Leitner > Co-authored-by: Mike Pattrick > Signed-off-by: Mike Pattrick > Reviewed-by: David Marchand Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/6] ovsdb-tool: Fix cluster-to-standalone for DB conversion records.

2023-03-31 Thread Simon Horman
abase file will not be that similar to the original, > but there is no way to represent conversion in a standalone database > file format otherwise. > > Fixes: 00de46f9ee42 ("ovsdb-tool: Convert clustered db to standalone db.") > Sign

Re: [ovs-dev] [PATCH 2/6] ovsdb: Check for ephemeral columns before writing a new schema.

2023-03-31 Thread Simon Horman
() remains, because we shouldn't blindly > trust the storage. > > Signed-off-by: Ilya Maximets Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/6] ovsdb: Allow conversion records with no data in a clustered storage.

2023-03-31 Thread Simon Horman
commits targeting > conversion speed increase. > > Signed-off-by: Ilya Maximets Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 4/6] ovsdb: Perform conversion with no data for clustered databases.

2023-03-31 Thread Simon Horman
rade. > Handled the same way as we did for the previous incompatible format > change in 2.15 (column diffs). > > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2022-December/052140.html > Signed-off-by: Ilya Maximets Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 6/6] ovsdb: monitor: Keep and maintain the initial change set.

2023-03-31 Thread Simon Horman
conds to send out all the monitor > replies in the example above. So, it's a 40x performance improvement. > On a more reasonable setup with 250 nodes, the process takes up to > 8-10 seconds instead of 4-5 minutes. > > Conditional monitoring will benefit from this change as

Re: [ovs-dev] [PATCH 5/6] ovsdb: Avoid converting database twice on an initiator.

2023-03-31 Thread Simon Horman
the storage. > > Keep the converted database from the first time around and use it > after reading the request back from the storage. This cuts in half > the conversion CPU cost. > > Signed-off-by: Ilya Maximets Reviewed-by: Simon Horman

Re: [ovs-dev] [PATCH ovn 1/4] northd: Break ACLs into two stages.

2023-03-31 Thread Simon Horman
On Fri, Mar 31, 2023 at 02:10:35PM +0200, Dumitru Ceara wrote: > On 3/31/23 13:52, Simon Horman wrote: > > On Tue, Mar 21, 2023 at 01:59:06PM -0400, Mark Michelson wrote: > >> Prior to this commit, ACLs were evaluated and acted on in a single > >> stage. With this com

Re: [ovs-dev] [PATCH v10] netdev-offload-tc: del ufid mapping if device not exist.

2023-04-03 Thread Simon Horman
now and the loop has run the test 73014 times without recording any failures. I think we are good here :) Reviewed-by: Simon Horman Tested-by: Simon Horman > > > > +]) > > +NS_CHECK_EXEC([at_ns0], [ping -q -c 2 -i 0.2 10.1.1.3 | FORMAT_PING], [0], > > [dnl > > +2 p

Re: [ovs-dev] [PATCH v2] learning-switch: Fix coredump of OpenFlow15 learning-switch

2023-04-03 Thread Simon Horman
> at utilities/ovs-testcontroller.c:180 > > Fix that by zeroing out the po variable. > > Fixes: 577bfa9f6879 ("ofp-util: Add OpenFlow 1.5 packet-out support") > Signed-off-by: Faicker Mo Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] util: fix an issue that thread name cannot be set

2023-04-04 Thread Simon Horman
is longer than 16 bytes, the thread > name will fail to be set > > Signed-off-by: Songtao Zhan Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress and egress pkts policer.

2023-04-05 Thread Simon Horman
On Tue, Apr 04, 2023 at 01:46:05PM +, lin huang wrote: > Hi Ilya, > > Pls review my code. > > I want to add a new policer which is pps-based in netdev-dpdk module. > The policer is divided into ingress and egress part. Both use the ovs native > tocken bucket library as the counter. > Compar

Re: [ovs-dev] [PATCH ovn] northd: take into account qos_min_rate in port_has_qos_params

2023-04-05 Thread Simon Horman
On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo Bianconi wrote: > Similar to qos_max_rate and qos_burst, take into account qos_min_rate in > port_has_qos_params routine. > > Fixes: dbf12e5fe1f7 ("qos: add support for port minimum bandwidth guarantee") > Signed-off-by: Lorenzo Bianconi Hi Loren

Re: [ovs-dev] [PATCH ovn] northd: rever ct.inv drop flows

2023-04-05 Thread Simon Horman
g a flow per load-balancer backend. > > Signed-off-by: Lorenzo Bianconi Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [External] Re: [PATCH v5] utilities/ofctl: add-meters for save and restore

2023-04-05 Thread Simon Horman
Hi Wan Junjie, On Tue, Apr 04, 2023 at 03:42:47PM +0800, Wan Junjie wrote: > Hi Simon, > > On Wed, Mar 29, 2023 at 11:57 PM Simon Horman > wrote: > > On Fri, Mar 10, 2023 at 09:03:48PM +0800, Wan Junjie wrote: ... > > > @@ -805,5 +831,73 @@ ofputil_format_meter_mod

Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress and egress pkts policer.

2023-04-05 Thread Simon Horman
On Wed, Apr 05, 2023 at 02:07:42PM +, lin huang wrote: > Hi Simon, > > : ) > Thanks for your reply. > > There are some explanations about your comments. > > Best regards, Huang Lin. > > > -Original Message- > > From: Simon Horman > >

Re: [ovs-dev] [PATCH ovn] northd: take into account qos_min_rate in port_has_qos_params

2023-04-06 Thread Simon Horman
On Thu, Apr 06, 2023 at 02:07:00PM +0200, Dumitru Ceara wrote: > On 4/5/23 14:43, Simon Horman wrote: > > On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo Bianconi wrote: > >> Similar to qos_max_rate and qos_burst, take into account qos_min_rate in > >>

Re: [ovs-dev] [PATCH v1 0/2] Add netdev-dpdk support for ingress and egress pkts policer.

2023-04-06 Thread Simon Horman
On Thu, Apr 06, 2023 at 02:13:00PM +0200, Ilya Maximets wrote: > On 4/6/23 08:38, Simon Horman wrote: > > On Wed, Apr 05, 2023 at 02:07:42PM +, lin huang wrote: > >> Hi Simon, > >> > >> : ) > >> Thanks for your reply. > >> > >>

Re: [ovs-dev] [PATCH ovn v2] controller: Clear tunnels from old integration bridge

2023-04-06 Thread Simon Horman
On Mon, Apr 03, 2023 at 11:50:26AM +0200, Ales Musil wrote: > After integration bridge change the tunnels would > stay on the old bridge preventing new tunnels creation > and disrupting traffic. Detect the bridge change > and clear the tunnels from the old integration bridge. > > Reported-at: http

Re: [ovs-dev] [PATCH v3] ovs-dpctl: Add new command dpctl/ct-[sg]et-sweep-interval.

2023-04-06 Thread Simon Horman
reschedule time may be convenient in > some conditions, like debugging. > This patch introduces new commands allowing to get and set the sweep > interval in ms. > > Signed-off-by: Paolo Valerio Reviewed-by: Simon Horman ___ dev ma

Re: [ovs-dev] [PATCH ovn] northd: take into account qos_min_rate in port_has_qos_params

2023-04-07 Thread Simon Horman
On Thu, Apr 06, 2023 at 05:25:06PM +0200, Dumitru Ceara wrote: > On 4/6/23 14:45, Simon Horman wrote: > > On Thu, Apr 06, 2023 at 02:07:00PM +0200, Dumitru Ceara wrote: > >> On 4/5/23 14:43, Simon Horman wrote: > >>> On Tue, Apr 04, 2023 at 11:01:26PM +0200, Lorenzo

Re: [ovs-dev] [PATCH v4] OpenFlow: Add extn to set conntrack entries limit per zone.

2023-04-07 Thread Simon Horman
On Thu, Mar 30, 2023 at 08:17:18AM +, Naveen Yerramneni wrote: > Add OpenFlow extn to set conntrack entries limit per zone. > This extn will be used in future to set the zone level limit for > drop zones used by OVN. > > Signed-off-by: Naveen Yerramneni > Reviewe

Re: [ovs-dev] [PATCH net v3] net: openvswitch: fix race on port output

2023-04-07 Thread Simon Horman
On Thu, Apr 06, 2023 at 07:05:13PM -0700, Jakub Kicinski wrote: > On Wed, 5 Apr 2023 07:53:41 + Felix Huettner wrote: > > assume the following setup on a single machine: > > 1. An openvswitch instance with one bridge and default flows > > 2. two network namespaces "server" and "client" > > 3. t

Re: [ovs-dev] [PATCH net v3] net: openvswitch: fix race on port output

2023-04-07 Thread Simon Horman
On Fri, Apr 07, 2023 at 10:44:35AM +0200, Simon Horman wrote: > On Thu, Apr 06, 2023 at 07:05:13PM -0700, Jakub Kicinski wrote: > > On Wed, 5 Apr 2023 07:53:41 + Felix Huettner wrote: > > > assume the following setup on a single machine: > > > 1. An openvswitch i

Re: [ovs-dev] [PATCH ovn v3] controller: Clear tunnels from old integration bridge

2023-04-07 Thread Simon Horman
> Reported-at: https://bugzilla.redhat.com/2173635 > Signed-off-by: Ales Musil Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] util: fix an issue that thread name cannot be set

2023-04-07 Thread Simon Horman
is longer than 16 bytes, the thread > name will fail to be set > > Signed-off-by: Songtao Zhan Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] learning-switch: Fix coredump of OpenFlow15 learning-switch

2023-04-07 Thread Simon Horman
> at utilities/ovs-testcontroller.c:180 > > Fix that by initing the flow metadata. > > Fixes: 35eb6326d5d0 ("ofp-util: Add flow metadata to ofputil_packet_out") > Signed-off-by: Faicker Mo Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovsdb-cs: fix 'cs_db' lock flag not updated error.

2023-04-07 Thread Simon Horman
On Fri, Apr 07, 2023 at 02:59:04PM +0800, wanghanlin wrote: > When 'cs' is not connected to a server, then > ovsdb_cs_db_compose_lock_request__ will update > 'cs_db' lock flag, but the lock flag will not > be updated next. > > Signed-off-by: wanghanlin Hi, Are there also error conditions where

Re: [ovs-dev] [PATCH ovn branch-22.09] ci: ovn-kubernetes: Pin ovn-k8s version.

2023-04-07 Thread Simon Horman
; > > Signed-off-by: Dumitru Ceara > > --- > > NOTE: this should be applied to branches 22.09, 22.06 and 22.03 (LTS). > > --- > > .ci/ovn-kubernetes/Dockerfile| 2 +- > > .github/workflows/ovn-kubernetes.yml | 2 +- > > 2 files changed

Re: [ovs-dev] [PATCH ovn v8 1/2] northd: Update the is_stateless helper for rotuer nat

2023-04-10 Thread Simon Horman
Musil > --- > v8: No change since v7. Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v6] utilities/ofctl: add-meters for save and restore

2023-04-10 Thread Simon Horman
On Mon, Apr 10, 2023 at 09:23:46PM +0800, Wan Junjie via dev wrote: > put dump-meters' result in one line so add-meters can handle. > save and restore meters when restart ovs. > bundle functions are not implemented in this patch. > > Signed-off-by: Wan Junjie Hi, unfortunately this one doesn't

Re: [ovs-dev] [PATCH v9] utilities/ofctl: add-meters for save and restore

2023-04-11 Thread Simon Horman
On Tue, Apr 11, 2023 at 11:03:46AM +0800, Wan Junjie wrote: > put dump-meters' result in one line so add-meters can handle. > save and restore meters when restart ovs. > bundle functions are not implemented in this patch. > > Signed-off-by: Wan Junjie > > --- > v9: > fix verbosity mask bits for

Re: [ovs-dev] [PATCH ovn v2 2/4] northd: Add tiered ACL support.

2023-04-11 Thread Simon Horman
On Mon, Apr 10, 2023 at 01:26:11PM -0400, Mark Michelson wrote: > With this commit, ACLs can now be arranged in hierarchical tiers. A tier > number can be assigned to an ACL. When evaluating ACLs, we first will > consider ACLs at tier 0. If no matching ACL is found, then we move to > tier 1. This c

Re: [ovs-dev] [PATCH ovn v2 3/4] ovn-nbctl: Add tier ACL options.

2023-04-11 Thread Simon Horman
On Mon, Apr 10, 2023 at 01:26:12PM -0400, Mark Michelson wrote: ... > diff --git a/utilities/ovn-nbctl.c b/utilities/ovn-nbctl.c ... > @@ -2390,6 +2394,16 @@ nbctl_acl_add(struct ctl_context *ctx) > nbrec_acl_set_options(acl, &options); > } > > +const char *tier_s = shash_fi

<    1   2   3   4   5   6   7   8   9   10   >