[ovs-dev] [PATCH 0/2] docs: afxdp: Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling.

This short patch set: * Corrects the spelling of CONFIG_HAVE_EBPF_JIT in AFXDP documentation - This patch extracted from GitHub PR https://github.com/openvswitch/ovs/pull/393 * Adds Ville Skyttä to the authors file --- Simon Horman (1): AUTHORS: Add Ville Skyttä. Ville Skyttä (1

Re: [ovs-dev] [PATCH 1/2] docs: afxdp: Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling.

On Tue, May 21, 2024 at 08:35:21AM +0200, Eelco Chaudron wrote: > > > On 20 May 2024, at 20:13, Simon Horman wrote: > > > From: Ville Skyttä > > > > Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling "EBPF" vs "BPF"). > > > > Signed-

Re: [ovs-dev] [PATCH v2] ovsdb: Use table indexes if available for ovsdb_query().

On Mon, Jun 03, 2024 at 12:20:36AM -0400, Mike Pattrick wrote: > Currently all OVSDB database queries except for UUID lookups all result > in linear lookups over the entire table, even if an index is present. > > This patch modifies ovsdb_query() to attempt an index lookup first, if > possible. If

Re: [ovs-dev] [PATCH v2 1/2] ipf: Only add fragments to batch of same dl_type.

e datapath: Add fragmentation handling.") > Reported-at: https://issues.redhat.com/browse/FDP-560 > Signed-off-by: Mike Pattrick Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 2/2] ipf: Handle common case of ipf defragmentation.

st of the > time. > > Fixes: 4ea96698f667 ("Userspace datapath: Add fragmentation handling.") > Reported-at: https://issues.redhat.com/browse/FDP-560 > Signed-off-by: Mike Pattrick Acked-by: Simon Horman ___ dev mailing list d..

Re: [ovs-dev] [PATCH 1/3] tests: sendpkt: Allow different input formats.

s as well as pure hex strings provided by ovs-ofctl compose-packet > and ovs-pcap. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/3] tests: Convert ND, MPLS and CT sendpkt tests to compose-packet.

hell variables, because we can see the > substitution result in the test log. So, using m4_define and m4_join > extensively. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 3/3] nsh: Add support to compose-packet and use it in system tests.

don't feel strongly about it. > M4 macros are better than shell variables, because we can see the > substitution result in the test log. So, using m4_define and m4_join > extensively. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman _

Re: [ovs-dev] [PATCH 1/1] netdev-offload-tc: Reserve lower tc prio for vlan ethertype.

On Thu, May 30, 2024 at 09:31:06AM +0300, Roi Dayan via dev wrote: > > > On 28/05/2024 20:12, Ilya Maximets wrote: > > On 5/26/24 10:31, Roi Dayan via dev wrote: > >> From: Maor Dickman > >> > >> The cited commit reserved lower tc priorities for IP ethertypes in order > >> to give IP traffic hig

Re: [ovs-dev] [PATCH] socket: Increase listen backlog to 128 everywhere.

+ Ihar On Fri, May 31, 2024 at 03:40:08PM -0400, Brian Haley wrote: > An earlier patch [1] increased the size of the listen > backlog to 64. While that was a huge improvement over > 10, further testing in large deployments showed 128 > was even better. nit: I would slightly prefer if a commit was

Re: [ovs-dev] [PATCH 0/2] docs: afxdp: Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling.

On Mon, May 20, 2024 at 07:13:43PM +0100, 'Simon Horman' wrote: > This short patch set: > > * Corrects the spelling of CONFIG_HAVE_EBPF_JIT in AFXDP documentation > - This patch extracted from GitHub PR > https://github.com/openvswitch/ovs/pull/393 > * Adds Vill

Re: [ovs-dev] [PATCH 0/2] ovs-ctl: Fix typo.

On Mon, May 20, 2024 at 04:39:49PM +0100, 'Simon Horman' wrote: > -- > v1 [Simon] > - Added punctuation to subject > - Added commit message > - Extracted ptach from GitHub PR workflow > + https://github.com/openvswitch/ovs/pull/406 > > --- > Jun Gu (1):

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows : Add sanity check in OvsInitConntrack.

On Sun, May 26, 2024 at 04:08:18PM +0800, Wilson Peng via dev wrote: > From: Wilson Peng > > While deploying Tanzu Kubernetes(Antrea based solution) in Broadcom customer, > Sometimes it is found that the kernel thread OvsConntrackEntryCleaner is not > started > After the Windows node is rebooted

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

On Wed, Jun 05, 2024 at 01:35:52PM +0800, Wilson Peng via dev wrote: > From: Wilson Peng > > It is found the TFTP reply packet with source port 69 will trigger host hang > And the possible coredump. > > According to part 4 in TFTP RFC https://datatracker.ietf.org/doc/html/rfc1350, > The TFTP rep

Re: [ovs-dev] [PATCH] netdev-offload-dpdk: support offload of set dscp action.

On Sun, May 26, 2024 at 04:43:16PM +0800, Sunyang Wu via dev wrote: > Signed-off-by: Sunyang Wu Recheck-request: github-robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/1] debian: Fix tabs vs spaces.

instead. > Fix it. > > Signed-off-by: Roi Dayan Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net-next v2 9/9] selftests: openvswitch: add emit_sample test

On Mon, Jun 03, 2024 at 08:56:43PM +0200, Adrian Moreno wrote: > Add a test to verify sampling packets via psample works. > > In order to do that, create a subcommand in ovs-dpctl.py to listen to > on the psample multicast group and print samples. > > In order to also test simultaneous sFlow and

Re: [ovs-dev] [PATCH net-next v2 5/9] net: openvswitch: add emit_sample action

On Mon, Jun 03, 2024 at 08:56:39PM +0200, Adrian Moreno wrote: > Add support for a new action: emit_sample. > > This action accepts a u32 group id and a variable-length cookie and uses > the psample multicast group to make the packet available for > observability. > > The maximum length of the us

Re: [ovs-dev] [PATCH net-next v2 5/9] net: openvswitch: add emit_sample action

On Wed, Jun 05, 2024 at 07:31:55PM +, Adrián Moreno wrote: > On Wed, Jun 05, 2024 at 08:29:22AM GMT, kernel test robot wrote: > > Hi Adrian, > > > > kernel test robot noticed the following build errors: > > > > [auto build test ERROR on net-next/main] > > > > url: > > https://github.com/int

Re: [ovs-dev] [PATCH v2] netdev-offload-dpdk: Support offload of set dscp action.

On Wed, May 29, 2024 at 09:14:03AM +0800, Sunyang Wu via dev wrote: Hi Sunyang, It would be nice to include a patch description here. > Signed-off-by: Sunyang Wu ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/o

Re: [ovs-dev] [PATCH 1/1] debian: Fix tabs vs spaces.

On Tue, May 28, 2024 at 11:34:17AM +0300, Roi Dayan via dev wrote: > Getting the following message while trying to build a debian package. > debian/openvswitch-switch.init > debian/openvswitch-switch.postinst > See above for files that use tabs for indentation. > Please use spaces instead. > Fix it

Re: [ovs-dev] [PATCH v2] checkpatch: Don't warn on pointer to pointer.

e raised when the > patch contains a simple list of pointers, e.g: "char **errrp"). > > Fix the regexp to allow more than one consecutive "+" characters. > > Signed-off-by: Adrian Moreno Acked-by: Simon Horman ___ dev ma

Re: [ovs-dev] [PATCH v2] system-dpdk: Tolerate new warnings 23.11.1/24.03.

s://github.com/DPDK/dpdk-stable/commit/cbd1c165 > > Signed-off-by: Christian Ehrhardt > --- > Changes since v1: > - adapt to grammar rules for the subject Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] checkpatch: Extend and move extra_keywords list to file.

patches and selecting any words that appeared multiple times. > > The rational for using a separate file is to make management of this > list simpler by decoupling the code from the keywords. > > Signed-off-by: Mike Pattrick Acked-by: Simon Horman

Re: [ovs-dev] [PATCH v2] checkpatch: Extend and move extra_keywords list to file.

patches and selecting any words that appeared multiple times. > > The rational for using a separate file is to make management of this > list simpler by decoupling the code from the keywords. > > Signed-off-by: Mike Pattrick > --- > v2: Included new file in

Re: [ovs-dev] [PATCH 1/1] netdev-offload-tc: Reserve lower tc prio for vlan ethertype.

On Thu, Jun 06, 2024 at 10:54:45AM +, Roi Dayan wrote: > Hi Simon, > > I appreciate the review, Yes we will look in some of the other ether > types and see if it's something we think is needed to prioritize as well. Thanks Roi, Much appreciated. I've gone ahead and applied this patch to mai

Re: [ovs-dev] [PATCH v2 1/1] datapath-windows : Avoid a deadlock when processing TFTP conntrack.

On Wed, Jun 05, 2024 at 09:26:02PM +0800, Wilson Peng wrote: > Hi, Simon, > In this case, for tftp packet processing, it does have a child-parent > processing logic just like ftp in tcp. > Tftp packet1 from port1 to 69 and it will create one new conntrack entry > and create one related conntrac

Re: [ovs-dev] [Patch v2] ovsdb-client: Add "COLUMN" arg to help for 'dump'.

Signed-off-by: Martin Kalcok Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] checkpatch: Don't warn on pointer to pointer.

On Fri, Jun 07, 2024 at 07:06:21AM +, Adrián Moreno wrote: > On Fri, Jun 07, 2024 at 08:57:11AM GMT, Eelco Chaudron wrote: > > > > > > On 5 Jun 2024, at 15:51, Adrian Moreno wrote: > > > > > Current regexp used to check whitespaces around operators does not > > > consider that there can be more

Re: [ovs-dev] [PATCH v2] checkpatch: Don't warn on pointer to pointer.

On Fri, Jun 07, 2024 at 12:03:15PM +0100, Simon Horman wrote: > On Fri, Jun 07, 2024 at 07:06:21AM +, Adrián Moreno wrote: > > On Fri, Jun 07, 2024 at 08:57:11AM GMT, Eelco Chaudron wrote: > > > > > > > > > On 5 Jun 2024, at 15:51, Adrian Moreno wrote:

Re: [ovs-dev] [PATCH net-next v2 4/9] net: psample: allow using rate as probability

On Mon, Jun 03, 2024 at 08:56:38PM +0200, Adrian Moreno wrote: > Although not explicitly documented in the psample module itself, the > definition of PSAMPLE_ATTR_SAMPLE_RATE seems inherited from act_sample. > > Quoting tc-sample(8): > "RATE of 100 will lead to an average of one sampled packet out

Re: [ovs-dev] [PATCH net-next v2 5/9] net: openvswitch: add emit_sample action

On Mon, Jun 03, 2024 at 08:56:39PM +0200, Adrian Moreno wrote: > Add support for a new action: emit_sample. > > This action accepts a u32 group id and a variable-length cookie and uses > the psample multicast group to make the packet available for > observability. > > The maximum length of the us

Re: [ovs-dev] [PATCH net-next v2 1/9] net: psample: add user cookie

Signed-off-by: Adrian Moreno Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH net-next v2 2/9] net: sched: act_sample: add action cookie to sample

On Mon, Jun 03, 2024 at 08:56:36PM +0200, Adrian Moreno wrote: > If the action has a user_cookie, pass it along to the sample so it can > be easily identified. > > Signed-off-by: Adrian Moreno Reviewed-by: Simon Horman ___ dev ma

Re: [ovs-dev] [PATCH net-next v2 3/9] net: psample: skip packet copy if no listeners

On Mon, Jun 03, 2024 at 08:56:37PM +0200, Adrian Moreno wrote: > If nobody is listening on the multicast group, generating the sample, > which involves copying packet data, seems completely unnecessary. > > Return fast in this case. > > Signed-off-by: Adrian Moreno Reviewe

Re: [ovs-dev] [PATCH net-next v2 7/9] net: openvswitch: do not notify drops inside sample

imization by which the skb is not cloned on last sample actions. > But, given explicit drop actions are now supported, OVS can just add one > after the last sample() and rewrite the flow as: > > actions:sample(..,emit_sample(..)),drop > > Signed-off-by: Adrian Mor

Re: [ovs-dev] [RFC net-next 1/7] selftests: openvswitch: Support explicit tunnel port creation.

] Hi Aaron, It is corrected as part of another patch in this series, but the correct port for vxlan is 4789 (i.e. 89 rather than 98). With that fixed, feel free to add: Reviewed-by: Simon Horman Tested-by: Simon Horman .. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC net-next 4/7] selftests: openvswitch: Add support for tunnel() key.

On Thu, Jun 13, 2024 at 02:13:30PM -0400, Aaron Conole wrote: > This will be used when setting details about the tunnel to use as > transport. There is a difference between the ODP format between tunnel(): > the 'key' flag is not actually a flag field, so we don't support it in the > same way that

Re: [ovs-dev] [RFC net-next 5/7] selftests: openvswitch: Support implicit ipv6 arguments.

> def convert_int(size): > def convert_int_sized(data): > value, _, mask = data.partition('/') ... The nit above notwithstanding, this patch looks good to me. Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC net-next 2/7] selftests: openvswitch: Refactor actions parsing.

> > Signed-off-by: Aaron Conole Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC net-next 3/7] selftests: openvswitch: Add set() and set_masked() support.

arsing to > properly understand it. > > Signed-off-by: Aaron Conole Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC net-next 7/7] selftests: net: add config for openvswitch

On Thu, Jun 13, 2024 at 02:13:33PM -0400, Aaron Conole wrote: > The pmtu testing will require that the OVS module is installed, > so do that. > > Signed-off-by: Aaron Conole Reviewed-by: Simon Horman Tested-by: Simon Horman ___ dev ma

[ovs-dev] [PATCH net] selftests: openvswitch: Use bash as interpreter

test_ct_connect_v4 dp:ct4 {, , } ./openvswitch.sh: 322: eval: Bad substitution create namespaces Resolve this by making openvswitch.sh a bash script. Fixes: 918423fda910 ("selftests: openvswitch: add an initial flow programming case") Signed-off-by: Simon Horman --- tools/testing/selfte

Re: [ovs-dev] [PATCH net-next v2 4/9] net: psample: allow using rate as probability

On Mon, Jun 17, 2024 at 06:32:14AM +, Adrián Moreno wrote: > On Fri, Jun 14, 2024 at 05:11:30PM GMT, Simon Horman wrote: > > On Mon, Jun 03, 2024 at 08:56:38PM +0200, Adrian Moreno wrote: > > > Although not explicitly documented in the psample module itself, the &

Re: [ovs-dev] [PATCH net] selftests: openvswitch: Use bash as interpreter

On Mon, Jun 17, 2024 at 12:05:11PM +0200, Przemek Kitszel wrote: > On 6/17/24 10:28, Simon Horman wrote: > > openvswitch.sh makes use of substitutions of the form ${ns:0:1}, to > > obtain the first character of $ns. Empirically, this is works with bash > > but not dash. Whe

Re: [ovs-dev] [Patch] ovsdb-client: Document "--timeout" option in help.

applying. Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] checkpatch: Don't warn on pointer to pointer.

On Mon, Jun 10, 2024 at 10:56:10AM -0400, Aaron Conole wrote: > Aaron Conole writes: > > > Adrian Moreno writes: > > > >> Current regexp used to check whitespaces around operators does not > >> consider that there can be more than one "*" together to express pointer > >> to pointer. > >> > >> As

Re: [ovs-dev] [PATCH] vswitchd: Only lock pages that are faulted in.

on shared huge pages, which is only available in 4.11+ kernels. > So, technically, it should not be possible for MCL_ONFAULT to fail and > the call without it to succeed. But keeping the check just in case > for now. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] ovsdb: Use table indexes if available for ovsdb_query().

On Mon, Jun 17, 2024 at 01:11:28PM -0400, Mike Pattrick wrote: > On Mon, Jun 3, 2024 at 2:01 PM Ilya Maximets wrote: > > > > On 6/3/24 06:20, Mike Pattrick wrote: > > > Currently all OVSDB database queries except for UUID lookups all result > > > in linear lookups over the entire table, even if an

Re: [ovs-dev] [PATCH v2] ovsdb: Use table indexes if available for ovsdb_query().

On Wed, Jun 19, 2024 at 08:35:20AM -0400, Mike Pattrick wrote: > On Wed, Jun 19, 2024 at 8:32 AM Simon Horman wrote: > > > > On Mon, Jun 17, 2024 at 01:11:28PM -0400, Mike Pattrick wrote: > > > On Mon, Jun 3, 2024 at 2:01 PM Ilya Maximets wrote: > > > > &g

Re: [ovs-dev] [PATCH v3] netdev-offload-dpdk: Support offload of set dscp action.

On Thu, Jun 20, 2024 at 03:35:20PM +0800, Sunyang Wu via dev wrote: > Add the "set dscp action" parsing function, > so that the "set dscp action" can be offloaded. > > Signed-off-by: Sunyang Wu Acked-by: Simon Horman __

Re: [ovs-dev] [Patch v2] ovsdb-client: Add "COLUMN" arg to help for 'dump'.

On Fri, Jun 07, 2024 at 11:30:55AM +0200, Martin Kalcok wrote: > Help text for 'ovsdb-client dump' does not mention that it's capable > of dumping a specific column's contents if the user supplies the > column's name as a fourth positional argument. > > Signed-off-by: Martin Kalcok Thanks Martin

Re: [ovs-dev] [Patch] ovsdb-client: Document "--timeout" option in help.

On Wed, Jun 19, 2024 at 11:54:37AM +0100, Simon Horman wrote: > On Fri, Jun 07, 2024 at 01:58:42PM +0200, martin.kal...@canonical.com wrote: > > I made a silly typo in the commit message s/infomration/information. > > Would it be possible to fix it when the commit is applied, or

Re: [ovs-dev] [dpdk-latest] sparse: Fix build with DPDK v23.11-rc1.

ready. > I am expecting more changes in EAL headers and I'll update this patch > if hitting more issues. Hi David, It seems appropriate to mark this as deffered in patchwork, so I have done so. Patch looks find to me. Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovsdb-cluster.at: Remove extra ordinal schema and schema name operations.

On Fri, Sep 01, 2023 at 07:32:02PM +0200, Ilya Maximets wrote: > Many tests are retrieving the schema name twice and also producing > an ordinal schema which is not used in these tests. > > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___

Re: [ovs-dev] [PATCH] checkpatch: Add checks for the subject line.

ubject when spell checking is otherwise active. > Signed-off-by: Eelco Chaudron Patch looks otherwise good to me. Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-trace: Support detailed output for conjunctive match.

On Thu, Sep 07, 2023 at 03:08:41PM +0900, Nobuhiro MIKI wrote: > A conjunctive flow consists of two or more multiple flows with > conjunction actions. When input to the ofproto/trace command > matches a conjunctive flow, it outputs flows of all dimensions. > > Signed-off-by: Nobuhiro MIKI Hi Mik

Re: [ovs-dev] [PATCH v2] checkpatch: Add checks for the subject line.

On Mon, Sep 11, 2023 at 05:06:26PM +0200, Eelco Chaudron wrote: > This patch adds WARNINGs for the subject line length and the format, > i.e., the sentence should start with a capital and end with a dot. > > Signed-off-by: Eelco Chaudron Acked-by:

Re: [ovs-dev] [PATCH] python: idl: Fix last-id update from a monitor reply.

s: 46d44cf3be0d ("python: idl: Add monitor_cond_since support.") > Signed-off-by: Ilya Maximets Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3] checkpatch: Add checks for the subject line.

On Thu, Sep 14, 2023 at 03:52:50PM +0200, Eelco Chaudron wrote: > > > On 14 Sep 2023, at 15:44, Eelco Chaudron wrote: > > > This patch adds WARNINGs for the subject line length and the format, > > i.e., the sentence should start with a capital and end with a dot. > &g

Re: [ovs-dev] [PATCH v2 2/2] ofproto-dpif-trace: Support detailed output for conjunctive match.

On Fri, Sep 15, 2023 at 12:02:13PM +0900, Nobuhiro MIKI wrote: > A conjunctive flow consists of two or more multiple flows with > conjunction actions. When input to the ofproto/trace command > matches a conjunctive flow, it outputs flows of all dimensions. > > Signed-off-by: Nobuhiro MIKI Hi Mik

Re: [ovs-dev] [PATCH] connmgr: Fix ofconn configuration on vswitchd startup.

) and max_backoff (8s) on initial creation > of the ofservice, as these config values are available from the > ofproto_controller struct c. > > Signed-off-by: Brad Cowie Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4] utilities: Add kernel_delay.py script to debug a busy Linux kernel.

developers.redhat.com/articles/2023/07/24/troubleshooting-open-vswitch-kernel-blame > > Signed-off-by: Eelco Chaudron Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/3] ovs-vsctl: Add limit to CT zone

s preparation step and the value is not yet > propagated to the datapath. > > Signed-off-by: Ales Musil Hi Ales, Please address the 0-day Robot request for the patch subject to end in a '.' The above comment notwithstanding, Acked-by: Simon Horman _

Re: [ovs-dev] [PATCH v2 2/3] vswitchd, ofproto-dpif: Propagate the CT limit from database

On Tue, Sep 26, 2023 at 12:03:51PM +0200, Ales Musil wrote: > Progpagate the CT limit that is present in the DB into > datapath. The limit is currently only propagated on change > and can be overwritten by the dpctl commands. > > Signed-off-by: Ales Musil ... > @@ -6366,7 +6378,7 @@ handle_flow

Re: [ovs-dev] [PATCH v2 3/3] netlink, netdev: Enforce CT limit protection

> Signed-off-by: Ales Musil Hi Ales, Please add a '.' to the end of the patch subject. That notwithstanding, Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] netdev: Fixed DPDK specific interface status options.

On Wed, Sep 27, 2023 at 01:46:19PM +0200, jm...@redhat.com wrote: > From: Jakob Meng > > The documentation in vswitchd/vswitch.xml for status columns has been > updated to reflect recent and not so recent changes to dpdk netdevs. > For example, status columns pci-vendor_id and pci-device_id have

Re: [ovs-dev] [PATCH v2 2/2] conntrack: Use helpers from committed connections.

On Mon, Sep 04, 2023 at 07:45:07PM +0400, Viacheslav Galaktionov via dev wrote: > Currently, if the user wants to track related connections, they have to > specify a helper in all CT actions, which contradicts the behaviour > described in the documentation. > > Fix this by using the helper committ

Re: [ovs-dev] [PATCH v3] ofproto-dpif-mirror: Add support for pre-selection filter

On Fri, Sep 08, 2023 at 12:28:24PM -0400, Mike Pattrick wrote: > Currently a bridge mirror will collect all packets and tools like > ovs-tcpdump can apply additional filters after they have already been > duplicated by vswitchd. This can result in inefficient collection. > > This patch adds suppor

Re: [ovs-dev] [PATCH v3 1/1] ofproto-dpif-trace: Improve conjunctive match tracing.

+ Mike Pattrick On Mon, Sep 25, 2023 at 06:09:00PM +0900, Nobuhiro MIKI wrote: > A conjunctive flow consists of two or more multiple flows with > conjunction actions. When input to the ofproto/trace command > matches a conjunctive flow, it outputs flows of all dimensions. > > Signed-off-by: Nobu

Re: [ovs-dev] [PATCH, v3] netdev: Sync'ed and cleaned {get, set}_config().

On Wed, Sep 27, 2023 at 03:24:07PM +0200, jm...@redhat.com wrote: > From: Jakob Meng > > For better usability, the function pairs get_config() and > set_config() for each netdev should be symmetric: Options which are > accepted by set_config() should be returned by get_config() and the > latter s

Re: [ovs-dev] [PATCH v2 branch-2.17 2/2] conntrack: Remove nat_conn introducing key directionality.

On Wed, Sep 27, 2023 at 11:31:22AM -0400, Aaron Conole wrote: > From: Peng He > > The patch avoids the extra allocation for nat_conn. > Currently, when doing NAT, the userspace conntrack will use an extra > conn for the two directions in a flow. However, each conn has actually > the two keys for

Re: [ovs-dev] [PATCH v2 2/3] vswitchd, ofproto-dpif: Propagate the CT limit from database

On Mon, Oct 02, 2023 at 12:33:57PM +0200, Ales Musil wrote: > On Thu, Sep 28, 2023 at 9:35 AM Simon Horman wrote: > > > On Tue, Sep 26, 2023 at 12:03:51PM +0200, Ales Musil wrote: > > > Progpagate the CT limit that is present in the DB into > > > datapath. The limi

Re: [ovs-dev] [PATCH 1/2] ofp-prop: Add helper for parsing and storing of ovs_u128.

On Tue, Oct 03, 2023 at 07:56:29AM +0200, Ales Musil wrote: > Add helper methods that allow us to store and parse the > ovs_u128 type. > > Signed-off-by: Ales Musil Acked-by: Simon Horman ___ dev mailing list d...@openvswit

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On Tue, Oct 03, 2023 at 07:56:30AM +0200, Ales Musil wrote: > Extend the current NX_CT_FLUSH with four additional fields, > that allow to match on CT entry "mark" or "labels". This > is encoded as separate TLV values which is backward compatible. > Versions that do not support them will simply igno

Re: [ovs-dev] [PATCH v5 1/1] dpif-netdev: Add per pmd sleep config.

o set PMD thread cores 10 and 11 to request a max sleep of 100 usecs > and all other PMD thread cores to never request a sleep: > > $ ovs-vsctl set open_vswitch . other_config:pmd-sleep-max=10:100,11:100 > > 'pmd-sleep-show' is updated to show the max sleep value

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On Tue, Oct 03, 2023 at 10:18:45AM +0200, Ales Musil wrote: > On Tue, Oct 3, 2023 at 10:14 AM Simon Horman wrote: > > > On Tue, Oct 03, 2023 at 07:56:30AM +0200, Ales Musil wrote: > > > Extend the current NX_CT_FLUSH with four additional fields, > > > that allow

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Check mirror port before do terminate_native_tunnel

On Fri, Jul 26, 2019 at 08:18:39PM +0800, Wang Li wrote: > From: Wang Li > > The problem is the ovs-tcpdump can not capture the ingress vxlan traffics > when it listens on the dpdk port, and the following dump-flows described > the details: > > ovs-tcpdump stopped: > recirc_id(0),in_port(2),pack

Re: [ovs-dev] [PATCH] connmgr: fix flow-restore-wait not work with controller connects

On Sat, May 09, 2020 at 05:32:22PM +0800, we...@ucloud.cn wrote: > From: wenxu > > When restart the vswitchd with flow-restore-wait. The Vswitch doesn't > connect to the controller util the flow-restore-wait finished. > > Because when bridge_configure_remotes() calls bridge_get_controllers(), >

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix tun_metadata match after recirc

On Thu, Aug 20, 2020 at 03:45:22PM -0700, Yi-Hung Wei wrote: > Consider the following OpenFlow rules that match on tun_metadata0 after > recirculation. If we start ICMP flow with tun_metadata0=0x1 follow by > a flow with tun_metadata0=0x3, OVS will incorrectly match the second > flow with the tun_

Re: [ovs-dev] [PATCH v3] userspace: fix bad UDP performance issue of veth

On Thu, Sep 24, 2020 at 10:05:16AM +0800, yang_y...@163.com wrote: > From: Yi Yang > > iperf3 UDP performance of veth to veth case is > very very bad because of too many packet loss, > the root cause is rmem_default and wmem_default > are just 212992, but iperf3 UDP test used 8K > UDP size which

Re: [ovs-dev] [PATCH] ofproto-dpif: remove checking setting nd_ext field

On Mon, Sep 28, 2020 at 09:49:47PM +0800, fankaixi...@bytedance.com wrote: > From: "fankaixi.li" > > In order to support openflow rule which setting nd_ext fields in openflow > tables, > we should remove setting nd_ext fields when constructing rule. The ofproto > would > translate it into users

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

.") > Signed-off-by: Roi Dayan The above notwithstanding, this looks good to me. Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/1] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

On Tue, Oct 03, 2023 at 01:51:34PM +0300, Roi Dayan wrote: > > On 03/10/2023 13:36, Simon Horman wrote: > > On Tue, Oct 03, 2023 at 11:33:04AM +0300, Roi Dayan via dev wrote: > >> The cited commit fixed missing mirror packets by reset mirror when > >> packets a

Re: [ovs-dev] [PATCH v2 2/2] conntrack: Use helpers from committed connections.

On Tue, Oct 03, 2023 at 04:10:47PM +0400, Viacheslav Galaktionov wrote: > On 9/29/23 17:02, Simon Horman wrote: > > On Mon, Sep 04, 2023 at 07:45:07PM +0400, Viacheslav Galaktionov via dev > > wrote: > > > Currently, if the user wants to track related connections, they

Re: [ovs-dev] [PATCH 2/2] openflow: Allow CT flush to match on mark and labels.

On Tue, Oct 03, 2023 at 04:01:15PM +0200, Ilya Maximets wrote: > On 10/3/23 15:46, Ales Musil wrote: > > On Tue, Oct 3, 2023 at 3:40 PM Ilya Maximets > > wrote: > > On 10/3/23 07:56, Ales Musil wrote: ... > > > @@ -95,10 +139,27 @@ ofp_ct_match_format(struct ds

Re: [ovs-dev] [PATCH 1/3] netdev-dpdk: Document status options for VF MAC address.

On Wed, Oct 04, 2023 at 10:26:29AM +0200, jm...@redhat.com wrote: > From: Jakob Meng > > Fixes: f4336f504b17 ("netdev-dpdk: Add option to configure VF MAC address. ") Acked-by: Simon Horman ___ dev mailing list d...@op

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Fixed DPDK specific interface status options.

; Fixes: a77c7796f23a ("dpdk: Update to use v22.11.1.") Reviewed-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Fixed DPDK specific interface status options.

On Wed, Oct 04, 2023 at 11:28:38AM +0200, Simon Horman wrote: > On Wed, Oct 04, 2023 at 10:31:25AM +0200, jm...@redhat.com wrote: > > From: Jakob Meng > > > > The status options pci-vendor_id and pci-device_id for dpdk netdevs > > have been replaced by bus_i

Re: [ovs-dev] [PATCH 3/3] netdev-dpdk: Document rx-steering status options.

On Wed, Oct 04, 2023 at 10:32:22AM +0200, jm...@redhat.com wrote: > From: Jakob Meng > > Fixes: fc06ea9a1883 ("netdev-dpdk: Add custom rx-steering configuration.") Acked-by: Simon Horman ___ dev mailing list d...@op

Re: [ovs-dev] [PATCH 1/1] tests: Update some tests title prefix print.

On Tue, Oct 03, 2023 at 05:03:20PM +0300, Roi Dayan via dev wrote: > Use test title prefix according to filename the test is in > for tunnel.at and ofproto-dpif.at. > > Signed-off-by: Roi Dayan > --- > tests/ofproto-dpif.at | 6 +++--- > tests/tunnel.at | 2 +- > 2 files changed, 4 inserti

Re: [ovs-dev] [PATCH v2 2/3] tests/tunnel.at: Add geneve options mirror test.

On Wed, Oct 04, 2023 at 01:09:43PM +0300, Roi Dayan wrote: > Test geneve options mirror flow doesn't add redundant mirror. > > Signed-off-by: Roi Dayan Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.o

Re: [ovs-dev] [PATCH v2 3/3] tests: Update some tests title prefix print.

On Wed, Oct 04, 2023 at 01:09:44PM +0300, Roi Dayan wrote: > Use test title prefix according to filename the test is in > for tunnel.at and ofproto-dpif.at. > > Signed-off-by: Roi Dayan Acked-by: Simon Horman ___ dev ma

Re: [ovs-dev] [PATCH, v3] netdev: Sync'ed and cleaned {get, set}_config().

On Wed, Oct 04, 2023 at 02:27:17PM +0200, Jakob Meng wrote: > On 04.10.23 12:18, Ilya Maximets wrote: > > On 10/2/23 16:44, David Marchand wrote: > >> On Mon, Oct 2, 2023 at 1:52 PM Simon Horman wrote: > >>> On Wed, Sep 27, 2023 at 03:24:07PM +0200, jm...@redhat.com

Re: [ovs-dev] [PATCH v5 1/2] ofproto-dpif-mirror: Reduce number of function parameters.

ed-off-by: Mike Pattrick Thanks for addressing this Mike, much appreciated. Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v5 2/2] ofproto-dpif-mirror: Add support for pre-selection filter.

tion in total throughput when > mirroring is used either with or without a filter. > > Signed-off-by: Mike Pattrick Acked-by: Simon Horman ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] Documentation: Add CVE-2022-40982, aka Downfall reference.

On Wed, Oct 04, 2023 at 02:59:48PM +0200, Eelco Chaudron wrote: > Added a reference to the DPDK documentation as a result of > analyzing the OVS code for potential performance impacts due > to the Downfall mitigation. > > Signed-off-by: Eelco Chaudron Acked-b

Re: [ovs-dev] [PATCH] netdev-offload: add offload-delay option to delay offload the datapath flows

On Mon, Oct 12, 2020 at 04:48:40PM +0800, we...@ucloud.cn wrote: > From: wenxu > > Add offload-delay option to delay offload the datapath flow. > Sometimes there is no need for offload the short connection flows which > overload the add/del flows in the HW. It is better to offload persistent > co

Re: [ovs-dev] [PATCH] bridge:The retry function does not work.

On Mon, Dec 14, 2020 at 09:36:54AM +0800, XiaoXiong Ding wrote: > The value of status_txn_try_again is set to true after bridge_reconfigure. It > is expected that the system will try again later. However, run_status_update > will Check status_txn. if status_txn is not null, the logic for re-apply

Re: [ovs-dev] [PATCH ovs v1 0/4] Support Flow Bifurcation

On Mon, Dec 14, 2020 at 10:19:57AM +0800, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > Flow Bifurcation is a mechanism which uses hardware capable > Ethernet devices to split traffic between Linux user space > and kernel space. Since it is a hardware assisted feature > this approach

<    5   6   7   8   9   10   11   12   13   14   >