Re: [ovs-dev] [PATCH] rhel: Fixed a bug for checking the correct major version and revision.

Thanks Ashish for the fix. Reviewed-by: Yifeng Sun On Fri, Jun 7, 2019 at 3:45 PM Ashish Varma wrote: > > Fixed a bug where checking for major version 3.10 and major revision not > equal to 327 or 693 or 957 should have gone to the default else at the end. > In the current code,

[ovs-dev] [PATCH 0/5] datapath: Support 5.0.x kernel version

witch/ovs/pull/278 Travis passed at: https://travis-ci.org/yifsun/ovs-travis/builds/543907186 In addition, builds succeeded and 'make check-kmod' passed on: CentOS73, Fedora, RHEL74, RHEL75, RHEL76 and Ubuntu (bionic, trusty, xenial, Disco Dingo). Yifeng Sun (5): datapath: Check ext

[ovs-dev] [PATCH 1/5] datapath: Check extack argument of rtnl_create_link()

Upstream commit d0522f1cd25edb796548f91e04766fa3cbc3b6df ("net: Add extack argument to rtnl_create_link") added new argument to rtnl_create_link(). This introduced compiling errors in the code of kernel datapath. This patch fixes this issue. Signed-off-by: Yifeng Sun --- ac

[ovs-dev] [PATCH 2/5] OVS: remove use of VLAN_TAG_PRESENT

osław Signed-off-by: Yifeng Sun --- acinclude.m4 | 4 datapath/actions.c| 13 + datapath/flow.c | 6 +++--- datapath/flow.h | 2 +- datapath/flow_netl

[ovs-dev] [PATCH 4/5] net: core: dev: Add extack argument to dev_change_flags()

iewed-by: Ido Schimmel Reviewed-by: David Ahern Signed-off-by: David S. Miller This patch backports the above upstream patch and also adds fixes in compat code. Cc: Petr Machata Signed-off-by: Yifeng Sun --- acinclude.m4| 3 +++ datapath/linux/c

[ovs-dev] [PATCH 3/5] datapath: Backport the removal of __tcp_checksum_complete()

same with __tcp_checksum_complete(). Signed-off-by: Yifeng Sun --- datapath/linux/compat/stt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c index 5f045120ed20..21fef09f4329 100644 --- a/datapath/linux/compat/stt.c +++ b/datapath/li

[ovs-dev] [PATCH 5/5] datapath: Support kernel version 5.0.x

This patch updated acinclude.m4 so that OVS can be compiled on 5.0.x kernels. This patch also updated travis files so that 5.0.x kernel versions are used during travis test builds. Besides, NEWS and releases.rst are also updated to reflect this new support. Signed-off-by: Yifeng Sun

Re: [ovs-dev] [PATCH 5/5] datapath: Support kernel version 5.0.x

Thanks Yi-Hung, I will rebase .travis.yml, fix the small issue you mentioned in another email, and send v2. Yifeng On Wed, Jun 12, 2019 at 2:21 PM Yi-Hung Wei wrote: > > On Mon, Jun 10, 2019 at 4:46 PM Yifeng Sun wrote: > > > > This patch updated acinclude.m4 so that OVS

[ovs-dev] [PATCH 0/5 v2] datapath: Support 5.0.x kernel version

d fix minor issues. Yifeng Sun (5): datapath: Check extack argument of rtnl_create_link() OVS: remove use of VLAN_TAG_PRESENT datapath: Backport the removal of __tcp_checksum_complete() net: core: dev: Add extack argument to dev_change_flags() datapath: Support kernel version 5

[ovs-dev] [PATCH 1/5 v2] datapath: Check extack argument of rtnl_create_link()

Upstream commit d0522f1cd25edb796548f91e04766fa3cbc3b6df ("net: Add extack argument to rtnl_create_link") added new argument to rtnl_create_link(). This introduced compiling errors in the code of kernel datapath. This patch fixes this issue. Acked-by: Yi-Hung Wei Signed-off-by:

[ovs-dev] [PATCH 2/5 v2] OVS: remove use of VLAN_TAG_PRESENT

backports the above upstream patch to OVS and adds extra checking in kernel module's compat code. Cc: Michał Mirosław Acked-by: Yi-Hung Wei Signed-off-by: Yifeng Sun --- v1->v2: Add an upstream fixup commit, thanks Yihung for pointing it out. acinclude.m4

[ovs-dev] [PATCH 4/5 v2] net: core: dev: Add extack argument to dev_change_flags()

iewed-by: Ido Schimmel Reviewed-by: David Ahern Signed-off-by: David S. Miller This patch backports the above upstream patch and also adds fixes in compat code. Cc: Petr Machata Acked-by: Yi-Hung Wei Signed-off-by: Yifeng Sun --- acinclude.m4

[ovs-dev] [PATCH 3/5 v2] datapath: Backport the removal of __tcp_checksum_complete()

same with __tcp_checksum_complete(). Acked-by: Yi-Hung Wei Signed-off-by: Yifeng Sun --- datapath/linux/compat/stt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datapath/linux/compat/stt.c b/datapath/linux/compat/stt.c index 5f045120ed20..21fef09f4329 100644 --- a/datapath/linux/compat/s

[ovs-dev] [PATCH 5/5 v2] datapath: Support kernel version 5.0.x

: Yifeng Sun --- v1->v2: Rebased changes for .travis.yml, thanks YiHung. .travis.yml| 1 + .travis/linux-build.sh | 4 +++- Documentation/faq/releases.rst | 2 +- NEWS | 1 + acinclude.m4 | 10 ++ 5 files changed,

Re: [ovs-dev] [PATCH 0/5 v2] datapath: Support 5.0.x kernel version

This series were already acked by YiHung. On Wed, Jun 12, 2019 at 3:35 PM Yifeng Sun wrote: > > This series of patches enabled OVS to run on kernel 5.0.x. > > Tests shows that this series of patches passed check-kmod tests or > didn't introduce new failed check-kmod tes

Re: [ovs-dev] [PATCH 0/5 v2] datapath: Support 5.0.x kernel version

Thanks Ben and Darrell. Yifeng On Thu, Jun 13, 2019 at 10:12 AM Darrell Ball wrote: > > > > On Wed, Jun 12, 2019 at 3:38 PM Yifeng Sun wrote: >> >> This series of patches enabled OVS to run on kernel 5.0.x. >> >> Tests shows that this series of patches

Re: [ovs-dev] [PATCH] Documentation: Clarify connection tracking tutorial

Looks good to me, thanks for the fix. Reviewed-by: Yifeng Sun On Fri, Jun 14, 2019 at 1:44 PM Greg Rose wrote: > > The current documentation states that "all packets entering OVS for > the first time are "untracked"". However there is a minor exception > to thi

Re: [ovs-dev] [PATCH] faq: Correct supported kernel versions for OVS 2.11.x.

Got it, thanks for the fix. Reviewed-by: Yifeng Sun On Thu, Jun 27, 2019 at 6:51 AM Ben Pfaff wrote: > > I don't think we're planning to backport 5.0 support to OVS 2.11.x, because > that would be counter to our usual practice. > > CC: Yifeng Sun > Fixes: 2ada

[ovs-dev] [PATCH] userspace: Enable non-bridge port as tunnel endpoint.

as the tunnel endpoint. Signed-off-by: Yifeng Sun Signed-off-by: William Tu --- ofproto/ofproto-dpif-xlate.c | 56 ++-- tests/tunnel-push-pop.at | 55 +++ 2 files changed, 104 insertions(+), 7 deletions(-) diff

Re: [ovs-dev] [PATCH] userspace: Enable non-bridge port as tunnel endpoint.

Thanks Ben for pointing this out. There surely is a mistake that we need to fix. We will come up a new version. Thanks, Yifeng On Tue, Jul 16, 2019 at 3:04 PM Ben Pfaff wrote: > > On Tue, Jul 16, 2019 at 10:55:08AM -0700, Yifeng Sun wrote: > > For userspace datapath, currently onl

[ovs-dev] [PATCH v2] userspace: Enable non-bridge port as tunnel endpoint.

as the tunnel endpoint. Signed-off-by: William Tu Co-authored-by: William Tu Signed-off-by: Yifeng Sun --- v1->v2: Fixed an error pointed out by Ben. ofproto/ofproto-dpif-xlate.c | 56 +++- tests/tunnel-push-pop.at |

[ovs-dev] [PATCH] datapath: Print friendly error message when conntrack fails to init

On 4.14 kernels, if kernel isn't configured with CONFIG_NF_CONNTRACK_IPV4 and CONFIG_NF_CONNTRACK_IPV6, openvswitch module will fail to load. The error message is "openvswitch: failed to init nf_conncount -91". This patch prints helpful error message for this case. Signed-off

Re: [ovs-dev] [PATCH] datapath: Print friendly error message when conntrack fails to init

Ok, I will do that. Thanks for reviewing. Yifeng On Fri, Jul 19, 2019 at 9:10 AM Gregory Rose wrote: > > On 7/18/2019 6:43 PM, Yifeng Sun wrote: > > On 4.14 kernels, if kernel isn't configured with CONFIG_NF_CONNTRACK_IPV4 > > and CONFIG_NF_CONNTRACK_IPV6, openvswitch m

Re: [ovs-dev] [PATCH 1/1] stream_ssl: fix important memory leak in ssl_connect() function

Thanks for this patch. Worked on this leak before but didn't find the fix. Tested-by: Yifeng Sun Reviewed-by: Yifeng Sun On Fri, Jul 26, 2019 at 1:11 AM Damijan Skvarc wrote: > > > While checking valgrind reports after running "make check-valgrind" I have > no

[ovs-dev] [PATCH] datapath: compat: Backports bugfixes for nf_conncount

stead of spin_lock") VMware-BZ: #2396471 CC: Taehee Yoo Signed-off-by: Yifeng Sun --- datapath/linux/compat/nf_conncount.c | 54 ++-- 1 file changed, 33 insertions(+), 21 deletions(-) diff --git a/datapath/linux/compat/nf_conncount.c b/datapath/linux/comp

[ovs-dev] [PATCH v2] datapath: compat: Backports bugfixes for nf_conncount

_del corruption in conn_free") fd3e71a ("netfilter: nf_conncount: use spin_lock_bh instead of spin_lock") This patch also added additional compat code so that it can build on all supported kernel versions. Travis tests are at https://travis-ci.org/yifsun/ovs-travis/builds/56860379

[ovs-dev] [PATCH] datapath: Apply bug fixes of nf_conncount for different kernel versions

iHung Wei. Signed-off-by: Yifeng Sun --- acinclude.m4 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index f8e856d3303f..f0e38898b17a 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -713,7 +713,9 @@ AC_DEFUN([OVS_CHECK_LINUX_COMPAT], [ OVS_GREP_

[ovs-dev] [PATCH v3] datapath: compat: Backports bugfixes for nf_conncount

code. If kernel already has these fixes, then kernel's nf_conncount is being used. Otherwise, OVS falls back to use compat nf_conncount functions. Travis tests are at https://travis-ci.org/yifsun/ovs-travis/builds/569056850 On latest RHEL kernel, 'make check-kmod' runs good. VMware

Re: [ovs-dev] [PATCH v2] datapath: compat: Backports bugfixes for nf_conncount

Thanks YiHung for reviewing. I've sent out a new version. Best, Yifeng On Wed, Aug 7, 2019 at 10:24 AM Yi-Hung Wei wrote: > > On Tue, Aug 6, 2019 at 5:06 PM Yifeng Sun wrote: > > > > This patch backports several critical bug fixes related to > > locking and dat

<    1   2   3   4   5   6