Re: [ovs-discuss] [ovs-dev] [PATCH] datapath: fix crash when ipv6 fragment pkt recalculate L4 checksum

2021-12-09 Thread Tonghao Zhang
On Fri, Dec 10, 2021 at 10:59 AM zhounan (E) via discuss wrote: > > From: Zhou Nan > > When we set ipv6 addr, we need to recalculate checksum of L4 header. > In our testcase, after send ipv6 fragment package, KASAN detect "use after > free" when calling function update_ipv6_checksum, and crash o

Re: [ovs-discuss] [ovs-dev] meter stats cleared when modify meter bands

2021-07-27 Thread Tonghao Zhang
On Wed, Jul 28, 2021 at 10:57 AM ychen wrote: > > Hi, all: > I have a question why meter stats need cleared when just modify meter > bands? > when call function handle_modify_meter(), it finally call function > dpif_netdev_meter_set(), in this function new dp_meter will be allocated and

Re: [ovs-discuss] change configuration of VLAN access port

2021-01-21 Thread Tonghao Zhang
On Thu, Jan 21, 2021 at 8:13 AM Matthias Waehlisch wrote: > > > ... i was able to change the configuration using "ovs-vsctl set port > xyz vlan_mode=native-untagged" but the virtual switch still sends > packets that include a vlan tag on the access port instead of removing > the tag. this is quite

Re: [ovs-discuss] Double free in recent kernels after memleak fix

2020-08-11 Thread Tonghao Zhang
On Wed, Aug 12, 2020 at 2:28 AM Johan Knöös wrote: > On Mon, Aug 10, 2020 at 10:59 PM Tonghao Zhang > wrote: > > > > On Tue, Aug 11, 2020 at 12:08 PM Cong Wang > wrote: > > > > > > On Mon, Aug 10, 2020 at 8:27 PM Tonghao Zhang < > xiangxia.m@gma

Re: [ovs-discuss] Double free in recent kernels after memleak fix

2020-08-10 Thread Tonghao Zhang
On Tue, Aug 11, 2020 at 12:08 PM Cong Wang wrote: > > On Mon, Aug 10, 2020 at 8:27 PM Tonghao Zhang > wrote: > > > > On Tue, Aug 11, 2020 at 10:24 AM Cong Wang wrote: > > > > > > On Mon, Aug 10, 2020 at 6:16 PM Tonghao Zhang > > > wrote: >

Re: [ovs-discuss] Double free in recent kernels after memleak fix

2020-08-10 Thread Tonghao Zhang
On Tue, Aug 11, 2020 at 10:24 AM Cong Wang wrote: > > On Mon, Aug 10, 2020 at 6:16 PM Tonghao Zhang > wrote: > > Hi all, I send a patch to fix this. The rcu warnings disappear. I > > don't reproduce the double free issue. > > But I guess this patch may

Re: [ovs-discuss] Double free in recent kernels after memleak fix

2020-08-10 Thread Tonghao Zhang
On Tue, Aug 11, 2020 at 4:28 AM Paul E. McKenney wrote: > > On Mon, Aug 10, 2020 at 04:08:59PM -0400, Joel Fernandes wrote: > > On Fri, Aug 07, 2020 at 03:20:15PM -0700, Paul E. McKenney wrote: > > > On Fri, Aug 07, 2020 at 04:47:56PM -0400, Joel Fernandes wrote: > > > > Hi, > > > > Adding more of

Re: [ovs-discuss] Double free in recent kernels after memleak fix

2020-08-04 Thread Tonghao Zhang
On Tue, Aug 4, 2020 at 3:02 AM Johan Knöös wrote: > > Hi Open vSwitch contributors, > > We have found openvswitch is causing double-freeing of memory. The > issue was not present in kernel version 5.5.17 but is present in > 5.6.14 and newer kernels. > > After reverting the RCU commits below for de

Re: [ovs-discuss] OVS version for Linux 5.5 kernel version

2020-06-09 Thread Tonghao Zhang
On Wed, Jun 10, 2020 at 12:36 AM Sravan A Dinesh wrote: > Hi OVS team > Can you please suggest the OVS version which is > compatible with Linux 5.5 kernel version or is there any patch available > for the same. Also when are you planning to release OVS version 2.14. > Please

Re: [ovs-discuss] [HELP] OVS-DPDK crash when executing ovs-tcpdump

2020-05-21 Thread Tonghao Zhang
On Tue, May 19, 2020 at 2:59 PM txfh2007 via discuss wrote: > > Hi all: > I am using OVS-2.13 together with DPDK-19.11 and hw-offload turnd on. I > have found when I tried to capture pkts by using ovs-tcpdump, the main > process crash, I have found in log there is an assertion fail: " > |ut

Re: [ovs-discuss] [OVN] OVN Load balancing algorithm

2020-04-30 Thread Tonghao Zhang
flows of LB it may be ok since the majority of packets are > >> > still in fastpath). > >> > > >> > I am not familiar with the dp_hash implementation. I will do some more > >> > study, but any idea on how to ensure the consistency of dp_hash is > >> >

Re: [ovs-discuss] Combined Kernel and DPDK with Same Interface

2020-04-08 Thread Tonghao Zhang
On Thu, Apr 9, 2020 at 12:07 PM Lazuardi Nasution wrote: > > Hi Greg, > > Any concern I should know if I choose to use option No. 1? Something like > what Tonghao tell on previous e-mail on this thread? maybe different solution, about isolated mode, please see: https://doc.dpdk.org/guides/prog_g

Re: [ovs-discuss] Combined Kernel and DPDK with Same Interface

2020-04-08 Thread Tonghao Zhang
On Wed, Apr 8, 2020 at 11:32 PM Lazuardi Nasution wrote: > > Hi Greg, > > Thank you for your suggestion. But anyway, why don't you suggest No. 1? > > In term of using suggested No. 2 with MLX5 PMD, is representor port still > needed? I assume that there is no need to communicate between PF and VF

Re: [ovs-discuss] dpdk, netns and jumbo frames dropping packets

2020-01-09 Thread Tonghao Zhang
On Tue, Jul 9, 2019 at 3:43 PM Liam Young wrote: > > Hi, > > I have a server which has an ovs bridge with a dpdk device attached > for external network access and a network namespace attached via a tap > device. Sending data out of the namespace fails if jumbo frames are enabled. > Sending data in

Re: [ovs-discuss] problem with multiple pop_mpls

2019-11-18 Thread Tonghao Zhang
On Fri, Nov 15, 2019 at 12:39 AM Adel Belkhiri wrote: > Hello again, > > Thanks Ahmed and Tonghao for your replies. > > > Tonghao : IP packets are encapsulated By the MPLS protocol. After popping > the inner mpls header we will find the IP header. That's why i used > pop_mpls:0x800 to change the

Re: [ovs-discuss] problem with multiple pop_mpls

2019-11-13 Thread Tonghao Zhang
> On Nov 14, 2019, at 1:46 AM, Adel Belkhiri wrote: > > Hi All, > > I have an issue with popping multiple mpls headers with ovs. The pushing via > push_mpls works fine but the popping via pop_mpls triggers a warning in the > log and the operation is not accomplished. > > |WARN|system@ovs-sy

Re: [ovs-discuss] the network performence is not normal when use openvswitch.ko make from ovs tree

2019-11-05 Thread Tonghao Zhang
0-10.00 sec 1.68 GBytes 7.20 Gbits/sec 2421554 KBytes > - - - - - - - - - - - - - - - - - - - - - - - - - > [ ID] Interval Transfer Bandwidth Retr > [ 4] 0.00-10.00 sec 8.28 GBytes 7.11 Gbits/sec 26739 sender > [ 4] 0.00-10.00 sec 8.2

Re: [ovs-discuss] the network performence is not normal when use openvswitch.ko make from ovs tree

2019-11-05 Thread Tonghao Zhang
On Mon, Nov 4, 2019 at 5:14 PM shuangyang qian wrote: > > Hi: > I make rpm packages for ovs and ovn with this > document:http://docs.openvswitch.org/en/latest/intro/install/fedora/ . For > use the kernel module in ovs tree, i configure with the command: ./configure > --with-linux=/lib/modules/$

[ovs-discuss] one question about openvswitch flow_hash

2019-09-22 Thread Tonghao Zhang
Hi Pravin one question about openvswitch, why we add BUILD_BUG_ON in flow_hash? It is never be true, right ? flow_hash ... /* Make sure number of hash bytes are multiple of u32. */ BUILD_BUG_ON(sizeof(long) % sizeof(u32)); ... ___ disc

Re: [ovs-discuss] ovs offloading stops suddenly stops working

2019-03-24 Thread Tonghao Zhang
On Fri, Mar 22, 2019 at 1:26 PM Manuel Sopena Ballesteros wrote: > > Dear OVS community, > > > > I am trying to setup OVS offload on a mellanox connectX4-LX through 2 vms > suing SR-IOV to the VFs. > > > > For some reason when I start pinging the offload works but after a while I am > getting th

[ovs-discuss] interface mac setting

2018-04-23 Thread Tonghao Zhang
One question, why now ovs can only set the mac of internal interface, for example: ovs-vsctl set Interface p1 type=internal mac=\"00:11:22:33:44:55\" ovs-vsctl get Interface p1 mac_in_use And the doc about 'mac' is not explained, why we cannot set it for other type interface. So it's a bug? diff

Re: [ovs-discuss] Fedora 25+ with OVS kernel trainted?

2017-08-13 Thread Tonghao Zhang
Hi This bug has been fixed in 4.11, 4.12 and 4.13 kernel version. and if you don't use the UFO, you can disable it. https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=8d63bee643f1fb53e472f0e135cae4eb99d62d19 On Sat, Aug 5, 2017 at 12:24 AM, Timothy M. Redaelli wrote:

Re: [ovs-discuss] Fedora 25+ with OVS kernel trainted?

2017-08-04 Thread Tonghao Zhang
That my be a bug in the kernel and it will be fixed. On Tue, Aug 1, 2017 at 12:01 AM, Ziemowit Pierzycki wrote: > Hi, > > I have a hypervisor with Fedora 25 on a few machines and ever since > upgrading I started getting occasional messages: > > [321428.168903] WARNING: CPU: 0 PID: 2279 at net/cor