Re: [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

2021-06-15 Thread Ilya Maximets
On 6/15/21 4:31 AM, Tony van der Peet wrote: > I did the patch as suggested, and it looks something like this: > > --- a/lib/dpif-netdev.c > +++ b/lib/dpif-netdev.c > @@ -4168,9 +4168,13 @@dpif_netdev_execute(struct dpif *dpif, struct > dpif_execute *execute) >    flow

Re: [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

2021-06-14 Thread Tony van der Peet
I did the patch as suggested, and it looks something like this: --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4168,9 +4168,13 @@ dpif_netdev_execute(struct dpif *dpif, struct dpif_execute *execute) flow_hash_5tuple(execute->flow, 0)); } +/* We are not

Re: [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

2021-06-14 Thread Tony van der Peet
Yes, I can create that patch. Tony On Sat, Jun 12, 2021 at 5:24 AM Ilya Maximets wrote: > On 6/9/21 3:12 PM, Aaron Conole wrote: > > Ilya Maximets writes: > > > >> On 6/7/21 3:59 PM, Ilya Maximets wrote: > >>> On 6/7/21 3:09 PM, Aaron Conole wrote: > Ilya Maximets writes: > > >>

Re: [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

2021-06-11 Thread Ilya Maximets
On 6/9/21 3:12 PM, Aaron Conole wrote: > Ilya Maximets writes: > >> On 6/7/21 3:59 PM, Ilya Maximets wrote: >>> On 6/7/21 3:09 PM, Aaron Conole wrote: Ilya Maximets writes: >> Here is a patch with both a test and a fix. Thanks so much! It's nice to get fixes, but I think

Re: [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

2021-06-09 Thread Aaron Conole
Ilya Maximets writes: > On 6/7/21 3:59 PM, Ilya Maximets wrote: >> On 6/7/21 3:09 PM, Aaron Conole wrote: >>> Ilya Maximets writes: >>> > Here is a patch with both a test and a fix. >>> >>> Thanks so much! It's nice to get fixes, but I think it's really great >>> when test cases come along

Re: [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

2021-06-07 Thread Ilya Maximets
On 6/7/21 3:59 PM, Ilya Maximets wrote: > On 6/7/21 3:09 PM, Aaron Conole wrote: >> Ilya Maximets writes: >> Here is a patch with both a test and a fix. >> >> Thanks so much! It's nice to get fixes, but I think it's really great >> when test cases come along with them. >> >>> Hi. Thanks for

Re: [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

2021-06-07 Thread Ilya Maximets
On 6/7/21 3:09 PM, Aaron Conole wrote: > Ilya Maximets writes: > >>> Here is a patch with both a test and a fix. > > Thanks so much! It's nice to get fixes, but I think it's really great > when test cases come along with them. > >> Hi. Thanks for working n this! >> >> CC: ovs-dev >> >>> Not s

Re: [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

2021-06-07 Thread Aaron Conole
Ilya Maximets writes: >> Here is a patch with both a test and a fix. Thanks so much! It's nice to get fixes, but I think it's really great when test cases come along with them. > Hi. Thanks for working n this! > > CC: ovs-dev > >> Not submitting as a formal >> patch because I would like some

Re: [ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

2021-06-04 Thread Ilya Maximets
> Here is a patch with both a test and a fix. Hi. Thanks for working n this! CC: ovs-dev > Not submitting as a formal > patch because I would like some feedback on whether 1) maintainers feel > this is worth fixing and I can reproduce the crash with your test. Basically, actions in userspace

[ovs-discuss] Patch for PACKET_OUT getting deleted twice crash

2021-06-03 Thread Tony van der Peet
Here is a patch with both a test and a fix. Not submitting as a formal patch because I would like some feedback on whether 1) maintainers feel this is worth fixing and 2) whether this is the way to fix it. I have tried to make the most minimal change possible, but this means that there might be pa