Re: [Owfs-developers] [GIT PULL] Fix race conditions in ow_regcomp

2017-11-15 Thread Johan Ström
Changes have been merged to master, thanks for contribution! On 12/11/17 18:55, Justin Brewer wrote: Thanks for the review. On Sun, Nov 12, 2017 at 04:19:00PM +0100, Johan Ström wrote: Looks good to me, much cleaner indeed! Given that pthread_once is available everywhere? pthread_once is

Re: [Owfs-developers] [GIT PULL] Fix race conditions in ow_regcomp

2017-11-12 Thread Justin Brewer
Thanks for the review. On Sun, Nov 12, 2017 at 04:19:00PM +0100, Johan Ström wrote: > Looks good to me, much cleaner indeed! Given that pthread_once is available > everywhere? pthread_once is part of standard POSIX thread support, so any libc implementing pthreads should include it. All the

Re: [Owfs-developers] [GIT PULL] Fix race conditions in ow_regcomp

2017-11-12 Thread Johan Ström
Looks good to me, much cleaner indeed! Given that pthread_once is available everywhere? On 11/11/17 18:53, Justin Brewer wrote: I have been experiencing crashes, or other random failures, while developing an application using libowcapi. Backtracing shows that these issues occur during

[Owfs-developers] [GIT PULL] Fix race conditions in ow_regcomp

2017-11-11 Thread Justin Brewer
I have been experiencing crashes, or other random failures, while developing an application using libowcapi. Backtracing shows that these issues occur during ow_regcomp. Ultimately, the cause is the tsearch algorithm being misused for performing lazy initialization, resulting in race