Re: [Owncloud] [QA-Announcement] Code Reviews to increase quality

2012-11-07 Thread Frank Karlitschek
We have a lot of activity and good discussion. Thats good :-) The real benchmark is of course how bugfree ownCloud 5 and 4.5.2 will be and how happy our users are. Please don´t forget to backport bugfixes to stable45 by the way. This is important. Thanks Frank On 06.11.2012, at 19:17, Jan-C

Re: [Owncloud] [QA-Announcement] Code Reviews to increase quality

2012-11-06 Thread Jan-Christoph Borchardt
Just as an update after one week of working like that, I have to say that so far it seems to work great! There’s always something you miss, and through these reviews we’ll introduce less new issues in the code. And good on everyone for fixing existing issues! Also see Frank’s previous mail about t

Re: [Owncloud] [QA-Announcement] Code Reviews to increase quality

2012-10-30 Thread Jan-Christoph Borchardt
On Tue, Oct 30, 2012 at 12:59 AM, Sam Tuke wrote: > On 10/29/2012 11:43 PM, Jan-Christoph Borchardt wrote: >> TL;DR: Do not directly push to core master, and instead use pull >> requests. > > How much of the procedure is enforced, and how much relies upon convention? We are all smart people, so I

Re: [Owncloud] [QA-Announcement] Code Reviews to increase quality

2012-10-29 Thread Sam Tuke
On 10/29/2012 11:43 PM, Jan-Christoph Borchardt wrote: > TL;DR: Do not directly push to core master, and instead use pull > requests. How much of the procedure is enforced, and how much relies upon convention? Who counts as a "reviewer" - should only certain people fulfil this role (are there spec

Re: [Owncloud] [QA-Announcement] Code Reviews to increase quality

2012-10-29 Thread Jan-Christoph Borchardt
TL;DR: Do not directly push to core master, and instead use pull requests. Then other people can review it (@mention them), we identify issues before they land in the code, and we’re all a bit happier. But yeah, also read the complete thing at http://owncloud.org/dev/code-reviews-on-github/ Than

[Owncloud] [QA-Announcement] Code Reviews to increase quality

2012-10-29 Thread Thomas Müller
Hi, those of you being with us in Berlin last weekend already know about all the discussions we had within the QA/Testing working group, the meeting with all of you Sunday evening and in smaller groups of a few. Thank you for your input and opinions! As already announced by Frank on Sunday durin