Re: [Owncloud] regarding quality

2012-07-18 Thread Jörn Friedrich Dreyer
On 18.07.2012 22:15, Michał Jaskurzyński wrote: Hi, I would like to join of creating test environment. I have some experience with Jenkins and Selenium testing. I am also agree that PHPUnit should be used instead of simpletest because it is more powerful and it is standard for php tests. Do you

Re: [Owncloud] regarding quality

2012-07-18 Thread Michał Jaskurzyński
Hi, I would like to join of creating test environment. I have some experience with Jenkins and Selenium testing. I am also agree that PHPUnit should be used instead of simpletest because it is more powerful and it is standard for php tests. Are there any news about this topis? Do you have some co

Re: [Owncloud] regarding quality

2012-07-06 Thread Jörn Friedrich Dreyer
On 03.07.2012 14:09, Sam Tuke wrote: On Saturday 30 Jun 2012 22:52:48 eMerzh wrote: May be the automatic test (with a good coverage!) may help us here.. but we have a lng job to make everything testable :/ [...] Whilst we're on the subject, can I ask why we're using simpletest rather than

Re: [Owncloud] regarding quality

2012-07-03 Thread eMerzh
One thing that could be cool too is to have auto tests for different OS / config and databases ...beause testing everything on every db is hard... wasn't there already someone working on a jenkins or smth? Another place where we must do something is js... selenium will clearly help, but js should

Re: [Owncloud] regarding quality

2012-07-03 Thread Thomas Müller
Am Sonntag, dem 01.07.2012 um 18:13 schrieb Klaas Freitag: > On 29.06.2012 21:18, Thomas Müller wrote: > > > > Am Freitag, dem 29.06.2012 um 14:20 schrieb Frank Karlitschek: > >> Hi everybody, > >> > >> > >> the main problem our users mention about ownCloud is the number of bugs we > >> have. I t

Re: [Owncloud] regarding quality

2012-07-03 Thread Thomas Müller
Am Dienstag, dem 03.07.2012 um 14:09 schrieb Sam Tuke: > On Saturday 30 Jun 2012 22:52:48 eMerzh wrote: > > May be the automatic test (with a good coverage!) may help us here.. > > but we have a lng job to make everything testable :/ > > Exactly. > > ownCloud development is moving extremely

Re: [Owncloud] regarding quality

2012-07-03 Thread Sam Tuke
On Saturday 30 Jun 2012 22:52:48 eMerzh wrote: > May be the automatic test (with a good coverage!) may help us here.. > but we have a lng job to make everything testable :/ Exactly. ownCloud development is moving extremely fast - developing at this speed without unit tests understandably res

Re: [Owncloud] regarding quality

2012-07-02 Thread Bjoern Schiessle
Hi Florian, On Fri, 29 Jun 2012 20:07:37 +0200 Florian Rüchel wrote: > concerning input sanatization, especially on forms: > Maybe you should take a look at available form frameworks or start > coding your own. Since I never did this on PHP (only WTForms for > Python) I cannot direct you to one. >

Re: [Owncloud] regarding quality

2012-07-01 Thread Klaas Freitag
On 29.06.2012 21:18, Thomas Müller wrote: Am Freitag, dem 29.06.2012 um 14:20 schrieb Frank Karlitschek: Hi everybody, the main problem our users mention about ownCloud is the number of bugs we have. I think we have to be more careful in the future about code quality if we want that more us

Re: [Owncloud] regarding quality

2012-07-01 Thread Frank Karlitschek
Absolutely!! :-) It´s awesome that we have good UX experts in our community. So developers should use this expertise On 29.06.2012, at 22:12, Jan-Christoph Borchardt wrote: > In addition to testing your code before pushing – if you do anything > user-facing, please also always test the inter

Re: [Owncloud] regarding quality

2012-06-30 Thread eMerzh
Hi, i totally agree with you Frank... here are my 2c on this topic ... i think we need to extend the beta/rc time and to clearly tag bugs in our tracker (genie,...) Then we must carefully choose wich one are blocker and we need to dedicate time to fix those... Clearly oc is a great tool evolving a

Re: [Owncloud] regarding quality

2012-06-30 Thread Klaas Freitag
Hi, the main problem our users mention about ownCloud is the number of bugs we have. I think we have to be more careful in the future about code quality if we want that more users use our software to manage their important documents and data. We got a lot of bad press and feedback for ownClou

Re: [Owncloud] regarding quality

2012-06-29 Thread Florian Rüchel
Hello Frank, concerning input sanatization, especially on forms: Maybe you should take a look at available form frameworks or start coding your own. Since I never did this on PHP (only WTForms for Python) I cannot direct you to one. You create a Form as a class, an XML file or any other representa

Re: [Owncloud] regarding quality

2012-06-29 Thread Jan-Christoph Borchardt
In addition to testing your code before pushing – if you do anything user-facing, please also always test the interface, and review it yourself. Don’t hesitate to ask me for advice regarding that, or if you would like me to review the interaction, user experience, … Picking up the quality point –

Re: [Owncloud] regarding quality

2012-06-29 Thread Thomas Tanghus
On Friday 29 June 2012 21:18 Thomas Müller wrote: > Am Freitag, dem 29.06.2012 um 14:20 schrieb Frank Karlitschek: > > I'd like to add: > - ask other devs for code reviews - a second pair of eyes will see more A very simple way for code review is to turn email notification on in https://gitorio

Re: [Owncloud] regarding quality

2012-06-29 Thread Thomas Müller
Am Freitag, dem 29.06.2012 um 14:20 schrieb Frank Karlitschek: > Hi everybody, > > > the main problem our users mention about ownCloud is the number of bugs we > have. I think we have to be more careful in the future about code quality if > we want that more users use our software to manage th

[Owncloud] regarding quality

2012-06-29 Thread Frank Karlitschek
Hi everybody, the main problem our users mention about ownCloud is the number of bugs we have. I think we have to be more careful in the future about code quality if we want that more users use our software to manage their important documents and data. We got a lot of bad press and feedback fo