[GitHub] [hadoop-ozone] captainzmc removed a comment on pull request #1280: HDDS-4054. Remove duplicate judgments in allocateBlockInKey.

2020-08-04 Thread GitBox
captainzmc removed a comment on pull request #1280: URL: https://github.com/apache/hadoop-ozone/pull/1280#issuecomment-667041335 Hi @bharatviswa504 @arp7 Could you help to review this? This is an automated message from the

[GitHub] [hadoop-ozone] runitao commented on pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-04 Thread GitBox
runitao commented on pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289#issuecomment-668919240 /pending This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (HDDS-4039) Reduce the number of fields in hdds.proto to improve performance

2020-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4039: - Labels: pull-request-available (was: ) > Reduce the number of fields in hdds.proto to improve per

[GitHub] [hadoop-ozone] runitao opened a new pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-04 Thread GitBox
runitao opened a new pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289 ## What changes were proposed in this pull request? Reduce the number of fields in hdds.proto to improve performance ## What is the link to the Apache JIRA HDDS-4039 ##

[jira] [Created] (HDDS-4063) Fix InstallSnapshot in OM HA

2020-08-04 Thread Hanisha Koneru (Jira)
Hanisha Koneru created HDDS-4063: Summary: Fix InstallSnapshot in OM HA Key: HDDS-4063 URL: https://issues.apache.org/jira/browse/HDDS-4063 Project: Hadoop Distributed Data Store Issue Type:

[jira] [Commented] (HDDS-4040) OFS should use deleteObjects when deleting directory

2020-08-04 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171086#comment-17171086 ] Siyao Meng commented on HDDS-4040: -- [~Sammi] Should be good. I have posted PR. Thanks for

[jira] [Commented] (HDDS-1745) Add integration test for createDirectory for OM HA

2020-08-04 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171031#comment-17171031 ] Rui Wang commented on HDDS-1745: In fact, for 1 I find the model in https://issues.apach

[GitHub] [hadoop-ozone] arp7 commented on pull request #1270: HDDS-4044. Deprecate ozone.s3g.volume.name.

2020-08-04 Thread GitBox
arp7 commented on pull request #1270: URL: https://github.com/apache/hadoop-ozone/pull/1270#issuecomment-668741765 Leaving this key easily discoverable is a bad idea and will result in users unintentionally shooting themselves in the foot. However I don't have the energy to argue this ad-i

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on pull request #1270: HDDS-4044. Deprecate ozone.s3g.volume.name.

2020-08-04 Thread GitBox
bharatviswa504 edited a comment on pull request #1270: URL: https://github.com/apache/hadoop-ozone/pull/1270#issuecomment-668733523 Removed all the code changes, in the latest commit updated only documentation. Thank You @elek for the review and @arp7 for offline discussion and consensu

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1270: HDDS-4044. Deprecate ozone.s3g.volume.name.

2020-08-04 Thread GitBox
bharatviswa504 commented on pull request #1270: URL: https://github.com/apache/hadoop-ozone/pull/1270#issuecomment-668733523 Removed all the code changes, in the latest commit updated only documentation. Thank You @elek for the review and @arp7 for offline discussion and consensus. --

[jira] [Created] (HDDS-4062) Non rack aware pipelines should not be created if multiple racks are alive

2020-08-04 Thread Stephen O'Donnell (Jira)
Stephen O'Donnell created HDDS-4062: --- Summary: Non rack aware pipelines should not be created if multiple racks are alive Key: HDDS-4062 URL: https://issues.apache.org/jira/browse/HDDS-4062 Project:

[GitHub] [hadoop-ozone] bshashikant commented on pull request #1154: HDDS-3867. Extend the chunkinfo tool to display information from all nodes in the pipeline.

2020-08-04 Thread GitBox
bshashikant commented on pull request #1154: URL: https://github.com/apache/hadoop-ozone/pull/1154#issuecomment-668696169 > > Thanks to create this patch @sadanand48 > > I have one design concern related to this change. I am not sure what is the good answer, but trying to share my view:

[GitHub] [hadoop-ozone] errose28 opened a new pull request #1288: HDDS-4061. Pending delete blocks are not always included in #BLOCKCOUNT metadata

2020-08-04 Thread GitBox
errose28 opened a new pull request #1288: URL: https://github.com/apache/hadoop-ozone/pull/1288 ## What changes were proposed in this pull request? - Make `KeyValueContainerUtil#initializeUsedBytesAndBlockCount` include pending delete blocks (with `#deleting#` prefix) when setting th

[jira] [Updated] (HDDS-4061) Pending delete blocks are not always included in #BLOCKCOUNT metadata

2020-08-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4061: - Labels: pull-request-available (was: ) > Pending delete blocks are not always included in #BLOCKC

[jira] [Created] (HDDS-4061) Pending delete blocks are not always included in #BLOCKCOUNT metadata

2020-08-04 Thread Ethan Rose (Jira)
Ethan Rose created HDDS-4061: Summary: Pending delete blocks are not always included in #BLOCKCOUNT metadata Key: HDDS-4061 URL: https://issues.apache.org/jira/browse/HDDS-4061 Project: Hadoop Distributed

[GitHub] [hadoop-ozone] elek commented on pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-04 Thread GitBox
elek commented on pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-668600956 @arp7 @bharatviswa504 Are you OK with this approach? This is an automated message from the Apache Git

[jira] [Assigned] (HDDS-1889) Add support for verifying multiline log entry

2020-08-04 Thread Peter Orova (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Orova reassigned HDDS-1889: - Assignee: Peter Orova > Add support for verifying multiline log entry > -

[jira] [Commented] (HDDS-3261) Fix TestOzoneManagerRestart.java

2020-08-04 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170755#comment-17170755 ] Attila Doroszlai commented on HDDS-3261: Thanks [~orova] for checking. Yes, it se

[jira] [Commented] (HDDS-3261) Fix TestOzoneManagerRestart.java

2020-08-04 Thread Peter Orova (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170749#comment-17170749 ] Peter Orova commented on HDDS-3261: --- [~adoroszlai] checked this one against ff621c6f0083

[jira] [Assigned] (HDDS-3261) Fix TestOzoneManagerRestart.java

2020-08-04 Thread Peter Orova (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Orova reassigned HDDS-3261: - Assignee: Peter Orova > Fix TestOzoneManagerRestart.java > > >

[jira] [Resolved] (HDDS-3259) Fix TestContainerReplicationEndToEnd.java

2020-08-04 Thread Peter Orova (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Orova resolved HDDS-3259. --- Resolution: Duplicate > Fix TestContainerReplicationEndToEnd.java > --

[jira] [Commented] (HDDS-3259) Fix TestContainerReplicationEndToEnd.java

2020-08-04 Thread Peter Orova (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170735#comment-17170735 ] Peter Orova commented on HDDS-3259: --- [~adoroszlai] that makes sense. Executing this repe

[jira] [Commented] (HDDS-3259) Fix TestContainerReplicationEndToEnd.java

2020-08-04 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170732#comment-17170732 ] Attila Doroszlai commented on HDDS-3259: I think this is already fixed in duplicat

[jira] [Assigned] (HDDS-3259) Fix TestContainerReplicationEndToEnd.java

2020-08-04 Thread Peter Orova (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Orova reassigned HDDS-3259: - Assignee: Peter Orova > Fix TestContainerReplicationEndToEnd.java > -

[jira] [Resolved] (HDDS-3994) Write object when met exception can be slower than before

2020-08-04 Thread Lokesh Jain (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lokesh Jain resolved HDDS-3994. --- Fix Version/s: 0.6.0 Resolution: Fixed > Write object when met exception can be slower than bef

[GitHub] [hadoop-ozone] lokeshj1703 closed pull request #1231: HDDS-3994. Make retry policy can be set by configuration.

2020-08-04 Thread GitBox
lokeshj1703 closed pull request #1231: URL: https://github.com/apache/hadoop-ozone/pull/1231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] lokeshj1703 commented on pull request #1231: HDDS-3994. Make retry policy can be set by configuration.

2020-08-04 Thread GitBox
lokeshj1703 commented on pull request #1231: URL: https://github.com/apache/hadoop-ozone/pull/1231#issuecomment-668488849 @maobaolong Thanks for the contribution! I have committed the PR to master branch. This is an automate

[jira] [Commented] (HDDS-3724) BackgroundPipelineCreator should not throw Pipeline creation failed exception due to insufficient nodes

2020-08-04 Thread Zheng Huang-Mu (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170623#comment-17170623 ] Zheng Huang-Mu commented on HDDS-3724: -- It's seems to be fixed by [~xyao] in HDDS-402

[GitHub] [hadoop-ozone] timmylicheng closed pull request #1191: HDDS-3837 Add isLeader check in SCMHAManager.

2020-08-04 Thread GitBox
timmylicheng closed pull request #1191: URL: https://github.com/apache/hadoop-ozone/pull/1191 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #1286: HDDS-4040. OFS should use deleteObjects when deleting directory

2020-08-04 Thread GitBox
smengcl commented on a change in pull request #1286: URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r464846912 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestRootedOzoneFileSystem.java ## @@ -1038,4 +1043,41 @@ public