[jira] [Commented] (HDDS-3684) Add tests for replication annotation

2020-08-07 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173579#comment-17173579 ] Rui Wang commented on HDDS-3684: [~timmylicheng] I am interested in what you are implemen

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467341943 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467343101 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467341943 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467341121 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467341121 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467340089 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467340089 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467339779 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467339332 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] runitao commented on pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-07 Thread GitBox
runitao commented on pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289#issuecomment-670795708 /ready This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
maobaolong commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467337235 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1286: HDDS-4040. [OFS] BasicRootedOzoneFileSystem to support batchDelete

2020-08-07 Thread GitBox
xiaoyuyao commented on pull request #1286: URL: https://github.com/apache/hadoop-ozone/pull/1286#issuecomment-670775889 Thanks @smengcl for the update. Let's merge it by EOD today if there is no additional comments. This i

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289#discussion_r467229952 ## File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto ## @@ -43,14 +43,22 @@ message DatanodeDetailsProto { // network name, can

[GitHub] [hadoop-ozone] hanishakoneru opened a new pull request #1303: HDDS-4075. Retry request on different OM on AccessControlException

2020-08-07 Thread GitBox
hanishakoneru opened a new pull request #1303: URL: https://github.com/apache/hadoop-ozone/pull/1303 ## What changes were proposed in this pull request? If a client attempts a request on an OM which has not caught up with leader OM and hence does have the delegation token, the reques

[jira] [Updated] (HDDS-4075) Retry request on different OM on AccessControlException

2020-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4075: - Labels: pull-request-available (was: ) > Retry request on different OM on AccessControlException

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #1286: HDDS-4040. [OFS] BasicRootedOzoneFileSystem to support batchDelete

2020-08-07 Thread GitBox
smengcl commented on a change in pull request #1286: URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r467211897 ## File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java ## @@ -457,38 +458,79 @@ p

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #1286: HDDS-4040. [OFS] BasicRootedOzoneFileSystem to support batchDelete

2020-08-07 Thread GitBox
smengcl commented on a change in pull request #1286: URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r467211897 ## File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java ## @@ -457,38 +458,79 @@ p

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-07 Thread GitBox
avijayanhwx commented on a change in pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289#discussion_r467201745 ## File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto ## @@ -43,14 +43,22 @@ message DatanodeDetailsProto { // network name,

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289#discussion_r467205547 ## File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto ## @@ -43,14 +43,22 @@ message DatanodeDetailsProto { // network name, can

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #1286: HDDS-4040. [OFS] BasicRootedOzoneFileSystem to support batchDelete

2020-08-07 Thread GitBox
smengcl commented on a change in pull request #1286: URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r467202871 ## File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java ## @@ -457,38 +458,79 @@ p

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-07 Thread GitBox
avijayanhwx commented on a change in pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289#discussion_r467201745 ## File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto ## @@ -43,14 +43,22 @@ message DatanodeDetailsProto { // network name,

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-07 Thread GitBox
avijayanhwx commented on a change in pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289#discussion_r467201745 ## File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto ## @@ -43,14 +43,22 @@ message DatanodeDetailsProto { // network name,

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-07 Thread GitBox
avijayanhwx commented on a change in pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289#discussion_r467085725 ## File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto ## @@ -43,14 +43,22 @@ message DatanodeDetailsProto { // network name,

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #1286: HDDS-4040. [OFS] BasicRootedOzoneFileSystem to support batchDelete

2020-08-07 Thread GitBox
smengcl commented on a change in pull request #1286: URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r467199383 ## File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java ## @@ -457,38 +458,79 @@ p

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467193705 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #1286: HDDS-4040. [OFS] BasicRootedOzoneFileSystem to support batchDelete

2020-08-07 Thread GitBox
smengcl commented on a change in pull request #1286: URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r467197266 ## File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java ## @@ -255,9 +258,11 @@ public FS

[jira] [Updated] (HDDS-4040) [OFS] BasicRootedOzoneFileSystem to support batchDelete

2020-08-07 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-4040: - Summary: [OFS] BasicRootedOzoneFileSystem to support batchDelete (was: OFS should use deleteObjects when

[jira] [Created] (HDDS-4090) [OFS] BasicRootedOzoneFileSystem to support batchRename

2020-08-07 Thread Siyao Meng (Jira)
Siyao Meng created HDDS-4090: Summary: [OFS] BasicRootedOzoneFileSystem to support batchRename Key: HDDS-4090 URL: https://issues.apache.org/jira/browse/HDDS-4090 Project: Hadoop Distributed Data Store

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #1286: HDDS-4040. OFS should use deleteObjects when deleting directory

2020-08-07 Thread GitBox
smengcl commented on a change in pull request #1286: URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r467194687 ## File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java ## @@ -457,38 +458,79 @@ p

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467193705 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
xiaoyuyao commented on pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-670642195 > But if multiple service ids are there, and if we want to provide convenience, where the commands used to work when only service id was there in the config, to not break

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1300: HDDS-4067.Implement toString for OMTransactionInfo

2020-08-07 Thread GitBox
adoroszlai commented on pull request #1300: URL: https://github.com/apache/hadoop-ozone/pull/1300#issuecomment-670635862 > Can you tell me how to trigger a new CI ``` git commit --allow-empty -m 'trigger new CI check' && git push ``` > (my first time to contribute to Ozo

[jira] [Assigned] (HDDS-1745) Add integration test for createDirectory for OM HA

2020-08-07 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Wang reassigned HDDS-1745: -- Assignee: Rui Wang > Add integration test for createDirectory for OM HA > -

[GitHub] [hadoop-ozone] amaliujia commented on pull request #1300: HDDS-4067.Implement toString for OMTransactionInfo

2020-08-07 Thread GitBox
amaliujia commented on pull request #1300: URL: https://github.com/apache/hadoop-ozone/pull/1300#issuecomment-670632935 @cxorm Thanks for helping trigger CI check! Can you tell me how to trigger a new CI (my first time to contribute to Ozone) so I can do myself? --

[GitHub] [hadoop-ozone] runitao commented on a change in pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-07 Thread GitBox
runitao commented on a change in pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289#discussion_r467179243 ## File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto ## @@ -43,14 +43,22 @@ message DatanodeDetailsProto { // network name, can

[jira] [Created] (HDDS-4089) Allow ozone ACL CLI to work with external authorizers

2020-08-07 Thread Xiaoyu Yao (Jira)
Xiaoyu Yao created HDDS-4089: Summary: Allow ozone ACL CLI to work with external authorizers Key: HDDS-4089 URL: https://issues.apache.org/jira/browse/HDDS-4089 Project: Hadoop Distributed Data Store

[jira] [Created] (HDDS-4088) Adding Owner info to OzoneObj so that Authorizer can honor owner access rights

2020-08-07 Thread Xiaoyu Yao (Jira)
Xiaoyu Yao created HDDS-4088: Summary: Adding Owner info to OzoneObj so that Authorizer can honor owner access rights Key: HDDS-4088 URL: https://issues.apache.org/jira/browse/HDDS-4088 Project: Hadoop Di

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
bharatviswa504 edited a comment on pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-670620669 > bq. Using internal service id when multiple is not handled in this? > > My understanding of the internal service id is only used internally by OM and

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
bharatviswa504 edited a comment on pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-670620669 > bq. Using internal service id when multiple is not handled in this? > > My understanding of the internal service id is only used internally by OM and

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
bharatviswa504 edited a comment on pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-670620669 > bq. Using internal service id when multiple is not handled in this? > > My understanding of the internal service id is only used internally by OM and

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
bharatviswa504 commented on pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-670620669 > bq. Using internal service id when multiple is not handled in this? > > My understanding of the internal service id is only used internally by OM and Recon.

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
xiaoyuyao commented on pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-670619948 bq. Using internal service id when multiple is not handled in this? My understanding of the internal service id is only used internally by OM and Recon. Normal

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
bharatviswa504 commented on pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-670618509 @elek I don't see any commits, but the comments are marked as resolved. Looks like commit push was missing? --

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
bharatviswa504 commented on a change in pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#discussion_r467163827 ## File path: hadoop-ozone/dist/src/main/compose/ozone-om-ha/test_disabled.sh ## @@ -1,41 +0,0 @@ -#!/usr/bin/env bash -# Licensed to the Apac

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1286: HDDS-4040. OFS should use deleteObjects when deleting directory

2020-08-07 Thread GitBox
xiaoyuyao commented on a change in pull request #1286: URL: https://github.com/apache/hadoop-ozone/pull/1286#discussion_r467156037 ## File path: hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java ## @@ -255,9 +258,11 @@ public

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1302: HDDS-4078. Use HDDS InterfaceAudience/Stability annotations

2020-08-07 Thread GitBox
adoroszlai opened a new pull request #1302: URL: https://github.com/apache/hadoop-ozone/pull/1302 ## What changes were proposed in this pull request? Replace usage of Hadoop Common annotations with ones from HDDS in code added since HDDS-3028. https://issues.apache.org/jira/br

[jira] [Updated] (HDDS-4078) Use HDDS InterfaceAudience/Stability annotations

2020-08-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4078: - Labels: pull-request-available (was: ) > Use HDDS InterfaceAudience/Stability annotations > -

[jira] [Resolved] (HDDS-4042) Update documentation for the GA release

2020-08-07 Thread Xiaoyu Yao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoyu Yao resolved HDDS-4042. -- Fix Version/s: 0.6.0 Resolution: Fixed Thanks [~elek] for the contribution and all for the review

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #1269: HDDS-4042. Update documentation for the GA release

2020-08-07 Thread GitBox
xiaoyuyao merged pull request #1269: URL: https://github.com/apache/hadoop-ozone/pull/1269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1297: HDDS-4073. Remove leftover robot.robot

2020-08-07 Thread GitBox
adoroszlai commented on pull request #1297: URL: https://github.com/apache/hadoop-ozone/pull/1297#issuecomment-670600455 Thanks @elek for reviewing and committing it. This is an automated message from the Apache Git Service.

[jira] [Assigned] (HDDS-2981) Add unit tests for Proto [de]serialization

2020-08-07 Thread Peter Orova (Jira)
[ https://issues.apache.org/jira/browse/HDDS-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Orova reassigned HDDS-2981: - Assignee: Peter Orova > Add unit tests for Proto [de]serialization >

[GitHub] [hadoop-ozone] llemec commented on a change in pull request #1293: HDDS-1889 Add support for verifying multiline log entry

2020-08-07 Thread GitBox
llemec commented on a change in pull request #1293: URL: https://github.com/apache/hadoop-ozone/pull/1293#discussion_r467139318 ## File path: hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java ## @@ -143,7 +143,31 @@ public void notLogRead

[GitHub] [hadoop-ozone] llemec commented on a change in pull request #1293: HDDS-1889 Add support for verifying multiline log entry

2020-08-07 Thread GitBox
llemec commented on a change in pull request #1293: URL: https://github.com/apache/hadoop-ozone/pull/1293#discussion_r467139013 ## File path: hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java ## @@ -158,20 +184,34 @@ private void verifyLo

[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #1290: HDDS-4064. Show container verbose info with verbose option

2020-08-07 Thread GitBox
maobaolong commented on a change in pull request #1290: URL: https://github.com/apache/hadoop-ozone/pull/1290#discussion_r467091313 ## File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/container/InfoSubcommand.java ## @@ -52,6 +53,10 @@ @Parameters(d

[GitHub] [hadoop-ozone] avijayanhwx edited a comment on pull request #1295: HDDS-4037. Incorrect container numberOfKeys and usedBytes in SCM after key deletion

2020-08-07 Thread GitBox
avijayanhwx edited a comment on pull request #1295: URL: https://github.com/apache/hadoop-ozone/pull/1295#issuecomment-670551035 @ChenSammi Thanks for fixing this. Can you add a short description on what the root cause is, and how this patch fixes it? That will help make the review easier.

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1275: HDDS-4009. Recon Overview page: The volume, bucket and key counts are not accurate

2020-08-07 Thread GitBox
avijayanhwx commented on pull request #1275: URL: https://github.com/apache/hadoop-ozone/pull/1275#issuecomment-670552632 /pending Patch is being reworked on after offline conversation with @vivekratnavel. This is an automat

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1289: HDDS-4039. Reduce the number of fields in hdds.proto to improve performance

2020-08-07 Thread GitBox
avijayanhwx commented on a change in pull request #1289: URL: https://github.com/apache/hadoop-ozone/pull/1289#discussion_r467085725 ## File path: hadoop-hdds/interface-client/src/main/proto/hdds.proto ## @@ -43,14 +43,22 @@ message DatanodeDetailsProto { // network name,

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1295: HDDS-4037. Incorrect container numberOfKeys and usedBytes in SCM after key deletion

2020-08-07 Thread GitBox
avijayanhwx commented on pull request #1295: URL: https://github.com/apache/hadoop-ozone/pull/1295#issuecomment-670551035 @ChenSammi Thanks for fixing this. Can you add a short description on what the root cause is, and how this patch fixes it? That will help the review easier.

[jira] [Resolved] (HDDS-4066) add core-site support debug ozone in IntelliJ using ofs

2020-08-07 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek resolved HDDS-4066. --- Fix Version/s: 0.7.0 Resolution: Fixed > add core-site support debug ozone in IntelliJ using of

[GitHub] [hadoop-ozone] elek merged pull request #1292: HDDS-4066. add core-site support debug ozone in IntelliJ using ofs.

2020-08-07 Thread GitBox
elek merged pull request #1292: URL: https://github.com/apache/hadoop-ozone/pull/1292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (HDDS-4073) Remove leftover robot.robot

2020-08-07 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-4073: -- Fix Version/s: 0.7.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Remo

[GitHub] [hadoop-ozone] elek merged pull request #1297: HDDS-4073. Remove leftover robot.robot

2020-08-07 Thread GitBox
elek merged pull request #1297: URL: https://github.com/apache/hadoop-ozone/pull/1297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1269: HDDS-4042. Update documentation for the GA release

2020-08-07 Thread GitBox
elek commented on a change in pull request #1269: URL: https://github.com/apache/hadoop-ozone/pull/1269#discussion_r467072858 ## File path: hadoop-hdds/docs/content/concept/StorageContainerManager.md ## @@ -0,0 +1,104 @@ +--- +title: "Storage Container Manager" +date: "2017-09-

[GitHub] [hadoop-ozone] elek commented on pull request #1269: HDDS-4042. Update documentation for the GA release

2020-08-07 Thread GitBox
elek commented on pull request #1269: URL: https://github.com/apache/hadoop-ozone/pull/1269#issuecomment-670542856 > One remaining question: do we need a Warning to the zh pages where the English version has (significant) changes? Thanks to @xiaoyuyao, the warning has been added. Tra

[GitHub] [hadoop-ozone] codecov-commenter edited a comment on pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
codecov-commenter edited a comment on pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#issuecomment-670541125 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1299?src=pr&el=h1) Report > Merging [#1299](https://codecov.io/gh/apache/hadoop-ozone/pull/1

[GitHub] [hadoop-ozone] codecov-commenter commented on pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
codecov-commenter commented on pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#issuecomment-670541125 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1299?src=pr&el=h1) Report > Merging [#1299](https://codecov.io/gh/apache/hadoop-ozone/pull/1299?src

[jira] [Created] (HDDS-4087) Create ZH translation of Ofs/O3fs.md in doc

2020-08-07 Thread Marton Elek (Jira)
Marton Elek created HDDS-4087: - Summary: Create ZH translation of Ofs/O3fs.md in doc Key: HDDS-4087 URL: https://issues.apache.org/jira/browse/HDDS-4087 Project: Hadoop Distributed Data Store Iss

[jira] [Created] (HDDS-4085) Create ZH translation of CSI.md in doc

2020-08-07 Thread Marton Elek (Jira)
Marton Elek created HDDS-4085: - Summary: Create ZH translation of CSI.md in doc Key: HDDS-4085 URL: https://issues.apache.org/jira/browse/HDDS-4085 Project: Hadoop Distributed Data Store Issue Ty

[jira] [Created] (HDDS-4086) Create ZH translation of Cli.md in doc

2020-08-07 Thread Marton Elek (Jira)
Marton Elek created HDDS-4086: - Summary: Create ZH translation of Cli.md in doc Key: HDDS-4086 URL: https://issues.apache.org/jira/browse/HDDS-4086 Project: Hadoop Distributed Data Store Issue Ty

[jira] [Created] (HDDS-4083) Create ZH translation of Recon.md in doc

2020-08-07 Thread Marton Elek (Jira)
Marton Elek created HDDS-4083: - Summary: Create ZH translation of Recon.md in doc Key: HDDS-4083 URL: https://issues.apache.org/jira/browse/HDDS-4083 Project: Hadoop Distributed Data Store Issue

[jira] [Created] (HDDS-4084) Create ZH translation of Topology.md in doc

2020-08-07 Thread Marton Elek (Jira)
Marton Elek created HDDS-4084: - Summary: Create ZH translation of Topology.md in doc Key: HDDS-4084 URL: https://issues.apache.org/jira/browse/HDDS-4084 Project: Hadoop Distributed Data Store Iss

[jira] [Created] (HDDS-4082) Create ZH translation of HA.md in doc

2020-08-07 Thread Marton Elek (Jira)
Marton Elek created HDDS-4082: - Summary: Create ZH translation of HA.md in doc Key: HDDS-4082 URL: https://issues.apache.org/jira/browse/HDDS-4082 Project: Hadoop Distributed Data Store Issue Typ

[jira] [Created] (HDDS-4081) Create ZH translation of StorageContainerManager.md in doc

2020-08-07 Thread Marton Elek (Jira)
Marton Elek created HDDS-4081: - Summary: Create ZH translation of StorageContainerManager.md in doc Key: HDDS-4081 URL: https://issues.apache.org/jira/browse/HDDS-4081 Project: Hadoop Distributed Data Stor

[jira] [Updated] (HDDS-4080) Create ZH translation of OzoneManager.md in doc

2020-08-07 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-4080: -- Summary: Create ZH translation of OzoneManager.md in doc (was: CLONE - Create ZH translation of Contain

[jira] [Updated] (HDDS-4079) Create ZH translation of Containers.md in doc

2020-08-07 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-4079: -- Description: HDDS-4042 modified the documentation page. zh translation should be updated for changed / n

[jira] [Updated] (HDDS-4080) CLONE - Create ZH translation of Containers.md in doc

2020-08-07 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-4080: -- Description: HDDS-4042 modified the documentation page. zh translation should be updated for changed / n

[jira] [Created] (HDDS-4080) CLONE - Create ZH translation of Containers.md in doc

2020-08-07 Thread Marton Elek (Jira)
Marton Elek created HDDS-4080: - Summary: CLONE - Create ZH translation of Containers.md in doc Key: HDDS-4080 URL: https://issues.apache.org/jira/browse/HDDS-4080 Project: Hadoop Distributed Data Store

[jira] [Created] (HDDS-4079) Create ZH translation of Containers.md in doc

2020-08-07 Thread Marton Elek (Jira)
Marton Elek created HDDS-4079: - Summary: Create ZH translation of Containers.md in doc Key: HDDS-4079 URL: https://issues.apache.org/jira/browse/HDDS-4079 Project: Hadoop Distributed Data Store I

[jira] [Updated] (HDDS-4078) Use HDDS InterfaceAudience/Stability annotations

2020-08-07 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-4078: --- Description: HDDS-3028 added Ozone-private versions of {{InterfaceAudience}} and {{InterfaceS

[GitHub] [hadoop-ozone] elek commented on pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
elek commented on pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#issuecomment-670532633 Thanks the review @bharatviswa504, I updated the patch. See my question about the tests, I am open to do anything, just let me know what do you suggest. @arp7 Do you hav

[jira] [Created] (HDDS-4078) Use HDDS InterfaceAudience/Stability annotations

2020-08-07 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-4078: -- Summary: Use HDDS InterfaceAudience/Stability annotations Key: HDDS-4078 URL: https://issues.apache.org/jira/browse/HDDS-4078 Project: Hadoop Distributed Data Stor

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
elek commented on a change in pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#discussion_r467059594 ## File path: hadoop-ozone/dist/src/main/compose/ozone-om-ha/test_disabled.sh ## @@ -1,41 +0,0 @@ -#!/usr/bin/env bash -# Licensed to the Apache Softwar

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1149: HDDS-3878. Make OMHA serviceID optional if one (but only one) is defined in the config

2020-08-07 Thread GitBox
elek commented on a change in pull request #1149: URL: https://github.com/apache/hadoop-ozone/pull/1149#discussion_r467055296 ## File path: hadoop-hdds/test-utils/src/main/java/org/apache/hadoop/test/InMemoryConfiguration.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache

[jira] [Created] (HDDS-4077) Incomplete OzoneFileSystem statistics

2020-08-07 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-4077: -- Summary: Incomplete OzoneFileSystem statistics Key: HDDS-4077 URL: https://issues.apache.org/jira/browse/HDDS-4077 Project: Hadoop Distributed Data Store

[GitHub] [hadoop-ozone] maobaolong commented on pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
maobaolong commented on pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#issuecomment-670517143 @adoroszlai Thanks for tell me how to test the docs changes locally. It works good, the link can works also. ![image](https://user-images.githubusercontent.com/

[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
maobaolong commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467035207 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可

[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
maobaolong commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r467035207 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可

[GitHub] [hadoop-ozone] maobaolong closed pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
maobaolong closed pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1293: HDDS-1889 Add support for verifying multiline log entry

2020-08-07 Thread GitBox
fapifta commented on a change in pull request #1293: URL: https://github.com/apache/hadoop-ozone/pull/1293#discussion_r466969810 ## File path: hadoop-hdds/common/src/test/java/org/apache/hadoop/ozone/audit/TestOzoneAuditLogger.java ## @@ -143,7 +143,31 @@ public void notLogRea

[GitHub] [hadoop-ozone] cxorm commented on pull request #1301: HDDS-3882. Update modification time when updating volume/bucket/key ACLs

2020-08-07 Thread GitBox
cxorm commented on pull request #1301: URL: https://github.com/apache/hadoop-ozone/pull/1301#issuecomment-670459094 Test would be added to pass code coverage. This is an automated message from the Apache Git Service. To respo

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
cxorm commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r466957782 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过Oz

[GitHub] [hadoop-ozone] adoroszlai edited a comment on pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
adoroszlai edited a comment on pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#issuecomment-670446249 > ## How was this patch tested? > No need Although this is only a documentation change, I don't agree that tests can be skipped. Some ideas for testing:

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
adoroszlai commented on pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#issuecomment-670446249 > ## How was this patch tested? > No need Although this is only a documentation change, I don't agree that tests can be skipped. Some ideas for testing:

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
adoroszlai commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r466950454 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可

[jira] [Updated] (HDDS-4037) Incorrect container numberOfKeys and usedBytes in SCM after key deletetion

2020-08-07 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen updated HDDS-4037: - Priority: Critical (was: Major) > Incorrect container numberOfKeys and usedBytes in SCM after key deletet

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
cxorm commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r466946528 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过Oz

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #1299: HDDS-4076. Translate CSI.md into Chinese

2020-08-07 Thread GitBox
cxorm commented on a change in pull request #1299: URL: https://github.com/apache/hadoop-ozone/pull/1299#discussion_r466938331 ## File path: hadoop-hdds/docs/content/interface/CSI.zh.md ## @@ -0,0 +1,78 @@ +--- +title: CSI 协议 +weight: 3 +summary: Ozone 支持 容器存储接口(CSI) 协议。你可以通过Oz

[jira] [Updated] (HDDS-4037) Incorrect container numberOfKeys and usedBytes in SCM after key deletetion

2020-08-07 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen updated HDDS-4037: - Summary: Incorrect container numberOfKeys and usedBytes in SCM after key deletetion (was: Incorrect conta

[GitHub] [hadoop-ozone] cxorm opened a new pull request #1301: HDDS-3882. Update modification time when updating volume/bucket/key ACLs

2020-08-07 Thread GitBox
cxorm opened a new pull request #1301: URL: https://github.com/apache/hadoop-ozone/pull/1301 ## What changes were proposed in this pull request? For renewing modification time when updating Acls of `Volume`/ `Bucket`/ `Key`, there are three parts to be modified in this patch. **I.

  1   2   >