linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499979751
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,283 @@
linyiqun commented on a change in pull request #1467:
URL: https://github.com/apache/hadoop-ozone/pull/1467#discussion_r499965831
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/RatisUpgradeUtils.java
##
@@ -78,14 +82,26 @@ public static void
prashantpogde commented on pull request #1457:
URL: https://github.com/apache/hadoop-ozone/pull/1457#issuecomment-703986990
I am investigating errors and I will fix if any.
This is an automated message from the Apache Git
flirmnave commented on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-703986323
Thanks for @iamabug @xiaoyuyao @cku328 reviewing and @elek merging.
This is an automated message from
[
https://issues.apache.org/jira/browse/HDDS-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uma Maheswara Rao G updated HDDS-4310:
--
Description:
Currently ozone getconf '-confKey' does not work as 'HDDS-3102' removed
Uma Maheswara Rao G created HDDS-4310:
-
Summary: Ozone getconf broke the compatibility
Key: HDDS-4310
URL: https://issues.apache.org/jira/browse/HDDS-4310
Project: Hadoop Distributed Data Store
[
https://issues.apache.org/jira/browse/HDDS-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yiqun Lin updated HDDS-4280:
Fix Version/s: 1.1.0
> Document notable configurations for Recon
>
linyiqun commented on pull request #1448:
URL: https://github.com/apache/hadoop-ozone/pull/1448#issuecomment-703976733
Thanks @vivekratnavel and @avijayanhwx for the review and merge!
This is an automated message from the
avijayanhwx commented on pull request #1467:
URL: https://github.com/apache/hadoop-ozone/pull/1467#issuecomment-703874936
cc @fapifta / @prashantpogde
This is an automated message from the Apache Git Service.
To respond to
bharatviswa504 commented on a change in pull request #1451:
URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r499806149
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -919,12 +920,32 @@ private
bharatviswa504 commented on a change in pull request #1451:
URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r499805554
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -919,12 +920,32 @@ private
bharatviswa504 commented on a change in pull request #1451:
URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r499800917
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java
##
@@ -298,21 +296,11 @@
[
https://issues.apache.org/jira/browse/HDDS-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-4309:
Priority: Minor (was: Major)
> Fix inconsistent Recon config keys that start with
Aravindan Vijayan created HDDS-4309:
---
Summary: Fix inconsistent Recon config keys that start with
"recon.om."
Key: HDDS-4309
URL: https://issues.apache.org/jira/browse/HDDS-4309
Project: Hadoop
[
https://issues.apache.org/jira/browse/HDDS-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-4309:
Labels: newbie (was: )
> Fix inconsistent Recon config keys that start with "recon.om."
>
avijayanhwx commented on a change in pull request #1467:
URL: https://github.com/apache/hadoop-ozone/pull/1467#discussion_r499785209
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java
##
@@ -432,7 +443,14 @@
[
https://issues.apache.org/jira/browse/HDDS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-4308:
-
Description:
Currently volumeArgs using getCacheValue and put the same object in
[
https://issues.apache.org/jira/browse/HDDS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-4308:
-
Description:
Currently volumeArgs using getCacheValue and put the same object in
[
https://issues.apache.org/jira/browse/HDDS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-4308:
-
Description:
Currently volumeArgs using getCacheValue and put the same object in
[
https://issues.apache.org/jira/browse/HDDS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bharat Viswanadham updated HDDS-4308:
-
Priority: Blocker (was: Major)
> Fix issue with quota update
>
[
https://issues.apache.org/jira/browse/HDDS-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siddharth Wagle updated HDDS-4122:
--
Priority: Major (was: Minor)
> Implement OM Delete Expired Open Key Request and Response
>
[
https://issues.apache.org/jira/browse/HDDS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208208#comment-17208208
]
Bharat Viswanadham commented on HDDS-4308:
--
cc [~micahzhao]
For ur comments on this issue.
> Fix
Bharat Viswanadham created HDDS-4308:
Summary: Fix issue with quota update
Key: HDDS-4308
URL: https://issues.apache.org/jira/browse/HDDS-4308
Project: Hadoop Distributed Data Store
bshashikant merged pull request #1460:
URL: https://github.com/apache/hadoop-ozone/pull/1460
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/HDDS-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shashikant Banerjee resolved HDDS-4298.
---
Fix Version/s: 1.1.0
Resolution: Fixed
> Use an interface in Ozone client
[
https://issues.apache.org/jira/browse/HDDS-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai resolved HDDS-4302.
Fix Version/s: 1.1.0
Resolution: Fixed
> Shade the org.apache.common.lang3 package
swagle commented on a change in pull request #1457:
URL: https://github.com/apache/hadoop-ozone/pull/1457#discussion_r499748734
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##
@@ -240,8 +247,19 @@ public
sodonnel opened a new pull request #1474:
URL: https://github.com/apache/hadoop-ozone/pull/1474
## What changes were proposed in this pull request?
Merge current master branch into the decom branch to keep it up-to-date.
## What is the link to the Apache JIRA
No Jira
[
https://issues.apache.org/jira/browse/HDDS-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aravindan Vijayan updated HDDS-4280:
Resolution: Fixed
Status: Resolved (was: Patch Available)
Merged the PR.
>
avijayanhwx merged pull request #1448:
URL: https://github.com/apache/hadoop-ozone/pull/1448
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
avijayanhwx commented on pull request #1448:
URL: https://github.com/apache/hadoop-ozone/pull/1448#issuecomment-703744589
Thanks for the review @vivekratnavel.
This is an automated message from the Apache Git Service.
To
avijayanhwx commented on pull request #1448:
URL: https://github.com/apache/hadoop-ozone/pull/1448#issuecomment-703744057
> > Can we add a follow up JIRA to fix this inconsistent config key
(recon.om.snapshot.task.interval.delay) ?
>
> Hi @avijayanhwx , I also find there is more
bharatviswa504 commented on a change in pull request #1083:
URL: https://github.com/apache/hadoop-ozone/pull/1083#discussion_r499720959
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DropTable.java
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the
bshashikant commented on a change in pull request #1460:
URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499427088
##
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientFactory.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the
bharatviswa504 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499686249
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java
##
@@ -0,0
bharatviswa504 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499683786
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java
##
@@ -0,0
bharatviswa504 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499683786
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java
##
@@ -0,0
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499416480
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java
##
@@ -0,0 +1,283 @@
errose28 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499585384
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java
##
@@ -0,0 +1,233 @@
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499628011
##
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCommitRequestV1.java
##
@@ -0,0 +1,379 @@
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499612439
##
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileOps.java
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed
elek commented on pull request #1466:
URL: https://github.com/apache/hadoop-ozone/pull/1466#issuecomment-703646855
> I don't see why, as requestPreprocessor is only called in the trace branch.
Ups, you are right. I missed it. In that case it will be slower (object
copy) only for
elek commented on pull request #1363:
URL: https://github.com/apache/hadoop-ozone/pull/1363#issuecomment-703644522
/pending
This is an automated message from the Apache Git Service.
To respond to the message, please log on
elek commented on pull request #1327:
URL: https://github.com/apache/hadoop-ozone/pull/1327#issuecomment-703643969
/pending
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/HDDS-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Elek resolved HDDS-4300.
---
Fix Version/s: 1.1.0
Resolution: Fixed
> Remove no longer needed class
[
https://issues.apache.org/jira/browse/HDDS-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4300:
-
Labels: pull-request-available (was: )
> Remove no longer needed class DatanodeAdminNodeDetails
[
https://issues.apache.org/jira/browse/HDDS-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208087#comment-17208087
]
Marton Elek commented on HDDS-4300:
---
Nice jira number ;-)
> Remove no longer needed class
elek merged pull request #1465:
URL: https://github.com/apache/hadoop-ozone/pull/1465
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499569565
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -346,6 +369,7 @@ protected
elek commented on pull request #1319:
URL: https://github.com/apache/hadoop-ozone/pull/1319#issuecomment-703634704
/pending @GlenGeng What is the plan with this issue? Do you need help? How
can I help to move it forward?
elek merged pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/HDDS-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Elek resolved HDDS-4156.
---
Fix Version/s: 1.1.0
Resolution: Fixed
> add hierarchical layout to Chinese doc
>
elek commented on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-703633236
Comments from @xiaoyuyao are addressed (issue is created) and @cku328 also
reviewed it (thanks for both)
I don't speak Mandarin well, but merging this now as structure
elek commented on pull request #1418:
URL: https://github.com/apache/hadoop-ozone/pull/1418#issuecomment-703631972
/pending In this specific case, intermediate directories will be created
even if OZONE_OM_ENABLE_FILESYSTEM_PATHS
errose28 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499579108
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java
##
@@ -0,0 +1,233 @@
errose28 commented on a change in pull request #1435:
URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499578543
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/AbstractOMKeyDeleteResponse.java
##
@@ -0,0 +1,150
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499387631
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##
@@ -129,6 +132,8 @@
*
adoroszlai commented on pull request #1466:
URL: https://github.com/apache/hadoop-ozone/pull/1466#issuecomment-703593031
Thanks @elek for reviewing and committing this.
> My only counterargument is that it makes the debug slightly slower (and
not only the TRACE but DEBUG as well).
elek commented on a change in pull request #1460:
URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499544019
##
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestReadRetries.java
##
@@ -147,7 +145,8 @@ public void
[
https://issues.apache.org/jira/browse/HDDS-4242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Elek resolved HDDS-4242.
---
Fix Version/s: 1.1.0
Resolution: Fixed
> Copy PrefixInfo proto to new project
elek commented on pull request #1444:
URL: https://github.com/apache/hadoop-ozone/pull/1444#issuecomment-703580641
Sorry, I was busy at apachecon last week. Sure, fine to do it later. it's
just an opinion and fine to follow it in next PRs.
Let me merge it now.
elek merged pull request #1444:
URL: https://github.com/apache/hadoop-ozone/pull/1444
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
elek commented on pull request #1298:
URL: https://github.com/apache/hadoop-ozone/pull/1298#issuecomment-703579758
Just another thanks here to @errose28 for the patch and to @hanishakoneru
for the review. Very big patch but I think it's an important step forward.
elek merged pull request #1447:
URL: https://github.com/apache/hadoop-ozone/pull/1447
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/HDDS-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Elek resolved HDDS-4264.
---
Target Version/s: 1.1.0
Resolution: Fixed
> Uniform naming conventions of Ozone Shell
elek commented on pull request #1272:
URL: https://github.com/apache/hadoop-ozone/pull/1272#issuecomment-703576217
>> I checked but it's not something which can be added easily.
> Thanks for checking. I'm fine with doing it as a follow-up (created
HDDS-4271).
You were right,
elek merged pull request #1466:
URL: https://github.com/apache/hadoop-ozone/pull/1466
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/HDDS-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Elek resolved HDDS-4271.
---
Fix Version/s: 1.1.0
Resolution: Fixed
> Avoid logging chunk content in Ozone Insight
>
[
https://issues.apache.org/jira/browse/HDDS-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai updated HDDS-4299:
---
Labels: (was: pull-request-available)
> Display Ratis version with ozone version
>
[
https://issues.apache.org/jira/browse/HDDS-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai resolved HDDS-4299.
Fix Version/s: 1.1.0
Resolution: Implemented
> Display Ratis version with ozone
adoroszlai commented on pull request #1464:
URL: https://github.com/apache/hadoop-ozone/pull/1464#issuecomment-703572792
Thanks @elek for the contribution.
This is an automated message from the Apache Git Service.
To respond
adoroszlai merged pull request #1464:
URL: https://github.com/apache/hadoop-ozone/pull/1464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
elek commented on pull request #1440:
URL: https://github.com/apache/hadoop-ozone/pull/1440#issuecomment-703571687
I agree. Better to have the slow tests in the acceptance test layer.
@aryangupta1998 Can you please update the patch with removing the method?
elek commented on a change in pull request #1451:
URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r499525922
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##
@@ -919,12 +920,32 @@ private boolean
adoroszlai commented on a change in pull request #1460:
URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499526330
##
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestReadRetries.java
##
@@ -147,7 +145,8 @@ public
adoroszlai commented on a change in pull request #1460:
URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499526330
##
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestReadRetries.java
##
@@ -147,7 +145,8 @@ public
bshashikant commented on pull request #1371:
URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-703565884
Can we also make the policy configurable? Also, one policy should also be
defined for no priority at all incase, this turns out to be a performance
killer.
[
https://issues.apache.org/jira/browse/HDDS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sadanand Shenoy updated HDDS-4307:
--
Parent: HDDS-3367
Issue Type: Sub-task (was: Test)
> Start Trash Emptier in Ozone
Sadanand Shenoy created HDDS-4307:
-
Summary: Start Trash Emptier in Ozone Manager
Key: HDDS-4307
URL: https://issues.apache.org/jira/browse/HDDS-4307
Project: Hadoop Distributed Data Store
elek commented on a change in pull request #1460:
URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499454095
##
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientFactory.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache
elek commented on a change in pull request #1460:
URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499453456
##
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestReadRetries.java
##
@@ -147,7 +145,8 @@ public void
elek commented on pull request #1411:
URL: https://github.com/apache/hadoop-ozone/pull/1411#issuecomment-703504639
We had an offline conversation with @bharatviswa504 @arp7
Got the feedback from Arpit: the 3rd option can be useful (we had
disagreement how useful it is), but it was
[
https://issues.apache.org/jira/browse/HDDS-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marton Elek updated HDDS-4097:
--
Attachment: Ozone filesystem path enabled v3.xlsx
> S3/Ozone Filesystem inter-op
>
[
https://issues.apache.org/jira/browse/HDDS-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HDDS-4266:
-
Labels: pull-request-available (was: )
> CreateFile : store parent dir entries into DirTable and
linyiqun commented on a change in pull request #1473:
URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499385995
##
File path:
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/OMMetadataManager.java
##
@@ -399,4 +399,15 @@ String
85 matches
Mail list logo
