[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502755091 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -227,6 +247,9 @@ protected OmMet

[GitHub] [hadoop-ozone] timmylicheng merged pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names

2020-10-09 Thread GitBox
timmylicheng merged pull request #1428: URL: https://github.com/apache/hadoop-ozone/pull/1428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] timmylicheng commented on pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names

2020-10-09 Thread GitBox
timmylicheng commented on pull request #1428: URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706478866 LGTM. +1. Merging. This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
rakeshadr commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502734677 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java ## @@ -453,4 +456,145 @@ public

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
rakeshadr commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502734533 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java ## @@ -0,0 +1,289 @@ +/*

[jira] [Created] (HDDS-4330) Bootstrap new OM node

2020-10-09 Thread Hanisha Koneru (Jira)
Hanisha Koneru created HDDS-4330: Summary: Bootstrap new OM node Key: HDDS-4330 URL: https://issues.apache.org/jira/browse/HDDS-4330 Project: Hadoop Distributed Data Store Issue Type: New Fea

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
bharatviswa504 commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502699811 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java ## @@ -0,0 +1,289 @

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
bharatviswa504 commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502696947 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java ## @@ -0,0 +1,289 @

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
bharatviswa504 commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502697158 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -227,6 +247,9 @@ protected

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
bharatviswa504 commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502690355 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java ## @@ -453,4 +456,145 @@ pu

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1476: HDDS-4312. findbugs check succeeds despite compile error

2020-10-09 Thread GitBox
adoroszlai commented on pull request #1476: URL: https://github.com/apache/hadoop-ozone/pull/1476#issuecomment-706409745 Thanks @elek for reviewing and committing it, and @amaliujia for the review. This is an automated messag

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1454: HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens()

2020-10-09 Thread GitBox
adoroszlai commented on pull request #1454: URL: https://github.com/apache/hadoop-ozone/pull/1454#issuecomment-706409317 Thanks @xiaoyuyao for reviewing and committing it, @ChenSammi and @linyiqun for the review, and @elek for finding the issue. ---

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1486: HDDS-4296. SCM changes to process Layout Info in heartbeat request/response

2020-10-09 Thread GitBox
avijayanhwx commented on pull request #1486: URL: https://github.com/apache/hadoop-ozone/pull/1486#issuecomment-706377348 cc @fapifta / @sodonnel Please review. This is an automated message from the Apache Git Service. To re

[jira] [Created] (HDDS-4329) Expose Ratis retry config cache in OM

2020-10-09 Thread Bharat Viswanadham (Jira)
Bharat Viswanadham created HDDS-4329: Summary: Expose Ratis retry config cache in OM Key: HDDS-4329 URL: https://issues.apache.org/jira/browse/HDDS-4329 Project: Hadoop Distributed Data Store

[jira] [Comment Edited] (HDDS-4308) Fix issue with quota update

2020-10-09 Thread Bharat Viswanadham (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211269#comment-17211269 ] Bharat Viswanadham edited comment on HDDS-4308 at 10/9/20, 6:47 PM:

[jira] [Commented] (HDDS-4308) Fix issue with quota update

2020-10-09 Thread Bharat Viswanadham (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211269#comment-17211269 ] Bharat Viswanadham commented on HDDS-4308: -- I think the better solution here is c

[jira] [Updated] (HDDS-4296) SCM changes to process Layout Info in heartbeat request/response

2020-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4296: - Labels: pull-request-available (was: ) > SCM changes to process Layout Info in heartbeat request/

[GitHub] [hadoop-ozone] prashantpogde opened a new pull request #1486: HDDS-4296. SCM changes to process Layout Info in heartbeat request/response

2020-10-09 Thread GitBox
prashantpogde opened a new pull request #1486: URL: https://github.com/apache/hadoop-ozone/pull/1486 ## What changes were proposed in this pull request? SCM changes to process Layout Info in heartbeat request/response ## What is the link to the Apache JIRA https://issues

[jira] [Comment Edited] (HDDS-4308) Fix issue with quota update

2020-10-09 Thread Bharat Viswanadham (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211254#comment-17211254 ] Bharat Viswanadham edited comment on HDDS-4308 at 10/9/20, 6:17 PM:

[jira] [Commented] (HDDS-4308) Fix issue with quota update

2020-10-09 Thread Bharat Viswanadham (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211254#comment-17211254 ] Bharat Viswanadham commented on HDDS-4308: -- As mentioned in the scenario this can

[jira] [Commented] (HDDS-4164) OM client request fails with "failed to commit as key is not found in OpenKey table"

2020-10-09 Thread Bharat Viswanadham (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211251#comment-17211251 ] Bharat Viswanadham commented on HDDS-4164: -- HDDS-4262 is the root cause for this

[jira] [Commented] (HDDS-3728) Bucket space: check quotaUsageInBytes when write key

2020-10-09 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211239#comment-17211239 ] Rui Wang commented on HDDS-3728: [~micahzhao] thank you! I send other space quota related

[jira] [Issue Comment Deleted] (HDDS-3728) Bucket space: check quotaUsageInBytes when write key

2020-10-09 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Wang updated HDDS-3728: --- Comment: was deleted (was: [~micahzhao] thank you! I send other space quota related PR soon after rebased aga

[jira] [Updated] (HDDS-4262) Use ClientID and CallID from Rpc Client to detect retry requests

2020-10-09 Thread Bharat Viswanadham (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Viswanadham updated HDDS-4262: - Fix Version/s: 1.1.0 Resolution: Fixed Status: Resolved (was: Patch Avai

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1436: HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests

2020-10-09 Thread GitBox
bharatviswa504 commented on pull request #1436: URL: https://github.com/apache/hadoop-ozone/pull/1436#issuecomment-706312696 Thank You @hanishakoneru for the review. This is an automated message from the Apache Git Service. T

[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #1436: HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests

2020-10-09 Thread GitBox
bharatviswa504 merged pull request #1436: URL: https://github.com/apache/hadoop-ozone/pull/1436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [hadoop-ozone] hanishakoneru commented on pull request #1436: HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests

2020-10-09 Thread GitBox
hanishakoneru commented on pull request #1436: URL: https://github.com/apache/hadoop-ozone/pull/1436#issuecomment-706304462 Thanks Bharat. LGTM. +1. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
rakeshadr commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502565993 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -227,6 +247,9 @@ protected OmMe

[GitHub] [hadoop-ozone] rakeshadr commented on pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
rakeshadr commented on pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#issuecomment-706282123 Thank you @linyiqun and @bharatviswa504 for the continuous help in reviews. Please let me know if any more comments. --

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
bharatviswa504 commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502546088 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -227,6 +247,9 @@ protected

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
bharatviswa504 commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502546088 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -227,6 +247,9 @@ protected

[GitHub] [hadoop-ozone] hanishakoneru commented on pull request #1480: HDDS-4315. Use Epoch to generate unique ObjectIDs

2020-10-09 Thread GitBox
hanishakoneru commented on pull request #1480: URL: https://github.com/apache/hadoop-ozone/pull/1480#issuecomment-706275207 Thank you @linyiqun and @prashantpogde for the reviews. Agree that setting aside 16 bits for epoch doesn't work for both the epoch as well as the transaction i

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
rakeshadr commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502525148 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -227,6 +247,9 @@ protected OmMe

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1468: HDDS-4301. SCM CA certificate does not encode KeyUsage extension properly

2020-10-09 Thread GitBox
xiaoyuyao commented on pull request #1468: URL: https://github.com/apache/hadoop-ozone/pull/1468#issuecomment-706258012 bq. Is it a backward compatible change? If I understood well both the old method and new method is good enough for validation, but the new version is more standard.

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
rakeshadr commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502350594 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -227,6 +247,9 @@ protected OmMe

[jira] [Updated] (HDDS-4285) Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens()

2020-10-09 Thread Xiaoyu Yao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaoyu Yao updated HDDS-4285: - Fix Version/s: 1.1.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Read i

[jira] [Commented] (HDDS-4285) Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens()

2020-10-09 Thread Xiaoyu Yao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211083#comment-17211083 ] Xiaoyu Yao commented on HDDS-4285: -- Thanks [~adoroszlai] for the contribution and all for

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1454: HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens()

2020-10-09 Thread GitBox
xiaoyuyao commented on pull request #1454: URL: https://github.com/apache/hadoop-ozone/pull/1454#issuecomment-706248107 Thanks @adoroszlai for the update. LGTM, +1. This is an automated message from the Apache Git Service. To

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #1454: HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens()

2020-10-09 Thread GitBox
xiaoyuyao merged pull request #1454: URL: https://github.com/apache/hadoop-ozone/pull/1454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502393095 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -227,6 +247,9 @@ protected OmMet

[GitHub] [hadoop-ozone] sodonnel commented on a change in pull request #1484: HDDS-4322. Add integration tests for Decommission and resolve issues detected by the tests.

2020-10-09 Thread GitBox
sodonnel commented on a change in pull request #1484: URL: https://github.com/apache/hadoop-ozone/pull/1484#discussion_r502444281 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java ## @@ -294,6 +294,9 @@ private boo

[GitHub] [hadoop-ozone] sodonnel commented on pull request #1484: HDDS-4322. Add integration tests for Decommission and resolve issues detected by the tests.

2020-10-09 Thread GitBox
sodonnel commented on pull request #1484: URL: https://github.com/apache/hadoop-ozone/pull/1484#issuecomment-706203898 Thanks for taking a look @elek > Can you please share more details. It would help me to understand the changes. I added some comments inline with each change

[GitHub] [hadoop-ozone] elek merged pull request #1476: HDDS-4312. findbugs check succeeds despite compile error

2020-10-09 Thread GitBox
elek merged pull request #1476: URL: https://github.com/apache/hadoop-ozone/pull/1476 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1481: HDDS-4316. Upgrade to angular 1.8.0 due to CVE-2020-7676

2020-10-09 Thread GitBox
adoroszlai merged pull request #1481: URL: https://github.com/apache/hadoop-ozone/pull/1481 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1483: HDDS-4319. Compile error with Java 11

2020-10-09 Thread GitBox
adoroszlai commented on pull request #1483: URL: https://github.com/apache/hadoop-ozone/pull/1483#issuecomment-705355508 Thanks @avijayanhwx for reviewing and committing it. This is an automated message from the Apache Git Se

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
rakeshadr commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501645890 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java ## @@ -0,0 +1,289 @@ +/*

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501717309 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequestV1.java ## @@ -0,0 +1,275 @@ +/** +

[GitHub] [hadoop-ozone] errose28 commented on a change in pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

2020-10-09 Thread GitBox
errose28 commented on a change in pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r501976342 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/AbstractOMKeyDeleteResponse.java ## @@ -0,0 +1,143 @

[GitHub] [hadoop-ozone] ChenSammi merged pull request #1458: HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block.

2020-10-09 Thread GitBox
ChenSammi merged pull request #1458: URL: https://github.com/apache/hadoop-ozone/pull/1458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] maobaolong commented on a change in pull request #1083: HDDS-3814. Drop a column family through debug cli tool

2020-10-09 Thread GitBox
maobaolong commented on a change in pull request #1083: URL: https://github.com/apache/hadoop-ozone/pull/1083#discussion_r502165402 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DropTable.java ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache So

[GitHub] [hadoop-ozone] codecov-io edited a comment on pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names

2020-10-09 Thread GitBox
codecov-io edited a comment on pull request #1428: URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1) Report > Merging [#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src

[GitHub] [hadoop-ozone] ChenSammi commented on pull request #1458: HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block.

2020-10-09 Thread GitBox
ChenSammi commented on pull request #1458: URL: https://github.com/apache/hadoop-ozone/pull/1458#issuecomment-706132636 LGTM +1. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop-ozone] elek merged pull request #1477: HDDS-4311. Type-safe config design doc points to OM HA

2020-10-09 Thread GitBox
elek merged pull request #1477: URL: https://github.com/apache/hadoop-ozone/pull/1477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hadoop-ozone] prashantpogde commented on pull request #1480: HDDS-4315. Use Epoch to generate unique ObjectIDs

2020-10-09 Thread GitBox
prashantpogde commented on pull request #1480: URL: https://github.com/apache/hadoop-ozone/pull/1480#issuecomment-705775239 General comment on using the epoch id that increments with every OM restart. This can get tricky. If OM goes in crash restart loop then we have just 2^16 increment

[GitHub] [hadoop-ozone] ChenSammi commented on pull request #1454: HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens()

2020-10-09 Thread GitBox
ChenSammi commented on pull request #1454: URL: https://github.com/apache/hadoop-ozone/pull/1454#issuecomment-705945770 @adoroszlai , thanks for the explanation. +1. This is an automated message from the Apache Git Service.

[GitHub] [hadoop-ozone] elek commented on pull request #1083: HDDS-3814. Drop a column family through debug cli tool

2020-10-09 Thread GitBox
elek commented on pull request #1083: URL: https://github.com/apache/hadoop-ozone/pull/1083#issuecomment-706156646 Merging it now. Thanks the review @bharatviswa504 and @avijayanhwx and the patch @maobaolong This is an auto

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

2020-10-09 Thread GitBox
elek commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r502352349 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -919,12 +920,32 @@ private boolean isKeyEmp

[GitHub] [hadoop-ozone] elek merged pull request #1083: HDDS-3814. Drop a column family through debug cli tool

2020-10-09 Thread GitBox
elek merged pull request #1083: URL: https://github.com/apache/hadoop-ozone/pull/1083 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hadoop-ozone] umamaheswararao merged pull request #1485: HDDS-4325. Incompatible return codes from Ozone getconf -confKey

2020-10-09 Thread GitBox
umamaheswararao merged pull request #1485: URL: https://github.com/apache/hadoop-ozone/pull/1485 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
bharatviswa504 commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r501443397 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java ## @@ -0,0 +1,289 @

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1454: HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens()

2020-10-09 Thread GitBox
adoroszlai commented on pull request #1454: URL: https://github.com/apache/hadoop-ozone/pull/1454#issuecomment-705673221 Thanks @xiaoyuyao for the suggestion to directly pass down the block token. I have updated the patch accordingly. -

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1484: HDDS-4322. Add integration tests for Decommission and resolve issues detected by the tests.

2020-10-09 Thread GitBox
elek commented on a change in pull request #1484: URL: https://github.com/apache/hadoop-ozone/pull/1484#discussion_r502419123 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java ## @@ -294,6 +294,9 @@ private boolean

[GitHub] [hadoop-ozone] umamaheswararao commented on pull request #1485: HDDS-4325. Incompatible return codes from Ozone getconf -confKey

2020-10-09 Thread GitBox
umamaheswararao commented on pull request #1485: URL: https://github.com/apache/hadoop-ozone/pull/1485#issuecomment-705697044 Thanks @adoroszlai for working on this. The changes looks good to me. +1 This is an automated me

[GitHub] [hadoop-ozone] captainzmc commented on a change in pull request #1458: HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block.

2020-10-09 Thread GitBox
captainzmc commented on a change in pull request #1458: URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r50227 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java ## @@ -218,6 +219,8 @@

[GitHub] [hadoop-ozone] codecov-io commented on pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names

2020-10-09 Thread GitBox
codecov-io commented on pull request #1428: URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1) Report > Merging [#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1485: HDDS-4325. Incompatible return codes from Ozone getconf -confKey

2020-10-09 Thread GitBox
adoroszlai commented on pull request #1485: URL: https://github.com/apache/hadoop-ozone/pull/1485#issuecomment-705710675 Thanks @umamaheswararao for reviewing and merging it. This is an automated message from the Apache Git S

[GitHub] [hadoop-ozone] maobaolong closed pull request #1407: HDDS-4158. Provide a class type for Java based configuration

2020-10-09 Thread GitBox
maobaolong closed pull request #1407: URL: https://github.com/apache/hadoop-ozone/pull/1407 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [hadoop-ozone] prashantpogde edited a comment on pull request #1480: HDDS-4315. Use Epoch to generate unique ObjectIDs

2020-10-09 Thread GitBox
prashantpogde edited a comment on pull request #1480: URL: https://github.com/apache/hadoop-ozone/pull/1480#issuecomment-705775239 General comment on using the epoch id that increments with every OM restart. This can get tricky. If OM goes in crash restart loop then we have just 2^16 in

[jira] [Updated] (HDDS-4312) findbugs check succeeds despite compile error

2020-10-09 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-4312: -- Fix Version/s: 1.1.0 Resolution: Fixed Status: Resolved (was: Patch Available) > find

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #1458: HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block.

2020-10-09 Thread GitBox
ChenSammi commented on a change in pull request #1458: URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r502231114 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java ## @@ -218,6 +219,8 @@ p

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

2020-10-09 Thread GitBox
bharatviswa504 commented on a change in pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r501938720 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/AbstractOMKeyDeleteResponse.java ## @@ -0,0 +1

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1484: HDDS-4322. Add integration tests for Decommission and resolve issues detected by the tests.

2020-10-09 Thread GitBox
elek commented on a change in pull request #1484: URL: https://github.com/apache/hadoop-ozone/pull/1484#discussion_r502419123 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DatanodeAdminMonitorImpl.java ## @@ -294,6 +294,9 @@ private boolean

[GitHub] [hadoop-ozone] elek merged pull request #1477: HDDS-4311. Type-safe config design doc points to OM HA

2020-10-09 Thread GitBox
elek merged pull request #1477: URL: https://github.com/apache/hadoop-ozone/pull/1477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (HDDS-4311) Type-safe config design doc points to OM HA

2020-10-09 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek updated HDDS-4311: -- Fix Version/s: 1.1.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Type

[jira] [Updated] (HDDS-4311) Type-safe config design doc points to OM HA

2020-10-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4311: - Labels: pull-request-available (was: ) > Type-safe config design doc points to OM HA > --

[jira] [Resolved] (HDDS-3814) Drop a column family through debug ldb tool

2020-10-09 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Elek resolved HDDS-3814. --- Fix Version/s: 1.1.0 Resolution: Fixed > Drop a column family through debug ldb tool >

[GitHub] [hadoop-ozone] elek merged pull request #1083: HDDS-3814. Drop a column family through debug cli tool

2020-10-09 Thread GitBox
elek merged pull request #1083: URL: https://github.com/apache/hadoop-ozone/pull/1083 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hadoop-ozone] elek commented on pull request #1083: HDDS-3814. Drop a column family through debug cli tool

2020-10-09 Thread GitBox
elek commented on pull request #1083: URL: https://github.com/apache/hadoop-ozone/pull/1083#issuecomment-706156646 Merging it now. Thanks the review @bharatviswa504 and @avijayanhwx and the patch @maobaolong This is an auto

[GitHub] [hadoop-ozone] codecov-io edited a comment on pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names

2020-10-09 Thread GitBox
codecov-io edited a comment on pull request #1428: URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1) Report > Merging [#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502393095 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -227,6 +247,9 @@ protected OmMet

[jira] [Resolved] (HDDS-3728) Bucket space: check quotaUsageInBytes when write key

2020-10-09 Thread mingchao zhao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingchao zhao resolved HDDS-3728. - Resolution: Fixed > Bucket space: check quotaUsageInBytes when write key > ---

[jira] [Commented] (HDDS-3728) Bucket space: check quotaUsageInBytes when write key

2020-10-09 Thread mingchao zhao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210881#comment-17210881 ] mingchao zhao commented on HDDS-3728: - PR has been merged, close this. > Bucket space

[jira] [Updated] (HDDS-3728) Bucket space: check quotaUsageInBytes when write key

2020-10-09 Thread mingchao zhao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingchao zhao updated HDDS-3728: Fix Version/s: 1.1.0 > Bucket space: check quotaUsageInBytes when write key > --

[GitHub] [hadoop-ozone] ChenSammi merged pull request #1458: HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block.

2020-10-09 Thread GitBox
ChenSammi merged pull request #1458: URL: https://github.com/apache/hadoop-ozone/pull/1458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] ChenSammi commented on pull request #1458: HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block.

2020-10-09 Thread GitBox
ChenSammi commented on pull request #1458: URL: https://github.com/apache/hadoop-ozone/pull/1458#issuecomment-706132636 LGTM +1. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

2020-10-09 Thread GitBox
elek commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r502358863 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -919,12 +920,32 @@ private boolean isKeyEmp

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

2020-10-09 Thread GitBox
elek commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r502357778 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -919,12 +920,32 @@ private boolean isKeyEmp

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

2020-10-09 Thread GitBox
elek commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r502356956 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java ## @@ -298,21 +296,11 @@ public static S

[GitHub] [hadoop-ozone] codecov-io commented on pull request #1428: HDDS-4192: enable SCM Raft Group based on config ozone.scm.names

2020-10-09 Thread GitBox
codecov-io commented on pull request #1428: URL: https://github.com/apache/hadoop-ozone/pull/1428#issuecomment-706121048 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=h1) Report > Merging [#1428](https://codecov.io/gh/apache/hadoop-ozone/pull/1428?src=pr&el=

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

2020-10-09 Thread GitBox
elek commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r502352349 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -919,12 +920,32 @@ private boolean isKeyEmp

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

2020-10-09 Thread GitBox
rakeshadr commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r502350594 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -227,6 +247,9 @@ protected OmMe

[jira] [Commented] (HDDS-4209) S3A Filesystem does not work with Ozone S3 in file system compat mode

2020-10-09 Thread Marton Elek (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210831#comment-17210831 ] Marton Elek commented on HDDS-4209: --- If not, It might be better to add this information

[GitHub] [hadoop-ozone] captainzmc commented on a change in pull request #1458: HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block.

2020-10-09 Thread GitBox
captainzmc commented on a change in pull request #1458: URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r50227 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java ## @@ -218,6 +219,8 @@

[jira] [Comment Edited] (HDDS-4308) Fix issue with quota update

2020-10-09 Thread mingchao zhao (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210583#comment-17210583 ] mingchao zhao edited comment on HDDS-4308 at 10/9/20, 7:31 AM: -

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #1458: HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block.

2020-10-09 Thread GitBox
ChenSammi commented on a change in pull request #1458: URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r502232094 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java ## @@ -279,11 +279,12 @@ p

[GitHub] [hadoop-ozone] ChenSammi commented on a change in pull request #1458: HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block.

2020-10-09 Thread GitBox
ChenSammi commented on a change in pull request #1458: URL: https://github.com/apache/hadoop-ozone/pull/1458#discussion_r502231114 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java ## @@ -218,6 +219,8 @@ p