[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1505: HDDS-4328. Provide fallback cache restore key

2020-10-20 Thread GitBox
adoroszlai commented on pull request #1505: URL: https://github.com/apache/hadoop-ozone/pull/1505#issuecomment-712751567 Thanks @vivekratnavel for the review. This is an automated message from the Apache Git Service. To respo

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1505: HDDS-4328. Provide fallback cache restore key

2020-10-20 Thread GitBox
adoroszlai merged pull request #1505: URL: https://github.com/apache/hadoop-ozone/pull/1505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Updated] (HDDS-4328) Provide fallback cache restore key

2020-10-20 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-4328: --- Labels: (was: pull-request-available) > Provide fallback cache restore key > ---

[jira] [Updated] (HDDS-4328) Provide fallback cache restore key

2020-10-20 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-4328: --- Fix Version/s: 1.1.0 Resolution: Fixed Status: Resolved (was: Patch Availabl

[jira] [Created] (HDDS-4359) Expose VolumeIOStats in DN JMX

2020-10-20 Thread Siyao Meng (Jira)
Siyao Meng created HDDS-4359: Summary: Expose VolumeIOStats in DN JMX Key: HDDS-4359 URL: https://issues.apache.org/jira/browse/HDDS-4359 Project: Hadoop Distributed Data Store Issue Type: Improv

[GitHub] [hadoop-ozone] smengcl opened a new pull request #1506: HDDS-4359. Expose VolumeIOStats in DN JMX

2020-10-20 Thread GitBox
smengcl opened a new pull request #1506: URL: https://github.com/apache/hadoop-ozone/pull/1506 https://issues.apache.org/jira/browse/HDDS-4359 ## How was this patch tested? Checked manually in DN JMX: ```json }, { "name" : "Hadoop:service=HddsDatanode,name=Vo

[jira] [Updated] (HDDS-4359) Expose VolumeIOStats in DN JMX

2020-10-20 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-4359: - Status: Patch Available (was: Open) > Expose VolumeIOStats in DN JMX > -- > >

[jira] [Updated] (HDDS-4359) Expose VolumeIOStats in DN JMX

2020-10-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4359: - Labels: pull-request-available (was: ) > Expose VolumeIOStats in DN JMX > ---

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-20 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r508418142 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void list

[jira] [Assigned] (HDDS-4170) Fix typo in method description.

2020-10-20 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang reassigned HDDS-4170: - Assignee: Harinder Singh Bedi > Fix typo in method description. > ---

[jira] [Resolved] (HDDS-4170) Fix typo in method description.

2020-10-20 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HDDS-4170. --- Fix Version/s: 1.1.0 Resolution: Fixed [~harinder.s.bedi] thanks for your contribution.

[jira] [Updated] (HDDS-4307) Start Background Service for Trash Deletion in Ozone Manager

2020-10-20 Thread Sadanand Shenoy (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sadanand Shenoy updated HDDS-4307: -- Summary: Start Background Service for Trash Deletion in Ozone Manager (was: Start Trash Emptier

[GitHub] [hadoop-ozone] sadanand48 opened a new pull request #1507: HDDS-4307.Start Background Service for Trash Deletion in Ozone Manager

2020-10-20 Thread GitBox
sadanand48 opened a new pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507 ## What changes were proposed in this pull request? The change here is to implement a background service for Trash Deletion. This feature basically introduces Trash for Ozone File System by

[jira] [Updated] (HDDS-4307) Start Background Service for Trash Deletion in Ozone Manager

2020-10-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-4307: - Labels: pull-request-available (was: ) > Start Background Service for Trash Deletion in Ozone Man

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1506: HDDS-4359. Expose VolumeIOStats in DN JMX

2020-10-20 Thread GitBox
linyiqun commented on a change in pull request #1506: URL: https://github.com/apache/hadoop-ozone/pull/1506#discussion_r508574686 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeIOStats.java ## @@ -18,121 +18,135

[jira] [Comment Edited] (HDDS-4307) Start Background Service for Trash Deletion in Ozone Manager

2020-10-20 Thread YiSheng Lien (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213327#comment-17213327 ] YiSheng Lien edited comment on HDDS-4307 at 10/20/20, 2:54 PM: -

[jira] [Commented] (HDDS-4307) Start Background Service for Trash Deletion in Ozone Manager

2020-10-20 Thread Sadanand Shenoy (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217658#comment-17217658 ] Sadanand Shenoy commented on HDDS-4307: --- Hi [~cxorm] thanks for the doc and your tho

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1498: HDDS-4339. Skip aws signature when it's absent in header.

2020-10-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1498: URL: https://github.com/apache/hadoop-ozone/pull/1498#discussion_r508623536 ## File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java ## @@ -116,6 +116,13 @@ private OzoneC

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1498: HDDS-4339. Skip aws signature when it's absent in header.

2020-10-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1498: URL: https://github.com/apache/hadoop-ozone/pull/1498#discussion_r508623536 ## File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java ## @@ -116,6 +116,13 @@ private OzoneC

[jira] [Created] (HDDS-4360) ListFileStatus : list all the descendants of a given dir recursively

2020-10-20 Thread Rakesh Radhakrishnan (Jira)
Rakesh Radhakrishnan created HDDS-4360: -- Summary: ListFileStatus : list all the descendants of a given dir recursively Key: HDDS-4360 URL: https://issues.apache.org/jira/browse/HDDS-4360 Project:

[jira] [Resolved] (HDDS-4306) Ozone checkstyle rule can't be imported to IntelliJ

2020-10-20 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-4306. Fix Version/s: 1.1.0 Resolution: Fixed > Ozone checkstyle rule can't be imported to I

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1472: HDDS-4306. Ozone checkstyle rule can't be imported to IntelliJ.

2020-10-20 Thread GitBox
adoroszlai merged pull request #1472: URL: https://github.com/apache/hadoop-ozone/pull/1472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-20 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r508666092 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void list

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-20 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r508673206 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void list

[GitHub] [hadoop-ozone] mukul1987 commented on a change in pull request #1507: HDDS-4307.Start Background Service for Trash Deletion in Ozone Manager

2020-10-20 Thread GitBox
mukul1987 commented on a change in pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#discussion_r508628274 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/TrashDeletingService.java ## @@ -0,0 +1,114 @@ +/** + * Licensed

[GitHub] [hadoop-ozone] prashantpogde opened a new pull request #1508: Hdds 4342

2020-10-20 Thread GitBox
prashantpogde opened a new pull request #1508: URL: https://github.com/apache/hadoop-ozone/pull/1508 ## What changes were proposed in this pull request? Add DataNode state and transitions for a node going through upgrade ## What is the link to the Apache JIRA https://iss

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #1506: HDDS-4359. Expose VolumeIOStats in DN JMX

2020-10-20 Thread GitBox
smengcl commented on a change in pull request #1506: URL: https://github.com/apache/hadoop-ozone/pull/1506#discussion_r508747977 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/VolumeIOStats.java ## @@ -18,121 +18,135 @

[jira] [Updated] (HDDS-4315) Ensure ObjectIDs are unique across restarts

2020-10-20 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanisha Koneru updated HDDS-4315: - Summary: Ensure ObjectIDs are unique across restarts (was: Use Epoch to generate unique ObjectIDs

[jira] [Updated] (HDDS-4315) Ensure ObjectIDs are unique across restarts

2020-10-20 Thread Hanisha Koneru (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanisha Koneru updated HDDS-4315: - Description: In a non-Ratis OM, the transaction index used to generate ObjectID is reset on OM re

[GitHub] [hadoop-ozone] hanishakoneru commented on pull request #1480: HDDS-4315. Use Epoch to generate unique ObjectIDs

2020-10-20 Thread GitBox
hanishakoneru commented on pull request #1480: URL: https://github.com/apache/hadoop-ozone/pull/1480#issuecomment-713133700 @prashantpogde, @linyiqun, @bharatviswa504, I have updated the PR with the discussed approach. Please review when you get a chance. Thanks. -

[jira] [Assigned] (HDDS-4182) Onboard HDDS-3869 into Layout version management

2020-10-20 Thread Aravindan Vijayan (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aravindan Vijayan reassigned HDDS-4182: --- Assignee: Ethan Rose > Onboard HDDS-3869 into Layout version management > ---

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

2020-10-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r50638 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -919,12 +920,32 @@ private boolea

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

2020-10-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r508891177 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -919,12 +920,32 @@ private boolea

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

2020-10-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r508891177 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -919,12 +920,32 @@ private boolea

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

2020-10-20 Thread GitBox
bharatviswa504 commented on pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#issuecomment-713190031 Thank You @elek for the review. I have addressed the review comments. This is an automated messag

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-20 Thread GitBox
linyiqun commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r508951839 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void listS

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-20 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r508953520 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void list

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #1498: HDDS-4339. Allow AWSSignatureProcessor init when aws signature is absent.

2020-10-20 Thread GitBox
timmylicheng commented on a change in pull request #1498: URL: https://github.com/apache/hadoop-ozone/pull/1498#discussion_r508953508 ## File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java ## @@ -116,6 +116,13 @@ private OzoneCli

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-20 Thread GitBox
linyiqun commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r508953973 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void listS

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-20 Thread GitBox
linyiqun commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r508955061 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void listS

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-20 Thread GitBox
linyiqun commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r508957775 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void listS

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-20 Thread GitBox
linyiqun commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r508957775 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void listS

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1498: HDDS-4339. Allow AWSSignatureProcessor init when aws signature is absent.

2020-10-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1498: URL: https://github.com/apache/hadoop-ozone/pull/1498#discussion_r508971879 ## File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java ## @@ -116,6 +116,13 @@ private OzoneC

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1498: HDDS-4339. Allow AWSSignatureProcessor init when aws signature is absent.

2020-10-20 Thread GitBox
bharatviswa504 commented on a change in pull request #1498: URL: https://github.com/apache/hadoop-ozone/pull/1498#discussion_r508972921 ## File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java ## @@ -116,6 +116,13 @@ private OzoneC

[GitHub] [hadoop-ozone] prashantpogde commented on a change in pull request #1507: HDDS-4307.Start Background Service for Trash Deletion in Ozone Manager

2020-10-20 Thread GitBox
prashantpogde commented on a change in pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#discussion_r508979580 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java ## @@ -197,6 +197,12 @@ public static final Str

[GitHub] [hadoop-ozone] linyiqun commented on pull request #1506: HDDS-4359. Expose VolumeIOStats in DN JMX

2020-10-20 Thread GitBox
linyiqun commented on pull request #1506: URL: https://github.com/apache/hadoop-ozone/pull/1506#issuecomment-713302412 I see you have manually tested this change and share the result above. +1 from me, : ). This is an auto

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

2020-10-20 Thread GitBox
rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r508999204 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2272,167 @@ private void list

[GitHub] [hadoop-ozone] smengcl commented on pull request #1506: HDDS-4359. Expose VolumeIOStats in DN JMX

2020-10-20 Thread GitBox
smengcl commented on pull request #1506: URL: https://github.com/apache/hadoop-ozone/pull/1506#issuecomment-713336320 > I see you have manually tested this change and share the result above. > +1 from me, : ). Thanks for reviewing and +1'ing this @linyiqun :) Just added test in