[GitHub] [ozone] bharatviswa504 opened a new pull request #1531: HDDS-4405. Proxy failover is logging with out trying all OMS.

bharatviswa504 opened a new pull request #1531: URL: https://github.com/apache/ozone/pull/1531 ## What changes were proposed in this pull request? Skip Retry INFO logging on first failover from a proxy is broken. This fixes the behavior. ## What is the link to the Apache JIRA

[GitHub] [ozone] bharatviswa504 commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

bharatviswa504 commented on a change in pull request #1503: URL: https://github.com/apache/ozone/pull/1503#discussion_r513799166 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2276,318 @@ private void listSt

[GitHub] [ozone] xiaoyuyao commented on a change in pull request #1497: HDDS-4345. Replace the deprecated Lock method

xiaoyuyao commented on a change in pull request #1497: URL: https://github.com/apache/ozone/pull/1497#discussion_r513750621 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -459,7 +459,7 @@ public OpenKeySession openKe

[GitHub] [ozone] mukul1987 opened a new pull request #1530: HDDS-4363. Add metric to track the number of RocksDB open/close operations.

mukul1987 opened a new pull request #1530: URL: https://github.com/apache/ozone/pull/1530 ## What changes were proposed in this pull request? While benchmarking Ozone performance, it was realized RocksDB open/close operations have impact on performance. Adding metrics on these operati

[GitHub] [ozone] cku328 commented on pull request #1524: HDDS-4258.Set GDPR to a Security submenu in EN and CN document

cku328 commented on pull request #1524: URL: https://github.com/apache/ozone/pull/1524#issuecomment-718114257 Thanks @frischHWC for working on this. When `GDPR in Ozone` is moved from `Features` to `Security`, the description on `Features` page should be updated, IMHO. ![擷取1](htt

[GitHub] [ozone] avijayanhwx merged pull request #1529: HDDS-4401. Fix compilation issue in HDDS-3698-upgrade branch.

avijayanhwx merged pull request #1529: URL: https://github.com/apache/ozone/pull/1529 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [ozone] avijayanhwx commented on pull request #1529: HDDS-4401. Fix compilation issue in HDDS-3698-upgrade branch.

avijayanhwx commented on pull request #1529: URL: https://github.com/apache/ozone/pull/1529#issuecomment-718104100 Integration test failure is unrelated. Since this is a branch PR, merging this with unclean CI to unblock efforts. ---

[GitHub] [ozone] avijayanhwx edited a comment on pull request #1529: HDDS-4401. Fix compilation issue in HDDS-3698-upgrade branch.

avijayanhwx edited a comment on pull request #1529: URL: https://github.com/apache/ozone/pull/1529#issuecomment-718072316 The remaining findbug failures will be fixed through DN finalization JIRA (HDDS-4175). `M D DLS: Dead store to controller in org.apache.hadoop.ozone.container.c

[GitHub] [ozone] avijayanhwx commented on pull request #1529: HDDS-4401. Fix compilation issue in HDDS-3698-upgrade branch.

avijayanhwx commented on pull request #1529: URL: https://github.com/apache/ozone/pull/1529#issuecomment-718072316 The current findbug failures will be fixed through DN finalization JIRA (HDDS-4175). `M D DLS: Dead store to controller in org.apache.hadoop.ozone.container.common.sta

[GitHub] [ozone] avijayanhwx opened a new pull request #1529: HDDS-4401. Fix compilation issue in HDDS-3698-upgrade branch.

avijayanhwx opened a new pull request #1529: URL: https://github.com/apache/ozone/pull/1529 ## What changes were proposed in this pull request? Fix compilation and findbugs issue. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-4401 ## Ho

[GitHub] [ozone] bharatviswa504 commented on pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

bharatviswa504 commented on pull request #1451: URL: https://github.com/apache/ozone/pull/1451#issuecomment-718022766 Thank You @rakeshadr and @elek for the review. @elek if you have any more comments, happy to address them in a new Jira.

[GitHub] [ozone] bharatviswa504 merged pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

bharatviswa504 merged pull request #1451: URL: https://github.com/apache/ozone/pull/1451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [ozone] rakeshadr commented on pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

rakeshadr commented on pull request #1451: URL: https://github.com/apache/ozone/pull/1451#issuecomment-718008243 +1 LGTM Thanks @bharatviswa504 for the contribution. This is an automated message from the Apache Git Service

[GitHub] [ozone] avijayanhwx commented on pull request #1518: HDDS-4386: Each EndpointStateMachine uses its own thread pool to talk with SCM/Recon

avijayanhwx commented on pull request #1518: URL: https://github.com/apache/ozone/pull/1518#issuecomment-717955429 @GlenGeng / @ChenSammi How many containers do you have on your prod cluster? I have encountered a similar issue in another cluster with million containers. The problem is exp

[GitHub] [ozone] rakeshadr opened a new pull request #1528: HDDS-4357: Rename : make rename an atomic ops by updating key path entry in dir/file table

rakeshadr opened a new pull request #1528: URL: https://github.com/apache/ozone/pull/1528 ## What changes were proposed in this pull request? https://issues.apache.org/jira/browse/HDDS-4357 ## What is the link to the Apache JIRA This task is to handle rename key path

[GitHub] [ozone] bshashikant opened a new pull request #1527: HDDS-4400. Make raft log directory deletion configurable during pipeline remove.

bshashikant opened a new pull request #1527: URL: https://github.com/apache/ozone/pull/1527 ## What changes were proposed in this pull request? Added a config to make raft log directory removal configurable during pipeline remove. ## What is the link to the Apache JIRA http

[GitHub] [ozone] bshashikant opened a new pull request #1526: HDDS-4399. Safe mode rule for piplelines should only consider open pipelines.

bshashikant opened a new pull request #1526: URL: https://github.com/apache/ozone/pull/1526 ## What changes were proposed in this pull request? Currently, for safe mode we consider all pipelines existing in DB for safe mode exit criteria. It ma happen that, SCM has the pipelines

[GitHub] [ozone] linyiqun commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

linyiqun commented on a change in pull request #1489: URL: https://github.com/apache/ozone/pull/1489#discussion_r51435 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected boolean

[GitHub] [ozone] linyiqun commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

linyiqun commented on a change in pull request #1489: URL: https://github.com/apache/ozone/pull/1489#discussion_r51435 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected boolean

[GitHub] [ozone] captainzmc commented on a change in pull request #1515: HDDS-4373. [Design] Ozone support append operation

captainzmc commented on a change in pull request #1515: URL: https://github.com/apache/ozone/pull/1515#discussion_r513230594 ## File path: hadoop-hdds/docs/content/design/append.md ## @@ -0,0 +1,87 @@ +--- +title: Append +summary: Append to the existing key. +date: 2020-10-22 +

[GitHub] [ozone] captainzmc commented on a change in pull request #1515: HDDS-4373. [Design] Ozone support append operation

captainzmc commented on a change in pull request #1515: URL: https://github.com/apache/ozone/pull/1515#discussion_r513229806 ## File path: hadoop-hdds/docs/content/design/append.md ## @@ -0,0 +1,87 @@ +--- +title: Append +summary: Append to the existing key. +date: 2020-10-22 +

[GitHub] [ozone] captainzmc commented on a change in pull request #1515: HDDS-4373. [Design] Ozone support append operation

captainzmc commented on a change in pull request #1515: URL: https://github.com/apache/ozone/pull/1515#discussion_r513229806 ## File path: hadoop-hdds/docs/content/design/append.md ## @@ -0,0 +1,87 @@ +--- +title: Append +summary: Append to the existing key. +date: 2020-10-22 +

[GitHub] [ozone] captainzmc commented on a change in pull request #1515: HDDS-4373. [Design] Ozone support append operation

captainzmc commented on a change in pull request #1515: URL: https://github.com/apache/ozone/pull/1515#discussion_r513224086 ## File path: hadoop-hdds/docs/content/design/append.md ## @@ -0,0 +1,87 @@ +--- +title: Append +summary: Append to the existing key. +date: 2020-10-22 +

[GitHub] [ozone] captainzmc commented on a change in pull request #1515: HDDS-4373. [Design] Ozone support append operation

captainzmc commented on a change in pull request #1515: URL: https://github.com/apache/ozone/pull/1515#discussion_r513224086 ## File path: hadoop-hdds/docs/content/design/append.md ## @@ -0,0 +1,87 @@ +--- +title: Append +summary: Append to the existing key. +date: 2020-10-22 +

[GitHub] [ozone] captainzmc commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

captainzmc commented on a change in pull request #1489: URL: https://github.com/apache/ozone/pull/1489#discussion_r513216585 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected boole

[GitHub] [ozone] captainzmc commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

captainzmc commented on a change in pull request #1489: URL: https://github.com/apache/ozone/pull/1489#discussion_r513219358 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected boole

[GitHub] [ozone] captainzmc commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

captainzmc commented on a change in pull request #1489: URL: https://github.com/apache/ozone/pull/1489#discussion_r513219195 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected boole

[GitHub] [ozone] captainzmc commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

captainzmc commented on a change in pull request #1489: URL: https://github.com/apache/ozone/pull/1489#discussion_r513216585 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected boole

[GitHub] [ozone] captainzmc commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

captainzmc commented on a change in pull request #1489: URL: https://github.com/apache/ozone/pull/1489#discussion_r513216585 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected boole

[GitHub] [ozone] bharatviswa504 commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

bharatviswa504 commented on a change in pull request #1489: URL: https://github.com/apache/ozone/pull/1489#discussion_r513169793 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected b

[GitHub] [ozone] bharatviswa504 commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

bharatviswa504 commented on a change in pull request #1489: URL: https://github.com/apache/ozone/pull/1489#discussion_r513169229 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected b

[GitHub] [ozone] bharatviswa504 commented on a change in pull request #1498: HDDS-4339. Allow AWSSignatureProcessor init when aws signature is absent.

bharatviswa504 commented on a change in pull request #1498: URL: https://github.com/apache/ozone/pull/1498#discussion_r513166313 ## File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java ## @@ -80,9 +81,15 @@ private OzoneClient get

[GitHub] [ozone] captainzmc commented on pull request #1497: HDDS-4345. Replace the deprecated Lock method

captainzmc commented on pull request #1497: URL: https://github.com/apache/ozone/pull/1497#issuecomment-717654070 Thanks for @xiaoyuyao’s feedback. The issues has been fixed This is an automated message from the Apache Git S

[GitHub] [ozone] captainzmc commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

captainzmc commented on a change in pull request #1489: URL: https://github.com/apache/ozone/pull/1489#discussion_r513140628 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected boole

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1515: HDDS-4373. [Design] Ozone support append operation

arp7 commented on a change in pull request #1515: URL: https://github.com/apache/hadoop-ozone/pull/1515#discussion_r513026161 ## File path: hadoop-hdds/docs/content/design/append.md ## @@ -0,0 +1,87 @@ +--- +title: Append +summary: Append to the existing key. +date: 2020-10-22

[GitHub] [hadoop-ozone] arp7 commented on a change in pull request #1515: HDDS-4373. [Design] Ozone support append operation

arp7 commented on a change in pull request #1515: URL: https://github.com/apache/hadoop-ozone/pull/1515#discussion_r513025813 ## File path: hadoop-hdds/docs/content/design/append.md ## @@ -0,0 +1,87 @@ +--- +title: Append +summary: Append to the existing key. +date: 2020-10-22

[GitHub] [hadoop-ozone] prashantpogde commented on pull request #1507: HDDS-4307.Start Trash Emptier in Ozone Manager

prashantpogde commented on pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#issuecomment-717415113 +1 LGTM This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #1516: HDDS-3731. [doc]add storage space quota document.

xiaoyuyao merged pull request #1516: URL: https://github.com/apache/hadoop-ozone/pull/1516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1516: HDDS-3731. [doc]add storage space quota document.

xiaoyuyao commented on pull request #1516: URL: https://github.com/apache/hadoop-ozone/pull/1516#issuecomment-717361668 Thanks @captainzmc for the update. LGTM, +1. This is an automated message from the Apache Git Service.

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

linyiqun commented on a change in pull request #1489: URL: https://github.com/apache/hadoop-ozone/pull/1489#discussion_r512749950 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1489: HDDS-4308. Fix issue with quota update

linyiqun commented on a change in pull request #1489: URL: https://github.com/apache/hadoop-ozone/pull/1489#discussion_r512749950 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java ## @@ -597,27 +596,40 @@ protected

[GitHub] [hadoop-ozone] bshashikant commented on pull request #1523: HDDS-4320. Let Ozone input streams implement CanUnbuffer

bshashikant commented on pull request #1523: URL: https://github.com/apache/hadoop-ozone/pull/1523#issuecomment-717257127 Thanks @adoroszlai . I am still reviewing this, however, i have couple of questions: 1) In unbuffer, do we need to remove the corresponding blockInputStreams and chu

[GitHub] [hadoop-ozone] avijayanhwx merged pull request #1518: HDDS-4386: Each EndpointStateMachine uses its own thread pool to talk with SCM/Recon

avijayanhwx merged pull request #1518: URL: https://github.com/apache/hadoop-ozone/pull/1518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] sadanand48 commented on a change in pull request #1507: HDDS-4307.Start Trash Emptier in Ozone Manager

sadanand48 commented on a change in pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#discussion_r512567525 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java ## @@ -1228,17 +1238,57 @@ public void restar

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1525: HDDS-3959. Avoid HddsProtos.PipelineID#toString

adoroszlai opened a new pull request #1525: URL: https://github.com/apache/hadoop-ozone/pull/1525 ## What changes were proposed in this pull request? Change `CreatePipelineCommandHandler` and `ClosePipelineCommandHandler` to use the non-proto `PipelineID` object for logging. This le

[GitHub] [hadoop-ozone] captainzmc commented on pull request #1489: HDDS-4308. Fix issue with quota update

captainzmc commented on pull request #1489: URL: https://github.com/apache/hadoop-ozone/pull/1489#issuecomment-717123932 Hi @linyiqun,I modified the implementation based on the latest comments. Can you help to review this PR. ---

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1507: HDDS-4307.Start Trash Emptier in Ozone Manager

rakeshadr commented on a change in pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#discussion_r512525048 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java ## @@ -1228,17 +1238,57 @@ public void restart

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1507: HDDS-4307.Start Trash Emptier in Ozone Manager

rakeshadr commented on a change in pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#discussion_r512525048 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java ## @@ -1228,17 +1238,57 @@ public void restart

[GitHub] [hadoop-ozone] captainzmc edited a comment on pull request #1489: HDDS-4308. Fix issue with quota update

captainzmc edited a comment on pull request #1489: URL: https://github.com/apache/hadoop-ozone/pull/1489#issuecomment-708182129 Hi @bharatviswa504, Can you help to review this PR. This is an automated message from the Apache

[GitHub] [hadoop-ozone] lokeshj1703 commented on pull request #1519: HDDS-4388. Make writeStateMachineTimeout retry count proportional to node failure timeout

lokeshj1703 commented on pull request #1519: URL: https://github.com/apache/hadoop-ozone/pull/1519#issuecomment-717039024 @bshashikant Thanks for the contribution! I have merged the PR to master branch. This is an automated

[GitHub] [hadoop-ozone] lokeshj1703 closed pull request #1519: HDDS-4388. Make writeStateMachineTimeout retry count proportional to node failure timeout

lokeshj1703 closed pull request #1519: URL: https://github.com/apache/hadoop-ozone/pull/1519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] rakeshadr commented on pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

rakeshadr commented on pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#issuecomment-717036194 > Thanks for updating the PR, @rakeshadr . One further review comment below. > > In additional, current test change not fully cover the test for listStatusV1. Examp

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r512452877 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2276,318 @@ private void list

[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1503: HDDS-4332: ListFileStatus - do lookup in directory and file tables

rakeshadr commented on a change in pull request #1503: URL: https://github.com/apache/hadoop-ozone/pull/1503#discussion_r512452877 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -2205,6 +2276,318 @@ private void list

[GitHub] [hadoop-ozone] frischHWC opened a new pull request #1524: HDDS-4258.Set GDPR to a Security submenu in EN and CN document

frischHWC opened a new pull request #1524: URL: https://github.com/apache/hadoop-ozone/pull/1524 ## What changes were proposed in this pull request? Setting GDPR to security submenu for EN & CN pages. ## What is the link to the Apache JIRA https://issues.apache.org/jira/

[GitHub] [hadoop-ozone] sadanand48 commented on pull request #1507: HDDS-4307.Start Trash Emptier in Ozone Manager

sadanand48 commented on pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#issuecomment-717002589 Thanks @rakeshadr for the review. Addressed your comments . Will incorporate the changes you suggested on the BackgroundService when i include it in the next patch. --

[GitHub] [hadoop-ozone] sadanand48 edited a comment on pull request #1507: HDDS-4307.Start Trash Emptier in Ozone Manager

sadanand48 edited a comment on pull request #1507: URL: https://github.com/apache/hadoop-ozone/pull/1507#issuecomment-717002589 Thanks @rakeshadr for the review. Addressed your comments . Will incorporate the changes you suggested on the TrashDeletingService when i include it in the next

[GitHub] [hadoop-ozone] GlenGeng commented on pull request #1518: HDDS-4386: Each EndpointStateMachine uses its own thread pool to talk with SCM/Recon

GlenGeng commented on pull request #1518: URL: https://github.com/apache/hadoop-ozone/pull/1518#issuecomment-716941212 @avijayanhwx We've create two Jiras for the Recon issue, HDDS-4385 and HDDS-4355. I've cc you in them. BTW, in our production cluster, since starting up recon will m

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1518: HDDS-4386: Each EndpointStateMachine uses its own thread pool to talk with SCM/Recon

avijayanhwx commented on pull request #1518: URL: https://github.com/apache/hadoop-ozone/pull/1518#issuecomment-716920861 > @GlenGeng Thanks for fixing this issue. > > Is there a JIRA created for the Recon slowness issue? > > Also, irrespective of whether there is a slow SCM or

[GitHub] [hadoop-ozone] github-actions[bot] commented on pull request #1327: HDDS-4098. Improve om admin getserviceroles error message

github-actions[bot] commented on pull request #1327: URL: https://github.com/apache/hadoop-ozone/pull/1327#issuecomment-716905708 Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.

[GitHub] [hadoop-ozone] github-actions[bot] commented on pull request #1363: HDDS-3805. [OFS] Remove usage of OzoneClientAdapter interface

github-actions[bot] commented on pull request #1363: URL: https://github.com/apache/hadoop-ozone/pull/1363#issuecomment-716905696 Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.

[GitHub] [hadoop-ozone] github-actions[bot] closed pull request #1327: HDDS-4098. Improve om admin getserviceroles error message

github-actions[bot] closed pull request #1327: URL: https://github.com/apache/hadoop-ozone/pull/1327 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop-ozone] github-actions[bot] closed pull request #1363: HDDS-3805. [OFS] Remove usage of OzoneClientAdapter interface

github-actions[bot] closed pull request #1363: URL: https://github.com/apache/hadoop-ozone/pull/1363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #1301: HDDS-3882. Update modification time when updating volume/bucket/key ACLs

xiaoyuyao merged pull request #1301: URL: https://github.com/apache/hadoop-ozone/pull/1301 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1301: HDDS-3882. Update modification time when updating volume/bucket/key ACLs

xiaoyuyao commented on pull request #1301: URL: https://github.com/apache/hadoop-ozone/pull/1301#issuecomment-716788128 Thanks @cxorm for fixing this. The change LGTM, +1. I will merge it shortly. Also notice similar unnecessary builder conversion issue in OMVolumeSetQuotaRequestw

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1497: HDDS-4345. Replace the deprecated Lock method

xiaoyuyao commented on a change in pull request #1497: URL: https://github.com/apache/hadoop-ozone/pull/1497#discussion_r512223510 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/VolumeManagerImpl.java ## @@ -620,7 +620,7 @@ public boolean che

[GitHub] [hadoop-ozone] prashantpogde commented on a change in pull request #1486: HDDS-4296. SCM changes to process Layout Info in heartbeat request/response

prashantpogde commented on a change in pull request #1486: URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r512168941 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java ## @@ -400,6 +405,66 @@ public void pro

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #1395: HDDS-4088. Adding Owner info for Authorizer plugin to honor owner access rights

xiaoyuyao merged pull request #1395: URL: https://github.com/apache/hadoop-ozone/pull/1395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] xiaoyuyao commented on pull request #1395: HDDS-4088. Adding Owner info for Authorizer plugin to honor owner access rights

xiaoyuyao commented on pull request #1395: URL: https://github.com/apache/hadoop-ozone/pull/1395#issuecomment-716722366 Thanks @smengcl for the review. This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1523: HDDS-4320. Let Ozone input streams implement CanUnbuffer

adoroszlai opened a new pull request #1523: URL: https://github.com/apache/hadoop-ozone/pull/1523 ## What changes were proposed in this pull request? Implement [`CanUnbuffer` interface](https://github.com/apache/hadoop/blob/b32926f1108bef1f1e506de684c021203b2432f1/hadoop-common-proje

[GitHub] [hadoop-ozone] asfgit merged pull request #1520: Merge master branch into HDDS-1880-Decom

asfgit merged pull request #1520: URL: https://github.com/apache/hadoop-ozone/pull/1520 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop-ozone] codecov-io edited a comment on pull request #1520: Merge master branch into HDDS-1880-Decom

codecov-io edited a comment on pull request #1520: URL: https://github.com/apache/hadoop-ozone/pull/1520#issuecomment-715660815 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1520?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`HDDS-1880-De

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1521: HDDS-4362. Change hadoop32 test to use 3.2 image

adoroszlai commented on pull request #1521: URL: https://github.com/apache/hadoop-ozone/pull/1521#issuecomment-716548122 Thanks @elek for reviewing and committing it. This is an automated message from the Apache Git Service.

[GitHub] [hadoop-ozone] elek merged pull request #1521: HDDS-4362. Change hadoop32 test to use 3.2 image

elek merged pull request #1521: URL: https://github.com/apache/hadoop-ozone/pull/1521 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [hadoop-ozone] timmylicheng opened a new pull request #1522: Hdds 4393 Test CI failures after force push

timmylicheng opened a new pull request #1522: URL: https://github.com/apache/hadoop-ozone/pull/1522 ## What changes were proposed in this pull request? Test CI failures after force push (Please fill in changes proposed in this fix) ## What is the link to the Apache JIRA http

[GitHub] [hadoop-ozone] captainzmc commented on pull request #1497: HDDS-4345. Replace the deprecated Lock method

captainzmc commented on pull request #1497: URL: https://github.com/apache/hadoop-ozone/pull/1497#issuecomment-716470302 Thanks for @xiaoyuyao‘s review, the issues has been fixed. This is an automated message from the Apache

[GitHub] [hadoop-ozone] timmylicheng commented on pull request #1498: HDDS-4339. Allow AWSSignatureProcessor init when aws signature is absent.

timmylicheng commented on pull request #1498: URL: https://github.com/apache/hadoop-ozone/pull/1498#issuecomment-716269366 This fix is to keep AWSSignatureProcessor out of NPE so that when OzoneClientProducer could be instantiated even when auth is missing in header. After that OzoneClient

[GitHub] [hadoop-ozone] cxorm commented on pull request #1301: HDDS-3882. Update modification time when updating volume/bucket/key ACLs

cxorm commented on pull request #1301: URL: https://github.com/apache/hadoop-ozone/pull/1301#issuecomment-716102947 > Thanks for the update @cxorm. A few similar usage that can be optimized. Sorry I did not explicitly comment all of them last time. That's my carelessness : ) Thank

[GitHub] [hadoop-ozone] codecov-io edited a comment on pull request #1520: Merge master branch into HDDS-1880-Decom

codecov-io edited a comment on pull request #1520: URL: https://github.com/apache/hadoop-ozone/pull/1520#issuecomment-715660815 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1520?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`HDDS-1880-De

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #1301: HDDS-3882. Update modification time when updating volume/bucket/key ACLs

cxorm commented on a change in pull request #1301: URL: https://github.com/apache/hadoop-ozone/pull/1301#discussion_r511484216 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/acl/OMVolumeAclRequest.java ## @@ -84,6 +84,7 @@ publ

[GitHub] [hadoop-ozone] cxorm commented on a change in pull request #1301: HDDS-3882. Update modification time when updating volume/bucket/key ACLs

cxorm commented on a change in pull request #1301: URL: https://github.com/apache/hadoop-ozone/pull/1301#discussion_r511484216 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/acl/OMVolumeAclRequest.java ## @@ -84,6 +84,7 @@ publ

[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #1521: HDDS-4362. Change hadoop32 test to use 3.2 image

adoroszlai opened a new pull request #1521: URL: https://github.com/apache/hadoop-ozone/pull/1521 ## What changes were proposed in this pull request? `ozone-mr/hadoop32` and `ozonesecure-mr` acceptance tests use "latest" `hadoop:3` docker image, which is currently Hadoop 3.2. If it

[GitHub] [hadoop-ozone] codecov-io commented on pull request #1520: Merge master branch into HDDS-1880-Decom

codecov-io commented on pull request #1520: URL: https://github.com/apache/hadoop-ozone/pull/1520#issuecomment-715660815 # [Codecov](https://codecov.io/gh/apache/hadoop-ozone/pull/1520?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`HDDS-1880-Decom@f64

[GitHub] [hadoop-ozone] GlenGeng commented on pull request #1518: HDDS-4386: Each EndpointStateMachine uses its own thread pool to talk with SCM/Recon

GlenGeng commented on pull request #1518: URL: https://github.com/apache/hadoop-ozone/pull/1518#issuecomment-715656741 @avijayanhwx Thanks for looking at this PR. @ChenSammi Could you please create a Jira for slow Recon ? > Also, irrespective of whether there is a slow SCM or Reco

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1497: HDDS-4345. Replace the deprecated Lock method

xiaoyuyao commented on a change in pull request #1497: URL: https://github.com/apache/hadoop-ozone/pull/1497#discussion_r511191225 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/PrefixManagerImpl.java ## @@ -253,18 +253,18 @@ public boolean c

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1518: HDDS-4386: Each EndpointStateMachine uses its own thread pool to talk with SCM/Recon

avijayanhwx commented on pull request #1518: URL: https://github.com/apache/hadoop-ozone/pull/1518#issuecomment-715582860 @GlenGeng Thanks for fixing this issue. Is there a JIRA created for the Recon slowness issue? Also, irrespective of whether there is a slow SCM or Recon, th

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1486: HDDS-4296. SCM changes to process Layout Info in heartbeat request/response

avijayanhwx commented on a change in pull request #1486: URL: https://github.com/apache/hadoop-ozone/pull/1486#discussion_r511140146 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java ## @@ -400,6 +405,66 @@ public void proce

[GitHub] [hadoop-ozone] sodonnel opened a new pull request #1520: Merge master branch into HDDS-1880-Decom

sodonnel opened a new pull request #1520: URL: https://github.com/apache/hadoop-ozone/pull/1520 ## What changes were proposed in this pull request? Merge master into the decommission branch. This was a clean merge with no conflicts at all. ## What is the link to the Apache JIR

[GitHub] [hadoop-ozone] lokeshj1703 commented on a change in pull request #1519: HDDS-4388. Make writeStateMachineTimeout retry count proportional to node failure timeout

lokeshj1703 commented on a change in pull request #1519: URL: https://github.com/apache/hadoop-ozone/pull/1519#discussion_r510844138 ## File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java ##

[GitHub] [hadoop-ozone] lokeshj1703 commented on pull request #1513: HDDS-4366. SCM deletion service should delete configured number of blocks every interval.

lokeshj1703 commented on pull request #1513: URL: https://github.com/apache/hadoop-ozone/pull/1513#issuecomment-715293590 @bshashikant Thanks for reviewing the PR! I have added a commit which addresses the comments. This is

[GitHub] [hadoop-ozone] lokeshj1703 commented on a change in pull request #1513: HDDS-4366. SCM deletion service should delete configured number of blocks every interval.

lokeshj1703 commented on a change in pull request #1513: URL: https://github.com/apache/hadoop-ozone/pull/1513#discussion_r510827330 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java ## @@ -323,31 +322,54 @@ public voi

[GitHub] [hadoop-ozone] timmylicheng commented on a change in pull request #1514: HDDS-4191 Add failover proxy for SCM container location.

timmylicheng commented on a change in pull request #1514: URL: https://github.com/apache/hadoop-ozone/pull/1514#discussion_r510791922 ## File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMContainerLocationFailoverProxyProvider.java ## @@ -0,0 +1

[GitHub] [hadoop-ozone] bshashikant opened a new pull request #1519: HDDS-4388. Make writeStateMachineTimeout retry count proportional to node failure timeout

bshashikant opened a new pull request #1519: URL: https://github.com/apache/hadoop-ozone/pull/1519 ## What changes were proposed in this pull request? Currently, in ratis "writeStateMachinecall" gets retried indefinitely in event of a timeout. In case, where disks are slow/overlo

[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request #1513: HDDS-4366. SCM deletion service should delete configured number of blocks every interval.

bshashikant commented on a change in pull request #1513: URL: https://github.com/apache/hadoop-ozone/pull/1513#discussion_r510761184 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/SCMBlockDeletingService.java ## @@ -127,62 +112,65 @@ public

[GitHub] [hadoop-ozone] GlenGeng opened a new pull request #1518: HDDS-4386: Each EndpointStateMachine uses its own thread pool to talk with SCM/Recon

GlenGeng opened a new pull request #1518: URL: https://github.com/apache/hadoop-ozone/pull/1518 ## What changes were proposed in this pull request? In Tencent production environment, after start Recon for a while, we got warnings that all DNs become stale/dead at SCM side. After kill

[GitHub] [hadoop-ozone] GlenGeng closed pull request #1510: [Draft]HDDS-4191: failover proxy for container location protocol

GlenGeng closed pull request #1510: URL: https://github.com/apache/hadoop-ozone/pull/1510 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1514: HDDS-4191 Add failover proxy for SCM container location.

xiaoyuyao commented on a change in pull request #1514: URL: https://github.com/apache/hadoop-ozone/pull/1514#discussion_r510581749 ## File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMContainerLocationFailoverProxyProvider.java ## @@ -0,0 +1,28

[GitHub] [hadoop-ozone] captainzmc commented on pull request #1516: HDDS-3731. [doc]add storage space quota document.

captainzmc commented on pull request #1516: URL: https://github.com/apache/hadoop-ozone/pull/1516#issuecomment-714884328 Thanks @xiaoyuyao 's review. I have submitted a new commit fix the above issues. This is an automated

[GitHub] [hadoop-ozone] captainzmc commented on a change in pull request #1516: HDDS-3731. [doc]add storage space quota document.

captainzmc commented on a change in pull request #1516: URL: https://github.com/apache/hadoop-ozone/pull/1516#discussion_r510568534 ## File path: hadoop-hdds/docs/content/feature/Quota.md ## @@ -0,0 +1,67 @@ +--- +title: "Quota in Ozone" +date: "2020-October-22" +weight: 4 +sum

[GitHub] [hadoop-ozone] captainzmc commented on a change in pull request #1516: HDDS-3731. [doc]add storage space quota document.

captainzmc commented on a change in pull request #1516: URL: https://github.com/apache/hadoop-ozone/pull/1516#discussion_r510568737 ## File path: hadoop-hdds/docs/content/feature/Quota.md ## @@ -0,0 +1,67 @@ +--- +title: "Quota in Ozone" +date: "2020-October-22" +weight: 4 +sum

  1   2   3   4   5   6   7   8   9   10   >