[GitHub] [hadoop-ozone] adoroszlai merged pull request #1475: HDDS-4310: Ozone getconf broke the compatibility

adoroszlai merged pull request #1475: URL: https://github.com/apache/hadoop-ozone/pull/1475 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] runzhiwang edited a comment on pull request #1371: HDDS-2922. Balance ratis leader distribution in datanodes

runzhiwang edited a comment on pull request #1371: URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-704242576 @bshashikant Thanks for suggestions. Actually, RandomLeaderChoosePolicy does not choose datanode, it return null in

[GitHub] [hadoop-ozone] runzhiwang edited a comment on pull request #1371: HDDS-2922. Balance ratis leader distribution in datanodes

runzhiwang edited a comment on pull request #1371: URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-704242576 @bshashikant Thanks for suggestions. Actually, RandomLeaderChoosePolicy does not choose datanode, it return null in

[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1371: HDDS-2922. Balance ratis leader distribution in datanodes

runzhiwang commented on pull request #1371: URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-704242576 @bshashikant Thanks for suggestions. Actually, RandomLeaderChoosePolicy does not choose datanode, it return null in

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1475: HDDS-4310: Ozone getconf broke the compatibility

adoroszlai commented on a change in pull request #1475: URL: https://github.com/apache/hadoop-ozone/pull/1475#discussion_r500240713 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/conf/PrintConfKeyCommandHandler.java ## @@ -42,8 +43,9 @@ public Void

[GitHub] [hadoop-ozone] linyiqun commented on pull request #1457: HDDS-4253. Add LayoutVersion request/response for DN registration.

linyiqun commented on pull request #1457: URL: https://github.com/apache/hadoop-ozone/pull/1457#issuecomment-704221050 All checks have passed, +1. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hadoop-ozone] bshashikant commented on pull request #1371: HDDS-2922. Balance ratis leader distribution in datanodes

bshashikant commented on pull request #1371: URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-704195949 > @GlenGeng @bshashikant Thanks for review. I have updated the patch. > > > Can we also make the policy configurable? Also, one policy should also be defined for

[GitHub] [hadoop-ozone] runzhiwang commented on pull request #1371: HDDS-2922. Balance ratis leader distribution in datanodes

runzhiwang commented on pull request #1371: URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-704131953 @GlenGeng @bshashikant Thanks for review. I have updated the patch. `Can we also make the policy configurable? Also, one policy should also be defined for no

[GitHub] [hadoop-ozone] runzhiwang edited a comment on pull request #1371: HDDS-2922. Balance ratis leader distribution in datanodes

runzhiwang edited a comment on pull request #1371: URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-704131953 @GlenGeng @bshashikant Thanks for review. I have updated the patch. > Can we also make the policy configurable? Also, one policy should also be defined

[GitHub] [hadoop-ozone] sodonnel closed pull request #1474: Merge Master into the HDDS-1880-Decom branch

sodonnel closed pull request #1474: URL: https://github.com/apache/hadoop-ozone/pull/1474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] sodonnel commented on pull request #1474: Merge Master into the HDDS-1880-Decom branch

sodonnel commented on pull request #1474: URL: https://github.com/apache/hadoop-ozone/pull/1474#issuecomment-704094468 Merged from the CLI, so closing this PR. This is an automated message from the Apache Git Service. To

[GitHub] [hadoop-ozone] umamaheswararao opened a new pull request #1475: HDDS-4310: Ozone getconf broke the compatibility

umamaheswararao opened a new pull request #1475: URL: https://github.com/apache/hadoop-ozone/pull/1475 ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-4310 ## How was this patch tested? Added test cases.

[GitHub] [hadoop-ozone] sodonnel commented on pull request #1474: Merge Master into the HDDS-1880-Decom branch

sodonnel commented on pull request #1474: URL: https://github.com/apache/hadoop-ozone/pull/1474#issuecomment-704081400 All tests have passed on 3 runs so this looks good. I will merge it from the CLI so we don't lose the commit history, and then close this PR.

[GitHub] [hadoop-ozone] GlenGeng commented on pull request #1319: HDDS-4107: replace scmID with clusterID for container and volume at Datanode side

GlenGeng commented on pull request #1319: URL: https://github.com/apache/hadoop-ozone/pull/1319#issuecomment-704078470 > /pending @GlenGeng What is the plan with this issue? Do you need help? How can I help to move it forward? Hey, @elek, sorry for the late reply! I've

[GitHub] [hadoop-ozone] GlenGeng closed pull request #1319: HDDS-4107: replace scmID with clusterID for container and volume at Datanode side

GlenGeng closed pull request #1319: URL: https://github.com/apache/hadoop-ozone/pull/1319 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499979751 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java ## @@ -0,0 +1,283 @@

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1467: HDDS-4268. Prepare for Upgrade step should purge the log after waiting for the last txn to be applied.

linyiqun commented on a change in pull request #1467: URL: https://github.com/apache/hadoop-ozone/pull/1467#discussion_r499965831 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/RatisUpgradeUtils.java ## @@ -78,14 +82,26 @@ public static void

[GitHub] [hadoop-ozone] prashantpogde commented on pull request #1457: HDDS-4253. Add LayoutVersion request/response for DN registration.

prashantpogde commented on pull request #1457: URL: https://github.com/apache/hadoop-ozone/pull/1457#issuecomment-703986990 I am investigating errors and I will fix if any. This is an automated message from the Apache Git

[GitHub] [hadoop-ozone] flirmnave commented on pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

flirmnave commented on pull request #1368: URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-703986323 Thanks for @iamabug @xiaoyuyao @cku328 reviewing and @elek merging. This is an automated message from

[GitHub] [hadoop-ozone] linyiqun commented on pull request #1448: HDDS-4280. Document notable configurations for Recon.

linyiqun commented on pull request #1448: URL: https://github.com/apache/hadoop-ozone/pull/1448#issuecomment-703976733 Thanks @vivekratnavel and @avijayanhwx for the review and merge! This is an automated message from the

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1467: HDDS-4268. Prepare for Upgrade step should purge the log after waiting for the last txn to be applied.

avijayanhwx commented on pull request #1467: URL: https://github.com/apache/hadoop-ozone/pull/1467#issuecomment-703874936 cc @fapifta / @prashantpogde This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

bharatviswa504 commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r499806149 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -919,12 +920,32 @@ private

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

bharatviswa504 commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r499805554 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -919,12 +920,32 @@ private

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

bharatviswa504 commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r499800917 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/OMClientRequest.java ## @@ -298,21 +296,11 @@

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1467: HDDS-4268. Prepare for Upgrade step should purge the log after waiting for the last txn to be applied.

avijayanhwx commented on a change in pull request #1467: URL: https://github.com/apache/hadoop-ozone/pull/1467#discussion_r499785209 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerRatisServer.java ## @@ -432,7 +443,14 @@

[GitHub] [hadoop-ozone] bshashikant merged pull request #1460: HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager

bshashikant merged pull request #1460: URL: https://github.com/apache/hadoop-ozone/pull/1460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] swagle commented on a change in pull request #1457: HDDS-4253. Add LayoutVersion request/response for DN registration.

swagle commented on a change in pull request #1457: URL: https://github.com/apache/hadoop-ozone/pull/1457#discussion_r499748734 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java ## @@ -240,8 +247,19 @@ public

[GitHub] [hadoop-ozone] sodonnel opened a new pull request #1474: Merge Master into the HDDS-1880-Decom branch

sodonnel opened a new pull request #1474: URL: https://github.com/apache/hadoop-ozone/pull/1474 ## What changes were proposed in this pull request? Merge current master branch into the decom branch to keep it up-to-date. ## What is the link to the Apache JIRA No Jira

[GitHub] [hadoop-ozone] avijayanhwx merged pull request #1448: HDDS-4280. Document notable configurations for Recon.

avijayanhwx merged pull request #1448: URL: https://github.com/apache/hadoop-ozone/pull/1448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1448: HDDS-4280. Document notable configurations for Recon.

avijayanhwx commented on pull request #1448: URL: https://github.com/apache/hadoop-ozone/pull/1448#issuecomment-703744589 Thanks for the review @vivekratnavel. This is an automated message from the Apache Git Service. To

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1448: HDDS-4280. Document notable configurations for Recon.

avijayanhwx commented on pull request #1448: URL: https://github.com/apache/hadoop-ozone/pull/1448#issuecomment-703744057 > > Can we add a follow up JIRA to fix this inconsistent config key (recon.om.snapshot.task.interval.delay) ? > > Hi @avijayanhwx , I also find there is more

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1083: HDDS-3814. Drop a column family through debug cli tool

bharatviswa504 commented on a change in pull request #1083: URL: https://github.com/apache/hadoop-ozone/pull/1083#discussion_r499720959 ## File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DropTable.java ## @@ -0,0 +1,74 @@ +/* + * Licensed to the

[GitHub] [hadoop-ozone] bshashikant commented on a change in pull request #1460: HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager

bshashikant commented on a change in pull request #1460: URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499427088 ## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientFactory.java ## @@ -0,0 +1,44 @@ +/* + * Licensed to the

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

bharatviswa504 commented on a change in pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499686249 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java ## @@ -0,0

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

bharatviswa504 commented on a change in pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499683786 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java ## @@ -0,0

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

bharatviswa504 commented on a change in pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499683786 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java ## @@ -0,0

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499416480 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequestV1.java ## @@ -0,0 +1,283 @@

[GitHub] [hadoop-ozone] errose28 commented on a change in pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

errose28 commented on a change in pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499585384 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java ## @@ -0,0 +1,233 @@

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499628011 ## File path: hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCommitRequestV1.java ## @@ -0,0 +1,379 @@

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499612439 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileOps.java ## @@ -0,0 +1,206 @@ +/* + * Licensed

[GitHub] [hadoop-ozone] elek commented on pull request #1466: HDDS-4271. Avoid logging chunk content in Ozone Insight

elek commented on pull request #1466: URL: https://github.com/apache/hadoop-ozone/pull/1466#issuecomment-703646855 > I don't see why, as requestPreprocessor is only called in the trace branch. Ups, you are right. I missed it. In that case it will be slower (object copy) only for

[GitHub] [hadoop-ozone] elek commented on pull request #1363: HDDS-3805. [OFS] Remove usage of OzoneClientAdapter interface

elek commented on pull request #1363: URL: https://github.com/apache/hadoop-ozone/pull/1363#issuecomment-703644522 /pending This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop-ozone] elek commented on pull request #1327: HDDS-4098. Improve om admin getserviceroles error message

elek commented on pull request #1327: URL: https://github.com/apache/hadoop-ozone/pull/1327#issuecomment-703643969 /pending This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [hadoop-ozone] elek merged pull request #1465: HDDS-4300. Removed unneeded class DatanodeAdminNodeDetails

elek merged pull request #1465: URL: https://github.com/apache/hadoop-ozone/pull/1465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499569565 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -346,6 +369,7 @@ protected

[GitHub] [hadoop-ozone] elek commented on pull request #1319: HDDS-4107: replace scmID with clusterID for container and volume at Datanode side

elek commented on pull request #1319: URL: https://github.com/apache/hadoop-ozone/pull/1319#issuecomment-703634704 /pending @GlenGeng What is the plan with this issue? Do you need help? How can I help to move it forward?

[GitHub] [hadoop-ozone] elek merged pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

elek merged pull request #1368: URL: https://github.com/apache/hadoop-ozone/pull/1368 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop-ozone] elek commented on pull request #1368: HDDS-4156. add hierarchical layout to Chinese doc

elek commented on pull request #1368: URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-703633236 Comments from @xiaoyuyao are addressed (issue is created) and @cku328 also reviewed it (thanks for both) I don't speak Mandarin well, but merging this now as structure

[GitHub] [hadoop-ozone] elek commented on pull request #1418: HDDS-4209. S3A Filesystem does not work with Ozone S3.

elek commented on pull request #1418: URL: https://github.com/apache/hadoop-ozone/pull/1418#issuecomment-703631972 /pending In this specific case, intermediate directories will be created even if OZONE_OM_ENABLE_FILESYSTEM_PATHS

[GitHub] [hadoop-ozone] errose28 commented on a change in pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

errose28 commented on a change in pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499579108 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java ## @@ -0,0 +1,233 @@

[GitHub] [hadoop-ozone] errose28 commented on a change in pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

errose28 commented on a change in pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r499578543 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/AbstractOMKeyDeleteResponse.java ## @@ -0,0 +1,150

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499387631 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java ## @@ -129,6 +132,8 @@ *

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1466: HDDS-4271. Avoid logging chunk content in Ozone Insight

adoroszlai commented on pull request #1466: URL: https://github.com/apache/hadoop-ozone/pull/1466#issuecomment-703593031 Thanks @elek for reviewing and committing this. > My only counterargument is that it makes the debug slightly slower (and not only the TRACE but DEBUG as well).

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1460: HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager

elek commented on a change in pull request #1460: URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499544019 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestReadRetries.java ## @@ -147,7 +145,8 @@ public void

[GitHub] [hadoop-ozone] elek commented on pull request #1444: HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage

elek commented on pull request #1444: URL: https://github.com/apache/hadoop-ozone/pull/1444#issuecomment-703580641 Sorry, I was busy at apachecon last week. Sure, fine to do it later. it's just an opinion and fine to follow it in next PRs. Let me merge it now.

[GitHub] [hadoop-ozone] elek merged pull request #1444: HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage

elek merged pull request #1444: URL: https://github.com/apache/hadoop-ozone/pull/1444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop-ozone] elek commented on pull request #1298: HDDS-3869. Use different column families for datanode block and metadata

elek commented on pull request #1298: URL: https://github.com/apache/hadoop-ozone/pull/1298#issuecomment-703579758 Just another thanks here to @errose28 for the patch and to @hanishakoneru for the review. Very big patch but I think it's an important step forward.

[GitHub] [hadoop-ozone] elek merged pull request #1447: HDDS-4264. Uniform naming conventions of Ozone Shell Options.

elek merged pull request #1447: URL: https://github.com/apache/hadoop-ozone/pull/1447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop-ozone] elek commented on pull request #1272: HDDS-2660. Create insight point for datanode container protocol

elek commented on pull request #1272: URL: https://github.com/apache/hadoop-ozone/pull/1272#issuecomment-703576217 >> I checked but it's not something which can be added easily. > Thanks for checking. I'm fine with doing it as a follow-up (created HDDS-4271). You were right,

[GitHub] [hadoop-ozone] elek merged pull request #1466: HDDS-4271. Avoid logging chunk content in Ozone Insight

elek merged pull request #1466: URL: https://github.com/apache/hadoop-ozone/pull/1466 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1464: HDDS-4299. Display Ratis version with ozone version

adoroszlai commented on pull request #1464: URL: https://github.com/apache/hadoop-ozone/pull/1464#issuecomment-703572792 Thanks @elek for the contribution. This is an automated message from the Apache Git Service. To respond

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1464: HDDS-4299. Display Ratis version with ozone version

adoroszlai merged pull request #1464: URL: https://github.com/apache/hadoop-ozone/pull/1464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] elek commented on pull request #1440: HDDS-2011. Enable TestRandomKeyGenerator Test Cases.

elek commented on pull request #1440: URL: https://github.com/apache/hadoop-ozone/pull/1440#issuecomment-703571687 I agree. Better to have the slow tests in the acceptance test layer. @aryangupta1998 Can you please update the patch with removing the method?

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1451: HDDS-4117. Normalize Keypath for listKeys.

elek commented on a change in pull request #1451: URL: https://github.com/apache/hadoop-ozone/pull/1451#discussion_r499525922 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java ## @@ -919,12 +920,32 @@ private boolean

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1460: HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager

adoroszlai commented on a change in pull request #1460: URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499526330 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestReadRetries.java ## @@ -147,7 +145,8 @@ public

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1460: HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager

adoroszlai commented on a change in pull request #1460: URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499526330 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestReadRetries.java ## @@ -147,7 +145,8 @@ public

[GitHub] [hadoop-ozone] bshashikant commented on pull request #1371: HDDS-2922. Balance ratis leader distribution in datanodes

bshashikant commented on pull request #1371: URL: https://github.com/apache/hadoop-ozone/pull/1371#issuecomment-703565884 Can we also make the policy configurable? Also, one policy should also be defined for no priority at all incase, this turns out to be a performance killer.

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1460: HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager

elek commented on a change in pull request #1460: URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499454095 ## File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientFactory.java ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache

[GitHub] [hadoop-ozone] elek commented on a change in pull request #1460: HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager

elek commented on a change in pull request #1460: URL: https://github.com/apache/hadoop-ozone/pull/1460#discussion_r499453456 ## File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestReadRetries.java ## @@ -147,7 +145,8 @@ public void

[GitHub] [hadoop-ozone] elek commented on pull request #1411: HDDS-4097. [DESIGN] S3/Ozone Filesystem inter-op

elek commented on pull request #1411: URL: https://github.com/apache/hadoop-ozone/pull/1411#issuecomment-703504639 We had an offline conversation with @bharatviswa504 @arp7 Got the feedback from Arpit: the 3rd option can be useful (we had disagreement how useful it is), but it was

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

linyiqun commented on a change in pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473#discussion_r499385995 ## File path: hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/OMMetadataManager.java ## @@ -399,4 +399,15 @@ String

[GitHub] [hadoop-ozone] nandakumar131 merged pull request #1471: HDDS-4304. Close Container event can fail if pipeline is removed first

nandakumar131 merged pull request #1471: URL: https://github.com/apache/hadoop-ozone/pull/1471 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop-ozone] nandakumar131 merged pull request #1274: HDDS-3810. Add the logic to distribute open containers among the pipelines of a datanode.

nandakumar131 merged pull request #1274: URL: https://github.com/apache/hadoop-ozone/pull/1274 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [hadoop-ozone] nandakumar131 commented on pull request #1274: HDDS-3810. Add the logic to distribute open containers among the pipelines of a datanode.

nandakumar131 commented on pull request #1274: URL: https://github.com/apache/hadoop-ozone/pull/1274#issuecomment-703405601 +1, LGTM. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

avijayanhwx commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r499305029 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] avijayanhwx commented on pull request #1457: HDDS-4253. Add LayoutVersion request/response for DN registration.

avijayanhwx commented on pull request #1457: URL: https://github.com/apache/hadoop-ozone/pull/1457#issuecomment-703337194 > > ``` > > Exception in thread "main" java.net.SocketException: Socket closed > > at java.net.PlainSocketImpl.socketAccept(Native Method) > > at

[GitHub] [hadoop-ozone] rakeshadr opened a new pull request #1473: HDDS-4266: CreateFile : store parent dir entries into DirTable and file entry into separate FileTable

rakeshadr opened a new pull request #1473: URL: https://github.com/apache/hadoop-ozone/pull/1473 ## What changes were proposed in this pull request? https://issues.apache.org/jira/browse/HDDS-4266 ## What is the link to the Apache JIRA This task is to handle the

[GitHub] [hadoop-ozone] xiaoyuyao merged pull request #1446: HDDS-4274. Change the log level of the SCM Delete block to improve performance.

xiaoyuyao merged pull request #1446: URL: https://github.com/apache/hadoop-ozone/pull/1446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] xiaoyuyao opened a new pull request #1472: HDDS-4306. Ozone checkstyle rule can't be imported to IntelliJ.

xiaoyuyao opened a new pull request #1472: URL: https://github.com/apache/hadoop-ozone/pull/1472 ## What changes were proposed in this pull request? CheckStyle: Move LineLength Check parent from TreeWalker to Checker, otherwise fail to import to latest IntelliJ ## What is the

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

linyiqun commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r499129873 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

linyiqun commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r499129830 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

linyiqun commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r499129787 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

linyiqun commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r499129787 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] linyiqun commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

linyiqun commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r499129654 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] amaliujia commented on pull request #1444: HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage

amaliujia commented on pull request #1444: URL: https://github.com/apache/hadoop-ozone/pull/1444#issuecomment-702992752 @elek friendly ping~ WDYT on the idea in my previous reply? This is an automated message from the

[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

bharatviswa504 commented on a change in pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#discussion_r498972861 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMOpenKeysDeleteRequest.java ## @@ -0,0

[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1435: HDDS-4122. Implement OM Delete Expired Open Key Request and Response

bharatviswa504 commented on pull request #1435: URL: https://github.com/apache/hadoop-ozone/pull/1435#issuecomment-702871382 I will take a look at it today. Thanks, @avijayanhwx for tagging. This is an automated message

[GitHub] [hadoop-ozone] sodonnel opened a new pull request #1471: Add try catch block to handle pipeline which does not exist

sodonnel opened a new pull request #1471: URL: https://github.com/apache/hadoop-ozone/pull/1471 ## What changes were proposed in this pull request? If you call `pipelineManager.finalizeAndDestroyPipeline()` with onTimeout=false, then the finalizePipeline call will result in a

[GitHub] [hadoop-ozone] errose28 opened a new pull request #1470: HDDS-4220. BlockManagerImpl#getBlockByID does unnecessary serialization

errose28 opened a new pull request #1470: URL: https://github.com/apache/hadoop-ozone/pull/1470 ## What changes were proposed in this pull request? BlockManager#getBlockImpl now returns a BlockData object instead of a byte stream. After HDDS-3869, this object can be retrieved

[GitHub] [hadoop-ozone] fapifta commented on pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

fapifta commented on pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#issuecomment-702771988 Guys thank you for the reviews, hopefully I was able to address all the concerns mentioned so far, let me know if you see anything more, and please share your opinion

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498861508 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] adoroszlai edited a comment on pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

adoroszlai edited a comment on pull request #1453: URL: https://github.com/apache/hadoop-ozone/pull/1453#issuecomment-702728136 Thanks @elek for noticing and fixing this. It seems this was lost while resolving merge conflicts of another Insight improvement

[GitHub] [hadoop-ozone] adoroszlai merged pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

adoroszlai merged pull request #1453: URL: https://github.com/apache/hadoop-ozone/pull/1453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1453: HDDS-4290. Enable insight point for SCM heartbeat protocol

adoroszlai commented on pull request #1453: URL: https://github.com/apache/hadoop-ozone/pull/1453#issuecomment-702728136 Thanks @elek for noticing and fixing this. It seems this was lost while resolving merge conflicts

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498802254 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498774350 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498766375 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498761138 ## File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/common/StorageInfo.java ## @@ -150,6 +179,16 @@ private void

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498760977 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

[GitHub] [hadoop-ozone] fapifta commented on a change in pull request #1456: HDDS-4172. Implement Finalize command in Ozone Manager server.

fapifta commented on a change in pull request #1456: URL: https://github.com/apache/hadoop-ozone/pull/1456#discussion_r498760785 ## File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/upgrade/OMUpgradeFinalizer.java ## @@ -0,0 +1,303 @@ +/** + *

<    1   2   3   4   5   6   7   8   9   10   >