captainzmc commented on pull request #1434:
URL: https://github.com/apache/hadoop-ozone/pull/1434#issuecomment-699612552
Thanks @ChenSammi for the review. Review issues has been fixed.
This is an automated message from the Ap
captainzmc removed a comment on pull request #1434:
URL: https://github.com/apache/hadoop-ozone/pull/1434#issuecomment-698235132
Thanks for @ChenSammi ‘s review. The review issues have been fixed. Could
you help take another look?
-
timmylicheng closed pull request #1340:
URL: https://github.com/apache/hadoop-ozone/pull/1340
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
timmylicheng closed pull request #1340:
URL: https://github.com/apache/hadoop-ozone/pull/1340
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
timmylicheng commented on pull request #1346:
URL: https://github.com/apache/hadoop-ozone/pull/1346#issuecomment-699599648
Thanks @amaliujia for the contribution. The patch looks good overall. Just a
few comments inline.
Thi
timmylicheng commented on a change in pull request #1346:
URL: https://github.com/apache/hadoop-ozone/pull/1346#discussion_r495539471
##
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/MockSCMHAManager.java
##
@@ -107,6 +108,14 @@ public void shut
timmylicheng commented on a change in pull request #1346:
URL: https://github.com/apache/hadoop-ozone/pull/1346#discussion_r495538752
##
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestScmAdminHA.java
##
@@ -0,0 +1,79 @@
+/*
+ * License
captainzmc commented on a change in pull request #1434:
URL: https://github.com/apache/hadoop-ozone/pull/1434#discussion_r495538695
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
##
@@ -277,6 +277,16 @@ p
timmylicheng commented on a change in pull request #1346:
URL: https://github.com/apache/hadoop-ozone/pull/1346#discussion_r495538644
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/scm/ScmAdmin.java
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apac
timmylicheng commented on a change in pull request #1346:
URL: https://github.com/apache/hadoop-ozone/pull/1346#discussion_r495538535
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/scm/GetScmRatisStatusSubcommand.java
##
@@ -0,0 +1,46 @@
+/*
+ * L
timmylicheng commented on a change in pull request #1428:
URL: https://github.com/apache/hadoop-ozone/pull/1428#discussion_r495538313
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMRatisServerImpl.java
##
@@ -59,18 +68,62 @@
SCMRatisServ
timmylicheng commented on pull request #1340:
URL: https://github.com/apache/hadoop-ozone/pull/1340#issuecomment-699594942
> Thanks @timmylicheng for working on this. The patch LGTM overall, a few
comments added inline.
@xiaoyuyao Thanks for the reviews! I've updated the PR. Please t
timmylicheng commented on a change in pull request #1340:
URL: https://github.com/apache/hadoop-ozone/pull/1340#discussion_r495537521
##
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMProxyInfo.java
##
@@ -0,0 +1,65 @@
+/**
+ * Licensed to t
captainzmc removed a comment on pull request #1412:
URL: https://github.com/apache/hadoop-ozone/pull/1412#issuecomment-697133030
Thanks @ChenSammi for the review. Review issues has been fixed.
This is an automated message fro
captainzmc commented on pull request #1412:
URL: https://github.com/apache/hadoop-ozone/pull/1412#issuecomment-699594512
Thanks @ChenSammi for the review. Review issues has been fixed.
This is an automated message from the Ap
timmylicheng commented on a change in pull request #1340:
URL: https://github.com/apache/hadoop-ozone/pull/1340#discussion_r495537306
##
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMClientConfig.java
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed t
timmylicheng commented on a change in pull request #1340:
URL: https://github.com/apache/hadoop-ozone/pull/1340#discussion_r495537270
##
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMClientConfig.java
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed t
captainzmc closed pull request #1446:
URL: https://github.com/apache/hadoop-ozone/pull/1446
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ChenSammi commented on a change in pull request #1434:
URL: https://github.com/apache/hadoop-ozone/pull/1434#discussion_r495521898
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##
@@ -239,8 +256,7 @@ p
ChenSammi commented on a change in pull request #1434:
URL: https://github.com/apache/hadoop-ozone/pull/1434#discussion_r495521569
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
##
@@ -533,6 +533,26 @@ protected
ChenSammi commented on a change in pull request #1434:
URL: https://github.com/apache/hadoop-ozone/pull/1434#discussion_r495521253
##
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClientAbstract.java
##
@@ -707,9 +707,71
ChenSammi commented on a change in pull request #1434:
URL: https://github.com/apache/hadoop-ozone/pull/1434#discussion_r495521089
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java
##
@@ -227,6 +232,18 @@
ChenSammi commented on a change in pull request #1434:
URL: https://github.com/apache/hadoop-ozone/pull/1434#discussion_r495520762
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileCreateRequest.java
##
@@ -277,6 +277,16 @@ pu
ChenSammi commented on a change in pull request #1412:
URL: https://github.com/apache/hadoop-ozone/pull/1412#discussion_r495519238
##
File path: hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto
##
@@ -314,6 +314,8 @@ enum Status {
PARTIAL_RENAME = 65;
captainzmc commented on a change in pull request #1446:
URL: https://github.com/apache/hadoop-ozone/pull/1446#discussion_r495517233
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java
##
@@ -218,7 +218,7 @@ public vo
amaliujia commented on a change in pull request #1446:
URL: https://github.com/apache/hadoop-ozone/pull/1446#discussion_r495508443
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMBlockProtocolServer.java
##
@@ -218,7 +218,7 @@ public voi
amaliujia opened a new pull request #1449:
URL: https://github.com/apache/hadoop-ozone/pull/1449
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## What is the link to the Apache JIRA
(Please create an issue in ASF JIRA b
linyiqun opened a new pull request #1448:
URL: https://github.com/apache/hadoop-ozone/pull/1448
## What changes were proposed in this pull request?
Document notable configurations for Recon
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS
amaliujia commented on pull request #1447:
URL: https://github.com/apache/hadoop-ozone/pull/1447#issuecomment-699255649
+1 on unifying the name convention.
Though not sure which name convention is better :) Would also want to hear
suggestions from @adoroszlai
-
ChenSammi commented on pull request #1338:
URL: https://github.com/apache/hadoop-ozone/pull/1338#issuecomment-698899914
> Sorry for the slow reply on this. I have been caught up on some other
things.
>
> > After a second thought, deleting the container record in SCM DB
immediately w
captainzmc opened a new pull request #1447:
URL: https://github.com/apache/hadoop-ozone/pull/1447
## What changes were proposed in this pull request?
Current Shell command of Ozone, some use hump connection, some use '-'
connection. We need to unify the naming conventions.
See the
captainzmc commented on pull request #1447:
URL: https://github.com/apache/hadoop-ozone/pull/1447#issuecomment-698921171
Hi @adoroszlai，Could you help review this PR?
This is an automated message from the Apache Git Service.
captainzmc commented on a change in pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#discussion_r494297018
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/bucket/OMBucketDeleteResponse.java
##
@@ -64,6 +76,12
amaliujia commented on pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#issuecomment-698104826
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
adoroszlai merged pull request #1383:
URL: https://github.com/apache/hadoop-ozone/pull/1383
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
amaliujia commented on a change in pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#discussion_r494575654
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java
##
@@ -201,6 +201,8 @@
cxorm commented on pull request #1425:
URL: https://github.com/apache/hadoop-ozone/pull/1425#issuecomment-698096286
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
adoroszlai merged pull request #1272:
URL: https://github.com/apache/hadoop-ozone/pull/1272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
sodonnel commented on a change in pull request #1338:
URL: https://github.com/apache/hadoop-ozone/pull/1338#discussion_r494180772
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/AbstractContainerReportHandler.java
##
@@ -96,13 +101,24 @@
bshashikant merged pull request #1442:
URL: https://github.com/apache/hadoop-ozone/pull/1442
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
captainzmc commented on pull request #1412:
URL: https://github.com/apache/hadoop-ozone/pull/1412#issuecomment-698132943
Hi all, status updates: rebase PR and resolve conflicts. This PR can be
reviewed again.
This is an aut
adoroszlai merged pull request #1443:
URL: https://github.com/apache/hadoop-ozone/pull/1443
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
elek commented on a change in pull request #1443:
URL: https://github.com/apache/hadoop-ozone/pull/1443#discussion_r494239916
##
File path: dev-support/byteman/watchforcommit_all.btm
##
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# co
captainzmc commented on pull request #1434:
URL: https://github.com/apache/hadoop-ozone/pull/1434#issuecomment-698235132
Thanks for @ChenSammi ‘s review. The review issues have been fixed. Could
you help take another look?
cxorm commented on pull request #1412:
URL: https://github.com/apache/hadoop-ozone/pull/1412#issuecomment-698094498
Thanks @captainzmc for the work.
Would you please rebase this PR ?
I would take a look on it.
This
adoroszlai commented on pull request #1443:
URL: https://github.com/apache/hadoop-ozone/pull/1443#issuecomment-698385899
Thanks @elek for updating the patch.
This is an automated message from the Apache Git Service.
To respon
cxorm commented on a change in pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#discussion_r494095636
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmVolumeArgs.java
##
@@ -68,15 +69,16 @@
"builder."})
pri
sodonnel commented on pull request #1338:
URL: https://github.com/apache/hadoop-ozone/pull/1338#issuecomment-698259315
Sorry for the slow reply on this. I have been caught up on some other things.
> After a second thought, deleting the container record in SCM DB
immediately while kee
hanishakoneru commented on pull request #1298:
URL: https://github.com/apache/hadoop-ozone/pull/1298#issuecomment-698555281
@errose28, the unit test failures seem to be related to the patch. Can you
please check.
This is an
ChenSammi commented on pull request #1338:
URL: https://github.com/apache/hadoop-ozone/pull/1338#issuecomment-698899914
> Sorry for the slow reply on this. I have been caught up on some other
things.
>
> > After a second thought, deleting the container record in SCM DB
immediately w
captainzmc opened a new pull request #1446:
URL: https://github.com/apache/hadoop-ozone/pull/1446
## What changes were proposed in this pull request?
There are scenarios in which the DELETE operation is very frequent. Now that
info level logs in SCM are affecting performance, we shou
amaliujia commented on pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#issuecomment-698558307
Thanks @cxorm and @captainzmc
comments are addressed.
Also created https://issues.apache.org/jira/browse/HDDS-4273 to track the
work that make `usedNamespa
amaliujia commented on a change in pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#discussion_r494576276
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmVolumeArgs.java
##
@@ -68,15 +69,16 @@
"builder."})
amaliujia commented on a change in pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#discussion_r494575654
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java
##
@@ -201,6 +201,8 @@
amaliujia commented on a change in pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#discussion_r494575930
##
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConsts.java
##
@@ -270,6 +270,7 @@ private OzoneConsts() {
public s
hanishakoneru commented on pull request #1298:
URL: https://github.com/apache/hadoop-ozone/pull/1298#issuecomment-698555281
@errose28, the unit test failures seem to be related to the patch. Can you
please check.
This is an
adoroszlai merged pull request #1383:
URL: https://github.com/apache/hadoop-ozone/pull/1383
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
adoroszlai commented on pull request #1443:
URL: https://github.com/apache/hadoop-ozone/pull/1443#issuecomment-698385899
Thanks @elek for updating the patch.
This is an automated message from the Apache Git Service.
To respon
adoroszlai merged pull request #1443:
URL: https://github.com/apache/hadoop-ozone/pull/1443
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
captainzmc commented on a change in pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#discussion_r494297018
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/bucket/OMBucketDeleteResponse.java
##
@@ -64,6 +76,12
elek commented on a change in pull request #1443:
URL: https://github.com/apache/hadoop-ozone/pull/1443#discussion_r494239916
##
File path: dev-support/byteman/watchforcommit_all.btm
##
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# co
adoroszlai merged pull request #1272:
URL: https://github.com/apache/hadoop-ozone/pull/1272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
bshashikant merged pull request #1442:
URL: https://github.com/apache/hadoop-ozone/pull/1442
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
sodonnel commented on pull request #1338:
URL: https://github.com/apache/hadoop-ozone/pull/1338#issuecomment-698259315
Sorry for the slow reply on this. I have been caught up on some other things.
> After a second thought, deleting the container record in SCM DB
immediately while kee
cxorm commented on a change in pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#discussion_r494095636
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmVolumeArgs.java
##
@@ -68,15 +69,16 @@
"builder."})
pri
sodonnel commented on a change in pull request #1338:
URL: https://github.com/apache/hadoop-ozone/pull/1338#discussion_r494180772
##
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/AbstractContainerReportHandler.java
##
@@ -96,13 +101,24 @@
captainzmc commented on pull request #1434:
URL: https://github.com/apache/hadoop-ozone/pull/1434#issuecomment-698235132
Thanks for @ChenSammi ‘s review. The review issues have been fixed. Could
you help take another look?
captainzmc commented on pull request #1412:
URL: https://github.com/apache/hadoop-ozone/pull/1412#issuecomment-698132943
Hi all, status updates: rebase PR and resolve conflicts. This PR can be
reviewed again.
This is an aut
amaliujia commented on pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445#issuecomment-698104826
R: @cxorm @ChenSammi @captainzmc
Can you take a look please?
This is an automated message from th
amaliujia opened a new pull request #1445:
URL: https://github.com/apache/hadoop-ozone/pull/1445
## What changes were proposed in this pull request?
Volume namespace: add usedNamespace and update it when create and delete
bucket
## What is the link to the Apache JIRA
ht
cxorm commented on pull request #1425:
URL: https://github.com/apache/hadoop-ozone/pull/1425#issuecomment-698097298
The work looks great to me.
A little question is about the title of the issue,
I think the title is too general, could we change it to address the fix of
this PR ?
cxorm commented on pull request #1425:
URL: https://github.com/apache/hadoop-ozone/pull/1425#issuecomment-698096286
>In a larger perspective, would it make sense to enhance checkstyle rules to
warn for this kind of spacing?
Yeah, thanks for the feedback, we could discuss about the id
cxorm commented on pull request #1412:
URL: https://github.com/apache/hadoop-ozone/pull/1412#issuecomment-698094498
Thanks @captainzmc for the work.
Would you please rebase this PR ?
I would take a look on it.
This
amaliujia commented on a change in pull request #1444:
URL: https://github.com/apache/hadoop-ozone/pull/1444#discussion_r493976795
##
File path:
hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/helpers/OzoneAclStorage.java
##
@@ -0,0 +1,63 @@
+/**
+ * Li
amaliujia edited a comment on pull request #1444:
URL: https://github.com/apache/hadoop-ozone/pull/1444#issuecomment-697997438
R @elek
Only migrating `PrefixInfo` because I want to see whether my current
approach makes sense (e.g. move some classes to `interface-storage` meanwhile
amaliujia commented on pull request #1444:
URL: https://github.com/apache/hadoop-ozone/pull/1444#issuecomment-697997438
R @elek
This is an automated message from the Apache Git Service.
To respond to the message, please log
amaliujia opened a new pull request #1444:
URL: https://github.com/apache/hadoop-ozone/pull/1444
## What changes were proposed in this pull request?
As a following effort, try to move `PrefixInfo` and other necessary classes
to `interface-stroage`
## What is the link to the A
hanishakoneru commented on pull request #1298:
URL: https://github.com/apache/hadoop-ozone/pull/1298#issuecomment-697956338
@errose28, great work on this Jira.
+1 for merge pending CI.
This is an automated message from the
adoroszlai commented on a change in pull request #1443:
URL: https://github.com/apache/hadoop-ozone/pull/1443#discussion_r493694568
##
File path: dev-support/byteman/ratis-flush.btm
##
@@ -0,0 +1,35 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# con
amaliujia commented on pull request #1424:
URL: https://github.com/apache/hadoop-ozone/pull/1424#issuecomment-697702757
@elek thank you for your review!
This is an automated message from the Apache Git Service.
To respond to
avijayanhwx commented on a change in pull request #1430:
URL: https://github.com/apache/hadoop-ozone/pull/1430#discussion_r493728718
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
##
@@ -246,4 +246,9 @@ private OMConfigKeys() {
elek commented on pull request #1319:
URL: https://github.com/apache/hadoop-ozone/pull/1319#issuecomment-697593857
(Sorry, late answer)
Why do we need to updated container files? I see no problems to keep (the
valid) clusterId in the container metadata files.
Or do you need t
elek commented on pull request #1083:
URL: https://github.com/apache/hadoop-ozone/pull/1083#issuecomment-697590296
@bharatviswa504 @avijayanhwx Are you fine with this approach?
Command won't be visible unless you put a magic file to the right place
(META-INF/services). It's a hidden
elek merged pull request #1417:
URL: https://github.com/apache/hadoop-ozone/pull/1417
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
elek merged pull request #1424:
URL: https://github.com/apache/hadoop-ozone/pull/1424
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ChenSammi commented on pull request #1431:
URL: https://github.com/apache/hadoop-ozone/pull/1431#issuecomment-697328180
LGTM, +1.
This is an automated message from the Apache Git Service.
To respond to the message, please l
ChenSammi merged pull request #1431:
URL: https://github.com/apache/hadoop-ozone/pull/1431
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
adoroszlai edited a comment on pull request #1272:
URL: https://github.com/apache/hadoop-ozone/pull/1272#issuecomment-697321399
> > I think we should avoid logging chunk content.
ContainerCommandRequestMessage implements related logic to clear data.
>
> I checked but it's not somethi
adoroszlai commented on pull request #1272:
URL: https://github.com/apache/hadoop-ozone/pull/1272#issuecomment-697321399
> > I think we should avoid logging chunk content.
ContainerCommandRequestMessage implements related logic to clear data.
>
> I checked but it's not something whic
elek opened a new pull request #1443:
URL: https://github.com/apache/hadoop-ozone/pull/1443
I am using https://byteman.jboss.org to debug the performance of spark +
teragen with different scripts. Some byteman scripts are already shared by
HDDS-4095 or HDDS-342 but it seems to be a goo
elek commented on a change in pull request #1383:
URL: https://github.com/apache/hadoop-ozone/pull/1383#discussion_r493498810
##
File path: hadoop-ozone/dist/src/main/smoketest/s3/s3_compatbility_check.sh
##
@@ -0,0 +1,47 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Softwa
elek commented on a change in pull request #1383:
URL: https://github.com/apache/hadoop-ozone/pull/1383#discussion_r493495525
##
File path: hadoop-ozone/dist/src/main/smoketest/s3/s3_compatbility_check.sh
##
@@ -0,0 +1,47 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Softwa
elek commented on pull request #1272:
URL: https://github.com/apache/hadoop-ozone/pull/1272#issuecomment-697312216
> I think we should avoid logging chunk content.
ContainerCommandRequestMessage implements related logic to clear data.
I checked but it's not something which can be add
linyiqun commented on a change in pull request #1430:
URL: https://github.com/apache/hadoop-ozone/pull/1430#discussion_r493463257
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java
##
@@ -246,4 +246,9 @@ private OMConfigKeys() {
cku328 removed a comment on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-697277442
Overall LGTM. Thanks @flirmnave for working on this.
This PR will make the Chinese docs more friendly.
---
cku328 commented on pull request #1368:
URL: https://github.com/apache/hadoop-ozone/pull/1368#issuecomment-697277442
Overall LGTM. Thanks @flirmnave for working on this.
This PR will make the Chinese docs more friendly.
Th
llemec commented on pull request #1425:
URL: https://github.com/apache/hadoop-ozone/pull/1425#issuecomment-697250771
Hello @cxorm,
Thank you for your review. I corrected the coding style as suggested. In a
larger perspective, would it make sense to enhance checkstyle rules to warn fo
llemec commented on a change in pull request #1425:
URL: https://github.com/apache/hadoop-ozone/pull/1425#discussion_r493369935
##
File path:
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/helpers/TestInstanceHelper.java
##
@@ -0,0 +1,67 @@
+/**
+ * Licensed to t
llemec commented on a change in pull request #1425:
URL: https://github.com/apache/hadoop-ozone/pull/1425#discussion_r493369544
##
File path:
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/om/helpers/TestInstanceHelper.java
##
@@ -0,0 +1,67 @@
+/**
+ * Licensed to t
maobaolong commented on pull request #1438:
URL: https://github.com/apache/hadoop-ozone/pull/1438#issuecomment-697206664
Hi @nandakumar131 , thanks for the first review and suggestion, I agree to
you that we should not remove the OriginDatanodeId handling blindly, now I add
a condition for
801 - 900 of 12474 matches
Mail list logo
