[GitHub] [hadoop-ozone] elek commented on pull request #1028: HDDS-3735. Improve SCM performance with 3.7% by remove unnecessary lock and unlock

elek commented on pull request #1028: URL: https://github.com/apache/hadoop-ozone/pull/1028#issuecomment-659297555 > @elek I think this case can not be avoided by only add read lock Agree. It seems to be necessary. But it means that we can't remove the lock in the ContainerStateMap

[GitHub] [hadoop-ozone] elek commented on pull request #1028: HDDS-3735. Improve SCM performance with 3.7% by remove unnecessary lock and unlock

elek commented on pull request #1028: URL: https://github.com/apache/hadoop-ozone/pull/1028#issuecomment-651659061 It's not just about the `updateState` method, but (for example) the `removeContainer` method. Without write lock the container might be removed from `ownerMap` and not

[GitHub] [hadoop-ozone] elek commented on pull request #1028: HDDS-3735. Improve SCM performance with 3.7% by remove unnecessary lock and unlock

elek commented on pull request #1028: URL: https://github.com/apache/hadoop-ozone/pull/1028#issuecomment-647466786 Actually I am not sure about the other part. Using read / write locks in the `ContainerStateMap` provides a consistent view. Read calls can see any containers only if