[GitHub] [hadoop-ozone] fapifta commented on issue #704: HDDS-3248. shutdown defaultMetricsSystem before tests

2020-03-24 Thread GitBox
fapifta commented on issue #704: HDDS-3248. shutdown defaultMetricsSystem before tests URL: https://github.com/apache/hadoop-ozone/pull/704#issuecomment-603316983 The changeset this way looks good to me, thank you for addressing the concerns, if it runs fine I am +1 on it (non-binding) --

[GitHub] [hadoop-ozone] fapifta commented on issue #704: HDDS-3248. shutdown defaultMetricsSystem before tests

2020-03-24 Thread GitBox
fapifta commented on issue #704: HDDS-3248. shutdown defaultMetricsSystem before tests URL: https://github.com/apache/hadoop-ozone/pull/704#issuecomment-603298533 Thank you for the follow up, and addressing my concern, I have added a few inline comments, can you please check to the questio

[GitHub] [hadoop-ozone] fapifta commented on issue #704: HDDS-3248. shutdown defaultMetricsSystem before tests

2020-03-23 Thread GitBox
fapifta commented on issue #704: HDDS-3248. shutdown defaultMetricsSystem before tests URL: https://github.com/apache/hadoop-ozone/pull/704#issuecomment-602771057 Thank you for figuring this out, and posting a JIRA about it. As in #705 I disagree with how the solution is implemented.