[GitHub] [hadoop-ozone] fapifta commented on pull request #1291: HDDS-4062. Non rack aware pipelines should not be created if multiple racks are alive

2020-08-14 Thread GitBox
fapifta commented on pull request #1291: URL: https://github.com/apache/hadoop-ozone/pull/1291#issuecomment-674022839 Hi @sodonnel, thank you for addressing the test related ideas, and for the contribution. The changes look good to me +1 (non-binding). -

[GitHub] [hadoop-ozone] fapifta commented on pull request #1291: HDDS-4062. Non rack aware pipelines should not be created if multiple racks are alive

2020-08-12 Thread GitBox
fapifta commented on pull request #1291: URL: https://github.com/apache/hadoop-ozone/pull/1291#issuecomment-673155132 Hi @sodonnel, the changeset looks good to me, I am +1 on committing it, though it is non-binding :) There is one thing I would change, but as this implementati