[GitHub] [hadoop-ozone] maobaolong commented on pull request #927: HDDS-3597. using protobuf maven plugin instead of the legacy protoc executable file

2020-05-21 Thread GitBox
maobaolong commented on pull request #927: URL: https://github.com/apache/hadoop-ozone/pull/927#issuecomment-632417425 @adoroszlai Oh, really? its surprising me. This is an automated message from the Apache Git Service. To re

[GitHub] [hadoop-ozone] maobaolong commented on pull request #927: HDDS-3597. using protobuf maven plugin instead of the legacy protoc executable file

2020-05-20 Thread GitBox
maobaolong commented on pull request #927: URL: https://github.com/apache/hadoop-ozone/pull/927#issuecomment-631913631 Hi @elek Is there something should i do else? Would you like to help me to merge this PR? This is an auto

[GitHub] [hadoop-ozone] maobaolong commented on pull request #927: HDDS-3597. using protobuf maven plugin instead of the legacy protoc executable file

2020-05-19 Thread GitBox
maobaolong commented on pull request #927: URL: https://github.com/apache/hadoop-ozone/pull/927#issuecomment-630772607 @elek I've resolved the conflicts, PTAL This is an automated message from the Apache Git Service. To respo

[GitHub] [hadoop-ozone] maobaolong commented on pull request #927: HDDS-3597. using protobuf maven plugin instead of the legacy protoc executable file

2020-05-18 Thread GitBox
maobaolong commented on pull request #927: URL: https://github.com/apache/hadoop-ozone/pull/927#issuecomment-630529069 @elek Updated the `CONTRIBUTING.md` now, Bye bye `protoc 2.5`, thanks for your review. This is an automat

[GitHub] [hadoop-ozone] maobaolong commented on pull request #927: HDDS-3597. using protobuf maven plugin instead of the legacy protoc executable file

2020-05-16 Thread GitBox
maobaolong commented on pull request #927: URL: https://github.com/apache/hadoop-ozone/pull/927#issuecomment-629654034 @mukul1987 Thanks for your comments, i have addressed all your comments, PTAL. This is an automated messa

[GitHub] [hadoop-ozone] maobaolong commented on pull request #927: HDDS-3597. using protobuf maven plugin instead of the legacy protoc executable file

2020-05-15 Thread GitBox
maobaolong commented on pull request #927: URL: https://github.com/apache/hadoop-ozone/pull/927#issuecomment-629553291 @elek Would you like to take a look at this PR?This is a improvement what i aways want to do. This is an