[GitHub] [hadoop-ozone] maobaolong commented on pull request #991: HDDS-3686. Insert an argument of ozone shell to accept jvm arguments

2020-06-09 Thread GitBox
maobaolong commented on pull request #991: URL: https://github.com/apache/hadoop-ozone/pull/991#issuecomment-641246806 @sodonnel Thanks for your review This is an automated message from the Apache Git Service. To respond to

[GitHub] [hadoop-ozone] maobaolong commented on pull request #991: HDDS-3686. Insert an argument of ozone shell to accept jvm arguments

2020-06-05 Thread GitBox
maobaolong commented on pull request #991: URL: https://github.com/apache/hadoop-ozone/pull/991#issuecomment-639658042 @sodonnel Sorry for the mistake, BTW, i change the "jvm arguments" to "arguments", i think it would be better if there is only one word here, two word maybe make people

[GitHub] [hadoop-ozone] maobaolong commented on pull request #991: HDDS-3686. Insert an argument of ozone shell to accept jvm arguments

2020-06-04 Thread GitBox
maobaolong commented on pull request #991: URL: https://github.com/apache/hadoop-ozone/pull/991#issuecomment-638823568 @sodonnel Thank you for your review again, i push a new commit to address your comment. PTAL This is an

[GitHub] [hadoop-ozone] maobaolong commented on pull request #991: HDDS-3686. Insert an argument of ozone shell to accept jvm arguments

2020-06-03 Thread GitBox
maobaolong commented on pull request #991: URL: https://github.com/apache/hadoop-ozone/pull/991#issuecomment-638320257 @sodonnel Thank you for your suggestion, i push a new commit to address it, PTAL. This is an automated

[GitHub] [hadoop-ozone] maobaolong commented on pull request #991: HDDS-3686. Insert an argument of ozone shell to accept jvm arguments

2020-06-01 Thread GitBox
maobaolong commented on pull request #991: URL: https://github.com/apache/hadoop-ozone/pull/991#issuecomment-636979218 @sodonnel Thank you for your review. > With your change, does this command append to existing HADOOP_OPTS or overwrite any existing arguments set by HADOOP_OPTS?

[GitHub] [hadoop-ozone] maobaolong commented on pull request #991: HDDS-3686. Insert an argument of ozone shell to accept jvm arguments

2020-06-01 Thread GitBox
maobaolong commented on pull request #991: URL: https://github.com/apache/hadoop-ozone/pull/991#issuecomment-636890274 @sodonnel Thank you for telling this. In fact i used to use HADOOP_OPTS and HADOOP_CLIENT_OPTS to achieve my debug purpose, but it hard to support me to write the