[GitHub] [hadoop-ozone] mukul1987 commented on pull request #924: HDDS-3595. Add a maven proto file backward compatibility checker in Ozone.

2020-05-18 Thread GitBox
mukul1987 commented on pull request #924: URL: https://github.com/apache/hadoop-ozone/pull/924#issuecomment-630301975 @elek, can you please have another look at this change ? This is an automated message from the Apache Git S

[GitHub] [hadoop-ozone] mukul1987 commented on pull request #924: HDDS-3595. Add a maven proto file backward compatibility checker in Ozone.

2020-05-18 Thread GitBox
mukul1987 commented on pull request #924: URL: https://github.com/apache/hadoop-ozone/pull/924#issuecomment-630301738 Do we need to check the backward compatibility for RPC or just for the persisted data? If only for the persisted data, it would be more useful to separated the two RPC set.

[GitHub] [hadoop-ozone] mukul1987 commented on pull request #924: HDDS-3595. Add a maven proto file backward compatibility checker in Ozone.

2020-05-18 Thread GitBox
mukul1987 commented on pull request #924: URL: https://github.com/apache/hadoop-ozone/pull/924#issuecomment-630295146 @adoroszlai , Thanks for the review. Have addressed the comments in the followup patch. This is an automat

[GitHub] [hadoop-ozone] mukul1987 commented on pull request #924: HDDS-3595. Add a maven proto file backward compatibility checker in Ozone.

2020-05-15 Thread GitBox
mukul1987 commented on pull request #924: URL: https://github.com/apache/hadoop-ozone/pull/924#issuecomment-629252681 I found the plugin to be useful to detect backward compatibility issues. However I still am not completely sure about LICENSE and checkstyle and other related issue.