rakeshadr commented on pull request #1404:
URL: https://github.com/apache/hadoop-ozone/pull/1404#issuecomment-702608629
Thank you @bharatviswa504 and @linyiqun for help in reviews and provided
really useful comments.
rakeshadr commented on pull request #1404:
URL: https://github.com/apache/hadoop-ozone/pull/1404#issuecomment-700860595
Thanks again @bharatviswa504 for the comments. Uploaded patch addressing
the comments. Please let me know the feedback!
rakeshadr commented on pull request #1404:
URL: https://github.com/apache/hadoop-ozone/pull/1404#issuecomment-696143619
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rakeshadr commented on pull request #1404:
URL: https://github.com/apache/hadoop-ozone/pull/1404#issuecomment-696275956
I've updated another patch addressing @bharatviswa504's comments.
This is an automated message from the
rakeshadr commented on pull request #1404:
URL: https://github.com/apache/hadoop-ozone/pull/1404#issuecomment-696247887
> As any way we are testing at UT, we can add the entries to KeyTable and
implement/simulate these tests. (Similar to Old Requests)
Sure, will do that way.
rakeshadr commented on pull request #1404:
URL: https://github.com/apache/hadoop-ozone/pull/1404#issuecomment-696245686
Thanks a lot @bharatviswa504 for the useful review comments and your time.
I will upstream next commit.
rakeshadr commented on pull request #1404:
URL: https://github.com/apache/hadoop-ozone/pull/1404#issuecomment-696143619
> I see we used layOutVersion and tested the change. But this might cause
failures to other test like when key and directory with same name, as we have
not used new
rakeshadr commented on pull request #1404:
URL: https://github.com/apache/hadoop-ozone/pull/1404#issuecomment-689493252
> With new layout version added, the latest PR logic looks more clear and
independent.
> I just left my minor comments. I am thinking one next part of work is
delete
