[GitHub] [hadoop-ozone] runzhiwang edited a comment on pull request #1028: HDDS-3735. Improve SCM performance with 3.7% by remove unnecessary lock and unlock

runzhiwang edited a comment on pull request #1028: URL: https://github.com/apache/hadoop-ozone/pull/1028#issuecomment-647830265 @elek Thanks for review. You are right, if the write code like following, maybe after `currentInfo.setState(newState)` and before `currentInfo.setOwner(owner)`,

[GitHub] [hadoop-ozone] runzhiwang edited a comment on pull request #1028: HDDS-3735. Improve SCM performance with 3.7% by remove unnecessary lock and unlock

runzhiwang edited a comment on pull request #1028: URL: https://github.com/apache/hadoop-ozone/pull/1028#issuecomment-647830265 @elek Thanks for review. You are right, if the write code like following, maybe after `currentInfo.setState(newState)` and before `currentInfo.setOwner(owner)`,

[GitHub] [hadoop-ozone] runzhiwang edited a comment on pull request #1028: HDDS-3735. Improve SCM performance with 3.7% by remove unnecessary lock and unlock

runzhiwang edited a comment on pull request #1028: URL: https://github.com/apache/hadoop-ozone/pull/1028#issuecomment-647830265 @elek Thanks for review. You are right, if the write code like following, maybe after `currentInfo.setState(newState)` and before `currentInfo.setOwner(owner)`,

[GitHub] [hadoop-ozone] runzhiwang edited a comment on pull request #1028: HDDS-3735. Improve SCM performance with 3.7% by remove unnecessary lock and unlock

runzhiwang edited a comment on pull request #1028: URL: https://github.com/apache/hadoop-ozone/pull/1028#issuecomment-651703240 > Without write lock the container might be removed from ownerMap and not from the typeMap, which can cause inconsistency. @elek I think this case can not b