[GitHub] [hadoop-ozone] sodonnel commented on issue #668: HDDS-3139. Pipeline placement should max out pipeline usage

2020-04-21 Thread GitBox
sodonnel commented on issue #668: URL: https://github.com/apache/hadoop-ozone/pull/668#issuecomment-617114038 @timmylicheng Thanks for the update and the Jira. Unfortunately Github is now reporting conflicts, possibly due to HDDS-3101 which was merged. Could you resolve the conflicts and p

[GitHub] [hadoop-ozone] sodonnel commented on issue #668: HDDS-3139. Pipeline placement should max out pipeline usage

2020-04-20 Thread GitBox
sodonnel commented on issue #668: URL: https://github.com/apache/hadoop-ozone/pull/668#issuecomment-616706028 With the second look @fapifta gave this, I am +1 to commit. We just need to do two more things: 1. Create a Jira with my benchmark results and some of the details from my co

[GitHub] [hadoop-ozone] sodonnel commented on issue #668: HDDS-3139. Pipeline placement should max out pipeline usage

2020-04-20 Thread GitBox
sodonnel commented on issue #668: URL: https://github.com/apache/hadoop-ozone/pull/668#issuecomment-616555768 I am a little concerned about the expense of forming the list of healthy nodes on large clusters. We have to do quite a lot of work to form a list and then only use 3 nodes from th

[GitHub] [hadoop-ozone] sodonnel commented on issue #668: HDDS-3139. Pipeline placement should max out pipeline usage

2020-04-14 Thread GitBox
sodonnel commented on issue #668: HDDS-3139. Pipeline placement should max out pipeline usage URL: https://github.com/apache/hadoop-ozone/pull/668#issuecomment-613407726 I think this looks better and I have just a few minor comments. I added a few inline plus these two: At line 243:

[GitHub] [hadoop-ozone] sodonnel commented on issue #668: HDDS-3139. Pipeline placement should max out pipeline usage

2020-04-10 Thread GitBox
sodonnel commented on issue #668: HDDS-3139. Pipeline placement should max out pipeline usage URL: https://github.com/apache/hadoop-ozone/pull/668#issuecomment-611950545 Thanks for the update. Its a holiday weekend here in Europe, so it will probably be Tuesday before I get to look at this

[GitHub] [hadoop-ozone] sodonnel commented on issue #668: HDDS-3139 Pipeline placement should max out pipeline usage

2020-04-01 Thread GitBox
sodonnel commented on issue #668: HDDS-3139 Pipeline placement should max out pipeline usage URL: https://github.com/apache/hadoop-ozone/pull/668#issuecomment-607397167 [example.txt](https://github.com/apache/hadoop-ozone/files/4416772/example.txt)

[GitHub] [hadoop-ozone] sodonnel commented on issue #668: HDDS-3139 Pipeline placement should max out pipeline usage

2020-04-01 Thread GitBox
sodonnel commented on issue #668: HDDS-3139 Pipeline placement should max out pipeline usage URL: https://github.com/apache/hadoop-ozone/pull/668#issuecomment-607396397 @timmylicheng I did some more experimenting and I have attached a patch file that should apply on your latest PR. In this

[GitHub] [hadoop-ozone] sodonnel commented on issue #668: HDDS-3139 Pipeline placement should max out pipeline usage

2020-04-01 Thread GitBox
sodonnel commented on issue #668: HDDS-3139 Pipeline placement should max out pipeline usage URL: https://github.com/apache/hadoop-ozone/pull/668#issuecomment-607342420 > @sodonnel I rebase the code with minor conflicts in test class, but the test won't pass. I took a close look and made s

[GitHub] [hadoop-ozone] sodonnel commented on issue #668: HDDS-3139 Pipeline placement should max out pipeline usage

2020-03-30 Thread GitBox
sodonnel commented on issue #668: HDDS-3139 Pipeline placement should max out pipeline usage URL: https://github.com/apache/hadoop-ozone/pull/668#issuecomment-605964160 Hi @timmylicheng this patch is giving some conflicts now, probably as we merged the other pipeline related change. Could