[GitHub] [hadoop-ozone] swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time.

2020-04-01 Thread GitBox
swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time. URL: https://github.com/apache/hadoop-ozone/pull/718#issuecomment-607503154 > OM bucket generator fails even in single OM environment: > > ``` > Freon OM Bucket Generator

[GitHub] [hadoop-ozone] swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time.

2020-04-01 Thread GitBox
swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time. URL: https://github.com/apache/hadoop-ozone/pull/718#issuecomment-607420879 > HDDS-2934 I am actually getting this failure on -

[GitHub] [hadoop-ozone] swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time.

2020-04-01 Thread GitBox
swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time. URL: https://github.com/apache/hadoop-ozone/pull/718#issuecomment-607397247 > Changes look good @swagle, however, there are multiple acceptance test failures for OM HA and Freon. Could you please

[GitHub] [hadoop-ozone] swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time.

2020-03-31 Thread GitBox
swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time. URL: https://github.com/apache/hadoop-ozone/pull/718#issuecomment-606749174 @ChenSammi wanted to get your input on above, thanks.

[GitHub] [hadoop-ozone] swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time.

2020-03-30 Thread GitBox
swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time. URL: https://github.com/apache/hadoop-ozone/pull/718#issuecomment-606121259 > > @swagle, thanks for working on the fix. I tried the patch locally with non-HA OM. A volume with name "11" still can

[GitHub] [hadoop-ozone] swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time.

2020-03-30 Thread GitBox
swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time. URL: https://github.com/apache/hadoop-ozone/pull/718#issuecomment-606100247 > @swagle, thanks for working on the fix. I tried the patch locally with non-HA OM. A volume with name "11" still can b

[GitHub] [hadoop-ozone] swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time.

2020-03-26 Thread GitBox
swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time. URL: https://github.com/apache/hadoop-ozone/pull/718#issuecomment-604776938 S3BucketCreateRequest checked for length but the verifyResourceName is more comprehensive. We are still doing length

[GitHub] [hadoop-ozone] swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time.

2020-03-25 Thread GitBox
swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time. URL: https://github.com/apache/hadoop-ozone/pull/718#issuecomment-604141630 > > > I have a few comments. > > > > > > Thanks, Bharat for your comments. I will make those changes requeste

[GitHub] [hadoop-ozone] swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time.

2020-03-24 Thread GitBox
swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time. URL: https://github.com/apache/hadoop-ozone/pull/718#issuecomment-603574378 > I have a few comments. Thanks, Bharat for your comments. I will make those changes requested but one point, li

[GitHub] [hadoop-ozone] swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time.

2020-03-24 Thread GitBox
swagle commented on issue #718: HDDS-3224. Enforce volume and bucket name rule at create time. URL: https://github.com/apache/hadoop-ozone/pull/718#issuecomment-603509830 cc: @ChenSammi / @bharatviswa504 for review. This is a