https://bugzilla.redhat.com/show_bug.cgi?id=1655284
Alain V. changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1581240
Alain V. changed:
What|Removed |Added
Status|POST|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1672047
--- Comment #4 from Antonio Trande ---
Spec URL: https://sagitter.fedorapeople.org/smoldyn/smoldyn.spec
SRPM URL: https://sagitter.fedorapeople.org/smoldyn/smoldyn-2.56-1.fc29.src.rpm
- Unbundle zlib, boost and BioNetGen
- Remove unused
https://bugzilla.redhat.com/show_bug.cgi?id=1649059
--- Comment #2 from Ankur Sinha (FranciscoD) ---
Looks good. Only, the spec (and the srpm) do not match the package name and
this needs to be corrected.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?]
https://bugzilla.redhat.com/show_bug.cgi?id=1671571
--- Comment #3 from Justin W. Flory ---
Hi Dridi, thanks for the feedback. I pushed a new commit [1] to my RPM spec
based on your feedback.
(In reply to Dridi Boukelmoune from comment #1)
> I can't sponsor you, but I will do the formal
https://bugzilla.redhat.com/show_bug.cgi?id=1645723
--- Comment #9 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/slack-cleaner
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1649059
--- Comment #1 from Ankur Sinha (FranciscoD) ---
Sorry for the delay. Looking at this now. I expect the name of the package in
the bug needs to be changed to match the spec file to begin with?
--
You are receiving this mail because:
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1645723
--- Comment #8 from Raphael Groner ---
Thanks for the review!
[builder@builder29]~% fedpkg request-repo slack-cleaner 1645723
https://pagure.io/releng/fedora-scm-requests/issue/9575
[builder@builder29]~% fedpkg request-branch --repo
https://bugzilla.redhat.com/show_bug.cgi?id=1658199
--- Comment #22 from Andrew Bauer ---
rpmlint seems okay (nothing new):
$ rpmlint *.rpm
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/afpd
netatalk.x86_64: E: missing-call-to-setgroups-before-setuid /usr/sbin/cnid_dbd
https://bugzilla.redhat.com/show_bug.cgi?id=1658199
--- Comment #21 from Andrew Bauer ---
Made the following changes:
- updated source url to use https
- buildrequires perl-generators
- (re)added epoch to devel subpackage requires
- use %make_build instead of make
- added Requires:
https://bugzilla.redhat.com/show_bug.cgi?id=1672047
--- Comment #3 from Antonio Trande ---
(In reply to Ankur Sinha (FranciscoD) from comment #2)
> Looks pretty good, but a few issues with bundling and enabling features.
>
> Package Review
> ==
>
> Legend:
> [x] = Pass, [!] =
https://bugzilla.redhat.com/show_bug.cgi?id=1672047
--- Comment #2 from Ankur Sinha (FranciscoD) ---
Looks pretty good, but a few issues with bundling and enabling features.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual
https://bugzilla.redhat.com/show_bug.cgi?id=1672047
Ankur Sinha (FranciscoD) changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1671571
--- Comment #2 from Dridi Boukelmoune ---
Also don't bother with %epoch unless one day upstream breaks the upgrade path.
See the guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1671571
Dridi Boukelmoune changed:
What|Removed |Added
CC||dridi.boukelmo...@gmail.com
---
https://bugzilla.redhat.com/show_bug.cgi?id=1672047
Antonio Trande changed:
What|Removed |Added
Blocks||1276941 (fedora-neuro)
Referenced
https://bugzilla.redhat.com/show_bug.cgi?id=1672047
Bug ID: 1672047
Summary: Review Request: smoldyn - A particle-based spatial
stochastic simulator
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1672032
Bug ID: 1672032
Summary: Review Request: rust-serde_stacker - Serde adapter
that avoids stack overflow by dynamically growing the
stack
Product: Fedora
Version:
https://bugzilla.redhat.com/show_bug.cgi?id=1672030
Bug ID: 1672030
Summary: Review Request: rust-stacker - Stack growth library
useful when implementing deeply recursive algorithms
Product: Fedora
Version: rawhide
https://bugzilla.redhat.com/show_bug.cgi?id=1671787
Miro Hrončok changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1671885
Fedora Update System changed:
What|Removed |Added
Status|NEW |MODIFIED
--- Comment #6 from
21 matches
Mail list logo
