https://bugzilla.redhat.com/show_bug.cgi?id=2084340
Tomas Hrcka changed:
What|Removed |Added
CC||package-review@lists.fedora
https://bugzilla.redhat.com/show_bug.cgi?id=2025153
--- Comment #1 from Jens Petersen ---
Seems ghc-tags might replace this though it needs ghc-9.2 really.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and co
https://bugzilla.redhat.com/show_bug.cgi?id=2069418
--- Comment #5 from Peter Robinson ---
(In reply to Fabio Valentini from comment #4)
> > This remains unresolved.
>
> If it's about the missing "rstest" dev-dependency for the tests, just adding
> this above "%bcond_with check" would be enoug
https://bugzilla.redhat.com/show_bug.cgi?id=2081539
Akira TAGOH changed:
What|Removed |Added
CC||ta...@redhat.com
--- Comment #5 from Ak
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
--- Comment #10 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains
https://bugzilla.redhat.com/show_bug.cgi?id=2065440
--- Comment #15 from Fedora Update System ---
FEDORA-2022-2a3013776b has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are o
https://bugzilla.redhat.com/show_bug.cgi?id=2006551
--- Comment #15 from Fedora Update System ---
FEDORA-2022-37a4046515 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are o
https://bugzilla.redhat.com/show_bug.cgi?id=2052407
--- Comment #14 from Fedora Update System ---
FEDORA-2022-189a40806d has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are a
https://bugzilla.redhat.com/show_bug.cgi?id=2065440
--- Comment #14 from Fedora Update System ---
FEDORA-2022-c637f0fe99 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are o
https://bugzilla.redhat.com/show_bug.cgi?id=2006551
--- Comment #14 from Fedora Update System ---
FEDORA-2022-f45b62a22a has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are a
https://bugzilla.redhat.com/show_bug.cgi?id=2077832
--- Comment #15 from Fedora Update System ---
FEDORA-2022-c144984c29 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are a
https://bugzilla.redhat.com/show_bug.cgi?id=2006551
--- Comment #13 from Fedora Update System ---
FEDORA-2022-2d3a304790 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are a
https://bugzilla.redhat.com/show_bug.cgi?id=2065440
--- Comment #13 from Fedora Update System ---
FEDORA-2022-0f83e989e3 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are o
https://bugzilla.redhat.com/show_bug.cgi?id=2069418
--- Comment #3 from Fabio Valentini ---
> It was literally done with rpm2rust, maybe I did it previously with an older
> version and didn't regenerate it.
That's unlikely, since the rest of the .spec file uses stuff that has only been
there
https://bugzilla.redhat.com/show_bug.cgi?id=2038638
Fabio Valentini changed:
What|Removed |Added
CC||decatho...@gmail.com
--- Comment #3
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
--- Comment #9 from Joshua Strobl ---
Ah nvm. Yea not sure why he used v for the tag but not tarball. Fixing. Just
check back in like 2min and it will be fixed :P
--
You are receiving this mail because:
You are always notified about changes
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
--- Comment #8 from Joshua Strobl ---
That is not correct. fossfreedom tags that one without the "v" prefix.
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
--- Comment #7 from Neal Gompa ---
> Source0:%{url}/releases/download/%{version}/%{name}-%{version}.tar.xz
Part of the URL is wrong, it should be "/v%{version}/" instead of
"/%{version}/".
--
You are receiving this mail because:
Yo
https://bugzilla.redhat.com/show_bug.cgi?id=2086269
Neal Gompa changed:
What|Removed |Added
Depends On||2086265
Referenced Bugs:
https://bugz
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
Neal Gompa changed:
What|Removed |Added
Blocks||2086269
Referenced Bugs:
https://bugz
https://bugzilla.redhat.com/show_bug.cgi?id=2086269
--- Comment #7 from Joshua Strobl ---
Updated to use macros for source to ease maintainability :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and componen
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
--- Comment #6 from Joshua Strobl ---
(In reply to Neal Gompa from comment #4)
> This needs fixing:
>
> > URL:https://github.com/BuddiesOfBudgie/budgie-control-center
> > Source0:
> > https://github.com/BuddiesOfBudgie/bud
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
--- Comment #10 from Joshua Strobl ---
Done!
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
https://bugzilla.redhat.com/show_bug.cgi?id=2086268
--- Comment #6 from Joshua Strobl ---
Done!
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2086268
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
Neal Gompa changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #5 from Neal Gompa ---
Dro
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
--- Comment #4 from Neal Gompa ---
This needs fixing:
> URL:https://github.com/BuddiesOfBudgie/budgie-control-center
> Source0:
> https://github.com/BuddiesOfBudgie/budgie-control-center/releases/download/v1.0.2/budgie-con
https://bugzilla.redhat.com/show_bug.cgi?id=2086268
Neal Gompa changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #5 from Neal Gompa ---
Dro
https://bugzilla.redhat.com/show_bug.cgi?id=2086268
--- Comment #4 from Neal Gompa ---
Another thing you should fix here:
> URL:https://github.com/BuddiesOfBudgie/budgie-desktop-view
> Source0:
> https://github.com/BuddiesOfBudgie/budgie-desktop-view/releases/download/v1.2/
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
--- Comment #9 from Neal Gompa ---
> URL:https://github.com/BuddiesOfBudgie/budgie-screensaver
> Source0:
> https://github.com/BuddiesOfBudgie/budgie-screensaver/releases/download/v5.0.1/budgie-screensaver-v5.0.1.tar.xz
So
https://bugzilla.redhat.com/show_bug.cgi?id=2086269
Neal Gompa changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #6 from Neal Gompa ---
I'v
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
Neal Gompa changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
--- Comment #8 from Neal Gompa ---
I'v
https://bugzilla.redhat.com/show_bug.cgi?id=2086299
--- Comment #3 from Maxwell G ---
Created attachment 1879895
--> https://bugzilla.redhat.com/attachment.cgi?id=1879895&action=edit
Review suggestions
--
You are receiving this mail because:
You are always notified about changes to this pr
https://bugzilla.redhat.com/show_bug.cgi?id=2086299
--- Comment #2 from Maxwell G ---
> # Avoid inclusion of package note file
> %undefine _package_note_file
I don't think this is necessary. There are no binaries built.
I would recommend mentioning that it's an ansible collection somewhere in
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
Neal Gompa changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2086299
Maxwell G changed:
What|Removed |Added
Flags||fedora-review?
Doc Type|---
https://bugzilla.redhat.com/show_bug.cgi?id=2086269
--- Comment #5 from Joshua Strobl ---
Issue raised should now be addressed. Thanks for the quick review!
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for
https://bugzilla.redhat.com/show_bug.cgi?id=2086268
--- Comment #3 from Joshua Strobl ---
Issue raised should now be addressed. Thanks for the quick review!
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
--- Comment #3 from Joshua Strobl ---
Issues raised should now be addressed. Using buildroot and check section with
app data and desktop file validation. The srpm was rebuild when performing all
the validation & building. Thanks for the quick
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
--- Comment #6 from Joshua Strobl ---
Issues raised should now be addressed. check section was added and the srpm was
rebuild when performing all the validation & building. Thanks for the quick
review!
--
You are receiving this mail because
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
--- Comment #5 from Neal Gompa ---
I don't know how useful this might be, but you might find some interesting
stuff worth pulling into budgie-screensaver from the old packaging of
gnome-screensaver from before it was retired:
https://src.fedor
https://bugzilla.redhat.com/show_bug.cgi?id=2086269
--- Comment #4 from Neal Gompa ---
Initial spec review:
> # Seems to ship /usr/lib/.build-id* otherwise
> %define _build_id_links none
Please remove this, as it breaks proper debuginfo subpackage generation.
--
You are receiving this mail
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
--- Comment #2 from Neal Gompa ---
Initial spec review:
> mkdir -p $RPM_BUILD_ROOT%{_datadir}/budgie/wm-properties
> rm -rf $RPM_BUILD_ROOT%{_datadir}/budgie/autostart
> rm -rf $RPM_BUILD_ROOT%{_datadir}/budgie/cursor-fonts
> chrpath --delete
https://bugzilla.redhat.com/show_bug.cgi?id=2086268
--- Comment #2 from Neal Gompa ---
> # Seems to ship /usr/lib/.build-id* otherwise
> %define _build_id_links none
Please remove this, as it breaks proper debuginfo subpackage generation.
--
You are receiving this mail because:
You are on t
https://bugzilla.redhat.com/show_bug.cgi?id=2081539
--- Comment #4 from Hedayat Vatankhah ---
Yes, sure. And thank you for reviewing my package :)
Just a quick question (part of the above emails): should I package variable
version of the fonts separately from the normal ones? I've seen that at
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
--- Comment #4 from Neal Gompa ---
> Issues:
> ===
> - Package installs a %{name}.desktop using desktop-file-install or desktop-
> file-validate if there is such a file.
This is fixable by adding BuildRequires: desktop-file-utils and ad
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
--- Comment #3 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-va
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
Neal Gompa changed:
What|Removed |Added
Blocks||2003783
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=2003783
Neal Gompa changed:
What|Removed |Added
Depends On||2086267
Referenced Bugs:
https://bugz
https://bugzilla.redhat.com/show_bug.cgi?id=2003783
Bug 2003783 depends on bug 2003785, which changed state.
Bug 2003785 Summary: Review Request: budgie-screensaver - Screensaver for the
Budgie desktop
https://bugzilla.redhat.com/show_bug.cgi?id=2003785
What|Removed
https://bugzilla.redhat.com/show_bug.cgi?id=2003785
Neal Gompa changed:
What|Removed |Added
Flags|fedora-review? |
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=2086269
Neal Gompa changed:
What|Removed |Added
CC||j...@sinervo.fi
--- Comment #3 from Neal
https://bugzilla.redhat.com/show_bug.cgi?id=2003783
Neal Gompa changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=2003786
Neal Gompa changed:
What|Removed |Added
Assignee|ngomp...@gmail.com |nob...@fedoraproject.org
Flag
https://bugzilla.redhat.com/show_bug.cgi?id=2003783
Bug 2003783 depends on bug 2003786, which changed state.
Bug 2003786 Summary: Review Request: libgnome-volume-control - An unstable
GObject API for accessing PulseAudio
https://bugzilla.redhat.com/show_bug.cgi?id=2003786
What|Rem
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
Neal Gompa changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=2086269
Neal Gompa changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
QA Contact|ngom
https://bugzilla.redhat.com/show_bug.cgi?id=2086268
Neal Gompa changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
Status|NEW
https://bugzilla.redhat.com/show_bug.cgi?id=2086269
Neal Gompa changed:
What|Removed |Added
Flags||fedora-review?
QA Contact|extras..
https://bugzilla.redhat.com/show_bug.cgi?id=2086268
Neal Gompa changed:
What|Removed |Added
Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
Neal Gompa changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #1 from Neal Gompa
https://bugzilla.redhat.com/show_bug.cgi?id=2086269
Neal Gompa changed:
What|Removed |Added
Doc Type|--- |If docs needed, set a value
Bl
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
Neal Gompa changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=2086299
Bug ID: 2086299
Summary: Review Request: ansible-collection-community-libvirt
- Manages virtual machines supported by libvirt
Product: Fedora
Version: rawhide
Hardware: Al
https://bugzilla.redhat.com/show_bug.cgi?id=2053420
Christoph Erhardt changed:
What|Removed |Added
CC||fed...@sicherha.de
--- Comment #1
https://bugzilla.redhat.com/show_bug.cgi?id=2086269
Bug ID: 2086269
Summary: Review Request: budgie-desktop - A feature-rich,
modern desktop designed to keep out the way of the
user
Product: Fedora
Version: rawhid
https://bugzilla.redhat.com/show_bug.cgi?id=2086268
Bug ID: 2086268
Summary: Review Request: budgie-desktop-view - Official Budgie
desktop icons application / implementation
Product: Fedora
Version: rawhide
Hardware: All
https://bugzilla.redhat.com/show_bug.cgi?id=2086267
Bug ID: 2086267
Summary: Review Request: budgie-screensaver - A fork of
gnome-screensaver intended for use with Budgie Desktop
Product: Fedora
Version: rawhide
Hardware: A
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
Joshua Strobl changed:
What|Removed |Added
Comment|0 |updated
--- Comment #0 has been edite
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
Joshua Strobl changed:
What|Removed |Added
Comment|0 |updated
--- Comment #0 has been edite
https://bugzilla.redhat.com/show_bug.cgi?id=2086265
Bug ID: 2086265
Summary: Review Request: budgie-control-center - Budgie
Desktop's Control Center
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
https://bugzilla.redhat.com/show_bug.cgi?id=2081539
--- Comment #3 from Parag AN(पराग) ---
Just to note one more thing after quicklook, Family names should be written as
they are in font files. You have added hyphen in place of space character.
e.g. %global fontfamily7 Vazirmatn-RD-UI-NL
https://bugzilla.redhat.com/show_bug.cgi?id=2081539
--- Comment #2 from Parag AN(पराग) ---
I wanted to review but not getting time. The more complex/subpackages in SPEC,
more it will take time to review.
Can you first try to remove comments from SPEC file and submit again same
package?
--
Yo
72 matches
Mail list logo
