https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #33 from Parag AN(पराग) panem...@gmail.com ---
Ouch! you are right. I forgot to change it to serif as it was just copy paste
from some other fontconfig file.
a)amiri-fontconfig.conf
?xml version=1.0 encoding=UTF-8?
!DOCTYPE
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #34 from Khaled Hosny khaledho...@eglug.org ---
(In reply to Parag AN(पराग) from comment #33)
b) Khaled you suggest not to include any fontconfig file for Amiri Quran
font?
I think it is better not to provide one.
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #35 from Mosaab Alzoubi moc...@hotmail.com ---
Thank You for attention (and for invitation) Parag
Thank You for your notes Khaled (maintainer of Amiri)
- Fix Sourceforg link in Source0.
- Decrease instructions to rebuild Amiri
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #36 from Parag AN(पराग) panem...@gmail.com ---
1) You need subpackage for Amiri Quran. Don't remove it. We add fonts
(sub-)packages per family. Here, Amiri Quran is one family for amiri-quran.ttf
and all other fonts under family
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #37 from Mosaab Alzoubi moc...@hotmail.com ---
Then, is amiri-quran-fontconfig.conf still needed?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
Parag AN(पराग) panem...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #39 from Nicolas Mailhot nicolas.mail...@laposte.net ---
(In reply to Parag AN(पराग) from comment #38)
generally we add fontconfig files per family per subpackage. I think if font
is not supposed to be used as a desktop font but
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #40 from Parag AN(पराग) panem...@gmail.com ---
Mosaab,
1)Add the fontconfig amiri-quran-fonts.conf file and submit new srpm for
further review. Note this is also serif font so add accordingly in fontconfig
file.
2) I saw your
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #41 from Mosaab Alzoubi moc...@hotmail.com ---
- Re-split into main and Quran fonts.
- Improve Amiri Quran font config.
- Add license files to -common, dropped from others.
- Drop fontpackages-filesystem requires from main package.
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #42 from Khaled Hosny khaledho...@eglug.org ---
(In reply to Nicolas Mailhot from comment #39)
(In reply to Parag AN(पराग) from comment #38)
generally we add fontconfig files per family per subpackage. I think if font
is not
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #43 from Parag AN(पराग) panem...@gmail.com ---
Though Amiri font is not yet in Fedora and Amiri Quran is modified version of
Amiri font, Let's take reference of
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #31 from Parag AN(पराग) panem...@gmail.com ---
suggestions:
1) your source download link should be
http://downloads.sourceforge.net/project/amiri/%{fontname}-%{version}.tar.bz2
2) good to always truncate your long lines with 80
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #32 from Khaled Hosny khaledho...@eglug.org ---
(In reply to Parag AN(पराग) from comment #31)
3) your fontconfig files should look neat as
a)amiri-fontconfig.conf
?xml version=1.0 encoding=UTF-8?
!DOCTYPE fontconfig SYSTEM
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #30 from Parag AN(पराग) panem...@gmail.com ---
Thanks. I will resume this review on Monday and will sponsor you.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
Bug 1015701 depends on bug 1021164, which changed state.
Bug 1021164 Summary: Review Request: general-purpose-preprocessor -
Customizable language-agnostic preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1021164
What
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #29 from Mosaab Alzoubi moc...@hotmail.com ---
Thank you Parag for your attention, Done: #1025601 #1025052
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
Parag AN(पराग) panem...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #26 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Informal review:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[x]: Package is
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:
What|Removed |Added
Assignee|zbys...@in.waw.pl
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #20 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
I learnt in another review that .woffs are not supposed to be packaged:
http://fedoraproject.org/wiki/Packaging:Web_Assets#Fonts.
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #21 from Parag AN(पराग) panem...@gmail.com ---
That's right. Whichever format upstream is providing fonts, try to package ttf
or otf only if available that format.
For fonts packages its recommended to create a font package
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
Mosaab Alzoubi moc...@hotmail.com changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #23 from Mosaab Alzoubi moc...@hotmail.com ---
- Dropped .woff fonts.
- Update description by official one.
- Make this package ready for building if it possible later.
Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec
SRPM :
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #24 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Oh, one more issue:
1. change %define to %global
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #25 from Mosaab Alzoubi moc...@hotmail.com ---
OK done:
Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec
SRPM : http://ojuba.org/oji/SRPMS/amiri-fonts-0.106-6.oji.fc19.src.rpm
--
You are receiving this mail because:
You are on
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #19 from Mosaab Alzoubi moc...@hotmail.com ---
First full-reviesion : bug 1023619
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #17 from Parag AN(पराग) panem...@gmail.com ---
Mosaab,
Do some full reviews of new packages not just one or two comments. I will be
happy to sponsor then.
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #18 from Mosaab Alzoubi moc...@hotmail.com ---
Ok I'll search. These was latest 3 new review bugs !!
--
You are receiving this mail because:
You are on the CC list for the bug.
___
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #14 from Parag AN(पराग) panem...@gmail.com ---
Thanks for submitting 7 packages for review but you need to do package review
of other people's submitted packages reviews.
--
You are receiving this mail because:
You are on the CC
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #15 from Mosaab Alzoubi moc...@hotmail.com ---
Ok . I read 4 package review new bugs and wrote my notes:
#1021721 #1022407 #1021749
Thank You again Parag.
--
You are receiving this mail because:
You are on the CC list for the
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #16 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
(Strong suggestion:) Please install fedora-review, and use it on your *own*
review requests. It will point out obvious things, letting the reviewers
concentrate on subtler
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #13 from Mosaab Alzoubi moc...@hotmail.com ---
Zbigniew ::
This font couldn't built by FontForge, It built by fork of it found here:
https://bitbucket.org/sortsmill/sortsmill-tools
That what Khaled Hosny (maintainer of Amiri
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #11 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
sfntly has been packaged: #912686, I think it is the same thing as sfnttool.
gpp is in #1021164.
fntsample, pdfoutline, latexmk are available.
So I think it is viable to
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #12 from Parag AN(पराग) panem...@gmail.com ---
I can sponsor the reporter provided he will show package reviews done on other
package review bugs where he can show he has helped in finding issues and
providing fix for them.
--
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #5 from Mosaab Alzoubi moc...@hotmail.com ---
All Done, Rewritten almost from Zero ::
Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec
SRPM : http://ojuba.org/oji/SRPMS/amiri-fonts-0.106-3.oji.fc19.src.rpm
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #6 from Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl ---
Some high-level problems:
1. Guidelines say that fonts must be built from sources, if those are provided.
Here they are provided.
2. -web fonts are the same as in the main
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #7 from Mosaab Alzoubi moc...@hotmail.com ---
Thanx for reply.
1 - When I build it from source directly, nothing done because the destination
of built fonts already busy, Also building of the font requirs gpp command I
couldn't
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #8 from Mosaab Alzoubi moc...@hotmail.com ---
For point 7 , I think (amiri-fonts) meta package make download of the fonts as
group more easy .
I think this way must be formal in Fedora ^_^
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #9 from Mosaab Alzoubi moc...@hotmail.com ---
All Fixed ::
Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec
SRPM : http://ojuba.org/oji/SRPMS/amiri-fonts-0.106-4.oji.fc19.src.rpm
--
You are receiving this mail because:
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:
What|Removed |Added
Depends On||1021164
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
Mosaab Alzoubi moc...@hotmail.com changed:
What|Removed |Added
Alias||Amiri
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #4 from Mosaab Alzoubi moc...@hotmail.com ---
Ok , rewiting in progress
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #2 from Mosaab Alzoubi moc...@hotmail.com ---
Hosted at Ojuba server , Alot of fixes after many packages revision :)
Spec : http://ojuba.org/oji/SPECS/amiri-fonts.spec
SRPM :
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Blocks||177841
https://bugzilla.redhat.com/show_bug.cgi?id=1015701
--- Comment #1 from Mosaab Alzoubi moc...@hotmail.com ---
Spec URL: http://helallinux.com/paste/show.php?id=1225mode=raw
SRPM URL:
http://downloads.sourceforge.net/projects/oji/srpms/amiri-fonts-0.106-1.fc19.src.rpm
Description:
مجموعة الخطوط
46 matches
Mail list logo
