https://bugzilla.redhat.com/show_bug.cgi?id=1023714
Igor Gnatenko i.gnatenko.br...@gmail.com changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #25 from Alec Leamas leamas.a...@gmail.com ---
While the resolution closed/wontfix certainly is OK, the process is not. This
was assigned to Simone (negativo17...), and IMHO the proper action would have
been to put a comment in the
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #22 from Simone Caronni negativ...@gmail.com ---
(In reply to Alec Leamas from comment #21)
In the best of all worlds I think we should co-maintain this package. You
know the skype stuff, I know lpf (which is as yet far from
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #23 from Alec Leamas leamas.a...@gmail.com ---
Sounds good. Using that recipe you could formally review rpmfusion 3033, and if
you make a similar request for lpf-skype I can formally review that. Those
reviews should just be a
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #21 from Alec Leamas leamas.a...@gmail.com ---
The FPC have discussed the issue. The ticket (#362) is still missing a +1 vote,
but I think it a safe bet to say it will be approved. This means that lpf-skype
should go to rpmfusion.
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #17 from Simone Caronni negativ...@gmail.com ---
Package APPROVED wrt lpf-skype.spec file.
Now to the bundled skype.spec file. I used to mantain the same for a few years;
would you like to take a look at:
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #18 from Alec Leamas leamas.a...@gmail.com ---
Hm... Since you actually have a working and tested spec file: would it be
problem if we just used it verbatim in this package? It actually seems to be in
a much better shape than
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
Simone Caronni negativ...@gmail.com changed:
What|Removed |Added
Flags||fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #20 from Alec Leamas leamas.a...@gmail.com ---
OK, done. New links:
spec: http://leamas.fedorapeople.org/lpf-skype/4/lpf-skype.spec
srpm:
http://leamas.fedorapeople.org/lpf-skype/4/lpf-skype-4.2.0.11-4.fc20.src.rpm
It's kind of
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #12 from Simone Caronni negativ...@gmail.com ---
OK, figured out. It happens only in f19 mock:
+ /usr/share/lpf/scripts/lpf-setup-pkg
/builddir/build/BUILDROOT/lpf-skype-4.2.0.11-2.fc19.x86_64
/builddir/build/SOURCES/skype.spec.in
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #13 from Simone Caronni negativ...@gmail.com ---
..because as it was suggested in the lpf-spotify-client review I was still
using the latest lpf package in the review which is quite old
(lpf-0-3.46ae0c3).
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #14 from Simone Caronni negativ...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package does not contain
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #15 from Simone Caronni negativ...@gmail.com ---
Issues:
- Package does not contain duplicates in %files.
Note: warning: File listed twice: /var/lib/lpf/packages/skype/state
See:
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #16 from Alec Leamas leamas.a...@gmail.com ---
(In reply to Simone Caronni from comment #15)
Issues:
Couple of issues in the %files section:
%{_datadir}/lpf/packages/%{target_pkg}
%attr(775,pkg-build,pkg-build)
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #10 from Rex Dieter rdie...@math.unl.edu ---
Easiest proof would be to do a rawhide koji scratch build.
While we're at it, why isn't lpf in f20 yet?
--
You are receiving this mail because:
You are on the CC list for the bug.
You
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #11 from Alec Leamas leamas.a...@gmail.com ---
I've postponed all lpf pushes: https://fedorahosted.org/fpc/ticket/362
(In reply to Rex Dieter from comment #10)
Welcome onboard!
Easiest proof would be to do a rawhide koji scratch
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #9 from Alec Leamas leamas.a...@gmail.com ---
I don't really get it. It builds for me in mock on two different machines, and
thus it should for you. You are using the rawhide buildroot i. e., mock -r
fedora-rawhide-i386 ... ?
lpf
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #2 from Alec Leamas leamas.a...@gmail.com ---
The question whether lpf-* packages are allowed in Fedora is by the fpc [1].
This might mean that this package won't go into fedora. OTOH, the review
process is the same here and in
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #3 from Simone Caronni negativ...@gmail.com ---
I think there's a leftover in the spec file, the package does not build:
+ /usr/share/lpf/scripts/lpf-setup-pkg
/builddir/build/BUILDROOT/lpf-skype-4.2.0.11-1.fc19.x86_64
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #4 from Alec Leamas leamas.a...@gmail.com ---
Updated, new links:
spec: http://leamas.fedorapeople.org/lpf-skype/2/lpf-skype.spec
srpm:
http://leamas.fedorapeople.org/lpf-skype/2/lpf-skype-4.2.0.11-2.fc20.src.rpm
Changelog:
* Fri
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #5 from Simone Caronni negativ...@gmail.com ---
(In reply to Alec Leamas from comment #4)
Keeping %install section, it looks sane and works for me. Puzzled why it
doesn't for you...
I'm sorry but it's not working with mock. The
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #6 from Alec Leamas leamas.a...@gmail.com ---
My bad, I did not run it in mock. BBL.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #7 from Alec Leamas leamas.a...@gmail.com ---
README installed in wrong section. Fixed, now builds in mock/rawhide for me.
Updated in-place, same links release, changelog modified.
--
You are receiving this mail because:
You
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
--- Comment #8 from Simone Caronni negativ...@gmail.com ---
(In reply to Alec Leamas from comment #7)
Fixed, now builds in mock/rawhide for me.
Still not able to build in mock, the desktop part has not changed.
Source0:
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
Simone Caronni negativ...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
Alec Leamas leamas.a...@gmail.com changed:
What|Removed |Added
Blocks||182235 (FE-Legal)
https://bugzilla.redhat.com/show_bug.cgi?id=1023714
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
Summary|Review Request: lpf skype: |Review Request:
27 matches
Mail list logo
