https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|ON_QA |CLOSED
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|MODIFIED|ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #23 from Fedora Update System upda...@fedoraproject.org ---
captcp-1.7-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/captcp-1.7-2.fc20
--
You are receiving this mail because:
You
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #22 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Jon Ciesla limburg...@gmail.com changed:
What|Removed |Added
Flags|fedora-cvs? |fedora-cvs+
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Michele Baldessari mich...@acksyn.org changed:
What|Removed |Added
Flags||fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Kevin Fenzi ke...@scrye.com changed:
What|Removed |Added
CC||ke...@scrye.com
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #20 from Kevin Fenzi ke...@scrye.com ---
I've sponsored you into the packager group. Welcome to the fun!
You can continue the process from:
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #16 from Michele Baldessari mich...@acksyn.org ---
Updated packages:
Spec URL: http://acksyn.org/files/rpms/captcp/captcp.spec
SRPM URL: http://acksyn.org/files/rpms/captcp/captcp-1.7-2.fc20.src.rpm
- Fixed Licensing tag after
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Simo Sorce sso...@redhat.com changed:
What|Removed |Added
Assignee|mizde...@redhat.com |sso...@redhat.com
--
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Simo Sorce sso...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #17 from Simo Sorce sso...@redhat.com ---
Looks good to me!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Simo Sorce sso...@redhat.com changed:
What|Removed |Added
Flags|
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #15 from Mikolaj Izdebski mizde...@redhat.com ---
I am currently on vacation [1] until 2013-12-01.
I'll continue this review when I come back.
[1] http://fedoraproject.org/wiki/Vacation
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Fabian Affolter m...@fabian-affolter.ch changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #14 from Michele Baldessari mich...@acksyn.org ---
Hi Mikolaj,
so I've discussed with upstream a few things and the package should be more or
less ready at this point. Here are a couple of points that are worth noting
and/or
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #13 from Mikolaj Izdebski mizde...@redhat.com ---
(In reply to Michele Baldessari from comment #12)
(In reply to Mikolaj Izdebski from comment #11)
But first I would think if chmod or %attr is really needed and why. If
make
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #11 from Mikolaj Izdebski mizde...@redhat.com ---
(In reply to Michele Baldessari from comment #10)
chmod calls in %install should be avoided, please use %attr macro in %files
section instead.
Ack, done. Although without
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #12 from Michele Baldessari mich...@acksyn.org ---
Hi Mikolaj,
(In reply to Mikolaj Izdebski from comment #11)
(In reply to Michele Baldessari from comment #10)
chmod calls in %install should be avoided, please use %attr macro
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #10 from Michele Baldessari mich...@acksyn.org ---
Hi Mikolaj,
(In reply to Mikolaj Izdebski from comment #8)
I understand that you may prefer git am, I prefer it too, but that's not
how patches are applied in Fedora. And there
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Mikolaj Izdebski mizde...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #9 from Mikolaj Izdebski mizde...@redhat.com ---
(In reply to Mikolaj Izdebski from comment #8)
After having a quick look I think that license tag should be GPL+ instead
of GPLv3 as there is no explicit GPL version specified (If
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #7 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Michele Baldessari from comment #6)
So I went through an iteration of fedora-review -b 1025977 and fixed
a couple of things. New files:
Spec URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Michele Baldessari mich...@acksyn.org changed:
What|Removed |Added
Blocks||177841
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
Antonio Trande anto.tra...@gmail.com changed:
What|Removed |Added
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #2 from Michele Baldessari mich...@acksyn.org ---
Hi Antonio,
thanks for letting me know. I've uploaded fixed spec and srpm:
Spec URL: http://acksyn.org/files/rpms/captcp/captcp.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #3 from Antonio Trande anto.tra...@gmail.com ---
(In reply to Michele Baldessari from comment #2)
Hi Antonio,
thanks for letting me know. I've uploaded fixed spec and srpm:
Spec URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #4 from Antonio Trande anto.tra...@gmail.com ---
Also, some slashes are redundant:
%{buildroot}/%{_bindir}/captcp is wrong.
%{buildroot}%{_bindir}/captcp is fine.
%{buildroot}/%{_mandir}/man8/captcp.8 is wrong.
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #5 from Michele Baldessari mich...@acksyn.org ---
(In reply to Antonio Trande from comment #3)
(In reply to Michele Baldessari from comment #2)
Hi Antonio,
thanks for letting me know. I've uploaded fixed spec and srpm:
https://bugzilla.redhat.com/show_bug.cgi?id=1025977
--- Comment #6 from Michele Baldessari mich...@acksyn.org ---
So I went through an iteration of fedora-review -b 1025977 and fixed
a couple of things. New files:
Spec URL: http://acksyn.org/files/rpms/captcp/captcp.spec
SRPM URL:
31 matches
Mail list logo
