[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 Gerard Ryan changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs:

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it Assignee|no

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 --- Comment #1 from gil cattaneo --- main package must be like: %files -f .mfiles-%{name} %dir %{_javadir}/%{name} %doc epl-v10.html please, fix unowned directory .mfiles should be empty, use .mfiles-%{name} instead if available license shou

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-17 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 --- Comment #2 from gil cattaneo --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed = MUST items = Generic: [x]: Package is licensed with an open-

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 --- Comment #3 from Gerard Ryan --- Thanks for taking this review Gil! (In reply to gil cattaneo from comment #1) > main package must be like: > > %files -f .mfiles-%{name} > %dir %{_javadir}/%{name} > %doc epl-v10.html > > please, fix unow

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 gil cattaneo changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-revie

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 --- Comment #5 from Gerard Ryan --- Wonderful, thanks for the review and approval gil! (In reply to gil cattaneo from comment #4) > Thanks, for your changes! > non blocking issues: > [!]: If (and only if) the source package includes the text

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 Gerard Ryan changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Gerard

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component __

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-19 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this m

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 Gerard Ryan changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|---

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437 Gerard Ryan changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.re