https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Fixed In Version|yarock-0.9.64-3.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|ON_QA |CLOSED
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #62 from Fedora Update System upda...@fedoraproject.org ---
yarock-0.9.64-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/yarock-0.9.64-3.fc19
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #63 from Fedora Update System upda...@fedoraproject.org ---
yarock-0.9.64-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/yarock-0.9.64-3.fc20
--
You are receiving this mail because:
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Fedora Update System upda...@fedoraproject.org changed:
What|Removed |Added
Status|MODIFIED|ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #57 from James Abtahi jamescateg...@gmail.com ---
I've applied Kevin Kofler's solution and now the translation files are
installed in %{_datadir}/%{name}/translations (see the installationpath patch).
I've also noticed that qt
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #58 from Kevin Kofler ke...@tigcc.ticalc.org ---
Please add:
%dir %{_datadir}/%{name}
which is otherwise unowned. Other than that, it looks fine.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #59 from James Abtahi jamescateg...@gmail.com ---
Please add:
%dir %{_datadir}/%{name}
which is otherwise unowned. Other than that, it looks fine.
Done. I'm going to put a request for creation of a repository in the next few
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #60 from James Abtahi jamescateg...@gmail.com ---
New Package SCM Request
===
Package Name: yarock
Short Description: A lightweight, beautiful music player
Owners: jam3s
Branches: f19 f20
InitialCC:
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
James Abtahi jamescateg...@gmail.com changed:
What|Removed |Added
Flags||fedora-cvs?
--
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Jon Ciesla limburg...@gmail.com changed:
What|Removed |Added
Flags|fedora-cvs? |fedora-cvs+
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #61 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #50 from James Abtahi jamescateg...@gmail.com ---
/usr/share/locale/yarock is a bug. Package simply MUST not install i18n files
there in.
reference?
I thought Kevin Kofler said:
The gettext scheme is
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #51 from Ralf Corsepius rc040...@freenet.de ---
(In reply to James Abtahi from comment #50)
/usr/share/locale/yarock is a bug. Package simply MUST not install i18n
files there in.
reference?
This is common sense ever since
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #52 from Ralf Corsepius rc040...@freenet.de ---
Where is your latest src.rpm?
http://jam3s.fedorapeople.org/yarock.spec
does not match the src.rpm under http://jam3s.fedorapeople.org/
--
You are receiving this mail because:
You
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #53 from Kevin Kofler ke...@tigcc.ticalc.org ---
One solution that Qt programs often use is to install the *.qm files under
%{_datadir}/%{name}/translations. It's also not really optimal, but at least it
doesn't abuse
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #54 from James Abtahi jamescateg...@gmail.com ---
Where is your latest src.rpm?
does not match the src.rpm under http://jam3s.fedorapeople.org/
updated now:
http://jam3s.fedorapeople.org/yarock-0.9.64-2.fc20.src.rpm
One
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #55 from James Abtahi jamescateg...@gmail.com ---
hum... something is terribly wrong. according to this source:
http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software#Translations
.ts file are just the xml source
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #56 from James Abtahi jamescateg...@gmail.com ---
nah, something stupid happened there. nothing related to the package. the .qt
files are installed in the /usr/share/locale/yarock. Ignore my previous
comment. sorry about it.
--
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #45 from James Abtahi jamescateg...@gmail.com ---
In any case, the directory containing the translations needs to be listed in
%files with a %dir tag, e.g.:
%dir %{_datadir}/locale/%{name}/
Thanks a lot for this solution. Saved
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Kevin Fenzi ke...@scrye.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
---
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #47 from Kevin Kofler ke...@tigcc.ticalc.org ---
Usually when adding comments for patches, thats done at the top where the
patch
is defined instead of in the prep where it's applied.
Well, I've seen both variants, but yes,
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #48 from James Abtahi jamescateg...@gmail.com ---
Usually when adding comments for patches, thats done at the top where the
patch
is defined instead of in the prep where it's applied. You might move those
comments up to the
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Ralf Corsepius rc040...@freenet.de changed:
What|Removed |Added
CC||rc040...@freenet.de
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Kevin Fenzi ke...@scrye.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #43 from Kevin Fenzi ke...@scrye.com ---
1. /usr/share/locale/yarock doesn't seem to be owned. Not sure if this
is a find_lang bug or what. Perhaps the arguments are confusing it?
You can manually run the find_lang.sh rpm uses and
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #44 from Kevin Kofler ke...@tigcc.ticalc.org ---
1. /usr/share/locale/yarock doesn't seem to be owned. Not sure if this
is a find_lang bug or what. Perhaps the arguments are confusing it?
You can manually run the find_lang.sh
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #40 from Kevin Kofler ke...@tigcc.ticalc.org ---
%{_datadir}/icons/hicolor/16x16/apps/application-x-yarock.png
%{_datadir}/icons/hicolor/32x32/apps/application-x-yarock.png
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #41 from James Abtahi jamescateg...@gmail.com ---
I agree with Rex Dieter (comment #11) there. Enumerating every single icon
(and
even every single size!) explicitly is totally pointless. It will just fail
the
build for no
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #35 from James Abtahi jamescateg...@gmail.com ---
If all the reviewers are satisfied with this package, please APPROVE it or
otherwise let me know of any suggestions.
--
You are receiving this mail because:
You are on the CC list
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #36 from Terje Røsten terje...@phys.ntnu.no ---
In actual review process has not started yet, no reviewer is assigned.
See:
http://fedoraproject.org/wiki/Package_Review_Process#Review_Process
for details.
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #37 from James Abtahi jamescateg...@gmail.com ---
In actual review process has not started yet, no reviewer is assigned.
Shouldn't the sponsor be also the reviewer? Kevin Fenzi sponsored me (for
co-maintaining another package)
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #38 from Michael Schwendt bugs.mich...@gmx.net ---
Shouldn't the sponsor be also the reviewer?
It's somewhat a grey area, since you've been sponsored prior to your first
package review request already (for becoming a
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #39 from Kevin Fenzi ke...@scrye.com ---
I'd be happy to review this, but not sure when I will get time to do so. :(
So, if anyone else would like to, please feel free... if not, I will try and do
so as time permits.
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #25 from James Abtahi jamescateg...@gmail.com ---
See http://rdieter.fedorapeople.org/rpms/yarock/
There is a minor typo in your spec:
qtsingleappliation-devel = qtsingleapplciation-devel
Anyway, even after fixing that the
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #26 from James Abtahi jamescateg...@gmail.com ---
There is a minor typo in your spec:
qtsingleappliation-devel = qtsingleapplciation-devel
I meant qtsingleapplication-devel. ;)
--
You are receiving this mail because:
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #27 from Christopher Meng cicku...@gmail.com ---
Bundled code is never allowed in Fedora. Or we won't approve your package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #28 from Terje Røsten terje...@phys.ntnu.no ---
Reference:
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
Or you can start here:
https://fedoraproject.org/wiki/Category:Package_Maintainers#Packaging_Guidelines
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #29 from James Abtahi jamescateg...@gmail.com ---
I think I have found the solution. Rex forgot one of the dependencies. lets
see...
Bundled code is never allowed in Fedora. Or we won't approve your package.
Reference:
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #30 from James Abtahi jamescateg...@gmail.com ---
Success! Actually Rex forgot to add qtsinglecoreapplication-devel in the
build requirements. With that in place, the build is successful.
updated SPEC:
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #31 from Christopher Meng cicku...@gmail.com ---
Still bad:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #32 from James Abtahi jamescateg...@gmail.com ---
Still bad:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
Done, please see the %check section:
http://jam3s.fedorapeople.org/yarock.spec
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #33 from Rex Dieter rdie...@math.unl.edu ---
fwiw, I can supply a separate (upstreamable) patch to fix build problems using
the bundled code when building with -DBUILD_SHARED_LIBS:BOOL=ON option too.
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #34 from James Abtahi jamescateg...@gmail.com ---
fwiw, I can supply a separate (upstreamable) patch to fix build problems using
the bundled code when building with -DBUILD_SHARED_LIBS:BOOL=ON option too.
You can contact the
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Terje Røsten terje...@phys.ntnu.no changed:
What|Removed |Added
Summary|Review Request: Yarock - A |Review Request:
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #21 from James Abtahi jamescateg...@gmail.com ---
Indeed, it's mandatory, build must use these flags. This is important for
security and creation for debuginfo package, abrt and retrace support etc.
Done. I've added %{optflags}
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #22 from Rex Dieter rdie...@math.unl.edu ---
I guess I'm just annoyed enough to figure out why %cmake fails. :)
Ah, pretty easy to spot (2 problems actually):
1. it bundles qtsingleapplication
2. this bundled build fails when
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #23 from Rex Dieter rdie...@math.unl.edu ---
prepping patch to fix this...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #24 from Rex Dieter rdie...@math.unl.edu ---
See http://rdieter.fedorapeople.org/rpms/yarock/
yarock.spec : updated spec file
spec.patch : patch to original .spec
Yarock_0.9.64_11_source-system_libs.patch : patch applied in
50 matches
Mail list logo
