https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Terje Røsten changed:
What|Removed |Added
Summary|Review Request: Yarock - A |Review Request: Yarock - A
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #21 from James Abtahi ---
> Indeed, it's mandatory, build must use these flags. This is important for
> security and creation for debuginfo package, abrt and retrace support etc.
Done. I've added %{optflags} to CFLAGS and CPPFLAGS
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #22 from Rex Dieter ---
I guess I'm just annoyed enough to figure out why %cmake fails. :)
Ah, pretty easy to spot (2 problems actually):
1. it bundles qtsingleapplication
2. this bundled build fails when building with -DBUILD_
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #23 from Rex Dieter ---
prepping patch to fix this...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #24 from Rex Dieter ---
See http://rdieter.fedorapeople.org/rpms/yarock/
yarock.spec : updated spec file
spec.patch : patch to original .spec
Yarock_0.9.64_11_source-system_libs.patch : patch applied in yarock.spec
allowing use of
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #25 from James Abtahi ---
> See http://rdieter.fedorapeople.org/rpms/yarock/
There is a minor typo in your spec:
qtsingleappliation-devel => qtsingleapplciation-devel
Anyway, even after fixing that the build fails. The variable
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #26 from James Abtahi ---
> There is a minor typo in your spec:
> qtsingleappliation-devel => qtsingleapplciation-devel
I meant "qtsingleapplication-devel". ;)
--
You are receiving this mail because:
You are on the CC list for t
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #27 from Christopher Meng ---
Bundled code is never allowed in Fedora. Or we won't approve your package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this pr
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #28 from Terje Røsten ---
Reference:
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
Or you can start here:
https://fedoraproject.org/wiki/Category:Package_Maintainers#Packaging_Guidelines
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #29 from James Abtahi ---
I think I have found the solution. Rex forgot one of the dependencies. lets
see...
> Bundled code is never allowed in Fedora. Or we won't approve your package.
> Reference:
> https://fedoraproject.org/wik
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #30 from James Abtahi ---
Success! Actually Rex forgot to add "qtsinglecoreapplication-devel" in the
build requirements. With that in place, the build is successful.
updated SPEC:
http://jam3s.fedorapeople.org/yarock.spec
update
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #31 from Christopher Meng ---
Still bad:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about cha
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #32 from James Abtahi ---
> Still bad:
> http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
Done, please see the %check section:
http://jam3s.fedorapeople.org/yarock.spec
--
You are receiving this mai
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #33 from Rex Dieter ---
fwiw, I can supply a separate (upstreamable) patch to fix build problems using
the bundled code when building with -DBUILD_SHARED_LIBS:BOOL=ON option too.
--
You are receiving this mail because:
You are on
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #34 from James Abtahi ---
> fwiw, I can supply a separate (upstreamable) patch to fix build problems using
> the bundled code when building with -DBUILD_SHARED_LIBS:BOOL=ON option too.
You can contact the original developer 'Sebas
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #35 from James Abtahi ---
If all the reviewers are satisfied with this package, please APPROVE it or
otherwise let me know of any suggestions.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are al
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #36 from Terje Røsten ---
In actual review process has not started yet, no reviewer is assigned.
See:
http://fedoraproject.org/wiki/Package_Review_Process#Review_Process
for details.
--
You are receiving this mail because:
Yo
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #37 from James Abtahi ---
> In actual review process has not started yet, no reviewer is assigned.
Shouldn't the sponsor be also the reviewer? Kevin Fenzi sponsored me (for
co-maintaining another package) into the fedora packager
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #38 from Michael Schwendt ---
> Shouldn't the sponsor be also the reviewer?
It's somewhat a grey area, since you've been sponsored prior to your first
package review request already (for becoming a co-maintainer). The following
pa
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #39 from Kevin Fenzi ---
I'd be happy to review this, but not sure when I will get time to do so. :(
So, if anyone else would like to, please feel free... if not, I will try and do
so as time permits.
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #40 from Kevin Kofler ---
> %{_datadir}/icons/hicolor/16x16/apps/application-x-yarock.png
> %{_datadir}/icons/hicolor/32x32/apps/application-x-yarock.png
> %{_datadir}/icons/hicolor/48x48/apps/application-x-yarock.png
> %{_datadir}
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #41 from James Abtahi ---
> I agree with Rex Dieter (comment #11) there. Enumerating every single icon
> (and
> even every single size!) explicitly is totally pointless. It will just fail
> the
> build for no reason when upstream
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Kevin Fenzi changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #43 from Kevin Fenzi ---
1. /usr/share/locale/yarock doesn't seem to be owned. Not sure if this
is a find_lang bug or what. Perhaps the arguments are confusing it?
You can manually run the find_lang.sh rpm uses and see if you can
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #44 from Kevin Kofler ---
> 1. /usr/share/locale/yarock doesn't seem to be owned. Not sure if this
> is a find_lang bug or what. Perhaps the arguments are confusing it?
> You can manually run the find_lang.sh rpm uses and see if y
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #45 from James Abtahi ---
> In any case, the directory containing the translations needs to be listed in
> %files with a %dir tag, e.g.:
> %dir %{_datadir}/locale/%{name}/
Thanks a lot for this solution. Saved me from a lot of hea
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Kevin Fenzi changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #46 from Kev
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #47 from Kevin Kofler ---
> Usually when adding comments for patches, thats done at the top where the
> patch
> is defined instead of in the prep where it's applied.
Well, I've seen both variants, but yes, doing it at the top is
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #48 from James Abtahi ---
> Usually when adding comments for patches, thats done at the top where the
> patch
> is defined instead of in the prep where it's applied. You might move those
> comments up to the top, you can do that b
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Ralf Corsepius changed:
What|Removed |Added
CC||rc040...@freenet.de
--- Comment #49
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #50 from James Abtahi ---
> /usr/share/locale/yarock is a bug. Package simply MUST not install i18n files
> there in.
reference?
I thought Kevin Kofler said:
> The gettext scheme is /usr/share/locale/%{locale}/%{name}.mo, but Q
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #51 from Ralf Corsepius ---
(In reply to James Abtahi from comment #50)
> > /usr/share/locale/yarock is a bug. Package simply MUST not install i18n
> > files there in.
>
> reference?
This is common sense ever since i18n exists an
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #52 from Ralf Corsepius ---
Where is your latest src.rpm?
http://jam3s.fedorapeople.org/yarock.spec
does not match the src.rpm under http://jam3s.fedorapeople.org/
--
You are receiving this mail because:
You are on the CC list f
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #53 from Kevin Kofler ---
One solution that Qt programs often use is to install the *.qm files under
%{_datadir}/%{name}/translations. It's also not really optimal, but at least it
doesn't abuse %{_datadir}/locale.
The ideal solut
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #54 from James Abtahi ---
> Where is your latest src.rpm?
> does not match the src.rpm under http://jam3s.fedorapeople.org/
updated now:
http://jam3s.fedorapeople.org/yarock-0.9.64-2.fc20.src.rpm
> One solution that Qt programs o
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #55 from James Abtahi ---
hum... something is terribly wrong. according to this source:
http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software#Translations
.ts file are just the xml source translations while the .qm files ar
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #56 from James Abtahi ---
nah, something stupid happened there. nothing related to the package. the .qt
files are installed in the /usr/share/locale/yarock. Ignore my previous
comment. sorry about it.
--
You are receiving this ma
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #57 from James Abtahi ---
I've applied Kevin Kofler's solution and now the translation files are
installed in %{_datadir}/%{name}/translations (see the installationpath patch).
I've also noticed that "qt" package translation files
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #58 from Kevin Kofler ---
Please add:
%dir %{_datadir}/%{name}
which is otherwise unowned. Other than that, it looks fine.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #59 from James Abtahi ---
> Please add:
> %dir %{_datadir}/%{name}
> which is otherwise unowned. Other than that, it looks fine.
Done. I'm going to put a request for creation of a repository in the next few
hours. In the meantime
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #60 from James Abtahi ---
New Package SCM Request
===
Package Name: yarock
Short Description: A lightweight, beautiful music player
Owners: jam3s
Branches: f19 f20
InitialCC:
--
You are receiving this mail bec
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
James Abtahi changed:
What|Removed |Added
Flags||fedora-cvs?
--
You are receiving this
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Jon Ciesla changed:
What|Removed |Added
Flags|fedora-cvs? |fedora-cvs+
--
You are receiving this m
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #61 from Jon Ciesla ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Fedora Update System changed:
What|Removed |Added
Status|ASSIGNED|MODIFIED
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #62 from Fedora Update System ---
yarock-0.9.64-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/yarock-0.9.64-3.fc19
--
You are receiving this mail because:
You are on the CC list for
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
--- Comment #63 from Fedora Update System ---
yarock-0.9.64-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/yarock-0.9.64-3.fc20
--
You are receiving this mail because:
You are on the CC list for
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Fedora Update System changed:
What|Removed |Added
Status|MODIFIED|ON_QA
--- Comment #64 from Fed
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Fedora Update System changed:
What|Removed |Added
Status|ON_QA |CLOSED
Fixed In Version|
https://bugzilla.redhat.com/show_bug.cgi?id=1032108
Fedora Update System changed:
What|Removed |Added
Fixed In Version|yarock-0.9.64-3.fc19|yarock-0.9.64-3.fc20
--- Comme
50 matches
Mail list logo
