https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Dominik 'Rathann' Mierzejewski changed:
What|Removed |Added
Blocks||182235 (FE-Legal)
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Jon Ciesla changed:
What|Removed |Added
Flags|fedora-cvs? |fedora-cvs+
--
You are receiving this m
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #21 from Jon Ciesla ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Adam Williamson changed:
What|Removed |Added
Flags||fedora-cvs?
--- Comment #20 from Ad
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Jon Ciesla changed:
What|Removed |Added
Flags|fedora-cvs? |
--
You are receiving this mail because
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #19 from Jon Ciesla ---
No owners specified.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Adam Williamson changed:
What|Removed |Added
Flags|fedora-cvs+ |fedora-cvs?
--
You are receiving t
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #18 from Adam Williamson ---
Package Change Request
==
Package Name: php-phpseclib-crypt-random
New Branches: f19 epel7
--
You are receiving this mail because:
You are on the CC list for the bug.
You are alway
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Adam Williamson changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #16 from Jon Ciesla ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Jon Ciesla changed:
What|Removed |Added
Flags|fedora-cvs? |fedora-cvs+
--
You are receiving this m
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Adam Williamson changed:
What|Removed |Added
Summary|Review Request: |Review Request:
|ph
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Adam Williamson changed:
What|Removed |Added
Blocks|182235 (FE-Legal) |
Depends On|
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Adam Williamson changed:
What|Removed |Added
Flags||fedora-cvs?
--- Comment #15 from Ad
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Bug 1047604 depends on bug 1047596, which changed state.
Bug 1047596 Summary: Review Request: php-channel-phpseclib - Adds the phpseclib
channel to PEAR
https://bugzilla.redhat.com/show_bug.cgi?id=1047596
What|Removed
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Remi Collet changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #14 from Rem
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Adam Williamson changed:
What|Removed |Added
Blocks||182235 (FE-Legal)
--- Comment #13 f
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #12 from Adam Williamson ---
URL fixed for all phpseclib reviews (silent fix, same spec / SRPM URLs as
before).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #11 from Adam Williamson ---
if this was C and it was getting compiled, that might be different, because
then there wouldn't necessarily be a copy of the license included with the
binary distribution. but that doesn't apply here. w
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #10 from Adam Williamson ---
I'm an amateur license nerd. Really, it's fine.
I wouldn't say the guidelines are 'ambiguous', I'd just say they're maybe a bit
hard to read. But if you follow the logic...
First paragraph starts with
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #9 from Remi Collet ---
Yes openssl is optional.
But as noted in the code: method 1. the fastest
And, well, openssl is always here ;) so this is only cosmetic.
Requires the prefered extension.
About License
https://fedoraproject
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #8 from Adam Williamson ---
Again, the license *is included inline in the source*. Each of these packages
ultimately contains a small number of PHP files and the XML file, and all the
PHP files have the license at the top. There's
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #7 from Adam Williamson ---
The use of openssl is also optional, I believe:
// method 1. the fastest
if (function_exists('openssl_random_pseudo_bytes')) {
return openssl_random_pseudo_bytes($length);
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #6 from Remi Collet ---
Forget my comment about dependencies.
Reading code, only "php-openssl" is needed
All others (mcrypt, session, Crypt_*) are only fallbacks which will never be
used.
So please:
-Requires: php-session
+Requi
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #5 from Remi Collet ---
Notice, could make sense to define and use everywhere:
%global pear_channel phpseclib.sourceforge.net
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Remi Collet changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #4 from Remi
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #3 from Remi Collet ---
Created attachment 845729
--> https://bugzilla.redhat.com/attachment.cgi?id=845729&action=edit
review.txt
Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-r
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Remi Collet changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #1 from Adam Williamson ---
Updated:
https://www.happyassassin.net/reviews/php-phpseclib-crypt-random/php-phpseclib-crypt-random.spec
https://www.happyassassin.net/reviews/php-phpseclib-crypt-random/php-phpseclib-crypt-random-0.3.
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Adam Williamson changed:
What|Removed |Added
Blocks||1047611
Referenced Bugs:
https://
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Adam Williamson changed:
What|Removed |Added
Blocks||1047608
Referenced Bugs:
https://
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
Adam Williamson changed:
What|Removed |Added
Depends On||1047596
Referenced Bugs:
https://
32 matches
Mail list logo
