https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Miroslav Suchý msu...@redhat.com changed:
What|Removed |Added
Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Perry Myers pmy...@redhat.com changed:
What|Removed |Added
Assignee|pmy...@redhat.com |nob...@fedoraproject.org
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Matthias Runge mru...@redhat.com changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
John Skeoch jske...@redhat.com changed:
What|Removed |Added
Assignee|sd...@redhat.com|pmy...@redhat.com
--
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Jon Ciesla limburg...@gmail.com changed:
What|Removed |Added
Flags|fedora-cvs? |fedora-cvs+
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #29 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #25 from Angus Thomas atho...@redhat.com ---
Thanks Steve.
I've updated the package so that that license is present in the subpackages.
Spec URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Steven Dake sd...@redhat.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
---
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #27 from Steven Dake sd...@redhat.com ---
Please submit a fedora SCM request:
http://fedoraproject.org/wiki/Package_SCM_admin_requests
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Angus Thomas atho...@redhat.com changed:
What|Removed |Added
Flags||fedora-cvs?
---
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #22 from Angus Thomas atho...@redhat.com ---
New version based on Icehouse RC1
Spec URL:
https://raw.github.com/agroup/tripleo-rpm-spec-files/master/ironic/openstack-ironic.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #23 from Steven Dake sd...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #24 from Steven Dake sd...@redhat.com ---
Angus,
Strictly speaking this package meets the license guidelines by installing any
package installs common which installs license and readme. I don't like to
leave things open to
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #21 from Angus Thomas atho...@redhat.com ---
Hi.
New version which builds into -common, -api and -conductor packages
Spec URL:
https://raw.github.com/agroup/tripleo-rpm-spec-files/master/ironic/openstack-ironic.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #20 from Steven Dake sd...@redhat.com ---
Angus,
I would recommend splitting up the api and conductor into separate packages.
All the OpenStack packaging behaves in this way. For an example of how it is
done take a look at the
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #19 from Steven Dake sd...@redhat.com ---
(In reply to Angus Thomas from comment #18)
Hi James.
Sorry about that. It fooled me by building fine locally. Fixed now.
Angus,
You can always use mock to build locally but without
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Bug 1069335 depends on bug 1067445, which changed state.
Bug 1067445 Summary: Review Request: python-pyghmi - Python General Hardware
Management Initiative
https://bugzilla.redhat.com/show_bug.cgi?id=1067445
What|Removed
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #17 from James Slagle jsla...@redhat.com ---
Hi Angus, the latest iteration does not build in mock. Nothing gets installed
because you also removed the BuildRequires on python-pbr. It's ok to have
python-pbr as a BuildRequires (and
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #18 from Angus Thomas atho...@redhat.com ---
Hi James.
Sorry about that. It fooled me by building fine locally. Fixed now.
Spec URL:
https://raw.github.com/agroup/tripleo-rpm-spec-files/master/ironic/openstack-ironic.spec
SRPM
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
James Slagle jsla...@redhat.com changed:
What|Removed |Added
CC||jsla...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #5 from James Slagle jsla...@redhat.com ---
I suggest providing a raw download link to the spec if using github:
Spec URL:
https://raw.github.com/agroup/tripleo-rpm-spec-files/master/ironic/openstack-ironic.spec
SRPM URL:
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #6 from James Slagle jsla...@redhat.com ---
Hi, I'm doing an unofficial review.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #7 from Steven Dake sd...@redhat.com ---
James,
Have a read of:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets
Does anything pop out to you as a suggestion related to systemd?
Regards
-steve
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #8 from Steven Dake sd...@redhat.com ---
James,
It is typically the packagers responsibility to diagnose and fix the rpmlint
warnings, but as the package reviewer, you have an opportunity to provide
guidance about what you would
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #9 from Steven Dake sd...@redhat.com ---
Angus,
I'd recommend having a read through this review:
https://bugzilla.redhat.com/show_bug.cgi?id=1066629
as well as:
https://bugzilla.redhat.com/show_bug.cgi?id=1066633
then
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #10 from Steven Dake sd...@redhat.com ---
Angus,
I just wanted to point out a couple pieces of documentation that you may or not
be aware of. I would recommend blocking off about 1-2 hours and reading
through them. The more
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #11 from James Slagle jsla...@redhat.com ---
(In reply to Steven Dake from comment #7)
James,
Have a read of:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets
Does anything pop out to you as a suggestion related
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #12 from James Slagle jsla...@redhat.com ---
(In reply to Steven Dake from comment #8)
James,
It is typically the packagers responsibility to diagnose and fix the rpmlint
warnings, but as the package reviewer, you have an
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #13 from James Slagle jsla...@redhat.com ---
I don't see anything additional from the binary RPM lint that I haven't
commented on above.
openstack-ironic.noarch: W: conffile-without-noreplace-flag
/etc/ironic/rootwrap.conf
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #14 from Steven Dake sd...@redhat.com ---
Regarding Comment #11, there is also some Requires (for systemd) required.
I am pretty sure the rest of the openstack packages break out the api from the
conductor. This is not something
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #15 from Steven Dake sd...@redhat.com ---
Re Comment #12:
What's the path forward here? It seems like the only thing that can be done in
the spec itself is to make these files +x in %files. But, these things aren't
actually scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #16 from Angus Thomas atho...@redhat.com ---
Many thanks for the detailed feedback. Based on all the recommended changes:
Spec URL:
https://raw.github.com/agroup/tripleo-rpm-spec-files/master/ironic/openstack-ironic.spec
SRPM
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Matthias Runge mru...@redhat.com changed:
What|Removed |Added
CC||mru...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Steven Dake sd...@redhat.com changed:
What|Removed |Added
CC||sd...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #3 from Steven Dake sd...@redhat.com ---
Angus,
I'll sponsor you.
Please have a quick read:
https://fedoraproject.org/wiki/Join_the_package_collection_maintainers
Let me know when you have completed this step.
--
You are
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Jordan OMara jom...@redhat.com changed:
What|Removed |Added
CC||jom...@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
--- Comment #1 from Jordan OMara jom...@redhat.com ---
I believe I am allowed to sponsor athomas for the openstack fedora group. If
not, please let me know and I'll find someone who can.
Overall, review looks good - please check the ! items
https://bugzilla.redhat.com/show_bug.cgi?id=1069335
Angus Thomas atho...@redhat.com changed:
What|Removed |Added
Depends On||1067445
Referenced
38 matches
Mail list logo
