[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-04-01 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #34 from Raphael Groner projects...@smart.ms --- Not sure how long to wait for Karel as the original requester. I could take this package and open a new bug for the request. -- You are receiving this mail because: You are on the

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-03-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Christopher Meng i...@cicku.me changed: What|Removed |Added Assignee|bjoern.es...@gmail.com |i...@cicku.me ---

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-03-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Raphael Groner projects...@smart.ms changed: What|Removed |Added External Bug ID||KDE Software

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-03-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #32 from Raphael Groner projects...@smart.ms --- HTML formatting seems to fail with Qt5, see upstream bug 345739. Release #2 with enabled Qt5. SPEC: https://raphgro.fedorapeople.org/review/qt/trojita/trojita.spec SRPM:

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-03-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Raphael Groner projects...@smart.ms changed: What|Removed |Added Flags|

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-03-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Raphael Groner projects...@smart.ms changed: What|Removed |Added CC||kvo...@redhat.com

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #30 from Raphael Groner projects...@smart.ms --- Fixed help2man. New rawhide scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=9102581 -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #29 from Raphael Groner projects...@smart.ms --- SPEC: https://raphgro.fedorapeople.org/review/qt/trojita/trojita.spec SRPM: https://raphgro.fedorapeople.org/review/qt/trojita/trojita-0.5-1.fc21.src.rpm rawhide scratch:

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #28 from Kevin Kofler ke...@tigcc.ticalc.org --- As I already said in comment #15 and explained in comment #17, I also agree that you MUST require hicolor-icon-theme instead of owning the same directories. -- You are receiving

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #27 from Michael Schwendt (Fedora Packager Sponsors Group) bugs.mich...@gmx.net --- Please don't be so stubborn. There is general agreement about explicitly requiring hicolor-icon-theme package instead of _trying_ to own all used

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #26 from Karel Volný kvo...@redhat.com --- (In reply to Raphael Groner from comment #25) Remove these lines and put Requires: hicolor-icon-theme. The guideline says to not own folders from a filesystem package, hicolor-icon-theme

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Karel Volný kvo...@redhat.com changed: What|Removed |Added Flags||needinfo? --- Comment

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #25 from Raphael Groner projects...@smart.ms --- (In reply to Karel Volný from comment #24) … btw, has anyone taken the hicolor-icon-theme issue anywhere, have I missed something? From your spec file: %dir

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added CC|

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #22 from Raphael Groner projects...@smart.ms --- (In reply to Mario Blättermann from comment #21) %doc LICENSE README Please move the license text to %license:

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Zbigniew Jędrzejewski-Szmek zbys...@in.waw.pl changed: What|Removed |Added CC|

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2015-02-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Björn besser82 Esser bjoern.es...@gmail.com changed: What|Removed |Added CC|

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-12-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Whiteboard|NotReady| --- Comment #19

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-11-03 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #18 from Karel Volný kvo...@redhat.com --- (In reply to Kevin Kofler from comment #17) The icon-theme.cache file is actually ghosted, which means it is NOT part of the installed size of the hicolor-icon-theme package. okay,

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #16 from Karel Volný kvo...@redhat.com --- (In reply to Kevin Kofler from comment #15) The hicolor-icon-theme package is a *filesystem-type package. the catch is that it is *filesystem-type but not *-filesystem it carries

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-10-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #17 from Kevin Kofler ke...@tigcc.ticalc.org --- The icon-theme.cache file is actually ghosted, which means it is NOT part of the installed size of the hicolor-icon-theme package. The file is NOT created by installing the

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-10-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Karel Volný kvo...@redhat.com changed: What|Removed |Added Flags||needinfo?(i...@cicku.me)

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-10-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #15 from Kevin Kofler ke...@tigcc.ticalc.org --- I still disagree about your handling of the hicolor icon theme. The hicolor-icon-theme package is a *filesystem-type package. Therefore, this section of the guidelines applies: An

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-07-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Christopher Meng i...@cicku.me changed: What|Removed |Added Whiteboard||NotReady --- Comment

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-05-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #12 from Kevin Kofler ke...@tigcc.ticalc.org --- We indeed do not care about cross builds for Fedora packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-05-05 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #11 from Karel Volný kvo...@redhat.com --- thanks Jan for the update sorry, I'm overloaded now, there was vacation on May 1st and there will be on May 8th, things should settle after the next RHSCL release, dont't expect me to get

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-04-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Jan Kundrát j...@flaska.net changed: What|Removed |Added CC||j...@flaska.net ---

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-04-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #9 from Christopher Meng cicku...@gmail.com --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: === - Package installs a %{name}.desktop using

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-04-16 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #8 from Karel Volný kvo...@redhat.com --- Spec URL: http://kvolny.fedorapeople.org/trojita.spec SRPM URL: http://kvolny.fedorapeople.org/trojita-0.4.1-2.fc20.src.rpm Koji scratch builds: F20:

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-04-15 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||fedora-review?

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-04-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #4 from Karel Volný kvo...@redhat.com --- (In reply to Rex Dieter from comment #2) Offhand looks like a good start, some initial suggestions (SHOULD are just recommendations and/or a matter of taste, MUST are required): thanks

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-04-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #5 from Karel Volný kvo...@redhat.com --- Created attachment 886100 -- https://bugzilla.redhat.com/attachment.cgi?id=886100action=edit trojita-0.4.1-2 $ diff trojita.spec~ trojita.spec

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-04-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #6 from Christopher Meng cicku...@gmail.com --- Please attach the fixed version, I will review it later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-04-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-04-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #2 from Rex Dieter rdie...@math.unl.edu --- Offhand looks like a good start, some initial suggestions (SHOULD are just recommendations and/or a matter of taste, MUST are required): 1. SHOULD add Requires: hicolor-icon-theme

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-04-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #3 from Christopher Meng cicku...@gmail.com --- (In reply to Rex Dieter from comment #2) Oh, just noticed the bug is assigned, but no review flag set, Christopher, was that just an oversight? Sorry, it's not an omission. I'm

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-03-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED

[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

2014-03-25 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #1 from Karel Volný kvo...@redhat.com --- note that I've filed some bugs upstream for the things I've workarounded in spec: Bug 332578 - superfluous x-test language [https://bugs.kde.org/show_bug.cgi?id=332578] Bug 332579 -