[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 Chris Lumens clum...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 --- Comment #5 from David Shea ds...@redhat.com --- Looks good with those changes. 5. Include the text of your review in a comment in the ticket. For easy readability, simply use a regular comment instead of an attachment. Ok, package review

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 David Shea ds...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ ---

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 --- Comment #1 from David Shea ds...@redhat.com --- A first look while I fight with mock: %build fails, because it runs make with no target, which chooses the first target: check. My suggestion is to add something like: build: Tab$(PYTHON)

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 --- Comment #2 from David Shea ds...@redhat.com --- To build+check in mock, needs a Requires: python3-six. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 David Shea ds...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 --- Comment #4 from Chris Lumens clum...@redhat.com --- See: https://github.com/rhinstaller/pocketlint/commit/7bda8a2b548e99b79a7816127661ff137dac5849 https://github.com/rhinstaller/pocketlint/commit/734ab4bac5e7a415dada4870a683c015fb12c8f9

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 Chris Lumens clum...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? ---

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 David Shea ds...@redhat.com changed: What|Removed |Added CC||ds...@redhat.com

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 --- Comment #3 from David Shea ds...@redhat.com --- (In reply to David Shea from comment #2) To build+check in mock, needs a Requires: python3-six. BuildRequires, rather -- You are receiving this mail because: You are on the CC list for

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You

[Bug 1200119] Review Request: python3-pocketlint - addon pylint checkers for installer-related projects

https://bugzilla.redhat.com/show_bug.cgi?id=1200119 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component