[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 Denis Arnaud changed: What|Removed |Added Status|NEW |CLOSED Resolution|---

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 Petr Menšík changed: What|Removed |Added CC||pemen...@redhat.com --- Comment #28

needinfo canceled: [Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

Product: Fedora EPEL Version: epel7 Component: Package Review Package Review has canceled Package Review 's request for James Hogarth 's needinfo: Bug 1210993: Review Request: boost157 - The free peer-reviewed portable C++ source libraries https://bugzilla.redhat.com/show_bug.cgi?id=1210993

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #25 from Denis Arnaud --- Note that a newer version (Boost1.69) has been accepted a while ago: https://bugzilla.redhat.com/show_bug.cgi?id=1667725 Boost 1.72 (or even 1.73) should very soon make its way onto Fedora Rawhide. I'll

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 Petr Pisar changed: What|Removed |Added Status|NEW |ASSIGNED CC|

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #24 from James Hogarth --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: === - Package contains BR: python2-devel or python3-devel

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #23 from Denis Arnaud --- Ok, so, taking all of that into account, it gives: Spec URL: http://denisarnaud.fedorapeople.org/boost/boost157/boost157.spec SRPM URL:

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #22 from James Hogarth --- It does complain a bit ... but so long as things align correctly before import it's not significant. Just one thing left in review that I can see... Please mark the licenses as

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #21 from Denis Arnaud --- (In reply to James Hogarth from comment #20) > There's no boost157.spec in your fedora people ... > > I'm guessing you missed a symlink? > > Placing this here to make

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #20 from James Hogarth --- There's no boost157.spec in your fedora people ... I'm guessing you missed a symlink? Placing this here to make fedora-review happy ... Spec URL:

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #19 from Denis Arnaud --- (In reply to James Hogarth from comment #17) Suggestions integrated. It built cleanly on my local EPEL6. Build on EPEL7 running (see the link above in comment #18). Thanks

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 Denis Arnaud changed: What|Removed |Added Flags|needinfo?(denis.arnaud_fedo |

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 James Hogarth changed: What|Removed |Added Flags|

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 James Hogarth changed: What|Removed |Added Flags||fedora-review?

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 James Hogarth changed: What|Removed |Added Flags|fedora-review? | -- You

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #16 from Denis Arnaud --- Spec URL: http://denisarnaud.fedorapeople.org/boost/boost157/boost157.spec SRPM URL: http://denisarnaud.fedorapeople.org/boost/boost157/boost157-1.57.0-4.src.rpm Successful

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #15 from Denis Arnaud --- (In reply to James Hogarth from comment #14) > Flag me when you're ready and I'll carry out the review. Thanks! I am now ready, thanks to Docker images allowing building RPM

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 James Hogarth changed: What|Removed |Added Assignee|nob...@fedoraproject.org

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 Denis Arnaud changed: What|Removed |Added Flags|needinfo?(denis.arnaud_fedo |

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 James Hogarth changed: What|Removed |Added CC|

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #11 from Denis Arnaud --- (In reply to Carl George from comment #10) > I'll go ahead and give some initial feedback that I noticed in the spec file. Thanks Carl, appreciated! > 1. BuildRoot isn't

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 Carl George changed: What|Removed |Added CC|

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #9 from Denis Arnaud --- (In reply to Carl George from comment #8) > Since this hasn't been reviewed yet, would you consider rebasing this to > 1.59.0 (boost159)? I would find it useful for building

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #10 from Carl George --- I haven't done a formal package review before, but I'm happy to learn. Based on the docs [1] "any Fedora account holder who is a member of the packager group" can do it, so I

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #7 from Denis Arnaud --- Spec URL: http://denisarnaud.fedorapeople.org/boost/boost157/boost157.spec SRPM URL: http://denisarnaud.fedorapeople.org/boost/boost157/boost157-1.57.0-3.src.rpm Fixed a few

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #6 from Denis Arnaud denis.arnaud_fed...@m4x.org --- Thanks! In case you can formally review (and approve!) that package, do not hesitate then :) -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 Xiangyang Chen che...@gmail.com changed: What|Removed |Added CC||che...@gmail.com

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #3 from Denis Arnaud denis.arnaud_fed...@m4x.org --- Successful builds on all the architectures: EPEL 6: http://koji.fedoraproject.org/koji/taskinfo?taskID=9463323 EPEL 7: http://koji.fedoraproject.org/koji/taskinfo?taskID=9463310

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #2 from Denis Arnaud denis.arnaud_fed...@m4x.org --- Successful builds: EPEL 6: http://koji.fedoraproject.org/koji/taskinfo?taskID=9463308 EPEL 7: http://koji.fedoraproject.org/koji/taskinfo?taskID=9463310 -- You are receiving

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #4 from Denis Arnaud denis.arnaud_fed...@m4x.org --- Re-used the same packaging techniques as for Boost148 (see #921134), around the source code of Boost-1.57 for Fedora 22

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 Denis Arnaud denis.arnaud_fed...@m4x.org changed: What|Removed |Added Flags|

[Bug 1210993] Review Request: boost157 - The free peer-reviewed portable C++ source libraries

https://bugzilla.redhat.com/show_bug.cgi?id=1210993 --- Comment #1 from Denis Arnaud denis.arnaud_fed...@m4x.org --- Successful build on EPEL 7: http://koji.fedoraproject.org/koji/taskinfo?taskID=9463282 -- You are receiving this mail because: You are on the CC list for the bug. You are