[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #19 from Fedora Update System --- nodejs-sinon-1.17.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You ar

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|---

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #18 from Fedora Update System --- nodejs-sinon-1.17.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You ar

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #17 from Fedora Update System --- nodejs-sinon-1.17.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fed

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #15 from Fedora Update System --- nodejs-sinon-1.17.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-4741c1fced -- You are receiving this mail because: You are on the CC l

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #14 from Fedora Update System --- nodejs-sinon-1.17.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-f637b4b4c0 -- You are receiving this mail because: You are on the CC l

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-14 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #13 from Piotr Popieluch --- Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ p

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Tom Hughes changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review?

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #11 from Piotr Popieluch --- Ok thank you, I've added the fixdep on lolex, uploaded file, didn't bump release number. ps. also added release-monitoring for lolex and working on update. -- You are receiving this mail because: Y

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #10 from Tom Hughes --- The test failure is because we have formatio 1.1.2 not 1.1.1 and that includes https://github.com/busterjs/formatio/commit/116d0ace0103b21436e448091bb0fad9b46eb8c5 which makes the "(empty string)" appear. So

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #9 from Tom Hughes --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Package installs properly. Note: Installation errors (

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-13 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #8 from Piotr Popieluch --- Thanks for finding that. Updated to 1.17.1 with correct hash now. Now only one test fails. Spec URL: https://piotrp.fedorapeople.org/nodejs-sinon.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-si

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-12 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #7 from Tom Hughes --- Well no, npmjs.org does have 1.17.1 and I just realised it is in the github repo but on a branch and they forgot to tag it. The correct git hash is d5512942fa64d3775760af3cfb22cdd297fca38c I think: https://

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #6 from Piotr Popieluch --- I'm sorry, I mixed up. Latest release is 1.17.0. Spec URL: https://piotrp.fedorapeople.org/nodejs-sinon.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-sinon-1.17.0-1.fc22.src.rpm -- You are re

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #5 from Tom Hughes --- That is actually 1.17.0 by the looks of it, but 1.17.1 seems to be missing from the github repo? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about cha

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-10 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #4 from Piotr Popieluch --- I think the only relevant test is: ./node_modules/buster/bin/buster-test --config-group node Other tests do browser tests and coverage. Unfortunately this one fails on 3 out of 1169 tests. I don't know

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-07 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #3 from Piotr Popieluch --- I think the buster tests actually try to test the browser code not the nodejs. The tests explicitly load the browserified lolex version. I will need some more time to sort this out. -- You are receivi

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Tom Hughes changed: What|Removed |Added CC||t...@compton.nu Assignee|nob...@

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-10-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 --- Comment #2 from Tom Hughes --- Needs updating to 1.17.1 upstream release and there are some BRs missing for running the tests, namely: npm(formatio) npm(lolex) npm(samsam) npm(util) Even with those, and the unpackaged ones installed via

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-09-18 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Bug 1258160 depends on bug 1258157, which changed state. Bug 1258157 Summary: Review Request: nodejs-formatio - Human-readable object formatting https://bugzilla.redhat.com/show_bug.cgi?id=1258157 What|Removed

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-09-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Bug 1258160 depends on bug 1258159, which changed state. Bug 1258159 Summary: Review Request: nodejs-lolex - Fake JavaScript timers https://bugzilla.redhat.com/show_bug.cgi?id=1258159 What|Removed |Added --

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-09-11 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Bug 1258160 depends on bug 1258156, which changed state. Bug 1258156 Summary: Review Request: nodejs-samsam - Value identification and comparison functions https://bugzilla.redhat.com/show_bug.cgi?id=1258156 What|Removed

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-08-31 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Tom Hughes changed: What|Removed |Added Blocks||1258222 Referenced Bugs: https://bugzi

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-08-30 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Piotr Popieluch changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced

[Bug 1258160] Review Request: nodejs-sinon - Test spies, stubs and mocks for JavaScript

2015-08-29 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1258160 Piotr Popieluch changed: What|Removed |Added Depends On||1258159, 1258156, 1258157 Referenc