[Bug 1305091] Review Request: statsite - A C implementation of statsd

2016-05-27 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1305091 Piotr Popieluch changed: What|Removed |Added Status|ASSIGNED|CLOSED Blocks|

[Bug 1305091] Review Request: statsite - A C implementation of statsd

2016-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1305091 Piotr Popieluch changed: What|Removed |Added Flags|needinfo?(piotr1212@gmail.c | |om)

[Bug 1305091] Review Request: statsite - A C implementation of statsd

2016-02-23 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1305091 Denis Fateyev changed: What|Removed |Added CC||piotr1...@gmail.com Flags|

[Bug 1305091] Review Request: statsite - A C implementation of statsd

2016-02-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1305091 --- Comment #5 from Denis Fateyev --- (In reply to Piotr Popieluch from comment #3) > 5) tried this initially but couldn't get it working because of the subdirs > in sinks. Will check the man pages again, maybe I just missed some option. I thi

[Bug 1305091] Review Request: statsite - A C implementation of statsd

2016-02-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1305091 --- Comment #4 from Denis Fateyev --- (In reply to Piotr Popieluch from comment #3) > 4) Aren't these part of the buildroot, thus not needed? They usually do, but it can be changed in the future. Some details https://fedorahosted.org/fpc/tick

[Bug 1305091] Review Request: statsite - A C implementation of statsd

2016-02-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1305091 --- Comment #3 from Piotr Popieluch --- Thank you for review. Unbundling will take some time as some of the deps are not in Fedora yet, and the source needs to be patched. 1,2,3) Agree, will implement 4) Aren't these part of the buildroot,

[Bug 1305091] Review Request: statsite - A C implementation of statsd

2016-02-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1305091 --- Comment #2 from Denis Fateyev --- Also, there are some points before review: 1) The `%if 0%{?rhel} && 0%{?rhel} <= 6` condition is used multiple times. I personally prefer using something like that: %if 0%{?rhel} >= 7 %global _with_s

[Bug 1305091] Review Request: statsite - A C implementation of statsd

2016-02-09 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1305091 --- Comment #1 from Piotr Popieluch --- I just noticed that upstream bundled some libraries. Trying to unbundle it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this pro

[Bug 1305091] Review Request: statsite - A C implementation of statsd

2016-02-08 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1305091 Denis Fateyev changed: What|Removed |Added Status|NEW |ASSIGNED CC|