https://bugzilla.redhat.com/show_bug.cgi?id=1310145
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |CLOSED
Fixed In Version
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #14 from Jon Ciesla ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-igor
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about change
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #13 from Zbigniew Jędrzejewski-Szmek ---
Thanks!
I updated License and opened a PR upstream:
https://github.com/wking/igor/pull/1
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notifie
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #12 from Jonathan Underwood ---
APPROVED
I'll trust you to make those minor changes. Thanks for the contribution to
Fedora.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified abou
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
Jonathan Underwood changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--
You are recei
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #11 from Jonathan Underwood ---
So, please address the following:
1) Add Public Domain to license field
2) Add comments about the patches, and submit upstream where appropriate,
giving a link in a comment for each patch.
--
You
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #10 from Jonathan Underwood ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #9 from Upstream Release Monitoring
---
zbyszek's scratch build of python-igor-0.2-3.20150408git2c2a79d.fc25.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=13166178
--
You are receiving this mai
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #8 from Zbigniew Jędrzejewski-Szmek ---
Thanks for the review.
Package is updated to a git snapshot, it has some fixes, and in particular:
- also installs /usr/bin/igorbinarywave
- clears up the licensing in favour of LGPLv3+
I p
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #7 from Upstream Release Monitoring
---
zbyszek's scratch build of python-igor-0.2-3.20150408git2c2a79d.fc25.src.rpm
for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=13166009
--
You are receiving this mai
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #6 from Jonathan Underwood ---
Here's a nice recipe for fixing up a shebang (taken from the python-pillow
package):
find -name '*.py' | xargs sed -i '1s|^#!.*python|#!%{__python3}|'
--
You are receiving this mail because:
You ar
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #5 from Jonathan Underwood ---
Also, should the igorpackedexperiment.py script also not be packaged?
Both the igorpackedexperiment.py and igorbinarywave.py scripts have
/usr/bin/env shebangs at the top. They should be patched to c
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #4 from Jonathan Underwood ---
Also, this file:
%{_bindir}/igorbinarywave
should be part of the python3 package, rather than the python2 package, unless
there's a very good reason otherwise - if so, a comment needs adding to the
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #3 from Jonathan Underwood ---
Also, the files in the project have the LGPLv3 header, but the COPYING file is
the GPLv3 file, not the LGPLv3 file. So, the licensing situation is unclear -
please contact upstream to clarify, and ask
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #2 from Jonathan Underwood ---
Also, building fails:
+ cd /builddir/build/BUILD
+ cd igor-0.2
+ nosetests-2.7 --with-doctest --doctest-tests igor test
/var/tmp/rpm-tmp.jGiA96: line 31: nosetests-2.7: command not found
Your Requir
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
Jonathan Underwood changed:
What|Removed |Added
Flags||fedora-review?
--
You are recei
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
--- Comment #1 from Jonathan Underwood ---
$ fedora-review -m fedora-rawhide-x86_64 -b 1310145
INFO: Processing bugzilla bug: 1310145
INFO: Getting .spec and .srpm Urls from : 1310145
INFO: --> SRPM url:
https://in.waw.pl/~zbyszek/fedora/pyt
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
Jonathan Underwood changed:
What|Removed |Added
CC||jonathan.underw...@gmail.co
https://bugzilla.redhat.com/show_bug.cgi?id=1310145
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Blocks||1276941 (fedora-neuro)
19 matches
Mail list logo
