[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #12 from Fedora Update System --- gap-pkg-guava-3.13.1-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #11 from Fedora Update System --- gap-pkg-guava-3.13.1-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 Fedora Update System changed: What|Removed |Added Status|ON_QA

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #10 from Fedora Update System --- gap-pkg-guava-3.13.1-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 Fedora Update System changed: What|Removed |Added Status|NEW

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #8 from Fedora Update System --- gap-pkg-guava-3.13.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2547786f05 -- You are receiving this mail

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #7 from Fedora Update System --- gap-pkg-guava-3.13.1-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-bcd5fe40a8 -- You are receiving this mail

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-guava -- You are receiving this mail because: You are on the CC list for the bug. You are

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 Paulo Andrade changed: What|Removed |Added Flags|fedora-review?

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #4 from Jerry James --- I added those parentheses. I also noticed that guava has a software popcount implementation, so I added another patch to use a CPU popcount instruction instead if one is available.

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #3 from Paulo Andrade --- I think the last one is likely a bug, because the "+ cSize" is added in the next line, but (adding parenthesis,) what is happening is: priority = (20ul

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #2 from Jerry James --- Thanks for the review, Paulo. (In reply to Paulo Andrade from comment #1) > It is not required to have: > BuildRequires: gcc Actually, it is now. See:

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 --- Comment #1 from Paulo Andrade --- It is not required to have: BuildRequires: gcc --- This looks suspecting, as it means it will loop only once: ./src/randschr.c:238:10: warning: this 'if'

[Bug 1367598] Review Request: gap-pkg-guava - Computing with error-correcting codes

https://bugzilla.redhat.com/show_bug.cgi?id=1367598 Paulo Andrade changed: What|Removed |Added CC|