https://bugzilla.redhat.com/show_bug.cgi?id=1391457
Charalampos Stratakis changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #18 from Jon Ciesla ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-netjsonconfig
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notifie
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
Charalampos Stratakis changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #16 from Charalampos Stratakis ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed wit
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #15 from Germano Massullo ---
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig.spec
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig-0.5.3-1.fc25.
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #14 from Charalampos Stratakis ---
Also on line 82 it should be 'permissions'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #13 from Charalampos Stratakis ---
Regarding the python2 runtime requirements for ipaddress.
In order to test it at a machine or chroot where you have installed the python2
rpm you can run python2 -c 'import netjsonconfig' and you
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #12 from Germano Massullo ---
netjsonconfig 0.5.2 has been released
spec file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig.spec
srpm file:
https://germano.fedorapeople.org/package_re
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
Germano Massullo changed:
What|Removed |Added
Depends On|1395651, 1395653|
Flags|needinfo?(german
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
Germano Massullo changed:
What|Removed |Added
Depends On||1395651
Referenced Bugs:
https:/
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
Germano Massullo changed:
What|Removed |Added
Depends On||1395653
Referenced Bugs:
https:/
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
Charalampos Stratakis changed:
What|Removed |Added
CC||germano.massu...@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #10 from Charalampos Stratakis ---
When testing the python2 subpackage I stumbled upon some tracebacks
The python2 subpackage should have a runtime requirement for python-ipaddress
module because of:
ImportError: No module named i
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #9 from Germano Massullo ---
I have forgotten to write that the spec is made for EPEL7 & Fedora >= 24
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this produ
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #8 from Germano Massullo ---
I removed all BuildRequires required for tests, because:
- python-coveralls has no builds for EPEL7;
- since tests are disabled, we no longer need those BuildRequires
spec file:
https://germano.fedorap
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #7 from Charalampos Stratakis ---
And my previous comment also applies for the runtime requirements, python-six,
python-jinja2 (but not for python-jsonschema as that package doesn't use the
python provide macro or an explicit provi
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #6 from Charalampos Stratakis ---
python-setuptools BuildRequires should be replaced with python2-setuptools as
the package provides that name from f24+ (unless you plan on building it for
F23 as well, where the python2 subpackage
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #5 from Germano Massullo ---
spec file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig.spec
srpm file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjson
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #4 from Charalampos Stratakis ---
Please remove the comment from the python2 subpackage, since it is explicitly
stated in the guidelines about the binary situation, you don't have to mention
it in the SPEC.
--
You are receiving t
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #3 from Germano Massullo ---
I edited the spec file to enable the binary for Python 3 only
spec file:
https://germano.fedorapeople.org/package_reviews/python-netjsonconfig/python-netjsonconfig.spec
srpm file:
https://germano.fedor
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
--- Comment #2 from Charalampos Stratakis ---
If the binary has the same functionality (usually it does) under python2 and
python3 it should only be packaged for the python3 subpackage.
As it is currently the binary is pointing to usr/bin/pyt
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
Charalampos Stratakis changed:
What|Removed |Added
CC||cstra...@redhat.com
A
https://bugzilla.redhat.com/show_bug.cgi?id=1391457
Charalampos Stratakis changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
You are receivin
23 matches
Mail list logo
