[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 Richard W.M. Jones changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #17 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/ocaml-ocamlbuild -- You are receiving this mail because: You are on the CC list for the bug. You

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #16 from Richard W.M. Jones --- Spec URL: http://oirase.annexia.org/reviews/ocaml-ocamlbuild/ocaml-ocamlbuild.spec SRPM URL:

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #15 from gil cattaneo --- Please use "install -pm 0644 man/ocamlbuild.1 $RPM_BUILD_ROOT%{_mandir}/man1/" for preserve file timestamp -- You are receiving this mail because: You are on the CC list for the bug.

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 gil cattaneo changed: What|Removed |Added Flags|fedora-review? |fedora-review+

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #13 from Richard W.M. Jones --- Spec URL: http://oirase.annexia.org/reviews/ocaml-ocamlbuild/ocaml-ocamlbuild.spec SRPM URL:

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #12 from Richard W.M. Jones --- [!]: Useful -debuginfo package or justification otherwise. ocaml-ocamlbuild-debuginfo.i686: E: debuginfo-without-sources I'd prefer to leave the debuginfo alone for now until we

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #11 from Richard W.M. Jones --- I should note that: [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/ocaml/ocamlbuild(ocaml)

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #9 from gil cattaneo --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - If (and only if) the source

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #10 from gil cattaneo --- Issues: - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 gil cattaneo changed: What|Removed |Added Status|NEW |ASSIGNED -- You

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #8 from Richard W.M. Jones --- Spec URL: http://oirase.annexia.org/reviews/ocaml-ocamlbuild/ocaml-ocamlbuild.spec SRPM URL:

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #7 from gil cattaneo --- other issues: "Requires: %{name} = %{version}-%{release}" please use "Requires: %{name}%{?_isa} = %{version}-%{release}" -- You are receiving this mail because: You are on

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #6 from gil cattaneo --- you should use %license LICENSE instead of %doc LICENSE in each (sub) packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #5 from gil cattaneo --- have time for review this https://bugzilla.redhat.com/show_bug.cgi?id=1390156 ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #4 from Richard W.M. Jones --- I have compiled this package successfully on x86_64, aarch64, ppc64 and ppc64le. You will need a scratch build of OCaml 4.04 in order to build it, see:

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #3 from Richard W.M. Jones --- It's not possible to do a scratch build in Koji, because it needs OCaml 4.04 which we're in the process of rebuilding. -- You are receiving this mail because: You are on the CC

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #2 from Richard W.M. Jones --- I should say that ocamlbuild was previously part of the ocaml package, but in OCaml >= 4.03 it has been spun out into a new package, hence the need to add a package to Fedora. --

[Bug 1391950] Review Request: ocaml-ocamlbuild - Build tool for OCaml libraries and programs

2016-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1391950 --- Comment #1 from Richard W.M. Jones --- rpmlint output is: ocaml-ocamlbuild.x86_64: W: only-non-binary-in-usr-lib This is a problem in rpmlint. ocaml-ocamlbuild.x86_64: W: no-manual-page-for-binary ocamlbuild.native