https://bugzilla.redhat.com/show_bug.cgi?id=1441828
mgans...@alice.de changed:
What|Removed |Added
Status|ASSIGNED|CLOSED
Resolution|---
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
mgans...@alice.de changed:
What|Removed |Added
Summary|Review Request: |Review Request:
|
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #41 from mgans...@alice.de ---
Hi Vit,
many thanks for your review !
polish changes are welcome.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product an
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
Vít Ondruch changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #40 from Vít
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #39 from mgans...@alice.de ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolaplayer.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaplayer-3.1.3-6.fc25.src.rpm
%changelog
* Mon May 15 2017 Mart
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #38 from Vít Ondruch ---
(In reply to mgans...@alice.de from comment #37)
> (In reply to Vít Ondruch from comment #36)
> > The version should be probably there. If I am not mistaken, rpmlint
> > complains about that.
> >
>
> I do
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #37 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #36)
> (In reply to mgans...@alice.de from comment #35)
> > > (In reply to mgans...@alice.de from comment #33)
> > > > (In reply to Vít Ondruch from comment #30)
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #36 from Vít Ondruch ---
(In reply to mgans...@alice.de from comment #35)
> > (In reply to mgans...@alice.de from comment #33)
> > > (In reply to Vít Ondruch from comment #30)
> > >
> > > > > > * Bundled engine.io library?
> > > >
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #35 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #34)
> (In reply to mgans...@alice.de from comment #32)
> > (In reply to Vít Ondruch from comment #30)
> > > (In reply to Vít Ondruch from comment #21)
> > > > >
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #34 from Vít Ondruch ---
(In reply to mgans...@alice.de from comment #32)
> (In reply to Vít Ondruch from comment #30)
> > (In reply to Vít Ondruch from comment #21)
> > > > * What is the purpose of %{_datadir}/nuvolaplayer3/web_ap
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #33 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #30)
> > > * Bundled engine.io library?
> > > - It seems engine.io library is bundled by nuvolaplayer. Is it required
> > > for
> > > something? If yes, s
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #32 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #30)
> There are still few things remaining from my previous review:
>
> (In reply to Vít Ondruch from comment #21)
> > * AppData should be validated
> > - Ple
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #31 from Vít Ondruch ---
(In reply to Vít Ondruch from comment #30)
> Actually, may be we should add some "gstreamer1-plugin-mpg123", not sure.
... we should add some "Recommends: gstreamer1-plugin-mpg123" ...
--
You are receivi
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #30 from Vít Ondruch ---
There are still few things remaining from my previous review:
(In reply to Vít Ondruch from comment #21)
> * AppData should be validated
> - Please add validation of AppData [1].
Actually have you follo
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #29 from mgans...@alice.de ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolaplayer.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaplayer-3.1.3-3.fc25.src.rpm
%changelog
* Thu May 04 2017 Mart
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #28 from mgans...@alice.de ---
(In reply to mgans...@alice.de from comment #27)
> (In reply to Vít Ondruch from comment #26)
> >
> > > > * What is the purpose of %{_datadir}/nuvolaplayer3/audio
> > > > - Is the .mp3 fie used som
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #27 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #26)
>
> > > * What is the purpose of %{_datadir}/nuvolaplayer3/audio
> > > - Is the .mp3 fie used somewhere for something?
> > >
> >
> > The mp3 file is use
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #26 from Vít Ondruch ---
(In reply to mgans...@alice.de from comment #24)
> (In reply to Vít Ondruch from comment #23)
> > (In reply to mgans...@alice.de from comment #22)
> > Well, the tests were not modified in past 3 years, so t
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #25 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #21)
I could not answer the questions, so I opened a ticket.
https://github.com/tiliado/nuvolaplayer/issues/334
>
> * Bundled engine.io library?
> - It seems
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #24 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #23)
> (In reply to mgans...@alice.de from comment #22)
> Well, the tests were not modified in past 3 years, so they might not be in
> good shape ... dunno :/
I
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #23 from Vít Ondruch ---
(In reply to mgans...@alice.de from comment #22)
Well, the tests were not modified in past 3 years, so they might not be in good
shape ... dunno :/
--
You are receiving this mail because:
You are on the C
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #22 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #21)
>
> * Test suite.
> - Is there test suite? Is it possible to execute it?
>
i tried it with this rpm spec file, but it fails with:
https://martinkg.fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #21 from Vít Ondruch ---
* AppData should be validated
- Please add validation of AppData [1].
* Unneeded build dependencies
- It appears that the following BRs are not needed (at least on Rawhide):
~~~
BuildRequires: gnome-
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #20 from mgans...@alice.de ---
scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=19385948
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #19 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #18)
> (In reply to mgans...@alice.de from comment #17)
> > - Add RR %%{_bindir}/waf-3
>
> Actually, this should be BR of course. Sorry for me mistyping it in my
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #18 from Vít Ondruch ---
(In reply to mgans...@alice.de from comment #17)
> - Add RR %%{_bindir}/waf-3
Actually, this should be BR of course. Sorry for me mistyping it in my previous
comment :/
Why the "pkgconfig(unity)"?
And on
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #17 from mgans...@alice.de ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolaplayer.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaplayer-3.1.3-1.fc25.src.rpm
%changelog
* Mon May 01 2017 Mart
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
Vít Ondruch changed:
What|Removed |Added
See Also||https://bugzilla.redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #16 from Vít Ondruch ---
Actually, checking the waf, there is "waf-python3" package which executes waf
using Python 3. So for the time being "Requires: %{_bindir}/waf-3" is the best
solution IMO.
I also opened ticket with waf main
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #15 from Vít Ondruch ---
(In reply to mgans...@alice.de from comment #14)
This might help you to get further:
"rm branding/default.json"
There does not appear to be anything in that file ATM.
--
You are receiving this mail beca
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #14 from mgans...@alice.de ---
I tried it again with diorite-0.3.4 and waf-1.9.10 on Fedora 25, but this fails
again:
installed diorite version:
$ rpm -qa |grep diorite
diorite-0.3.4-1.fc25.x86_64
diorite-devel-0.3.4-1.fc25.x86_6
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
Bug 1441828 depends on bug 1441816, which changed state.
Bug 1441816 Summary: Unretirement-Review Request: diorite - Utility and widget
library for Nuvola Player
https://bugzilla.redhat.com/show_bug.cgi?id=1441816
What|Removed
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #13 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #3)
>
> Also, it seems that the nuvola apps, although packaged into RPM and
> providing their own .desktop files, nuvolaplayer keeps to create other copy
> of th
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #12 from mgans...@alice.de ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolaplayer.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaplayer-3.1.2-2.fc25.src.rpm
%changelog
* Fri Apr 21 2017 Mart
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #11 from Vít Ondruch ---
(In reply to mgans...@alice.de from comment #10)
> nuvolaplayer compiles fine on F25 without this part in your patch:
Yep, that is why I was asking about Rawhide, because there is already the
latest waf, w
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #10 from mgans...@alice.de ---
nuvolaplayer compiles fine on F25 without this part in your patch:
@@ -546,16 +550,6 @@ def dist(ctx):
ctx.archive = archive
from waflib.TaskGen import extension
-@extension('.vapi')
-def vapi
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #9 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #8)
> (In reply to mgans...@alice.de from comment #6)
> >
> >
> >
> > [23/27] Compiling build/Transport.c
> > [24/27] Compiling build/jsapi.c
> > [25/27] Co
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #8 from Vít Ondruch ---
(In reply to mgans...@alice.de from comment #6)
>
>
>
> [23/27] Compiling build/Transport.c
> [24/27] Compiling build/jsapi.c
> [25/27] Compiling build/jsexecutor.c
> [26/27] Linking build/libengineio
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #7 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #5)
> Created attachment 1273606 [details]
> wscript patch
>
> After some fighting, I was able to come up with the attached patch which
> enables build of nuvolap
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #6 from mgans...@alice.de ---
(In reply to Vít Ondruch from comment #5)
> Created attachment 1273606 [details]
> wscript patch
>
> After some fighting, I was able to come up with the attached patch which
> enables build of nuvolap
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #5 from Vít Ondruch ---
Created attachment 1273606
--> https://bugzilla.redhat.com/attachment.cgi?id=1273606&action=edit
wscript patch
After some fighting, I was able to come up with the attached patch which
enables build of nuv
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #4 from mgans...@alice.de ---
compiling with this spec file fails:
https://martinkg.fedorapeople.org/Packages/nuvolaplayer/nuvolaplayer.spec
[martin@fc25 SPECS]$ rpmbuild -ba nuvolaplayer.spec
Executing(%prep): /bin/sh -e /var/tmp
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
Vít Ondruch changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedora
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #2 from mgans...@alice.de ---
correct links:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolaplayer.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaplayer-3.1.2-1.fc25.src.rpm
%changelog
* Sun A
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
--- Comment #1 from mgans...@alice.de ---
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/nuvolasdk.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/nuvolaplayer-3.1.2-1.fc25.src.rpm
%changelog
* Sun Apr 16 2017 Martin G
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
mgans...@alice.de changed:
What|Removed |Added
URL||https://github.com/tiliado/
https://bugzilla.redhat.com/show_bug.cgi?id=1441828
mgans...@alice.de changed:
What|Removed |Added
CC||vondr...@redhat.com
Depends
47 matches
Mail list logo
